Fix TCPClientServerTest stability

Client's toString() changes when the connection completes. Move the
check to after we have waited for callbacks.

JIRA: NETCONF-590
Change-Id: I1ad7e375ca60d350affd1b226fa11ffc87106fe6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/transport/transport-tcp/src/test/java/org/opendaylight/netconf/transport/tcp/TCPClientServerTest.java b/transport/transport-tcp/src/test/java/org/opendaylight/netconf/transport/tcp/TCPClientServerTest.java
index 54767e6943314f59645491478b67b717b73f01c1..3272b66afb7dcc889f147613cab3b7e866220de3 100644 (file)
--- a/transport/transport-tcp/src/test/java/org/opendaylight/netconf/transport/tcp/TCPClientServerTest.java
+++ b/transport/transport-tcp/src/test/java/org/opendaylight/netconf/transport/tcp/TCPClientServerTest.java
@@ -103,10 +103,6 @@ public class TCPClientServerTest {
             final var client = TCPClient.connect(clientListener, NettyTransportSupport.newBootstrap().group(group),
                 clientGrouping).get(2, TimeUnit.SECONDS);
             try {
-                assertThat(client.toString(), allOf(
-                    startsWith("TCPClient{listener=clientListener, state=TCPTransportChannel{channel=[id: 0x"),
-                    endsWith(":" + serverPort.getValue() + "]}}")));
-
                 verify(serverListener, timeout(500)).onTransportChannelEstablished(any());
                 final var serverTransports = serverCaptor.getAllValues();
                 assertEquals(1, serverTransports.size());
@@ -120,6 +116,10 @@ public class TCPClientServerTest {
                 assertThat(clientTransports.get(0).toString(), allOf(
                     startsWith("TCPTransportChannel{channel=[id: "),
                     endsWith(":" + serverPort.getValue() + "]}")));
+
+                assertThat(client.toString(), allOf(
+                    startsWith("TCPClient{listener=clientListener, state=TCPTransportChannel{channel=[id: 0x"),
+                    endsWith(":" + serverPort.getValue() + "]}}")));
             } finally {
                 client.shutdown().get(2, TimeUnit.SECONDS);
             }