Fix deprecation warnings in restconf-nb 21/106821/1
authorRobert Varga <robert.varga@pantheon.tech>
Wed, 5 Jul 2023 19:11:33 +0000 (21:11 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Wed, 5 Jul 2023 19:12:20 +0000 (21:12 +0200)
NormalizedNode and YangInstanceIdentifier have both new methods, switch
to using those.

Change-Id: If84f273fcb32a3ed2b876ec62209f660ac767482
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
28 files changed:
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/Rfc8040.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/handlers/SchemaContextHandler.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/jersey/providers/JsonNormalizedNodeBodyReader.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/jersey/providers/JsonNormalizedNodeBodyWriter.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/jersey/providers/ParameterAwareNormalizedNodeWriter.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/jersey/providers/XmlNormalizedNodeBodyWriter.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/services/impl/RestconfDataServiceImpl.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/services/impl/SubscribeToStreamUtil.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/transactions/BatchedExistenceCheck.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/transactions/MdsalRestconfTransaction.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/transactions/NetconfRestconfTransaction.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/utils/PostDataTransactionUtil.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/utils/PutDataTransactionUtil.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/utils/ReadDataTransactionUtil.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/utils/TransactionUtil.java
restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/parser/YangInstanceIdentifierDeserializer.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/jersey/providers/ParameterAwareNormalizedNodeWriterFieldsTest.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/jersey/providers/XmlBodyReaderMountPointTest.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/jersey/providers/patch/JsonPatchBodyReaderTest.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/jersey/providers/patch/XmlPatchBodyReaderTest.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/jersey/providers/test/XmlBodyReaderTest.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/rests/services/impl/RestconfDataServiceImplTest.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/rests/services/impl/RestconfStreamsSubscriptionServiceImplTest.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/rests/utils/PostDataTransactionUtilTest.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/rests/utils/ReadDataTransactionUtilTest.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/streams/listeners/ListenerAdapterTest.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/test/incubate/InMemoryMdsalModule.java
restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/utils/mapping/RestconfMappingNodeUtilTest.java

index 0ac9905818da4351e9c1870e9cb3cb2bcfa8f4f5..42a85ca7e407a0d6784bc2fb7bf8ebce5252b280 100644 (file)
@@ -25,7 +25,7 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.NodeIdent
  * Common constants defined and relating to RFC8040.
  */
 public final class Rfc8040 {
-    private static final YangInstanceIdentifier RESTCONF_STATE_STREAMS = YangInstanceIdentifier.create(
+    private static final YangInstanceIdentifier RESTCONF_STATE_STREAMS = YangInstanceIdentifier.of(
         NodeIdentifier.create(RestconfState.QNAME), NodeIdentifier.create(Streams.QNAME),
         NodeIdentifier.create(Stream.QNAME));
     private static final QName NAME_QNAME = QName.create(Stream.QNAME, "name").intern();
index 2c684ac6a9506f30f62162b5f0ee7fb1afeec9be..27cdd0dbe3f35217b3783cdb96d6043197461e11 100644 (file)
@@ -141,7 +141,7 @@ public final class SchemaContextHandler implements EffectiveModelContextListener
     private void putData(final ContainerNode normNode) {
         final DOMDataTreeWriteTransaction wTx = domDataBroker.newWriteOnlyTransaction();
         wTx.put(LogicalDatastoreType.OPERATIONAL,
-                YangInstanceIdentifier.create(NodeIdentifier.create(normNode.getIdentifier().getNodeType())), normNode);
+                YangInstanceIdentifier.of(NodeIdentifier.create(normNode.name().getNodeType())), normNode);
         try {
             wTx.commit().get();
         } catch (InterruptedException e) {
index c443fda24959b78bf957b8a4e2c1a7891cc8771b..3e5e641f92b384e3fa9103ff46007ca9966a5b37 100644 (file)
@@ -94,19 +94,19 @@ public class JsonNormalizedNodeBodyReader extends AbstractNormalizedNodeBodyRead
         while (result instanceof ChoiceNode choice) {
             final var childNode = choice.body().iterator().next();
             if (isPost) {
-                iiToDataList.add(result.getIdentifier());
+                iiToDataList.add(result.name());
             }
             result = childNode;
         }
 
         if (isPost) {
             if (result instanceof MapEntryNode) {
-                iiToDataList.add(new NodeIdentifier(result.getIdentifier().getNodeType()));
-                iiToDataList.add(result.getIdentifier());
+                iiToDataList.add(new NodeIdentifier(result.name().getNodeType()));
+                iiToDataList.add(result.name());
             } else {
                 final var parentPath = parentSchema.statementPath();
                 if (parentPath.isEmpty() || !(parentPath.get(parentPath.size() - 1) instanceof OperationDefinition)) {
-                    iiToDataList.add(result.getIdentifier());
+                    iiToDataList.add(result.name());
                 }
             }
         } else if (result instanceof MapNode map) {
index ab63cbe4df3a5876e59254f395b45c51a0091b26..f5ff2761b251ee0ca381ee9a890cda9f8f70d0e7 100644 (file)
@@ -98,7 +98,7 @@ public class JsonNormalizedNodeBodyWriter extends AbstractNormalizedNodeBodyWrit
                     jsonWriter,
                     depth,
                     fields);
-            final Module module = context.getSchemaContext().findModule(data.getIdentifier().getNodeType().getModule())
+            final Module module = context.getSchemaContext().findModule(data.name().getNodeType().getModule())
                 .orElseThrow();
             jsonWriter.name(module.getName() + ":output");
             jsonWriter.beginObject();
@@ -111,7 +111,7 @@ public class JsonNormalizedNodeBodyWriter extends AbstractNormalizedNodeBodyWrit
             stack.enterSchemaTree(action.getOutput().getQName());
 
             nnWriter = createNormalizedNodeWriter(context, stack.toInference(), jsonWriter, depth, fields);
-            final Module module = context.getSchemaContext().findModule(data.getIdentifier().getNodeType().getModule())
+            final Module module = context.getSchemaContext().findModule(data.name().getNodeType().getModule())
                 .orElseThrow();
             jsonWriter.name(module.getName() + ":output");
             jsonWriter.beginObject();
@@ -127,9 +127,7 @@ public class JsonNormalizedNodeBodyWriter extends AbstractNormalizedNodeBodyWrit
             if (data instanceof MapEntryNode mapEntry) {
                 // Restconf allows returning one list item. We need to wrap it
                 // in map node in order to serialize it properly
-                nnWriter.write(ImmutableNodes.mapNodeBuilder(data.getIdentifier().getNodeType())
-                    .withChild(mapEntry)
-                    .build());
+                nnWriter.write(ImmutableNodes.mapNodeBuilder(data.name().getNodeType()).withChild(mapEntry).build());
             } else {
                 nnWriter.write(data);
             }
index 62b65c4743a11713f05ec249a1aa4642a432f41a..7370b229fb6f2260f82cd13a15ac22b9f554bf57 100644 (file)
@@ -136,19 +136,19 @@ public class ParameterAwareNormalizedNodeWriter implements RestconfNormalizedNod
     private boolean wasProcessAsSimpleNode(final NormalizedNode node) throws IOException {
         if (node instanceof LeafSetEntryNode<?> nodeAsLeafList) {
             if (selectedByParameters(node, false)) {
-                writer.startLeafSetEntryNode(nodeAsLeafList.getIdentifier());
+                writer.startLeafSetEntryNode(nodeAsLeafList.name());
                 writer.scalarValue(nodeAsLeafList.body());
                 writer.endNode();
             }
             return true;
         } else if (node instanceof LeafNode<?> nodeAsLeaf) {
-            writer.startLeafNode(nodeAsLeaf.getIdentifier());
+            writer.startLeafNode(nodeAsLeaf.name());
             writer.scalarValue(nodeAsLeaf.body());
             writer.endNode();
             return true;
         } else if (node instanceof AnyxmlNode<?> anyxmlNode) {
             final Class<?> objectModel = anyxmlNode.bodyObjectModel();
-            if (writer.startAnyxmlNode(anyxmlNode.getIdentifier(), objectModel)) {
+            if (writer.startAnyxmlNode(anyxmlNode.name(), objectModel)) {
                 if (DOMSource.class.isAssignableFrom(objectModel)) {
                     writer.domSourceValue((DOMSource) anyxmlNode.body());
                 } else {
@@ -159,7 +159,7 @@ public class ParameterAwareNormalizedNodeWriter implements RestconfNormalizedNod
             return true;
         } else if (node instanceof AnydataNode<?> anydataNode) {
             final Class<?> objectModel = anydataNode.bodyObjectModel();
-            if (writer.startAnydataNode(anydataNode.getIdentifier(), objectModel)) {
+            if (writer.startAnydataNode(anydataNode.name(), objectModel)) {
                 writer.scalarValue(anydataNode.body());
                 writer.endNode();
             }
@@ -219,7 +219,7 @@ public class ParameterAwareNormalizedNodeWriter implements RestconfNormalizedNod
         if (selectedByParameters(mapEntryNode, false)) {
             writeChildren(mapEntryNode.body(), false);
         } else if (fields == null && maxDepth != null && currentDepth == maxDepth) {
-            writeOnlyKeys(mapEntryNode.getIdentifier().entrySet());
+            writeOnlyKeys(mapEntryNode.name().entrySet());
         }
         return true;
     }
@@ -234,7 +234,7 @@ public class ParameterAwareNormalizedNodeWriter implements RestconfNormalizedNod
     }
 
     protected boolean writeMapEntryNode(final MapEntryNode node) throws IOException {
-        writer.startMapEntryNode(node.getIdentifier(), node.size());
+        writer.startMapEntryNode(node.name(), node.size());
         currentDepth++;
         writeMapEntryChildren(node);
         currentDepth--;
index 3b6544edfc7443efa040ce42b582781502baa5d6..9cded4e41b03c0f93d4bd6afdae4b4c803de86d6 100644 (file)
@@ -124,9 +124,7 @@ public class XmlNormalizedNodeBodyWriter extends AbstractNormalizedNodeBodyWrite
             if (data instanceof MapEntryNode mapEntry) {
                 // Restconf allows returning one list item. We need to wrap it
                 // in map node in order to serialize it properly
-                nnWriter.write(ImmutableNodes.mapNodeBuilder(data.getIdentifier().getNodeType())
-                    .addChild(mapEntry)
-                    .build());
+                nnWriter.write(ImmutableNodes.mapNodeBuilder(data.name().getNodeType()).addChild(mapEntry).build());
             } else if (isRoot) {
                 if (data instanceof ContainerNode container && container.isEmpty()) {
                     writeEmptyDataNode(xmlWriter, container);
@@ -150,7 +148,7 @@ public class XmlNormalizedNodeBodyWriter extends AbstractNormalizedNodeBodyWrite
 
     private static void writeAndWrapInDataNode(final XMLStreamWriter xmlWriter,
             final RestconfNormalizedNodeWriter nnWriter, final NormalizedNode data) throws IOException {
-        final QName nodeType = data.getIdentifier().getNodeType();
+        final QName nodeType = data.name().getNodeType();
         final String namespace = nodeType.getNamespace().toString();
         try {
             xmlWriter.writeStartElement(XMLConstants.DEFAULT_NS_PREFIX, nodeType.getLocalName(), namespace);
@@ -165,7 +163,7 @@ public class XmlNormalizedNodeBodyWriter extends AbstractNormalizedNodeBodyWrite
 
     private static void writeEmptyDataNode(final XMLStreamWriter xmlWriter, final ContainerNode data)
             throws IOException {
-        final QName nodeType = data.getIdentifier().getNodeType();
+        final QName nodeType = data.name().getNodeType();
         final String namespace = nodeType.getNamespace().toString();
         try {
             xmlWriter.writeStartElement(XMLConstants.DEFAULT_NS_PREFIX, nodeType.getLocalName(), namespace);
@@ -179,7 +177,7 @@ public class XmlNormalizedNodeBodyWriter extends AbstractNormalizedNodeBodyWrite
 
     private static void writeElements(final XMLStreamWriter xmlWriter, final RestconfNormalizedNodeWriter nnWriter,
             final ContainerNode data) throws IOException {
-        final QName nodeType = data.getIdentifier().getNodeType();
+        final QName nodeType = data.name().getNodeType();
         final String namespace = nodeType.getNamespace().toString();
         try {
             xmlWriter.writeStartElement(XMLConstants.DEFAULT_NS_PREFIX, nodeType.getLocalName(), namespace);
index 0eb3ab7ee63b0a34b41abcbf1a060735f807fd0e..0b19dc2ef33255a0aad0a111bff7a2cc46521e4b 100644 (file)
@@ -169,7 +169,7 @@ public class RestconfDataServiceImpl implements RestconfDataService {
 
         return switch (readParams.content()) {
             case ALL, CONFIG -> {
-                final QName type = node.getIdentifier().getNodeType();
+                final QName type = node.name().getNodeType();
                 yield Response.status(Status.OK)
                     .entity(NormalizedNodePayload.ofReadData(instanceIdentifier, node, queryParams))
                     .header("ETag", '"' + type.getModule().getRevision().map(Revision::toString).orElse(null) + "-"
@@ -208,7 +208,7 @@ public class RestconfDataServiceImpl implements RestconfDataService {
                 listener.getOutputType(), uri);
 
         tx.merge(LogicalDatastoreType.OPERATIONAL,
-            Rfc8040.restconfStateStreamPath(mapToStreams.getIdentifier()), mapToStreams);
+            Rfc8040.restconfStateStreamPath(mapToStreams.name()), mapToStreams);
     }
 
     @Override
@@ -306,7 +306,7 @@ public class RestconfDataServiceImpl implements RestconfDataService {
         final YangInstanceIdentifier yangIIdContext = context.getInstanceIdentifier();
         final NormalizedNode data = payload.getData();
 
-        if (yangIIdContext.isEmpty() && !NETCONF_BASE_QNAME.equals(data.getIdentifier().getNodeType())) {
+        if (yangIIdContext.isEmpty() && !NETCONF_BASE_QNAME.equals(data.name().getNodeType())) {
             throw new RestconfDocumentedException("Instance identifier need to contain at least one path argument",
                 ErrorType.PROTOCOL, ErrorTag.MALFORMED_MESSAGE);
         }
@@ -420,7 +420,7 @@ public class RestconfDataServiceImpl implements RestconfDataService {
      */
     @VisibleForTesting
     public static void validTopLevelNodeName(final YangInstanceIdentifier path, final NormalizedNodePayload payload) {
-        final QName dataNodeType = payload.getData().getIdentifier().getNodeType();
+        final QName dataNodeType = payload.getData().name().getNodeType();
         if (path.isEmpty()) {
             if (!NETCONF_BASE_QNAME.equals(dataNodeType)) {
                 throw new RestconfDocumentedException("Instance identifier has to contain at least one path argument",
@@ -450,8 +450,8 @@ public class RestconfDataServiceImpl implements RestconfDataService {
         final PathArgument lastPathArgument = iiWithData.getInstanceIdentifier().getLastPathArgument();
         final SchemaNode schemaNode = iiWithData.getSchemaNode();
         final NormalizedNode data = payload.getData();
-        if (schemaNode instanceof ListSchemaNode) {
-            final List<QName> keyDefinitions = ((ListSchemaNode) schemaNode).getKeyDefinition();
+        if (schemaNode instanceof ListSchemaNode listSchema) {
+            final var keyDefinitions = listSchema.getKeyDefinition();
             if (lastPathArgument instanceof NodeIdentifierWithPredicates && data instanceof MapEntryNode) {
                 final Map<QName, Object> uriKeyValues = ((NodeIdentifierWithPredicates) lastPathArgument).asMap();
                 isEqualUriAndPayloadKeyValues(uriKeyValues, (MapEntryNode) data, keyDefinitions);
@@ -467,7 +467,7 @@ public class RestconfDataServiceImpl implements RestconfDataService {
                     mutableCopyUriKeyValues.remove(keyDefinition), ErrorType.PROTOCOL, ErrorTag.DATA_MISSING,
                     "Missing key %s in URI.", keyDefinition);
 
-            final Object dataKeyValue = payload.getIdentifier().getValue(keyDefinition);
+            final Object dataKeyValue = payload.name().getValue(keyDefinition);
 
             if (!uriKeyValue.equals(dataKeyValue)) {
                 final String errMsg = "The value '" + uriKeyValue + "' for key '" + keyDefinition.getLocalName()
index c65b834e955e491bacbba059f13ebd6a3594c5f0..00174f72552aa27dac888117a6fcf9d12ca042c1 100644 (file)
@@ -206,8 +206,7 @@ abstract class SubscribeToStreamUtil {
     // FIXME: callers are utter duplicates, refactor them
     private static void writeDataToDS(final DOMDataTreeWriteOperations tx, final MapEntryNode mapToStreams) {
         // FIXME: use put() here
-        tx.merge(LogicalDatastoreType.OPERATIONAL, Rfc8040.restconfStateStreamPath(mapToStreams.getIdentifier()),
-            mapToStreams);
+        tx.merge(LogicalDatastoreType.OPERATIONAL, Rfc8040.restconfStateStreamPath(mapToStreams.name()), mapToStreams);
     }
 
     private static void submitData(final DOMDataTreeWriteTransaction readWriteTransaction) {
index 7800c5e929d4ee492663975e62bb6d163e53f614..8bb7b240c0691a837f8452f10f8d52101223e9f0 100644 (file)
@@ -32,7 +32,7 @@ final class BatchedExistenceCheck {
     private volatile int outstanding;
 
     private BatchedExistenceCheck(final int total) {
-        this.outstanding = total;
+        outstanding = total;
     }
 
     static BatchedExistenceCheck start(final DOMDataTreeReadOperations tx,
@@ -40,7 +40,7 @@ final class BatchedExistenceCheck {
                                        final Collection<? extends NormalizedNode> children) {
         final BatchedExistenceCheck ret = new BatchedExistenceCheck(children.size());
         for (NormalizedNode child : children) {
-            final YangInstanceIdentifier path = parentPath.node(child.getIdentifier());
+            final YangInstanceIdentifier path = parentPath.node(child.name());
             tx.exists(datastore, path).addCallback(new FutureCallback<Boolean>() {
                 @Override
                 public void onSuccess(final Boolean result) {
index 2a5e892c551a1223ecd2a24d09458a3a284d2f6d..9ccc63d74967ae83c86879a7418f7c2f0338f9a5 100644 (file)
@@ -26,6 +26,7 @@ import org.opendaylight.restconf.nb.rfc8040.rests.utils.TransactionUtil;
 import org.opendaylight.yangtools.yang.common.ErrorTag;
 import org.opendaylight.yangtools.yang.common.ErrorType;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
+import org.opendaylight.yangtools.yang.data.api.schema.DistinctNodeContainer;
 import org.opendaylight.yangtools.yang.data.api.schema.LeafSetNode;
 import org.opendaylight.yangtools.yang.data.api.schema.MapNode;
 import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
@@ -70,15 +71,15 @@ final class MdsalRestconfTransaction extends RestconfTransaction {
                        final EffectiveModelContext schemaContext) {
         if (data instanceof MapNode || data instanceof LeafSetNode) {
             final NormalizedNode emptySubTree = ImmutableNodes.fromInstanceId(schemaContext, path);
-            merge(YangInstanceIdentifier.create(emptySubTree.getIdentifier()), emptySubTree);
+            merge(YangInstanceIdentifier.of(emptySubTree.name()), emptySubTree);
             TransactionUtil.ensureParentsByMerge(path, schemaContext, this);
 
-            final Collection<? extends NormalizedNode> children = ((NormalizedNodeContainer<?>) data).body();
+            final Collection<? extends NormalizedNode> children = ((DistinctNodeContainer<?, ?>) data).body();
             final BatchedExistenceCheck check =
                 BatchedExistenceCheck.start(verifyNotNull(rwTx), CONFIGURATION, path, children);
 
             for (final NormalizedNode child : children) {
-                final YangInstanceIdentifier childPath = path.node(child.getIdentifier());
+                final YangInstanceIdentifier childPath = path.node(child.name());
                 verifyNotNull(rwTx).put(CONFIGURATION, childPath, child);
             }
             // ... finally collect existence checks and abort the transaction if any of them failed.
@@ -96,11 +97,11 @@ final class MdsalRestconfTransaction extends RestconfTransaction {
                         final EffectiveModelContext schemaContext) {
         if (data instanceof MapNode || data instanceof LeafSetNode) {
             final NormalizedNode emptySubtree = ImmutableNodes.fromInstanceId(schemaContext, path);
-            merge(YangInstanceIdentifier.create(emptySubtree.getIdentifier()), emptySubtree);
+            merge(YangInstanceIdentifier.of(emptySubtree.name()), emptySubtree);
             TransactionUtil.ensureParentsByMerge(path, schemaContext, this);
 
             for (final NormalizedNode child : ((NormalizedNodeContainer<?>) data).body()) {
-                final YangInstanceIdentifier childPath = path.node(child.getIdentifier());
+                final YangInstanceIdentifier childPath = path.node(child.name());
                 verifyNotNull(rwTx).put(CONFIGURATION, childPath, child);
             }
         } else {
index 308f22ce8f9e64fa76ffbf5eba8ca22bacb3beed..e0103ac7aea82cfaac0e158c967cf2e451f0b14d 100644 (file)
@@ -89,10 +89,10 @@ final class NetconfRestconfTransaction extends RestconfTransaction {
             final EffectiveModelContext schemaContext) {
         if (data instanceof MapNode || data instanceof LeafSetNode) {
             final NormalizedNode emptySubTree = ImmutableNodes.fromInstanceId(schemaContext, path);
-            merge(YangInstanceIdentifier.create(emptySubTree.getIdentifier()), emptySubTree);
+            merge(YangInstanceIdentifier.of(emptySubTree.name()), emptySubTree);
 
             for (final NormalizedNode child : ((NormalizedNodeContainer<?>) data).body()) {
-                final YangInstanceIdentifier childPath = path.node(child.getIdentifier());
+                final YangInstanceIdentifier childPath = path.node(child.name());
                 enqueueOperation(() -> netconfService.create(CONFIGURATION, childPath, child, Optional.empty()));
             }
         } else {
@@ -105,10 +105,10 @@ final class NetconfRestconfTransaction extends RestconfTransaction {
             final EffectiveModelContext schemaContext) {
         if (data instanceof MapNode || data instanceof LeafSetNode) {
             final NormalizedNode emptySubTree = ImmutableNodes.fromInstanceId(schemaContext, path);
-            merge(YangInstanceIdentifier.create(emptySubTree.getIdentifier()), emptySubTree);
+            merge(YangInstanceIdentifier.of(emptySubTree.name()), emptySubTree);
 
             for (final NormalizedNode child : ((NormalizedNodeContainer<?>) data).body()) {
-                final YangInstanceIdentifier childPath = path.node(child.getIdentifier());
+                final YangInstanceIdentifier childPath = path.node(child.name());
                 enqueueOperation(() -> netconfService.replace(CONFIGURATION, childPath, child, Optional.empty()));
             }
         } else {
index 35cf4bdd0dd0df416480656cbe622e439eb7d1b4..a115719e6ece74fef8c2e004343ce0d9ef4f9fe6 100644 (file)
@@ -9,7 +9,6 @@ package org.opendaylight.restconf.nb.rfc8040.rests.utils;
 
 import com.google.common.util.concurrent.FluentFuture;
 import java.net.URI;
-import java.util.Collection;
 import java.util.Optional;
 import javax.ws.rs.core.Response;
 import javax.ws.rs.core.Response.Status;
@@ -30,7 +29,6 @@ import org.opendaylight.restconf.nb.rfc8040.utils.parser.ParserIdentifier;
 import org.opendaylight.yangtools.yang.common.ErrorTag;
 import org.opendaylight.yangtools.yang.common.ErrorType;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
-import org.opendaylight.yangtools.yang.data.api.schema.MapEntryNode;
 import org.opendaylight.yangtools.yang.data.api.schema.MapNode;
 import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
 import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNodeContainer;
@@ -153,7 +151,7 @@ public final class PostDataTransactionUtil {
             ParserIdentifier.toInstanceIdentifier(point.value(), schemaContext, Optional.empty());
         int lastItemPosition = 0;
         for (final NormalizedNode nodeChild : readList.body()) {
-            if (nodeChild.getIdentifier().equals(instanceIdentifier.getInstanceIdentifier().getLastPathArgument())) {
+            if (nodeChild.name().equals(instanceIdentifier.getInstanceIdentifier().getLastPathArgument())) {
                 break;
             }
             lastItemPosition++;
@@ -163,12 +161,12 @@ public final class PostDataTransactionUtil {
         }
         int lastInsertedPosition = 0;
         final NormalizedNode emptySubtree = ImmutableNodes.fromInstanceId(schemaContext, parent);
-        transaction.merge(YangInstanceIdentifier.create(emptySubtree.getIdentifier()), emptySubtree);
+        transaction.merge(YangInstanceIdentifier.of(emptySubtree.name()), emptySubtree);
         for (final NormalizedNode nodeChild : readList.body()) {
             if (lastInsertedPosition == lastItemPosition) {
                 transaction.replace(path, data, schemaContext);
             }
-            final YangInstanceIdentifier childPath = parent.node(nodeChild.getIdentifier());
+            final YangInstanceIdentifier childPath = parent.node(nodeChild.name());
             transaction.replace(childPath, nodeChild, schemaContext);
             lastInsertedPosition++;
         }
@@ -200,10 +198,10 @@ public final class PostDataTransactionUtil {
         }
 
         YangInstanceIdentifier path = initialPath;
-        if (data instanceof MapNode) {
-            final Collection<MapEntryNode> children = ((MapNode) data).body();
+        if (data instanceof MapNode mapData) {
+            final var children = mapData.body();
             if (!children.isEmpty()) {
-                path = path.node(children.iterator().next().getIdentifier());
+                path = path.node(children.iterator().next().name());
             }
         }
 
index 546098b74822d1f39afdbfaacfff43b441cb60cd..08b37922c0564bdc9a41712470edc0ff2d3e2c81 100644 (file)
@@ -149,7 +149,7 @@ public final class PutDataTransactionUtil {
             ParserIdentifier.toInstanceIdentifier(point.value(), schemaContext, Optional.empty());
         int lastItemPosition = 0;
         for (final NormalizedNode nodeChild : readList.body()) {
-            if (nodeChild.getIdentifier().equals(instanceIdentifier.getInstanceIdentifier().getLastPathArgument())) {
+            if (nodeChild.name().equals(instanceIdentifier.getInstanceIdentifier().getLastPathArgument())) {
                 break;
             }
             lastItemPosition++;
@@ -159,12 +159,12 @@ public final class PutDataTransactionUtil {
         }
         int lastInsertedPosition = 0;
         final NormalizedNode emptySubtree = ImmutableNodes.fromInstanceId(schemaContext, path.getParent());
-        transaction.merge(YangInstanceIdentifier.create(emptySubtree.getIdentifier()), emptySubtree);
+        transaction.merge(YangInstanceIdentifier.of(emptySubtree.name()), emptySubtree);
         for (final NormalizedNode nodeChild : readList.body()) {
             if (lastInsertedPosition == lastItemPosition) {
                 transaction.replace(path, data, schemaContext);
             }
-            final YangInstanceIdentifier childPath = path.getParent().node(nodeChild.getIdentifier());
+            final YangInstanceIdentifier childPath = path.coerceParent().node(nodeChild.name());
             transaction.replace(childPath, nodeChild, schemaContext);
             lastInsertedPosition++;
         }
index d332412d233a8bc22774a9288b3b5cd2beb3bf06..69eba92e07b24e81fc5cbd0ae897549c72fd3438 100644 (file)
@@ -137,7 +137,7 @@ public final class ReadDataTransactionUtil {
 
         final var ctxNode = DataSchemaContextTree.from(ctx).findChild(path).orElseThrow();
         if (readData instanceof ContainerNode container) {
-            final var builder = Builders.containerBuilder().withNodeIdentifier(container.getIdentifier());
+            final var builder = Builders.containerBuilder().withNodeIdentifier(container.name());
             buildCont(builder, container.body(), ctxNode, trim);
             return builder.build();
         } else if (readData instanceof MapEntryNode mapEntry) {
@@ -145,7 +145,7 @@ public final class ReadDataTransactionUtil {
                 throw new IllegalStateException("Input " + mapEntry + " does not match " + ctxNode);
             }
 
-            final var builder = Builders.mapEntryBuilder().withNodeIdentifier(mapEntry.getIdentifier());
+            final var builder = Builders.mapEntryBuilder().withNodeIdentifier(mapEntry.name());
             buildMapEntryBuilder(builder, mapEntry.body(), ctxNode, trim, listSchema.getKeyDefinition());
             return builder.build();
         } else {
@@ -175,7 +175,7 @@ public final class ReadDataTransactionUtil {
 
     private static void appendContainer(final DataContainerNodeBuilder<?, ?> builder, final ContainerNode container,
             final DataSchemaContext ctxNode, final boolean trim) {
-        final var childBuilder = Builders.containerBuilder().withNodeIdentifier(container.getIdentifier());
+        final var childBuilder = Builders.containerBuilder().withNodeIdentifier(container.name());
         buildCont(childBuilder, container.body(), ctxNode, trim);
         builder.withChild(childBuilder.build());
     }
@@ -242,7 +242,7 @@ public final class ReadDataTransactionUtil {
             case SYSTEM -> Builders.mapBuilder();
             case USER -> Builders.orderedMapBuilder();
         };
-        buildList(childBuilder.withNodeIdentifier(map.getIdentifier()), map.body(), childCtx, trim,
+        buildList(childBuilder.withNodeIdentifier(map.name()), map.body(), childCtx, trim,
             listSchema.getKeyDefinition());
         builder.withChild(childBuilder.build());
     }
@@ -252,7 +252,7 @@ public final class ReadDataTransactionUtil {
             final List<@NonNull QName> keys) {
         for (var entry : entries) {
             final var childCtx = getChildContext(ctxNode, entry);
-            final var mapEntryBuilder = Builders.mapEntryBuilder().withNodeIdentifier(entry.getIdentifier());
+            final var mapEntryBuilder = Builders.mapEntryBuilder().withNodeIdentifier(entry.name());
             buildMapEntryBuilder(mapEntryBuilder, entry.body(), childCtx, trim, keys);
             builder.withChild(mapEntryBuilder.build());
         }
@@ -414,8 +414,8 @@ public final class ReadDataTransactionUtil {
      */
     private static void validateNodeMerge(final @NonNull NormalizedNode stateDataNode,
                                           final @NonNull NormalizedNode configDataNode) {
-        final QNameModule moduleOfStateData = stateDataNode.getIdentifier().getNodeType().getModule();
-        final QNameModule moduleOfConfigData = configDataNode.getIdentifier().getNodeType().getModule();
+        final QNameModule moduleOfStateData = stateDataNode.name().getNodeType().getModule();
+        final QNameModule moduleOfConfigData = configDataNode.name().getNodeType().getModule();
         if (!moduleOfStateData.equals(moduleOfConfigData)) {
             throw new RestconfDocumentedException("Unable to merge data from different modules.");
         }
@@ -432,14 +432,14 @@ public final class ReadDataTransactionUtil {
                                                           final @NonNull NormalizedNode stateDataNode) {
         final DataContainerNodeBuilder<NodeIdentifierWithPredicates, MapEntryNode> mapEntryBuilder = ImmutableNodes
                 .mapEntryBuilder();
-        mapEntryBuilder.withNodeIdentifier((NodeIdentifierWithPredicates) configDataNode.getIdentifier());
+        mapEntryBuilder.withNodeIdentifier((NodeIdentifierWithPredicates) configDataNode.name());
 
         // MAP CONFIG DATA
         mapRpcDataNode(configDataNode, mapEntryBuilder);
         // MAP STATE DATA
         mapRpcDataNode(stateDataNode, mapEntryBuilder);
 
-        return ImmutableNodes.mapNodeBuilder(configDataNode.getIdentifier().getNodeType())
+        return ImmutableNodes.mapNodeBuilder(configDataNode.name().getNodeType())
             .addChild(mapEntryBuilder.build())
             .build();
     }
@@ -467,7 +467,7 @@ public final class ReadDataTransactionUtil {
                                                        final @NonNull NormalizedNode stateDataNode) {
         if (configDataNode instanceof UserMapNode) {
             final CollectionNodeBuilder<MapEntryNode, UserMapNode> builder = Builders
-                    .orderedMapBuilder().withNodeIdentifier(((MapNode) configDataNode).getIdentifier());
+                    .orderedMapBuilder().withNodeIdentifier(((MapNode) configDataNode).name());
 
             mapValueToBuilder(
                     ((UserMapNode) configDataNode).body(), ((UserMapNode) stateDataNode).body(), builder);
@@ -475,7 +475,7 @@ public final class ReadDataTransactionUtil {
             return builder.build();
         } else if (configDataNode instanceof MapNode) {
             final CollectionNodeBuilder<MapEntryNode, SystemMapNode> builder = ImmutableNodes
-                    .mapNodeBuilder().withNodeIdentifier(((MapNode) configDataNode).getIdentifier());
+                    .mapNodeBuilder().withNodeIdentifier(((MapNode) configDataNode).name());
 
             mapValueToBuilder(
                     ((MapNode) configDataNode).body(), ((MapNode) stateDataNode).body(), builder);
@@ -483,7 +483,7 @@ public final class ReadDataTransactionUtil {
             return builder.build();
         } else if (configDataNode instanceof MapEntryNode) {
             final DataContainerNodeBuilder<NodeIdentifierWithPredicates, MapEntryNode> builder = ImmutableNodes
-                    .mapEntryBuilder().withNodeIdentifier(((MapEntryNode) configDataNode).getIdentifier());
+                    .mapEntryBuilder().withNodeIdentifier(((MapEntryNode) configDataNode).name());
 
             mapValueToBuilder(
                     ((MapEntryNode) configDataNode).body(), ((MapEntryNode) stateDataNode).body(), builder);
@@ -491,7 +491,7 @@ public final class ReadDataTransactionUtil {
             return builder.build();
         } else if (configDataNode instanceof ContainerNode) {
             final DataContainerNodeBuilder<NodeIdentifier, ContainerNode> builder = Builders
-                    .containerBuilder().withNodeIdentifier(((ContainerNode) configDataNode).getIdentifier());
+                    .containerBuilder().withNodeIdentifier(((ContainerNode) configDataNode).name());
 
             mapValueToBuilder(
                     ((ContainerNode) configDataNode).body(), ((ContainerNode) stateDataNode).body(), builder);
@@ -499,43 +499,43 @@ public final class ReadDataTransactionUtil {
             return builder.build();
         } else if (configDataNode instanceof ChoiceNode) {
             final DataContainerNodeBuilder<NodeIdentifier, ChoiceNode> builder = Builders
-                    .choiceBuilder().withNodeIdentifier(((ChoiceNode) configDataNode).getIdentifier());
+                    .choiceBuilder().withNodeIdentifier(((ChoiceNode) configDataNode).name());
 
             mapValueToBuilder(
                     ((ChoiceNode) configDataNode).body(), ((ChoiceNode) stateDataNode).body(), builder);
 
             return builder.build();
         } else if (configDataNode instanceof LeafNode) {
-            return ImmutableNodes.leafNode(configDataNode.getIdentifier().getNodeType(), configDataNode.body());
+            return ImmutableNodes.leafNode(configDataNode.name().getNodeType(), configDataNode.body());
         } else if (configDataNode instanceof UserLeafSetNode) {
             final ListNodeBuilder<Object, UserLeafSetNode<Object>> builder = Builders
-                .orderedLeafSetBuilder().withNodeIdentifier(((UserLeafSetNode<?>) configDataNode).getIdentifier());
+                .orderedLeafSetBuilder().withNodeIdentifier(((UserLeafSetNode<?>) configDataNode).name());
 
             mapValueToBuilder(((UserLeafSetNode<Object>) configDataNode).body(),
                     ((UserLeafSetNode<Object>) stateDataNode).body(), builder);
             return builder.build();
         } else if (configDataNode instanceof LeafSetNode) {
             final ListNodeBuilder<Object, SystemLeafSetNode<Object>> builder = Builders
-                    .leafSetBuilder().withNodeIdentifier(((LeafSetNode<?>) configDataNode).getIdentifier());
+                    .leafSetBuilder().withNodeIdentifier(((LeafSetNode<?>) configDataNode).name());
 
             mapValueToBuilder(((LeafSetNode<Object>) configDataNode).body(),
                     ((LeafSetNode<Object>) stateDataNode).body(), builder);
             return builder.build();
         } else if (configDataNode instanceof LeafSetEntryNode) {
             return Builders.leafSetEntryBuilder()
-                    .withNodeIdentifier(((LeafSetEntryNode<?>) configDataNode).getIdentifier())
+                    .withNodeIdentifier(((LeafSetEntryNode<?>) configDataNode).name())
                     .withValue(configDataNode.body())
                     .build();
         } else if (configDataNode instanceof UnkeyedListNode) {
             final CollectionNodeBuilder<UnkeyedListEntryNode, UnkeyedListNode> builder = Builders
-                    .unkeyedListBuilder().withNodeIdentifier(((UnkeyedListNode) configDataNode).getIdentifier());
+                    .unkeyedListBuilder().withNodeIdentifier(((UnkeyedListNode) configDataNode).name());
 
             mapValueToBuilder(((UnkeyedListNode) configDataNode).body(),
                     ((UnkeyedListNode) stateDataNode).body(), builder);
             return builder.build();
         } else if (configDataNode instanceof UnkeyedListEntryNode) {
             final DataContainerNodeBuilder<NodeIdentifier, UnkeyedListEntryNode> builder = Builders
-                .unkeyedListEntryBuilder().withNodeIdentifier(((UnkeyedListEntryNode) configDataNode).getIdentifier());
+                .unkeyedListEntryBuilder().withNodeIdentifier(((UnkeyedListEntryNode) configDataNode).name());
 
             mapValueToBuilder(((UnkeyedListEntryNode) configDataNode).body(),
                     ((UnkeyedListEntryNode) stateDataNode).body(), builder);
@@ -556,9 +556,9 @@ public final class ReadDataTransactionUtil {
             final @NonNull Collection<T> configData, final @NonNull Collection<T> stateData,
             final @NonNull NormalizedNodeContainerBuilder<?, PathArgument, T, ?> builder) {
         final Map<PathArgument, T> configMap = configData.stream().collect(
-                Collectors.toMap(NormalizedNode::getIdentifier, Function.identity()));
+                Collectors.toMap(NormalizedNode::name, Function.identity()));
         final Map<PathArgument, T> stateMap = stateData.stream().collect(
-                Collectors.toMap(NormalizedNode::getIdentifier, Function.identity()));
+                Collectors.toMap(NormalizedNode::name, Function.identity()));
 
         // merge config and state data of children with different identifiers
         mapDataToBuilder(configMap, stateMap, builder);
index badd248d5d59c0351487a335ef274d2aa2dab7da..0a87cf9e479be4f6233781b82e08033524ce5306 100644 (file)
@@ -8,12 +8,9 @@
 package org.opendaylight.restconf.nb.rfc8040.rests.utils;
 
 import java.util.ArrayList;
-import java.util.Iterator;
-import java.util.List;
 import org.opendaylight.restconf.nb.rfc8040.rests.transactions.RestconfTransaction;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.PathArgument;
-import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
 import org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNodes;
 import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
 import org.opendaylight.yangtools.yang.model.api.SchemaContext;
@@ -38,15 +35,15 @@ public final class TransactionUtil {
     public static void ensureParentsByMerge(final YangInstanceIdentifier path,
                                             final EffectiveModelContext schemaContext,
                                             final RestconfTransaction transaction) {
-        final List<PathArgument> normalizedPathWithoutChildArgs = new ArrayList<>();
+        final var normalizedPathWithoutChildArgs = new ArrayList<PathArgument>();
         YangInstanceIdentifier rootNormalizedPath = null;
 
-        final Iterator<PathArgument> it = path.getPathArguments().iterator();
+        final var it = path.getPathArguments().iterator();
 
         while (it.hasNext()) {
-            final PathArgument pathArgument = it.next();
+            final var pathArgument = it.next();
             if (rootNormalizedPath == null) {
-                rootNormalizedPath = YangInstanceIdentifier.create(pathArgument);
+                rootNormalizedPath = YangInstanceIdentifier.of(pathArgument);
             }
 
             if (it.hasNext()) {
@@ -58,8 +55,7 @@ public final class TransactionUtil {
             return;
         }
 
-        final NormalizedNode parentStructure = ImmutableNodes.fromInstanceId(schemaContext,
-                YangInstanceIdentifier.create(normalizedPathWithoutChildArgs));
-        transaction.merge(rootNormalizedPath, parentStructure);
+        transaction.merge(rootNormalizedPath,
+            ImmutableNodes.fromInstanceId(schemaContext, YangInstanceIdentifier.of(normalizedPathWithoutChildArgs)));
     }
 }
index cf8a0825747501af41b5423b822fdd591429559b..24834be811a97fdbeee767e8ae0d4b70f1392ec4 100644 (file)
@@ -75,7 +75,7 @@ public final class YangInstanceIdentifierDeserializer {
         }
 
         Result(final List<PathArgument> steps, final SchemaInferenceStack stack, final SchemaNode node) {
-            path = YangInstanceIdentifier.create(steps);
+            path = YangInstanceIdentifier.of(steps);
             this.stack = requireNonNull(stack);
             this.node = requireNonNull(node);
         }
index 11b4859ba76c14b91e8a54dc63e5f81f0e817160..96c846aef63df658c4d5719fe5614cbe5c4b8a4a 100644 (file)
@@ -134,7 +134,7 @@ public class ParameterAwareNormalizedNodeWriterFieldsTest {
     @Test
     public void writeMapNodeAllFieldsTest() throws Exception {
         final var parameterWriter = ParameterAwareNormalizedNodeWriter.forStreamWriter(writer, null,
-            List.of(Set.of(keyLeafNodeData.getIdentifier().getNodeType())));
+            List.of(Set.of(keyLeafNodeData.name().getNodeType())));
 
         parameterWriter.write(mapNodeData);
 
index b4afc7339596eb9a9d6ac4f6f474b8f59391f766..a4a41d270158f1d92973cd02950a977133d9138b 100644 (file)
@@ -166,7 +166,7 @@ public class XmlBodyReaderMountPointTest extends AbstractBodyReaderTest {
         // check return value
         checkMountPointNormalizedNodePayload(payload);
         // check if container was found both according to its name and namespace
-        final var dataNodeType = payload.getData().getIdentifier().getNodeType();
+        final var dataNodeType = payload.getData().name().getNodeType();
         assertEquals("foo-bar-container", dataNodeType.getLocalName());
         assertEquals("foo:module", dataNodeType.getNamespace().toString());
     }
@@ -185,7 +185,7 @@ public class XmlBodyReaderMountPointTest extends AbstractBodyReaderTest {
         // check return value
         checkMountPointNormalizedNodePayload(payload);
         // check if container was found both according to its name and namespace
-        final var dataNodeType = payload.getData().getIdentifier().getNodeType();
+        final var dataNodeType = payload.getData().name().getNodeType();
         assertEquals("foo-bar-container", dataNodeType.getLocalName());
         assertEquals("bar:module", dataNodeType.getNamespace().toString());
     }
index 956582d4d714dfca1681cdad536058c79c80b56b..ab6de83cbdfedf177de5be1925ed256373c1564b 100644 (file)
@@ -169,7 +169,7 @@ public class JsonPatchBodyReaderTest extends AbstractBodyReaderTest {
         final PatchContext returnValue = jsonToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(LEAF_NAME_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(LEAF_NAME_QNAME, data.name().getNodeType());
         assertEquals(ImmutableNodes.leafNode(LEAF_NAME_QNAME, "my-leaf20"), data);
     }
 
@@ -221,7 +221,7 @@ public class JsonPatchBodyReaderTest extends AbstractBodyReaderTest {
         final var returnValue = jsonToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(CONT_AUG_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(CONT_AUG_QNAME, data.name().getNodeType());
         assertEquals(expectedData, data);
     }
 
@@ -263,7 +263,7 @@ public class JsonPatchBodyReaderTest extends AbstractBodyReaderTest {
         final var returnValue = jsonToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(MAP_CONT_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(MAP_CONT_QNAME, data.name().getNodeType());
         assertEquals(expectedData, data);
     }
 
@@ -301,7 +301,7 @@ public class JsonPatchBodyReaderTest extends AbstractBodyReaderTest {
         final var returnValue = jsonToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(LEAF_SET_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(LEAF_SET_QNAME, data.name().getNodeType());
         assertEquals(expectedData, data);
     }
 
@@ -343,7 +343,7 @@ public class JsonPatchBodyReaderTest extends AbstractBodyReaderTest {
         final var returnValue = jsonToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(LIST_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(LIST_QNAME, data.name().getNodeType());
         assertEquals(expectedData, data);
     }
 
@@ -380,7 +380,7 @@ public class JsonPatchBodyReaderTest extends AbstractBodyReaderTest {
         final var returnValue = jsonToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(CHOICE_CONT_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(CHOICE_CONT_QNAME, data.name().getNodeType());
         assertEquals(expectedData, data);
     }
 }
index d0826a3a38263545b3f6a5443f216bbd75cb6043..683370e1fd4be110ab765f8a8b41de4a1694791f 100644 (file)
@@ -164,7 +164,7 @@ public class XmlPatchBodyReaderTest extends AbstractBodyReaderTest {
         final var returnValue = xmlToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(CONT_AUG_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(CONT_AUG_QNAME, data.name().getNodeType());
         assertEquals(expectedData, data);
     }
 
@@ -202,7 +202,7 @@ public class XmlPatchBodyReaderTest extends AbstractBodyReaderTest {
         final var returnValue = xmlToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(MAP_CONT_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(MAP_CONT_QNAME, data.name().getNodeType());
         assertEquals(expectedData, data);
     }
 
@@ -236,7 +236,7 @@ public class XmlPatchBodyReaderTest extends AbstractBodyReaderTest {
         final var returnValue = xmlToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(LEAF_SET_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(LEAF_SET_QNAME, data.name().getNodeType());
         assertEquals(expectedData, data);
     }
 
@@ -274,7 +274,7 @@ public class XmlPatchBodyReaderTest extends AbstractBodyReaderTest {
         final var returnValue = xmlToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(LIST_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(LIST_QNAME, data.name().getNodeType());
         assertEquals(expectedData, data);
     }
 
@@ -307,7 +307,7 @@ public class XmlPatchBodyReaderTest extends AbstractBodyReaderTest {
         final var returnValue = xmlToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(CHOICE_CONT_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(CHOICE_CONT_QNAME, data.name().getNodeType());
         assertEquals(expectedData, data);
     }
 
@@ -334,7 +334,7 @@ public class XmlPatchBodyReaderTest extends AbstractBodyReaderTest {
         final var returnValue = xmlToPatchBodyReader.readFrom(null, null, null, mediaType, null, inputStream);
         checkPatchContext(returnValue);
         final var data = returnValue.getData().get(0).getNode();
-        assertEquals(LEAF_NAME_QNAME, data.getIdentifier().getNodeType());
+        assertEquals(LEAF_NAME_QNAME, data.name().getNodeType());
         assertEquals(ImmutableNodes.leafNode(LEAF_NAME_QNAME, "my-leaf20"), data);
     }
 }
index d3e3763902e8766daf9cf9d3aa0871b6c1a8a66a..321a3373c248f6613eb5e976def9d28e28edaea2 100644 (file)
@@ -91,7 +91,7 @@ public class XmlBodyReaderTest extends AbstractBodyReaderTest {
         assertNotNull(payload);
 
         final InstanceIdentifierContext iid = payload.getInstanceIdentifierContext();
-        assertEquals(YangInstanceIdentifier.create(
+        assertEquals(YangInstanceIdentifier.of(
             new NodeIdentifier(TOP_LEVEL_LIST),
             NodeIdentifierWithPredicates.of(TOP_LEVEL_LIST, QName.create(TOP_LEVEL_LIST, "key-leaf"), "key-value")),
             iid.getInstanceIdentifier());
@@ -100,7 +100,7 @@ public class XmlBodyReaderTest extends AbstractBodyReaderTest {
         final MapEntryNode data = (MapEntryNode) payload.getData();
         assertEquals(2, data.size());
         for (final DataContainerChild child : data.body()) {
-            switch (child.getIdentifier().getNodeType().getLocalName()) {
+            switch (child.name().getNodeType().getLocalName()) {
                 case "key-leaf":
                     assertEquals("key-value", child.body());
                     break;
@@ -227,7 +227,7 @@ public class XmlBodyReaderTest extends AbstractBodyReaderTest {
         // check return value
         checkNormalizedNodePayload(payload);
         // check if container was found both according to its name and namespace
-        final var payloadNodeType = payload.getData().getIdentifier().getNodeType();
+        final var payloadNodeType = payload.getData().name().getNodeType();
         assertEquals("foo-bar-container", payloadNodeType.getLocalName());
         assertEquals("foo:module", payloadNodeType.getNamespace().toString());
     }
@@ -247,7 +247,7 @@ public class XmlBodyReaderTest extends AbstractBodyReaderTest {
         // check return value
         checkNormalizedNodePayload(payload);
         // check if container was found both according to its name and namespace
-        final var payloadNodeType = payload.getData().getIdentifier().getNodeType();
+        final var payloadNodeType = payload.getData().name().getNodeType();
         assertEquals("foo-bar-container", payloadNodeType.getLocalName());
         assertEquals("bar:module", payloadNodeType.getNamespace().toString());
     }
index 80d470c36989032fbde5c77cf79a42f9244b4012..bf4dca6d391d23c7dad241f5b08be172f7c9a72b 100644 (file)
@@ -202,7 +202,7 @@ public class RestconfDataServiceImplTest {
 
     @Test
     public void testReadData() {
-        doReturn(new MultivaluedHashMap<String, String>()).when(uriInfo).getQueryParameters();
+        doReturn(new MultivaluedHashMap<>()).when(uriInfo).getQueryParameters();
         doReturn(immediateFluentFuture(Optional.of(buildBaseCont))).when(read)
                 .read(LogicalDatastoreType.CONFIGURATION, iidBase);
         doReturn(immediateFluentFuture(Optional.empty()))
@@ -215,7 +215,7 @@ public class RestconfDataServiceImplTest {
 
     @Test
     public void testReadRootData() {
-        doReturn(new MultivaluedHashMap<String, String>()).when(uriInfo).getQueryParameters();
+        doReturn(new MultivaluedHashMap<>()).when(uriInfo).getQueryParameters();
         doReturn(immediateFluentFuture(Optional.of(wrapNodeByDataRootContainer(buildBaseContConfig))))
                 .when(read)
                 .read(LogicalDatastoreType.CONFIGURATION, YangInstanceIdentifier.of());
@@ -247,7 +247,7 @@ public class RestconfDataServiceImplTest {
      */
     @Test
     public void testReadDataMountPoint() {
-        doReturn(new MultivaluedHashMap<String, String>()).when(uriInfo).getQueryParameters();
+        doReturn(new MultivaluedHashMap<>()).when(uriInfo).getQueryParameters();
         doReturn(immediateFluentFuture(Optional.of(buildBaseContConfig))).when(read)
                 .read(LogicalDatastoreType.CONFIGURATION, iidBase);
         doReturn(immediateFluentFuture(Optional.of(buildBaseContOperational))).when(read)
@@ -263,14 +263,14 @@ public class RestconfDataServiceImplTest {
         final NormalizedNode data = ((NormalizedNodePayload) response.getEntity()).getData();
         assertTrue(data instanceof ContainerNode);
         assertEquals(3, ((ContainerNode) data).size());
-        assertTrue(((ContainerNode) data).findChildByArg(buildPlayerCont.getIdentifier()).isPresent());
-        assertTrue(((ContainerNode) data).findChildByArg(buildLibraryCont.getIdentifier()).isPresent());
-        assertTrue(((ContainerNode) data).findChildByArg(buildPlaylistList.getIdentifier()).isPresent());
+        assertNotNull(((ContainerNode) data).childByArg(buildPlayerCont.name()));
+        assertNotNull(((ContainerNode) data).childByArg(buildLibraryCont.name()));
+        assertNotNull(((ContainerNode) data).childByArg(buildPlaylistList.name()));
     }
 
     @Test
     public void testReadDataNoData() {
-        doReturn(new MultivaluedHashMap<String, String>()).when(uriInfo).getQueryParameters();
+        doReturn(new MultivaluedHashMap<>()).when(uriInfo).getQueryParameters();
         doReturn(immediateFluentFuture(Optional.empty()))
                 .when(read).read(LogicalDatastoreType.CONFIGURATION, iidBase);
         doReturn(immediateFluentFuture(Optional.empty()))
@@ -307,11 +307,11 @@ public class RestconfDataServiceImplTest {
         final NormalizedNode data = ((NormalizedNodePayload) response.getEntity()).getData();
 
         // config data present
-        assertTrue(((ContainerNode) data).findChildByArg(buildPlayerCont.getIdentifier()).isPresent());
-        assertTrue(((ContainerNode) data).findChildByArg(buildLibraryCont.getIdentifier()).isPresent());
+        assertNotNull(((ContainerNode) data).childByArg(buildPlayerCont.name()));
+        assertNotNull(((ContainerNode) data).childByArg(buildLibraryCont.name()));
 
         // state data absent
-        assertFalse(((ContainerNode) data).findChildByArg(buildPlaylistList.getIdentifier()).isPresent());
+        assertNull(((ContainerNode) data).childByArg(buildPlaylistList.name()));
     }
 
     /**
@@ -335,11 +335,11 @@ public class RestconfDataServiceImplTest {
         final NormalizedNode data = ((NormalizedNodePayload) response.getEntity()).getData();
 
         // state data present
-        assertTrue(((ContainerNode) data).findChildByArg(buildPlayerCont.getIdentifier()).isPresent());
-        assertTrue(((ContainerNode) data).findChildByArg(buildPlaylistList.getIdentifier()).isPresent());
+        assertNotNull(((ContainerNode) data).childByArg(buildPlayerCont.name()));
+        assertNotNull(((ContainerNode) data).childByArg(buildPlaylistList.name()));
 
         // config data absent
-        assertFalse(((ContainerNode) data).findChildByArg(buildLibraryCont.getIdentifier()).isPresent());
+        assertNull(((ContainerNode) data).childByArg(buildLibraryCont.name()));
     }
 
     @Test
@@ -376,7 +376,7 @@ public class RestconfDataServiceImplTest {
         final NodeIdentifierWithPredicates nodeWithKey =
                 NodeIdentifierWithPredicates.of(listQname, listKeyQname, "name of band");
 
-        doReturn(new MultivaluedHashMap<String, String>()).when(uriInfo).getQueryParameters();
+        doReturn(new MultivaluedHashMap<>()).when(uriInfo).getQueryParameters();
         final InstanceIdentifierContext iidContext = InstanceIdentifierContext.ofLocalPath(contextRef, iidBase);
         final NormalizedNodePayload payload = NormalizedNodePayload.of(iidContext, Builders.mapBuilder()
             .withNodeIdentifier(new NodeIdentifier(listQname))
@@ -388,7 +388,7 @@ public class RestconfDataServiceImplTest {
             .build());
         final MapNode data = (MapNode) payload.getData();
         final MapEntryNode entryNode = data.body().iterator().next();
-        final NodeIdentifierWithPredicates identifier = entryNode.getIdentifier();
+        final NodeIdentifierWithPredicates identifier = entryNode.name();
         final YangInstanceIdentifier node =
                 payload.getInstanceIdentifierContext().getInstanceIdentifier().node(identifier);
         doReturn(immediateFalseFluentFuture())
index 7749946fd4924f22c95f07bddfe59f2c5a688e19..fc06fbef815016458a415e00f897e65630701533 100644 (file)
@@ -49,7 +49,6 @@ import org.opendaylight.yangtools.yang.common.ErrorTag;
 import org.opendaylight.yangtools.yang.common.ErrorType;
 import org.opendaylight.yangtools.yang.common.QName;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
-import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.NodeIdentifier;
 import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
 import org.opendaylight.yangtools.yang.test.util.YangParserTestUtils;
 
@@ -99,8 +98,8 @@ public class RestconfStreamsSubscriptionServiceImplTest {
     public static void setUpBeforeTest() {
         final String name =
             "data-change-event-subscription/toaster:toaster/toasterStatus/datastore=OPERATIONAL/scope=ONE";
-        final ListenerAdapter adapter = new ListenerAdapter(YangInstanceIdentifier.create(new NodeIdentifier(
-            QName.create("http://netconfcentral.org/ns/toaster", "2009-11-20", "toaster"))),
+        final ListenerAdapter adapter = new ListenerAdapter(YangInstanceIdentifier.of(
+            QName.create("http://netconfcentral.org/ns/toaster", "2009-11-20", "toaster")),
             name, NotificationOutputType.JSON);
         ListenersBroker.getInstance().setDataChangeListeners(Map.of(name, adapter));
     }
index 06d97b77404ad6c9c730daa9885545d01dbcf679..266a677c8217fb83803f607d295f74d7f65d37d9 100644 (file)
@@ -141,7 +141,7 @@ public class PostDataTransactionUtilTest {
 
         doReturn(immediateFalseFluentFuture()).when(readWrite).exists(LogicalDatastoreType.CONFIGURATION, iid2);
         final NodeIdentifier identifier =
-                ((ContainerNode) ((Collection<?>) payload.getData().body()).iterator().next()).getIdentifier();
+                ((ContainerNode) ((Collection<?>) payload.getData().body()).iterator().next()).name();
         final YangInstanceIdentifier node = iid2.node(identifier);
         doNothing().when(readWrite).put(LogicalDatastoreType.CONFIGURATION, node.getParent(), payload.getData());
         doReturn(CommitInfo.emptyFluentFuture()).when(readWrite).commit();
@@ -168,7 +168,7 @@ public class PostDataTransactionUtilTest {
 
         final MapNode data = (MapNode) payload.getData();
         final MapEntryNode entryNode = data.body().iterator().next();
-        final NodeIdentifierWithPredicates identifier = entryNode.getIdentifier();
+        final NodeIdentifierWithPredicates identifier = entryNode.name();
         final YangInstanceIdentifier node = iidList.node(identifier);
         doReturn(immediateFalseFluentFuture()).when(readWrite).exists(LogicalDatastoreType.CONFIGURATION, node);
         doNothing().when(readWrite).put(LogicalDatastoreType.CONFIGURATION, node, entryNode);
@@ -204,7 +204,7 @@ public class PostDataTransactionUtilTest {
         doReturn(immediateFalseFluentFuture()).when(readWrite).exists(LogicalDatastoreType.CONFIGURATION,
             iid2);
         final NodeIdentifier identifier =
-                ((ContainerNode) ((Collection<?>) payload.getData().body()).iterator().next()).getIdentifier();
+                ((ContainerNode) ((Collection<?>) payload.getData().body()).iterator().next()).name();
         final YangInstanceIdentifier node = iid2.node(identifier);
         doNothing().when(readWrite).put(LogicalDatastoreType.CONFIGURATION, node.getParent(), payload.getData());
         final DOMException domException = new DOMException((short) 414, "Post request failed");
index 8b914932f2a40a8a7ca0a4ac393137b715b8082d..67e5d37210f2eb1ef347cafe700c0b227146a233 100644 (file)
@@ -156,7 +156,7 @@ public class ReadDataTransactionUtilTest {
                 .withChild(ImmutableNodes.leafNode(QName.create(DATA.base, "exampleLeaf"), "i am leaf"))
                 .build();
 
-        final YangInstanceIdentifier path = YangInstanceIdentifier.builder().node(content.getIdentifier()).build();
+        final YangInstanceIdentifier path = YangInstanceIdentifier.builder().node(content.name()).build();
 
         doReturn(immediateFluentFuture(Optional.of(content))).when(read)
                 .read(LogicalDatastoreType.CONFIGURATION, path);
index 9e1fff2771e42f60f2122591a81c2650e997330a..1d036df5ca0bab431b306bc7239cbc99f603f4eb 100644 (file)
@@ -51,7 +51,6 @@ import org.opendaylight.yang.gen.v1.urn.sal.restconf.event.subscription.rev14070
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.opendaylight.yangtools.yang.binding.util.BindingMap;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
-import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.NodeIdentifier;
 import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
 import org.opendaylight.yangtools.yang.test.util.YangParserTestUtils;
 import org.skyscreamer.jsonassert.JSONAssert;
@@ -102,8 +101,7 @@ public class ListenerAdapterTest extends AbstractConcurrentDataBrokerTest {
     private static final String XML_NOTIF_WITHOUT_DATA_DELETE =
             "/listener-adapter-test/notif-without-data-delete.xml";
 
-    private static final YangInstanceIdentifier PATCH_CONT_YIID =
-            YangInstanceIdentifier.create(new NodeIdentifier(PatchCont.QNAME));
+    private static final YangInstanceIdentifier PATCH_CONT_YIID = YangInstanceIdentifier.of(PatchCont.QNAME);
 
     private static EffectiveModelContext SCHEMA_CONTEXT;
 
index 7ef2e5a249481a2ee12628e63ca862d96b6b9c26..9477411bd0a97b2a8b0941533c956587078e1f3d 100644 (file)
@@ -33,14 +33,14 @@ import org.opendaylight.yangtools.yang.model.api.EffectiveModelContextProvider;
  * @author Michael Vorburger.ch
  */
 public class InMemoryMdsalModule extends AbstractModule {
-
     private static final int NOTIFICATION_SERVICE_QUEUE_DEPTH = 128;
 
     private final AbstractBaseDataBrokerTest dataBrokerTest;
     private final DOMNotificationRouter domNotificationRouter;
 
     public InMemoryMdsalModule() throws Exception {
-        dataBrokerTest = new AbstractConcurrentDataBrokerTest(true) { // NOT AbstractDataBrokerTest
+        dataBrokerTest = new AbstractConcurrentDataBrokerTest(true) {
+            // NOT AbstractDataBrokerTest
         };
         dataBrokerTest.setup();
 
index ccee1c33766f5f6edc7d7a5e51165d983fc6d9c8..c72791758f4aa28acc94de654784153d1c15148f 100644 (file)
@@ -30,7 +30,6 @@ import org.opendaylight.yangtools.yang.common.QName;
 import org.opendaylight.yangtools.yang.common.Revision;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
 import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode;
-import org.opendaylight.yangtools.yang.data.api.schema.DataContainerChild;
 import org.opendaylight.yangtools.yang.data.api.schema.LeafNode;
 import org.opendaylight.yangtools.yang.data.api.schema.MapEntryNode;
 import org.opendaylight.yangtools.yang.data.api.schema.MapNode;
@@ -122,11 +121,10 @@ public class RestconfMappingNodeUtilTest {
 
     private static void assertMappedData(final Map<QName, Object> map, final MapEntryNode mappedData) {
         assertNotNull(mappedData);
-        for (final DataContainerChild child : mappedData.body()) {
-            if (child instanceof LeafNode) {
-                final LeafNode<?> leaf = (LeafNode<?>) child;
-                assertTrue(map.containsKey(leaf.getIdentifier().getNodeType()));
-                assertEquals(map.get(leaf.getIdentifier().getNodeType()), leaf.body());
+        for (var child : mappedData.body()) {
+            if (child instanceof LeafNode<?> leaf) {
+                assertTrue(map.containsKey(leaf.name().getNodeType()));
+                assertEquals(map.get(leaf.name().getNodeType()), leaf.body());
             }
         }
     }
@@ -139,11 +137,11 @@ public class RestconfMappingNodeUtilTest {
      */
     private static void verifyDeviations(final ContainerNode containerNode) {
         int deviationsFound = 0;
-        for (final DataContainerChild child : containerNode.body()) {
-            if (child instanceof MapNode) {
-                for (final MapEntryNode mapEntryNode : ((MapNode) child).body()) {
-                    for (final DataContainerChild dataContainerChild : mapEntryNode.body()) {
-                        if (dataContainerChild.getIdentifier().getNodeType().equals(Deviation.QNAME)) {
+        for (var child : containerNode.body()) {
+            if (child instanceof MapNode mapChild) {
+                for (var mapEntryNode : mapChild.body()) {
+                    for (var dataContainerChild : mapEntryNode.body()) {
+                        if (dataContainerChild.name().getNodeType().equals(Deviation.QNAME)) {
                             deviationsFound++;
                         }
                     }
@@ -162,17 +160,17 @@ public class RestconfMappingNodeUtilTest {
     private static void verifyLoadedModules(final ContainerNode containerNode) {
         final Map<String, String> loadedModules = new HashMap<>();
 
-        for (final DataContainerChild child : containerNode.body()) {
+        for (var child : containerNode.body()) {
             if (child instanceof LeafNode) {
-                assertEquals(IetfYangLibrary.MODULE_SET_ID_LEAF_QNAME, child.getIdentifier().getNodeType());
+                assertEquals(IetfYangLibrary.MODULE_SET_ID_LEAF_QNAME, child.name().getNodeType());
             }
-            if (child instanceof MapNode) {
-                assertEquals(IetfYangLibrary.MODULE_QNAME_LIST, child.getIdentifier().getNodeType());
-                for (final MapEntryNode mapEntryNode : ((MapNode) child).body()) {
+            if (child instanceof MapNode mapChild) {
+                assertEquals(IetfYangLibrary.MODULE_QNAME_LIST, child.name().getNodeType());
+                for (var mapEntryNode : mapChild.body()) {
                     String name = "";
                     String revision = "";
-                    for (final DataContainerChild dataContainerChild : mapEntryNode.body()) {
-                        switch (dataContainerChild.getIdentifier().getNodeType().getLocalName()) {
+                    for (var dataContainerChild : mapEntryNode.body()) {
+                        switch (dataContainerChild.name().getNodeType().getLocalName()) {
                             case "name":
                                 name = String.valueOf(dataContainerChild.body());
                                 break;
@@ -181,7 +179,7 @@ public class RestconfMappingNodeUtilTest {
                                 break;
                             default :
                                 LOG.info("Unknown local name '{}' of node.",
-                                        dataContainerChild.getIdentifier().getNodeType().getLocalName());
+                                    dataContainerChild.name().getNodeType().getLocalName());
                                 break;
                         }
                     }