Update ParserIdentifier a bit

Hide a testing-only method and mark a method for movement.

JIRA: NETCONF-631
Change-Id: I73f8e32803bec49dce747503206cde78df75fbce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/parser/ParserIdentifier.java b/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/parser/ParserIdentifier.java
index 14cef762c52e91b2696172c0cab0aa2ccf2d6312..5b550dd711e568991e540026ac064f039e3ff13b 100644 (file)
--- a/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/parser/ParserIdentifier.java
+++ b/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/parser/ParserIdentifier.java
@@ -79,6 +79,10 @@ public final class ParserIdentifier {
      *           - mount point service
      * @return {@link InstanceIdentifierContext}
      */
+    // FIXME: NETCONF-631: this method should not be here, it should be a static factory in InstanceIdentifierContext:
+    //
+    //        @NonNull InstanceIdentifierContext forUrl(identifier, schemaContexxt, mountPointService)
+    //
     public static InstanceIdentifierContext<?> toInstanceIdentifier(final String identifier,
             final EffectiveModelContext schemaContext, final Optional<DOMMountPointService> mountPointService) {
         if (identifier == null || !identifier.contains(RestconfConstants.MOUNT)) {
@@ -170,7 +174,8 @@ public final class ParserIdentifier {
      *             path parameter
      * @return {@link QName}
      */
-    public static Entry<String, Revision> makeQNameFromIdentifier(final String identifier) {
+    @VisibleForTesting
+    static Entry<String, Revision> makeQNameFromIdentifier(final String identifier) {
         // check if more than one slash is not used as path separator
         if (identifier.contains("//")) {
             LOG.debug("URI has bad format. It should be \'moduleName/yyyy-MM-dd\' {}", identifier);