Cleanup WebInitializer a bit 53/102353/4
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 12 Sep 2022 15:32:37 +0000 (17:32 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Tue, 13 Sep 2022 10:04:11 +0000 (12:04 +0200)
This class should be final and should specify its close() method.

Change-Id: Ia3e839781f5f7ea658af9ff5157260be197ff28e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
restconf/sal-rest-docgen/src/main/java/org/opendaylight/netconf/sal/rest/doc/jaxrs/WebInitializer.java

index e2e5398463e85ea66159b752c1c29f8722b171e1..0bfae0a191ddead3c7b6c7adbef4992acd462801 100644 (file)
@@ -12,7 +12,6 @@ import javax.ws.rs.core.Application;
 import org.opendaylight.aaa.web.ResourceDetails;
 import org.opendaylight.aaa.web.ServletDetails;
 import org.opendaylight.aaa.web.WebContext;
-import org.opendaylight.aaa.web.WebContextBuilder;
 import org.opendaylight.aaa.web.WebContextSecurer;
 import org.opendaylight.aaa.web.WebServer;
 import org.opendaylight.aaa.web.servlet.ServletSupport;
@@ -23,14 +22,19 @@ import org.opendaylight.yangtools.concepts.Registration;
  *
  * @author Thomas Pantelis
  */
-public class WebInitializer {
+public final class WebInitializer implements AutoCloseable {
     private final Registration registration;
 
-    public WebInitializer(WebServer webServer,  WebContextSecurer webContextSecurer, ServletSupport servletSupport,
-            Application webApp) throws ServletException {
-        WebContextBuilder webContextBuilder = WebContext.builder().contextPath("apidoc").supportsSessions(true)
-            .addServlet(ServletDetails.builder().servlet(servletSupport.createHttpServletBuilder(webApp).build())
-                    .addUrlPattern("/swagger2/apis/*").addUrlPattern("/openapi3/apis/*").build())
+    public WebInitializer(final WebServer webServer, final WebContextSecurer webContextSecurer,
+            final ServletSupport servletSupport, final Application webApp) throws ServletException {
+        var webContextBuilder = WebContext.builder()
+            .contextPath("apidoc")
+            .supportsSessions(true)
+            .addServlet(ServletDetails.builder()
+                .servlet(servletSupport.createHttpServletBuilder(webApp).build())
+                .addUrlPattern("/swagger2/apis/*")
+                .addUrlPattern("/openapi3/apis/*")
+                .build())
             .addResource(ResourceDetails.builder().name("/explorer").build());
 
         webContextSecurer.requireAuthentication(webContextBuilder, "/swagger2/*", "/openapi3/*");
@@ -38,6 +42,7 @@ public class WebInitializer {
         registration = webServer.registerWebContext(webContextBuilder.build());
     }
 
+    @Override
     public void close() {
         registration.close();
     }