Use try-with-resources to get localport

Eclipse is flagging the use of AutoCloseable, oblige by restructuring
the code a bit.

Change-Id: I37d089ab9c783022ade6c66d6544613abc4f3fc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/protocol/netconf-client/src/test/java/org/opendaylight/netconf/client/NetconfClientFactoryImplTest.java b/protocol/netconf-client/src/test/java/org/opendaylight/netconf/client/NetconfClientFactoryImplTest.java
index e349d774fe68a9a02a394c4c32e2f5cafdc1d2b2..e082e0c6a9ac4e7a9f47ac5a6e767970498fe75d 100644 (file)
--- a/protocol/netconf-client/src/test/java/org/opendaylight/netconf/client/NetconfClientFactoryImplTest.java
+++ b/protocol/netconf-client/src/test/java/org/opendaylight/netconf/client/NetconfClientFactoryImplTest.java
@@ -126,14 +126,19 @@ class NetconfClientFactoryImplTest {
         doNothing().when(serverTransportListener).onTransportChannelEstablished(any());
 
         // create temp socket to get available port for test
-        final var socket = new ServerSocket(0);
+        final int localPort;
+        try (var socket = new ServerSocket(0)) {
+            localPort = socket.getLocalPort();
+        }
+
         final var address = IetfInetUtil.ipAddressFor(InetAddress.getLoopbackAddress());
-        final var port = new PortNumber(Uint16.valueOf(socket.getLocalPort()));
-        socket.close();
+        final var port = new PortNumber(Uint16.valueOf(localPort));
 
         tcpServerParams = new TcpServerParametersBuilder().setLocalAddress(address).setLocalPort(port).build();
-        tcpClientParams =
-            new TcpClientParametersBuilder().setRemoteAddress(new Host(address)).setRemotePort(port).build();
+        tcpClientParams = new TcpClientParametersBuilder()
+            .setRemoteAddress(new Host(address))
+            .setRemotePort(port)
+            .build();
     }
 
     @AfterEach