We really have only a single factory, remove the constant and inline
it to its sole caller. Also remove an unused factory.
Change-Id: I13523654e3ee4556365c3d809bcdf9f613aa6900
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
@Override
protected ClientBuilder fillWithDefaultValues() {
if (factory == null) {
@Override
protected ClientBuilder fillWithDefaultValues() {
if (factory == null) {
- factory = NetconfSshClient.DEFAULT_NETCONF_SSH_CLIENT_FACTORY;
+ factory = NetconfSshClient::new;
}
if (signatureFactories == null) {
signatureFactories = FULL_SIGNATURE_PREFERENCE;
}
if (signatureFactories == null) {
signatureFactories = FULL_SIGNATURE_PREFERENCE;
import io.netty.channel.ChannelHandlerContext;
import java.io.IOException;
import org.opendaylight.netconf.shaded.sshd.client.ClientFactoryManager;
import io.netty.channel.ChannelHandlerContext;
import java.io.IOException;
import org.opendaylight.netconf.shaded.sshd.client.ClientFactoryManager;
-import org.opendaylight.netconf.shaded.sshd.client.SshClient;
import org.opendaylight.netconf.shaded.sshd.client.session.ClientSessionImpl;
import org.opendaylight.netconf.shaded.sshd.client.session.ClientSessionImpl;
-import org.opendaylight.netconf.shaded.sshd.common.Factory;
import org.opendaylight.netconf.shaded.sshd.common.io.IoSession;
import org.opendaylight.netconf.shaded.sshd.common.session.ConnectionService;
import org.opendaylight.netconf.shaded.sshd.common.io.IoSession;
import org.opendaylight.netconf.shaded.sshd.common.session.ConnectionService;
*/
@Beta
public class NetconfClientSessionImpl extends ClientSessionImpl implements NettyAwareClientSession {
*/
@Beta
public class NetconfClientSessionImpl extends ClientSessionImpl implements NettyAwareClientSession {
- public static final Factory<SshClient> DEFAULT_NETCONF_SSH_CLIENT_FACTORY = SshClient::new;
-
public NetconfClientSessionImpl(final ClientFactoryManager client, final IoSession ioSession) throws Exception {
super(client, ioSession);
}
public NetconfClientSessionImpl(final ClientFactoryManager client, final IoSession ioSession) throws Exception {
super(client, ioSession);
}
import com.google.common.annotations.Beta;
import org.opendaylight.netconf.shaded.sshd.client.SshClient;
import com.google.common.annotations.Beta;
import org.opendaylight.netconf.shaded.sshd.client.SshClient;
-import org.opendaylight.netconf.shaded.sshd.common.Factory;
/**
* An extension to {@link SshClient} which uses {@link NetconfSessionFactory} to create sessions (leading towards
/**
* An extension to {@link SshClient} which uses {@link NetconfSessionFactory} to create sessions (leading towards
*/
@Beta
public class NetconfSshClient extends SshClient {
*/
@Beta
public class NetconfSshClient extends SshClient {
- public static final Factory<SshClient> DEFAULT_NETCONF_SSH_CLIENT_FACTORY = NetconfSshClient::new;
-
@Override
protected NetconfSessionFactory createSessionFactory() {
return new NetconfSessionFactory(this);
@Override
protected NetconfSessionFactory createSessionFactory() {
return new NetconfSessionFactory(this);