Move NetconfHelloMessage to netconf-api 77/34477/2
authorAndrej Mak <andmak@cisco.com>
Mon, 25 Jan 2016 14:11:30 +0000 (15:11 +0100)
committerTomas Cere <tcere@cisco.com>
Thu, 11 Feb 2016 16:51:49 +0000 (17:51 +0100)
Make sessionPreferences return NetconfHelloMessage.
Move NetconfHelloMessage and NetconfHelloMessageAdditionalHeader test to netconf-api.

Change-Id: I8f619954b2ae1428791d1161cba2b4c238083b42
Signed-off-by: Andrej Mak <andmak@cisco.com>
36 files changed:
opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/netconf/confignetconfconnector/NetconfMappingTest.java
opendaylight/netconf/netconf-api/pom.xml
opendaylight/netconf/netconf-api/src/main/java/org/opendaylight/netconf/api/NetconfClientSessionPreferences.java
opendaylight/netconf/netconf-api/src/main/java/org/opendaylight/netconf/api/NetconfServerSessionPreferences.java
opendaylight/netconf/netconf-api/src/main/java/org/opendaylight/netconf/api/NetconfSessionPreferences.java
opendaylight/netconf/netconf-api/src/main/java/org/opendaylight/netconf/api/messages/NetconfHelloMessage.java [moved from opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/netconf/util/messages/NetconfHelloMessage.java with 99% similarity]
opendaylight/netconf/netconf-api/src/main/java/org/opendaylight/netconf/api/messages/NetconfHelloMessageAdditionalHeader.java [moved from opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/netconf/util/messages/NetconfHelloMessageAdditionalHeader.java with 98% similarity]
opendaylight/netconf/netconf-api/src/test/java/org/opendaylight/netconf/api/messages/NetconfHelloMessageAdditionalHeaderTest.java [moved from opendaylight/netconf/netconf-util/src/test/java/org/opendaylight/netconf/util/messages/NetconfHelloMessageAdditionalHeaderTest.java with 96% similarity]
opendaylight/netconf/netconf-api/src/test/java/org/opendaylight/netconf/api/messages/NetconfHelloMessageTest.java [moved from opendaylight/netconf/netconf-util/src/test/java/org/opendaylight/netconf/util/messages/NetconfHelloMessageTest.java with 96% similarity]
opendaylight/netconf/netconf-client/src/main/java/org/opendaylight/netconf/client/NetconfClientSessionNegotiator.java
opendaylight/netconf/netconf-client/src/main/java/org/opendaylight/netconf/client/NetconfClientSessionNegotiatorFactory.java
opendaylight/netconf/netconf-client/src/main/java/org/opendaylight/netconf/client/conf/NetconfClientConfiguration.java
opendaylight/netconf/netconf-client/src/main/java/org/opendaylight/netconf/client/conf/NetconfClientConfigurationBuilder.java
opendaylight/netconf/netconf-client/src/main/java/org/opendaylight/netconf/client/conf/NetconfReconnectingClientConfiguration.java
opendaylight/netconf/netconf-client/src/main/java/org/opendaylight/netconf/client/conf/NetconfReconnectingClientConfigurationBuilder.java
opendaylight/netconf/netconf-client/src/test/java/org/opendaylight/netconf/client/NetconfClientConfigurationTest.java
opendaylight/netconf/netconf-client/src/test/java/org/opendaylight/netconf/client/NetconfClientDispatcherImplTest.java
opendaylight/netconf/netconf-client/src/test/java/org/opendaylight/netconf/client/NetconfClientSessionNegotiatorFactoryTest.java
opendaylight/netconf/netconf-client/src/test/java/org/opendaylight/netconf/client/NetconfClientSessionNegotiatorTest.java
opendaylight/netconf/netconf-client/src/test/java/org/opendaylight/netconf/client/NetconfReconnectingClientConfigurationTest.java
opendaylight/netconf/netconf-client/src/test/java/org/opendaylight/netconf/client/SimpleNetconfClientSessionListenerTest.java
opendaylight/netconf/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSession.java
opendaylight/netconf/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSessionNegotiator.java
opendaylight/netconf/netconf-impl/src/main/java/org/opendaylight/netconf/impl/NetconfServerSessionNegotiatorFactory.java
opendaylight/netconf/netconf-impl/src/test/java/org/opendaylight/netconf/impl/AdditionalHeaderParserTest.java
opendaylight/netconf/netconf-impl/src/test/java/org/opendaylight/netconf/impl/ConcurrentClientsTest.java
opendaylight/netconf/netconf-impl/src/test/java/org/opendaylight/netconf/impl/mapping/operations/DefaultCloseSessionTest.java
opendaylight/netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/AbstractNetconfSessionNegotiator.java
opendaylight/netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/handler/NetconfHelloMessageToXMLEncoder.java
opendaylight/netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/handler/NetconfXMLToHelloMessageDecoder.java
opendaylight/netconf/netconf-netty-util/src/test/java/org/opendaylight/netconf/nettyutil/AbstractNetconfSessionTest.java
opendaylight/netconf/netconf-netty-util/src/test/java/org/opendaylight/netconf/nettyutil/handler/NetconfHelloMessageToXMLEncoderTest.java
opendaylight/netconf/netconf-netty-util/src/test/java/org/opendaylight/netconf/nettyutil/handler/NetconfXMLToHelloMessageDecoderTest.java
opendaylight/netconf/netconf-ssh/src/main/java/org/opendaylight/netconf/ssh/RemoteNetconfCommand.java
opendaylight/netconf/netconf-ssh/src/main/java/org/opendaylight/netconf/ssh/SshProxyClientHandler.java
opendaylight/netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/client/stress/StressClientCallable.java

index c2caa165a4e709b52baf1061b4d6302b8a26a333..80dd64a6fd27f5ddc53f9c1c40860e325f392fea 100644 (file)
@@ -109,7 +109,7 @@ import org.opendaylight.netconf.impl.osgi.NetconfOperationRouter;
 import org.opendaylight.netconf.mapping.api.HandlingPriority;
 import org.opendaylight.netconf.mapping.api.NetconfOperation;
 import org.opendaylight.netconf.mapping.api.NetconfOperationChainedExecution;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.util.messages.NetconfMessageUtil;
 import org.opendaylight.netconf.util.test.XmlFileLoader;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.test.types.rev131127.TestIdentity1;
index ebc626c10440a624404eb8b4398f2f02793856ab..73e828937c8db1281c07fa60f43a5dac95f0eb46 100644 (file)
       <groupId>org.opendaylight.mdsal.model</groupId>
       <artifactId>ietf-yang-types</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.opendaylight.yangtools</groupId>
+      <artifactId>mockito-configuration</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <build>
index 2c9a17abb3e21730ac460748710bd1fc344f8cec..3f63db448020093892d398d66ae266d24f74b04b 100644 (file)
@@ -8,6 +8,8 @@
 
 package org.opendaylight.netconf.api;
 
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
+
 /**
  * The only input for the start of a NETCONF session is hello-message.
  */
@@ -15,7 +17,7 @@ public final class NetconfClientSessionPreferences extends NetconfSessionPrefere
 
     private final NetconfMessage startExiMessage;
 
-    public NetconfClientSessionPreferences(final NetconfMessage helloMessage,
+    public NetconfClientSessionPreferences(final NetconfHelloMessage helloMessage,
                                      final NetconfMessage startExiMessage) {
         super(helloMessage);
         this.startExiMessage = startExiMessage;
index 8b46dc1bc4a5770151c95965985152434a0656bb..348c273750e596a9e2abfb419f5a06140e274e53 100644 (file)
@@ -8,6 +8,8 @@
 
 package org.opendaylight.netconf.api;
 
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
+
 /**
  * The only input for the start of a NETCONF session is hello-message.
  */
@@ -15,7 +17,7 @@ public final class NetconfServerSessionPreferences extends NetconfSessionPrefere
 
     private final long sessionId;
 
-    public NetconfServerSessionPreferences(final NetconfMessage helloMessage,
+    public NetconfServerSessionPreferences(final NetconfHelloMessage helloMessage,
                                            long sessionId) {
         super(helloMessage);
         this.sessionId = sessionId;
index f8d2a1c0265eec41eea8376e89ea1809ef181379..26c612840a6b9fba9bbdea7aba22cb4bf4df003f 100644 (file)
@@ -8,18 +8,20 @@
 
 package org.opendaylight.netconf.api;
 
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
+
 public class NetconfSessionPreferences {
 
-    private final NetconfMessage helloMessage;
+    private final NetconfHelloMessage helloMessage;
 
-    public NetconfSessionPreferences(final NetconfMessage helloMessage) {
+    public NetconfSessionPreferences(final NetconfHelloMessage helloMessage) {
         this.helloMessage = helloMessage;
     }
 
     /**
      * @return the helloMessage
      */
-    public NetconfMessage getHelloMessage() {
+    public NetconfHelloMessage getHelloMessage() {
         return this.helloMessage;
     }
 
similarity index 99%
rename from opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/netconf/util/messages/NetconfHelloMessage.java
rename to opendaylight/netconf/netconf-api/src/main/java/org/opendaylight/netconf/api/messages/NetconfHelloMessage.java
index ab573ade2eb2b3e3b5686c45971566c299b9819e..a1ad34673b71e399ea6699d960480553a1fe9610 100644 (file)
@@ -6,7 +6,7 @@
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
 
-package org.opendaylight.netconf.util.messages;
+package org.opendaylight.netconf.api.messages;
 
 import com.google.common.base.Optional;
 import com.google.common.base.Preconditions;
index 965c32c872986a6b46cf537ebb6729dc376af6c8..4ae7dea12c77e4970ff785301948a82ef0d67596 100644 (file)
@@ -24,7 +24,7 @@ import org.opendaylight.controller.config.util.xml.XmlUtil;
 import org.opendaylight.netconf.nettyutil.AbstractChannelInitializer;
 import org.opendaylight.netconf.nettyutil.AbstractNetconfSessionNegotiator;
 import org.opendaylight.netconf.nettyutil.handler.exi.NetconfStartExiMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
 import org.opendaylight.netconf.util.messages.NetconfMessageUtil;
 import org.opendaylight.netconf.util.xml.XMLNetconfUtil;
 import org.opendaylight.netconf.api.NetconfClientSessionPreferences;
index 91c8c166a7b3c856cb1a212107ca3a06d8e9fd14..2d6cac2ba01c8b95886c6bc23e82cf63b12973ce 100644 (file)
@@ -16,8 +16,8 @@ import io.netty.util.Timer;
 import io.netty.util.concurrent.Promise;
 import java.util.Set;
 import org.opendaylight.netconf.nettyutil.handler.exi.NetconfStartExiMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.api.NetconfClientSessionPreferences;
 import org.opendaylight.netconf.api.NetconfDocumentedException;
 import org.opendaylight.netconf.api.NetconfMessage;
index d181627ca943650b448bac99ef1b58f487e587ef..cad5391481c26fbda424192468246ccb0b7c8318 100644 (file)
@@ -13,7 +13,7 @@ import com.google.common.base.Optional;
 import com.google.common.base.Preconditions;
 import java.net.InetSocketAddress;
 import org.opendaylight.netconf.nettyutil.handler.ssh.authentication.AuthenticationHandler;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.client.NetconfClientSessionListener;
 import org.opendaylight.protocol.framework.ReconnectStrategy;
 
index e8d6f83b3df058a41337d18bda08a97b5dccceec..368cc3b27f591b9e61de2fb0ada1badc75c16827 100644 (file)
@@ -9,7 +9,7 @@ package org.opendaylight.netconf.client.conf;
 
 import java.net.InetSocketAddress;
 import org.opendaylight.netconf.nettyutil.handler.ssh.authentication.AuthenticationHandler;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.client.NetconfClientSessionListener;
 import org.opendaylight.protocol.framework.ReconnectStrategy;
 
index 902d499017ad4489d4d972a683747f91b00ff582..f993f3cf6e146872a64576101c6e34f6454456db 100644 (file)
@@ -11,7 +11,7 @@ import com.google.common.base.MoreObjects.ToStringHelper;
 import com.google.common.base.Preconditions;
 import java.net.InetSocketAddress;
 import org.opendaylight.netconf.nettyutil.handler.ssh.authentication.AuthenticationHandler;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.client.NetconfClientSessionListener;
 import org.opendaylight.protocol.framework.ReconnectStrategy;
 import org.opendaylight.protocol.framework.ReconnectStrategyFactory;
index 91872711df025ea5fb57c54ada50d278bdb634a5..8052c77e7b2c532a4e1139fe24ed868315b2c8ba 100644 (file)
@@ -9,7 +9,7 @@ package org.opendaylight.netconf.client.conf;
 
 import java.net.InetSocketAddress;
 import org.opendaylight.netconf.nettyutil.handler.ssh.authentication.AuthenticationHandler;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.client.NetconfClientSessionListener;
 import org.opendaylight.protocol.framework.ReconnectStrategy;
 import org.opendaylight.protocol.framework.ReconnectStrategyFactory;
index f702b7ddc1b4abd6d322651098b581abc48335e5..7df2e6705f8149aeb3f554b216f11791cf329e8e 100644 (file)
@@ -14,7 +14,7 @@ import org.junit.Assert;
 import org.junit.Test;
 import org.mockito.Mockito;
 import org.opendaylight.netconf.nettyutil.handler.ssh.authentication.AuthenticationHandler;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.client.conf.NetconfClientConfiguration;
 import org.opendaylight.netconf.client.conf.NetconfClientConfigurationBuilder;
 import org.opendaylight.protocol.framework.ReconnectStrategy;
index ab39a158efc13d6802ae552cbc354822cc3d8c06..82172d771ec15676ed33a8b909c8c2d33d0f0bea 100644 (file)
@@ -24,7 +24,7 @@ import java.util.concurrent.Future;
 import org.junit.Test;
 import org.mockito.Mockito;
 import org.opendaylight.netconf.nettyutil.handler.ssh.authentication.AuthenticationHandler;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.client.conf.NetconfClientConfiguration;
 import org.opendaylight.netconf.client.conf.NetconfReconnectingClientConfiguration;
 import org.opendaylight.netconf.client.conf.NetconfReconnectingClientConfigurationBuilder;
index 3c11b7bddbb2cea39cbae2b5a54b522d42966968..3c24b7b5f8da7cd75b9a6433fce5ec227d2060cf 100644 (file)
@@ -18,7 +18,7 @@ import io.netty.util.HashedWheelTimer;
 import io.netty.util.Timer;
 import io.netty.util.concurrent.Promise;
 import org.junit.Test;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.protocol.framework.SessionListenerFactory;
 import org.opendaylight.protocol.framework.SessionNegotiator;
 
index e3006c7bb1c8ebce4b6f5d891814d46624041178..01c50c11e8269a51fc3992ed53e8d9c43b44506b 100644 (file)
@@ -43,8 +43,8 @@ import org.opendaylight.netconf.nettyutil.handler.ChunkedFramingMechanismEncoder
 import org.opendaylight.netconf.nettyutil.handler.NetconfXMLToHelloMessageDecoder;
 import org.opendaylight.netconf.nettyutil.handler.NetconfXMLToMessageDecoder;
 import org.opendaylight.netconf.nettyutil.handler.exi.NetconfStartExiMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.util.test.XmlFileLoader;
 import org.openexi.proc.common.EXIOptions;
 import org.w3c.dom.Document;
index 33c403b4386343e28ee84b727ad6d117e6cb362e..9d9d9320760fa089c76daf032ef569970308c5a6 100644 (file)
@@ -14,7 +14,7 @@ import org.junit.Assert;
 import org.junit.Test;
 import org.mockito.Mockito;
 import org.opendaylight.netconf.nettyutil.handler.ssh.authentication.AuthenticationHandler;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.client.conf.NetconfClientConfiguration;
 import org.opendaylight.netconf.client.conf.NetconfReconnectingClientConfiguration;
 import org.opendaylight.netconf.client.conf.NetconfReconnectingClientConfigurationBuilder;
index 0bc9b04d8ce337e082fedc4f7e488afa3baa74fc..32e5dbe43aa22cccc7d28a85934805bb19ca8613 100644 (file)
@@ -29,7 +29,7 @@ import org.junit.Test;
 import org.mockito.internal.util.collections.Sets;
 import org.mockito.invocation.InvocationOnMock;
 import org.mockito.stubbing.Answer;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
 import org.opendaylight.netconf.api.NetconfMessage;
 
 public class SimpleNetconfClientSessionListenerTest {
index 92c0c5f76310dbb9dd527e36d42c37db712c2efb..bb1b72d5ce459a9c28f87fb652e62d8142d5cfec 100644 (file)
@@ -21,7 +21,7 @@ import java.util.regex.Pattern;
 import org.opendaylight.netconf.nettyutil.AbstractNetconfSession;
 import org.opendaylight.netconf.nettyutil.handler.NetconfMessageToXMLEncoder;
 import org.opendaylight.netconf.nettyutil.handler.NetconfXMLToMessageDecoder;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.api.NetconfMessage;
 import org.opendaylight.netconf.api.monitoring.NetconfManagementSession;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.DomainName;
index 666e01a3ab1ee6a687e5c9e0f435674a0d2fa73c..c5d37b708e02d6347a7bc864b3066509f15ffb69 100644 (file)
@@ -18,8 +18,8 @@ import java.net.SocketAddress;
 import java.util.AbstractMap;
 import java.util.Map;
 import org.opendaylight.netconf.nettyutil.AbstractNetconfSessionNegotiator;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.api.NetconfDocumentedException;
 import org.opendaylight.netconf.api.NetconfServerSessionPreferences;
 import org.slf4j.Logger;
index 24ea8f655cb9e2428ef3a52854880ceded078a8b..5b278efceceddaec738681a3f005b4ea5c35b8fc 100644 (file)
@@ -20,7 +20,7 @@ import java.net.SocketAddress;
 import java.util.Set;
 import org.opendaylight.netconf.mapping.api.NetconfOperationService;
 import org.opendaylight.netconf.mapping.api.NetconfOperationServiceFactory;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
 import org.opendaylight.netconf.api.NetconfDocumentedException;
 import org.opendaylight.netconf.api.NetconfServerSessionPreferences;
 import org.opendaylight.netconf.api.monitoring.NetconfMonitoringService;
index 625f18167e81ddad6dc6e1ca2285435012d62674..91d16d06a4eb46ecf6764de34adbc059754679c2 100644 (file)
@@ -10,7 +10,7 @@ package org.opendaylight.netconf.impl;
 import static org.junit.Assert.assertEquals;
 
 import org.junit.Test;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 
 public class AdditionalHeaderParserTest {
 
index 7d675eb5926525017e98535f520c3e8e28238c39..83a88daf18213873ad2f3b3fe721022b63a6997e 100644 (file)
@@ -58,7 +58,7 @@ import org.opendaylight.netconf.mapping.api.NetconfOperationChainedExecution;
 import org.opendaylight.netconf.mapping.api.NetconfOperationService;
 import org.opendaylight.netconf.mapping.api.NetconfOperationServiceFactory;
 import org.opendaylight.netconf.nettyutil.handler.exi.NetconfStartExiMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.util.messages.NetconfMessageUtil;
 import org.opendaylight.netconf.util.test.XmlFileLoader;
 import org.opendaylight.netconf.api.NetconfMessage;
index f50fe52125ed8f672f0d8408345f77b004c8e1bb..2b8440899cd85c61983df84b26ea4a56f78eae73 100644 (file)
@@ -27,7 +27,7 @@ import org.mockito.stubbing.Answer;
 import org.opendaylight.controller.config.util.xml.DocumentedException;
 import org.opendaylight.controller.config.util.xml.XmlElement;
 import org.opendaylight.controller.config.util.xml.XmlUtil;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.api.NetconfDocumentedException;
 import org.opendaylight.netconf.api.NetconfMessage;
 import org.opendaylight.netconf.api.NetconfTerminationReason;
index 91dae4e4325a1387207e5a3fc90fcf9dc09320bd..4bfd94c9109db41b47d756eef5f3d29e4ea17656 100644 (file)
@@ -24,7 +24,7 @@ import io.netty.util.concurrent.GenericFutureListener;
 import io.netty.util.concurrent.Promise;
 import java.util.concurrent.TimeUnit;
 import org.opendaylight.netconf.util.messages.FramingMechanism;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
 import org.opendaylight.netconf.api.NetconfDocumentedException;
 import org.opendaylight.netconf.api.NetconfMessage;
 import org.opendaylight.netconf.api.NetconfSessionListener;
@@ -104,13 +104,12 @@ public abstract class AbstractNetconfSessionNegotiator<P extends NetconfSessionP
     }
 
     private void start() {
-        final NetconfMessage helloMessage = this.sessionPreferences.getHelloMessage();
+        final NetconfHelloMessage helloMessage = this.sessionPreferences.getHelloMessage();
         LOG.debug("Session negotiation started with hello message {} on channel {}", helloMessage, channel);
 
         channel.pipeline().addLast(NAME_OF_EXCEPTION_HANDLER, new ExceptionHandlingInboundChannelHandler());
 
-        // FIXME, make sessionPreferences return HelloMessage, move NetconfHelloMessage to API
-        sendMessage((NetconfHelloMessage)helloMessage);
+        sendMessage(helloMessage);
 
         replaceHelloMessageOutboundHandler();
         changeState(State.OPEN_WAIT);
index f5d37284d6ed09445ab84e4f082f9b80409cdae3..f1f110751d5a59f3a518ac4ace6f7521f49e746e 100644 (file)
@@ -15,8 +15,8 @@ import io.netty.buffer.ByteBuf;
 import io.netty.channel.ChannelHandlerContext;
 import java.io.IOException;
 import javax.xml.transform.TransformerException;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.api.NetconfMessage;
 
 /**
index 5eb8525cb303d2d35974b5a7f348b19f3f7ceb72..cc14fdf32d8acf968aa9e5c5b6acab314f3f6cb7 100644 (file)
@@ -22,8 +22,8 @@ import java.nio.ByteBuffer;
 import java.util.Arrays;
 import java.util.List;
 import org.opendaylight.controller.config.util.xml.XmlUtil;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.api.NetconfDocumentedException;
 import org.opendaylight.netconf.api.NetconfMessage;
 import org.slf4j.Logger;
index b55e861ed34fadb94692c40cfdb39346052387bc..5c2bb755b1befe22128f1e901b752476724a5b9e 100644 (file)
@@ -42,8 +42,8 @@ import org.opendaylight.netconf.api.NetconfSession;
 import org.opendaylight.netconf.api.NetconfSessionListener;
 import org.opendaylight.netconf.api.NetconfTerminationReason;
 import org.opendaylight.netconf.nettyutil.handler.exi.NetconfStartExiMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.openexi.proc.common.EXIOptions;
 
 public class AbstractNetconfSessionTest {
index 4aa069ea32452c8fdaa4dd691b9510392a036851..3aab586d4f3873182e089011fdb140423c4e802d 100644 (file)
@@ -20,8 +20,8 @@ import org.junit.Test;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
 import org.opendaylight.controller.config.util.xml.XmlUtil;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.api.NetconfMessage;
 
 public class NetconfHelloMessageToXMLEncoderTest {
index 8c73c4dad9e4f2c8cdbe95686898a8bce03c87cb..9ee511ace0356178c4719baaf76bbfba9784cb0a 100644 (file)
@@ -21,7 +21,7 @@ import java.util.List;
 import org.hamcrest.CoreMatchers;
 import org.junit.Test;
 import org.opendaylight.controller.config.util.xml.XmlUtil;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessage;
 
 public class NetconfXMLToHelloMessageDecoderTest {
 
index 57244745e5a20ab7d94fbc989c08d6a3efa0aaa4..69dd6bc6f946a88b7a1203602dec8465e20739ae 100644 (file)
@@ -31,7 +31,7 @@ import org.apache.sshd.server.Environment;
 import org.apache.sshd.server.ExitCallback;
 import org.apache.sshd.server.SessionAware;
 import org.apache.sshd.server.session.ServerSession;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
index 90ccec6f251e05dfd49f5319911b411f7bd8c887..87d774b147c0526d8f5c010510e561fbe0577731 100644 (file)
@@ -17,7 +17,7 @@ import org.apache.sshd.common.io.IoOutputStream;
 import org.apache.sshd.server.ExitCallback;
 import org.opendaylight.netconf.nettyutil.handler.ssh.client.AsyncSshHandlerReader;
 import org.opendaylight.netconf.nettyutil.handler.ssh.client.AsyncSshHandlerWriter;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
index 3680cb98375944eb95d2c5e76b5b080cc7884f8d..501ef8c71e70f245f11958188e1c394878cf1c65 100644 (file)
@@ -14,6 +14,7 @@ import java.util.List;
 import java.util.concurrent.Callable;
 import java.util.concurrent.ExecutionException;
 import org.opendaylight.netconf.api.NetconfMessage;
+import org.opendaylight.netconf.api.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.netconf.client.NetconfClientDispatcherImpl;
 import org.opendaylight.netconf.client.NetconfClientSession;
 import org.opendaylight.netconf.client.conf.NetconfClientConfiguration;
@@ -23,7 +24,6 @@ import org.opendaylight.netconf.sal.connect.api.RemoteDevice;
 import org.opendaylight.netconf.sal.connect.netconf.listener.NetconfDeviceCommunicator;
 import org.opendaylight.netconf.sal.connect.netconf.listener.NetconfSessionPreferences;
 import org.opendaylight.netconf.sal.connect.util.RemoteDeviceId;
-import org.opendaylight.netconf.util.messages.NetconfHelloMessageAdditionalHeader;
 import org.opendaylight.protocol.framework.NeverReconnectStrategy;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;