Convert mdsal-netconf-monitoring to OSGi DS

These are just two simple components, convert them to Declarative
Services.

JIRA: NETCONF-954
Change-Id: I3bf22d265feb8a1db086df396fb5ebaa26bbecdd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert mdsal-netconf-impl to OSGi DS

The blueprint here is just picking up config admin tuneables and wires
things together. This patch converts this wiring to OSGi DS.
Unfortunately the config admin bits are jumbled together, hence we use
factory components to split them up.

JIRA: NETCONF-951
Change-Id: Icdabc7b2e62cb77a6bf5659274955463be993f88
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump json-unit-assertj to 2.36.1

Fix CVE-2022-42003 by bumping json-unit-assertj to 2.36.1
which uses fixed jackson-databind version 2.14.0.

Change-Id: I3ab3cb9e03393ea1d223616e0b013f7f10e6a74c
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Remove duplicate authorization instantiation

We already have an authorization object, so it seems we should be
reusing it. This also fixes a potential leak as well.

JIRA: NETCONF-949
Change-Id: Id8c94b3f4deca9c62f3b02e1f0c9f3f36d5d23c9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline serverChannelInitializer

This bean is used only as an argument, inline it to make things clearer.

JIRA: NETCONF-951
Change-Id: Ie461efe86b7b80d087ad41770e8c75275db4b170
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline netconfServerSessionNegotiatorFactory

This bean is used only as an argument, inline it to make things clearer.

JIRA: NETCONF-951
Change-Id: If0430936c0ad85346ad26ee8903d2f3bfa73b870
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Split out NetconfMapperAggregator

Create a component to host the corresponding Blueprint element.
This starts the path to making the contract of
AggregatedNetconfOperationServiceFactory more explicit.

JIRA: NETCONF-951
Change-Id: Ic4f0164ac3423f39ca0d52a6200dcbbfa8f35f7f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use NetconfNodeUtils.DEFAULT_TOPOLOGY_IID

We have an open-coded reference to "topology-netconf", squash it and use
the common centralized constant.

Change-Id: Id6399cd4534333b0cce16c0ebdae00c0ede2835b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify builder

We do not need the intermediate products, we can just pass them to a
fluent builder.

Change-Id: Id384d2fd54a454b89de7b43b12b23f1f135a767f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a few more instanceof patterns

We can remove duplicate getter invocations, let's do that and also
eliminate the implied casts.

Change-Id: I582d64423b968b0c9e97b541feff80cfbaca7627
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Turn SessionIdProvider into a component

SessionIdProvider is a service, make sure it is an interface with a
default provider, instantiated via OSGi DS. This make things a tad more
reasonable, as the provider will survive most reconfiguration.

JIRA: NETCONF-951
Change-Id: I18e95bca90ed886d13b4cc03e3a2f1b5169d7876
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert netconf-config to OSGi DS

Convert blueprint to explicit OSGi DS wiring, retaining the API and
behaviour of the wiring. This requires use of ComponentFactories to
deal with the fact the configuration is in a single configurationPid,
but really ends up being configuration of three inter-dependend classes.

JIRA: NETCONF-950
Change-Id: I19d506a336483bf0ea06a230ef5108a35d8845cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unused method createDeviceCommunicator

Remove unused method AbstractNetconfTopology#createDeviceCommunicator.

Change-Id: I0042b1e3ce772dc9853f83080737e0250e50d070
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Add session-id to the operational datastore

Expose non-zero uint32 session-id provided by the device
in the HELLO-MESSAGE via operational datastore.

When device is disconnected null is used to indicate
a non-NETCONF entity session.

Session id can be used to retrieve session-specific info of the device.

JIRA: NETCONF-710
Change-Id: I1995e825cf32462232e164727a469a7b47d3acd0
Signed-off-by: Tibor Král <tibor.kral@pantheon.tech>
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>

Add fixme to NetconfNodeUtils

NetconfNodeUtils#extractUserCapabilities method is creating
UserPreferences from NetconfSessionPreferences.

Here the purpose is unclear because NetconfSessionPreferences
are (re)created in NetconfDeviceCommunicator#onSessionUp.

Change-Id: I78ae38ffbd327b29dd29753b8b61d1e9c07bf55b
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Clarify NetconfSessionPreferences usage

Remove the only one usage of NetconfSessionPreferences method
fromStrings(collection) from production code and mark it
as visible for testing because now it is used only in tests.

Change-Id: Ib17ddafaed113e3f18588e1870b0d53bf26e1513
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Hide CallHomeMountSessionManager

This is an implementation detail not used anywhere, hide it and document
that it is non-final (as is CallHomeMountDispatcher) for testing
purposes.

Change-Id: Ibe8c662aab5b45a4f696719928c04fe2166f5077
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Inline constants in CallHomeAuthProviderImpl

We are using constants only during initialization, just pass them
as arguments.

Change-Id: Id1ada2d05c41a46e9f1823b2d9a16db3df6d2689
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert TlsAllowedDevicesMonitorImpl to OSGi DS

This is a simple component, only depending on DataBroker. Use
declarative services to manage its lifecycle. Also eliminate close()
from the public contract of TlsAllowedDevicesMonitor to ensure it is
properly isolated.

JIRA: NETCONF-949
Change-Id: I4cc51ee5ea807f2b4db664b18b2f81888bb20a34
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Require allowedDevicesMonitor

We cannot reasonably operate without the monitor, make sure to require
it.

JIRA: NETCONF-949
Change-Id: Ia0f8648fbcca17fbcf8143ee91085ffbb4f0579e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Return immutable set from findAllowedKeys()

We are returning a mutable HashSet, let's use a simple Set.copyOf()
instead. Also update the sole caller to perform this operation only
once, closing a TOCTOE race.

JIRA: NETCONF-949
Change-Id: If49fb938b8ac09e63bdfdef229ef22635c9bb652
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove static state from TlsAllowedDevicesMonitorImpl

Using static maps will end up retaining information even after we have
restarted this class. Make sure the information gets removed by tying
the maps to a particular instance.

JIRA: NETCONF-949
Change-Id: I941d876c8a834b2db9a257ac258685cbca29dbe8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up TlsAllowedDevicesMonitorImpl constants

We have single-use constants, let's just inline them to their use in
constructor.

JIRA: NETCONF-949
Change-Id: I12618fe42c46b0b561e85980f5cdbfce5201fad3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove NetconfConnectorFactory

This interface is not used anywhere except for instantiation. Remove it.

Change-Id: I85ff414d10d8d54790989fea22f0c728c53c2e32
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump ietf-tcp-{common,client,server} to 2022-12-12

This is just a run-of-the-mill upgrade.

Change-Id: I0233d8e59cb9d8b467c283ae4c3f10e942266b37
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump ietf-keystore to 2022-12-12

This is just a run-of-the-mill upgrade.

Change-Id: I26ccadf05e7f864e5bacce989afa92fb1d12e274
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump ietf-crypto-types to 2022-12-12

This is just a run-of-the-mill upgrade.

Change-Id: If2c91e90f36c4dc34a0ee2ad1f8b3bb531768594
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump ietf-truststore to 2022-12-12

This is just a run-of-the mill upgrade.

Change-Id: I14357b9e2a770a369353eabfeb876cd2e0f17a7a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix testtool parameter signature

Add one missing '-' to testtool's "ip" parameter to make it look
the same way like other parameters.

Change-Id: Ib5aa71e4424d52aa9ff6d2ca9064e5751351d51e
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.2
- intrautils-5.0.2
- yangtools-10.0.3
- mdsal-11.0.6
- controller-7.0.3
- aaa-0.17.4

Change-Id: I3e34e381b39c16a3a465fb37c5fc6584765ee4de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not pass outer model context

createDeviceNotificationListener() is not using this argument at all, do
not pass it down.

Change-Id: I177aa0dfa3fffa706f1e9194326ba261eb2f186d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add proper path validation

Rather than incurring CCEs, make sure actually validate data and report
what is wrong.

Change-Id: I70b8172732e08bc44c999bea05ff5c0ce28beff0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Point out a few more ugly casts

We are making quite a few assumptions, mark them for revision.

Change-Id: I29ae17b01f8e29d0ea67a8f8c215ebf47e9a1cbb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize notification extraction

Extract-transform-verify arguments before talking to anyone, making it
obvious the definitions do not actually leak.

Change-Id: I46c079a08d72bb9f9847a7766bc3025a932ae7b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Acquire DOMNotificationService before changing state

We have a potential source of exceptions triggering after we have
mutated state. Fix that.

Change-Id: Id178c124c37cde804b10975590a773fab0df644e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Mark a potential CCE

We have blind cast here, mark it for fixing.

Change-Id: I77812192fb772fd8f9224db75bd5adaf0db97f77
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not acquire DOMSchemaService twice

Properly sanitize input, exactly once. Prevents a 500 when there is no
DOMSchemaService exposed.

Change-Id: I304ba58efe82530186cbb5a28e0b9a79b138ff3e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up DeviceNotificationListenerAdaptor

Reorg fields for clarity.

Change-Id: I088f8725f19b63c1ebebfc185598824d2a06b692
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reuse NetconfClientBuilder in NetconfCallHomeServer

To prevent issues with connecting to devices that
use old key exchange algorithms, use the default NetconfSshClient
inside the NetconfCallHomeServer.

JIRA: NETCONF-887
Change-Id: I379c26281dcec6df10dcdbe0ccbfa8c3bea7e8f0
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>

Bump versions to 5.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I00caf0b3e8c30bf4ed0e20a0ee04da09b87356db
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove target schema node

Searching for target schema node is used only to verify that
we have "parsed" a schema node from input.

Its not needed to be processed in XMLPatchBodyReader and if
payload is invalid we get errors from other places.

Change-Id: I777999b61e3c6bd891f255d0bc301a65b1628034
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Fix XML parser condition in XmlPatchBodyReader

Remove redundant if condition which rejects to parse
LeafListSchemaNode or LeafSchemaNode value from XML.

JIRA: NETCONF-937
Change-Id: Ib001582b8476f4508bab7d746296cb7ea1b1619e
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Test Json/Xml PatchBodyReaders on mixin nodes

Created tests for both JSON and XML PatchBodyReaders with
different types of mixin nodes.

JIRA: NETCONF-943
Change-Id: Idd9bc2da6d561463bdd01b9714ea9f61a7a86e88
Signed-off-by: OleksandrZharov <Oleksandr.Zharov@pantheon.tech>

Lock datastore for call-home devices

Netconf callhome does not obey default datastore values as defined
in odl-netconf-device.yang model.

We have to set datastore lock to true manually when creating
configuration node.

This way we can prevent error when we are unable to connect callhome
device because of already closed session.

JIRA: NETCONF-942
Change-Id: I98bc0e01d8d5bd3c2fdd3f4c57546656db61569c
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Bump upstreams

Adopt:
- mdsal-11.0.4
- controller-7.0.2
- aaa-0.17.3

Change-Id: I7c0e0b241f2ff9d4b8160e8c53c54d2f3cef841d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

NetconfMonitoringService should use Registration

We are using raw AutoCloseable here, whereas we should be using simple
registrations. It also flushes out a few places where we fail to clean
up registrations.

Change-Id: I60f956f7e7dd9b394834ae046069d0112d496975
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Return Registration on registerCapabilityListener()

Registrations, as a concept resulting via architecture-level fiat,
cannot throw exceptions. Codify this in registerCapabilityListener(),
which should previously have returned ListenerRegistration. Also clarify
nullness of return types.

Change-Id: I9f9cd1638568280ee4ae64ea104a665aeaca19e6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 5.0.1-SNAPSHOT

This starts the next development iteration.

Change-Id: Icacee80f9e4660160a19e9f0c240c92f779819b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove Optional wrapping

We are needlessly verbose in what is essentially internal comms. Remove
the indirection, getting right of a weird .map(Function.identity()).

Change-Id: Ibe162079f9eb08b8602b8fa5216c217a9d33e333
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ListenersBroker's enumerators

We never enumerate these, remove the accessors.

Change-Id: If4a5a30ce803de4bdb5fa36c560636d1ad72a318
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate netconf-node-topology RPCs

These RPCs are just augmenting the configuration datastore, deprecate
them for later removal.

JIRA: NETCONF-931
Change-Id: I6820a6111e9405dc58e198f8b782378efdf2bab8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add WebContext names

Provide descriptive names to each context we publish.

JIRA: NETCONF-940
Change-Id: I25558ad49bb6c5897a6c8bfb2a7195843cc48d61
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify YangLibProvider

Use a CharSource with UTF-8 encoding instead of manually constructing
strings.

Change-Id: Ib87a30321ccebb4c22920966fec86cf872ba2173
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize YangLibRestApp

Use Set.of() and make sure the service is not null.

Change-Id: I63c3feb978344ad08d794c3441890bfecb36d5cd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump aaa to 0.17.2

Pick up features from upstream.

Change-Id: I8e0ce2bd0e291bd557e47ee2591aa0e3cbf9b0a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bind /notif to WebInitializer

"/notif" is actually tied through WebInitializer, make sure that
connection is expressed in code.

Change-Id: I893fbece36ab8ec4d2fe30b3db9947f1521c9c71
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove LocalUriInfo

This is a rather shortcut to jax-rs, ditch the indirection.

Change-Id: I4bf70723c3cc58396c32df3db24d3618759e7cfe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Mark RestconfStreamsSubscriptionService's fate

This interface is going to be removed, mark a FIXME to that effect.

Change-Id: I4c6d43abca9b465c4467721c9196ba17fd8bd021
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Netconf Device Notification

Requirement - HTTP client should be able to get Device notification
after subscription.

Implementation:
1. Added a new Device Notification Yang for Rest request which takes
 input of Device mount point path
2. Added a DeviceNotificationListenerAdaptor which is get registered
in Device Notification service (on Mount point)
3. Created a dynamic Rest Notification SSE HTTP rest url (Response of 1st rest
call )
4. Updated Test-tool for Notification

JIRA: NETCONF-745
Change-Id: I9cac35d0a7b0f79382d223ae4ec0ac4a3ce2bae9
Signed-off-by: Nikhil Soni <nikk.sonitech@gmail.com>
Signed-off-by: nikhil.soni.lumina <nikk.sonitech@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Split out restconf-api

We have a ton of constructs which constitute a RFC8040 binding to Java.
Split those out into restconf-api.

Change-Id: I2660b6b17c0d024534e630c5a62c82844b3894f0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use switch expressions in QueryParams

This is a tad more expressive.

Change-Id: I52a42c01227228823516021586da07d472f9f8ff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize ApiPath

Use instanceof patterns throughout to reduce explicit casts.

Change-Id: I7b25e311686f0fb91b764f6a4e4f7e0e0dc44b04
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correct CREDENTIALS_NODE_IDENTIFIER

The 'credentials' item needs to be properly rooted in
netconf-node-topology, otherwise we will end up with failures to
serialize the payload. Also intern new QNames while we are near them.

JIRA: NETCONF-936
Change-Id: Iaf2c067d1b1ae0ceed732f52964ce586ec6ea819
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move netconf{-client,impl,util} to protocol/

These three artifacts are the API and client and server implementations
-- make sure we keep them in protocol/.

Change-Id: Iba32fb7533c5f1214bcb43a57cb06d2ccc2920df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move netconf-dom-api

netconf-dom-api is part of MD-SAL level integration, hence it should
live among plugins.

Change-Id: I887071ee77336e2da8b97d7849c425db18574da2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move netconf-api to protocol/

netconf-api is MD-SAL independent protocol-level API, move it to
protocol/ top-level directory.

Change-Id: I5fc4f3fed415bed00f6a84a1cbba9a7eb2e1b99b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move sal-netconf-connector to plugins/

sal-netconf-connector provides integration with MD-SAL, move it to
plugins/ directory.

Change-Id: I3b632f93ecf2fe4f7646b9127fead420de2cc2c5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move netconf-console to apps/

netconf-console a typical application, move it to apps.

Change-Id: I35f81c663f910d1cdefa8e6c147fa88e405a0a88
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move shaded components to third-party/

In order to make the project more navigable, separate out shaded
artifacts to a new top-level directory.

Change-Id: I227c8338c61b8f341cf4c6aa37cb6715db1f7ff3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move netconf topology applications in apps/

As of making the project better navigable, introduce apps/ top-level
directory, which hosts end-to-end applications.

Populate this with netconf-topology-* and callhome-provider, as these
are "NETCONF over network-topology" applications.

Change-Id: Ia1d9ca8bed3ec644261ab268008245c463beeb60
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add changed-leaf-nodes-only subscription extension

The behaviour of this extension is almost the same of
the odl-leaf-nodes-only except additional check is performed
where nodes containing the same data after write into them
are not contained in the notification that is being sent.
Unit tests contain cases for nested choice node serialization

JIRA: NETCONF-862
Change-Id: I9775b51b782f30161c6e33f5a0ac36326eb47d44
Signed-off-by: Peter Puškár <ppuskar@frinx.io>
Signed-off-by: Branislav Malo <bmalo@frinx.io>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup netconf dependencies a bit

We have a ton of warnings on used/unused dependencies, clean them up a
bit.

Change-Id: I4435e95f547cd86873031f911188746363b2d82f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move netconf-node-{optional,topology}.yang

This is the final bit of making sal-netconf-connector independent of
netconf-topology.yang

JIRA: NETCONF-913
Change-Id: If94b2623bba3d5576e27075eecc3ca5772626eaf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move DEFAULT_TOPOLOGY_NAME

RemoteDeviceId has no connection to topology, move DEFAULT_TOPOLOGY_NAME
and related constants to a better place.

JIRA: NETCONF-913
Change-Id: Ic54f8484c052a74579f9c35751f3e31478de557c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move DEFAULT_TOPOLOGY_IID

This is a pure topology construct, move it up one layer, further
reducing dependencies.

Change-Id: I3d10bc9caa53f2d1a0dcda2415effbd595a0ffc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move RemoteDeviceId

The class has lost most of its baggage and can now be promoted to an API
contract next to NetconfDeviceSchemasResolver, which is using it.
Reduces package tangle quite a bit.

JIRA: NETCONF-913
Change-Id: Ic662a9d972ac6f2e7adeb0a26ad5f976a5199ac8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Turn RemoteDeviceId into a simple record

There is no logic here and it is absolutely clear that this is just a
holder for two arguments.

Having record semantics actually helps, as we include the IP address
with toString(), which helps debugging.

JIRA: NETCONF-913
Change-Id: I1749d1d458a3ad2ba3b82b121b850caf5b9471b6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove RemoteDeviceId.getTopologyPath()

The name 'topologyPath()' implies attachment to network-topology,
whereas we only care about this being a valid path for
DOMMountPointService.

Eliminate this property and push the singleton value out to
NetconfDeviceMount for further processing.

JIRA: NETCONF-913
Change-Id: I70b4ac06a78c01fa3e0caf530bc4d6b36acae925
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove RemoteDeviceId.getTopologyBindingPath()

This path is only used transiently by netconf-topology components,
move the responsibility back to them, instantiating the path as needed.

JIRA: NETCONF-913
Change-Id: Iee8a62b9b181324a7ccc51cf3d9e70d37bf3c66f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reuse bindingTopologyPath key

Since we are accessing the path, we really can just use the key created
therein.

JIRA: NETCONF-913
Change-Id: I853103803905d310e385be6968afe26a5f597f9c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Annotate non-null properties

We will be passing things around from RemoteDeviceId, make sure
users get the best possible service.

JIRA: NETCONF-913
Change-Id: I6d8871d3d6befc052725281345333b6dbeb3c8f8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch RemoteDeviceId equality to topologyPath

We have two requivalent representations here, but topologyPath really
wants to be called mountPath().

JIRA: NETCONF-913
Change-Id: I2be7da552ab4cea5185b589d84878d7e6bb5f5ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove RemoteDeviceId.getBindingKey()

We expose this as the instance identifier already and there are no users
anyway.

JIRA: NETCONF-913
Change-Id: I38ad921fb321014167d59fe1f2a7932fcdc06087
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename MountInstance to NetconfDeviceMount

We have a rather useless indirection of components via
NetconfDeviceSalProvider. Eliminate it and promote the only part we care
about to a top-level construct.

Even this may prove unnecessary, as proper lifecycle would just track
the mount point within NetconfDeviceSalFacade. That requires more work
though, so we correctly integrate with netconf-topology-singleton, which
is doing its own thing.

JIRA: NETCONF-918
Change-Id: I014fe4953d4f832b8a9ad43cec95d3d961949716
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move NetconfDeviceTopologyAdapter

NetconfDeviceTopologyAdapter is updating the datastore view of the
device, and as such is tied to the fact that this is network topology.
Move the class out, opting to specialize NetconfDeviceSalFacade instead.

JIRA: NETCONF-918
Change-Id: I24115bee0f97852d4c4cfa09152fdeeab2395965
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use Files.readString()

Rather than relying on default charset and going through bytes
ourselves, use the Java 11+ method for that.

Change-Id: Ibea40f0d28a6627237ee21c4257356f21237f0f0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename netconf.api.ModifyAction to EffectiveOperation

This enum has a rather misleading name, as it really is talking about
operations in two contexts -- either an actual operation or the set
default operation. Combined this amounts to the effective operation on
a DataTree.

Let us call it EffectiveOperation, as it ends up being the combination
of default-operation and a potentially-absent explicit operation.

JIRA: NETCONF-932
Change-Id: I1dcf0ffd54fdcf7c7cc853ef595e1a04e69a3147
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate LockChangeListener

Configuration of netconf-sal-provider should not directly depend on the
datastore. Move the single leaf from netconf-node-optional into
odl-netconf-device:datastore-access grouping and let users propagate it
via normal configuration updates.

This removes a race as well as explicitly deals with lifecycle of the
device when the configuration is changed.

JIRA: NETCONF-921
Change-Id: I07ba946bdef56dfc9ba958384188d93a32e2d974
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate createTopologyListPath()

This is a single-user private method, just inline it to its sole caller.

Change-Id: I998bd1548e4f8e125d429f708b398c691c33c4de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move NetconfTopologyRPCProvider

We have a proper place for topology-related classes, move
NetconfTopologyRPCProvider so it does not clutter sal-netconf-connector.

JIRA: NETCONF-935
Change-Id: Idbe894671fcc53ac18972e3e9385eed831108ae6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use null input for discard-changes

There is already a NormalizedNode defined in NetconfMessageTransformUtil
for the content of the 'discard-changes' RPC.

Use the static variable instead of 'null'. This would make message
transformation more robust and fix an error caused by an augmentation
to the RPC input while generating NetconfMessage.

JIRA: NETCONF-934
Change-Id: I38777313d74e92bd955248ceea78e765729d9259
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Eliminate TransportType

This enumeration mirrors Protocol.Name we have already modeled in
odl-netconf-device. Reuse the definition, bringing the two plugins
closer together.

Change-Id: Id0b046d44ea14afb82247bdb8bcd08a3bedec4e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Split out odl-netconf-device.yang

We have a ton of configuration details tied directly to
ietf-network-topology. We want these constructs to be reusable, so that
the equivalent can be modeled in contexts.

This patch splits out the groupings into their own module, allowing them
to be reused.

JIRA: NETCONF-922
Change-Id: Idc8d6bed4f58137b75d2b4f798d972545274144f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate getResult()/getErrors() callers

These are deprecated, migrate their users.

Change-Id: I069d6e535ba1edcbd56f8ef2953db351c9837140
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix duplicate in error message

Fix duplicate occurrence of yang-ext:mount in error message
when operation is not found.

JIRA: NETCONF-926
Change-Id: I2d8f9f1e2f1c4257e3802f7e2df983597f34c6c4
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.1
- infrautils-5.0.1
- yangtools-10.0.2
- mdsal-11.0.3
- controller-7.0.1
- aaa-0.17.1

Change-Id: I08a761ecedf214fa7cb451eb7e97b0c10a652753
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Split up RESTCONF contexts

contextPath("/") is not valid and the only reason we need to use it that
we register two separate entities: /rests for RFC8040 endpoints and
/.well-known for resource discovery.

Split these into two registrations, so that we can form a proper prefix.
Also note that discovery is only started after RESTCONF is started.

Change-Id: I9cda36f86296399b78a19be36ea20fda38e35c79
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Specialize SchemalessRpcService

SchemalessRpcService really operates on DOMSources, without the need to
explicitly encapsulate with DOMSourceAnyxmlNode. This forces us to
specialize RpcTransformer, which in turn flushes out the need to remove
default handling and actually pass down RpcResult<M> -- which only makes
sense.

JIRA: NETCONF-669
Change-Id: Id0764cf6c00d764168c3b42c83fdc7a3e41d5ae6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Split up MessageTransformer

We have three groups of methods in one interface and we need to
correctly separate their implementations, as not everything can be a
DOMRpcResult.

JIRA: NETCONF-669
Change-Id: I39452c7050cd5c7da46910f708d37ef17caac279
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch use of SchemaAwareBuilders

We use the builders only for output validation and creating node
identifiers. Let's not to that and use simple builders.

Also change calling convention to use children, so that we can have some
code reuse independent of the parent, leading to a significant reduction
of duplicate code.

JIRA: NETCONF-917
Change-Id: I754213530ac5407a06dce5c3144d8a0a30a3ba1f
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>