Revert "Better FIXME comment in ietf-netconf-notifications model"

This reverts commit 9940f0ef33ebc84294f278423d33b031c3da1c72.

Since BUG 4414 is fixed, use shorthand version of case statement

Change-Id: Ia5947ae6b133f691d65034c0607898c270d427c7
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Fix changed version

Inadvertently changed version while cleaning up features.
This reverts it.

Change-Id: Id273a7feaf82d08a6be105b591b195e2fef7cbd6
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Fix NormalizedNodeStreamWriter implementation"

Fix NormalizedNodeStreamWriter implementation

Add startYangModeledAnyXmlNode() implementation to DelegatingNormalizedNodeStreamWriter

Change-Id: I1f189eff88dd9c2365760f21ac61826bac9c4666
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Bug 4713: Handle "missing-element" in RESTCONF."

Merge "Add payload along with the log.trace message for REST call"

Merge "Add netconf test to verify key ordering in output"

Add payload along with the log.trace message for REST call

Also add the log.trace for the POST request

Change-Id: I2aec41e37f4a70849fa2e71d8b53b6feecb6ef15
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Cleanup features

Migrate to features-parent
Use {{VERSION}} where appropriate

Change-Id: I74d36d75a44bd646127bc3ef339cd57ccf05ea87
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 4713: Handle "missing-element" in RESTCONF.

RESTCONF should return HTTP status 400 (Bad Request) if "missing-element"
is found in RPC error tag.

Change-Id: Iaca7d219b656e86f43f1a7f297ea3c10d24ed410
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Clustered topology module

Extract common code from both topology implementations.
Add Netconf specific topology callback implementations.
Change the clustered pipeline slightly as needed for clustering
implementation.

Change-Id: I6f9e424083423cf7491569ada35f4729e3af63f7
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Bug4698 netconf features.xml has dated documentation about a dependency loop with AAA"

Merge "Bug 4355 - Data Tree: Enforce case uniqueness and 'mandatory true' leaf presence"

Bug4698 netconf features.xml has dated documentation about a dependency loop with AAA

Just removes the documentation to help readers avoid confusion.

Change-Id: I622e6ca47aa6c79966e73223669d5d8949966c88
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Merge changes from topic 'netconf-clustering'

* changes:
  Abstract topology base implementation
  Abstract topology framework apis

Bug 4355 - Data Tree: Enforce case uniqueness and 'mandatory true' leaf presence

- quickfix of netconf unit tests after yangtools changes

Change-Id: I325d52eb984c49a7640094faee82b7a474dbeb5e
Signed-off-by: Peter Kajsa <pkajsa@cisco.com>

Use odlparent-lite as artifacts parent

We created odlparent-lite to provide a minimal pom which allows projects
to publish to the correct server. Without this ${project}-artifacts may
fail to deploy to Nexus.

Change-Id: Iede1f0d105e29b7a8659b1331b3e81ee8d5c1da2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Generate configs for beryllium path."

Abstract topology base implementation

Change-Id: I52b5d2f309789402dc72319d59fb75a3ac4c8df1
Signed-off-by: Tomas Cere <tcere@cisco.com>

Abstract topology framework apis

Change-Id: Ib3d8b9fab7132a25313094fe31c9a77028bb4ea0
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add netconf test to verify key ordering in output

Change-Id: Ife737433c720ea5da4ff35e849644d7df8237c70
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Merge "Fix get and get-config ordering for netconf-mdsal"

Generate configs for beryllium path.

Make testtool generate configs for beryllium paths with lithium fallback.
Also add keepalive executor to prevent warnings.

Change-Id: I63f5530e89fd024a0a1bb025ae9ba20bc8ee81ed
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 3897 - Arguments can be made final patch

Change-Id: I4c82829758b7b6509c9bd7331ceea4e31ffe0393
Signed-off-by: pande.gaurav <pande.gaurav@tcs.com>

Fix get and get-config ordering for netconf-mdsal

Change-Id: Ia0975226e62bdcf56dc30c0182fd8528653c80f9
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Fix javadocs and remove jdk8+ profile

Fixup the few errors from javadoc and remove the JDK8 profile which
turns off validation. Flushes out deficiencies in javadocs.

Change-Id: Iea1af1778179eb1da1650847de30a07d4a753547
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4638: handle StringTypeDefinition properly

This patch adds the path for StringTypeDefinition, so we do not lose the
length restrictions. I do not believe their mapping is accurate, though.

Change-Id: If400f97f9440dab5e5f77cdc2c1eaddcdb2979f8
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4638: use interface instead of concrete types

The parser is bound to switch its implementation of TypeDefinitions. As
a first step, look at the implemented type interface instead of looking
for a concrete implementation class.

Change-Id: I86b3b03d30e9098cbbd99bc61c23bc859ef02302
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Add the ability to edit running in stress-client"

BUG-3884: add exception cause

Add the exception which cause the documented exception.

Change-Id: Iedf5ec8f6f914d7a701cdbf257d8a2d7b33b14c5
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4351: remove commons-lang3 from features

RESTCONF no longer needs it, remove it.

Change-Id: I0f7bdbb210566ab687edbb85cb269a87853b47e0
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4351: remove use of commons-lang3 in tests

the use in assert is easily removed.

Change-Id: Ic734f28583217e491ecdb8ec901e91c50649f1b2
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4351: remove use of commons-lang from sal-rest-connector

Use CharMatcher instead. Also make private methods static.

Change-Id: I4e06a79ee84387472b71abce9e7b7e344c51cfda
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4351: remove use of commons-lang from sal-rest-docgen

Simple internal use of null-for-true. Fixup methods and also make
potentially-static methods static.

Change-Id: I1d3d3e48332e24b0b667a7ac189e72e213f95d81
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Remove use of commons-io in tests

Guava provides equivalent utilities, so use those.

Change-Id: Ieb8a86d4a9081413e6b75e7e84c323c6e8e36f51
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Fix BindingRuntimeContext stubbing

This test was broken by a refactor in controller, fix it up. Also make
methods static while we're in the area.

Change-Id: I06e5ca31ab05303ea45ac06e981dc7abd0c47f68
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Merge "Remove explicit version"

Merge "BUG-4521 Support milliseconds in event-time notification format"

Merge "Make topology listen for configuration in config datastore"

Remove explicit version

https://git.opendaylight.org/gerrit/29198 exposes the version in
artifacts, rendering this declaration unnecessary.

Change-Id: I0144fc74b7fb6178f178817290f2c85be6822305
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make topology listen for configuration in config datastore

Adds the ability to configure topology to listen for netconf connector configuration in
config datastore - makes it possible to bypass config subsystem for netconf connector configuration.

Change-Id: Ie88b8caf4d038bff53adc7f5ec4ba49801021766
Signed-off-by: Tomas Cere <tcere@cisco.com>

BUG-4521 Support milliseconds in event-time notification format

Current format does not support milliseconds right now and netconf
notification RFC clearly says the milliseconds should be supported

Change-Id: Ic5a001b5b9e798b83dc718538b26718e5ed95e19
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Merge "Fix for bug 4266 (unnecessary concurent map and set in java file)."

Merge "Revert "Bug 2515 - Jersey to support JAX-RS 2.0""

Revert "Bug 2515 - Jersey to support JAX-RS 2.0"

This reverts commit a0a9ab4967dd52bd28813961ee14e3cb363017b2.

Change-Id: Ia4d0fc43ac63f1f7ec551aa47fbdd181e99dfac8
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Merge "Bug 2515 - Jersey to support JAX-RS 2.0"

Delete yang-generated files in mvn clean phase

Change-Id: I988f2cc8f05108568859419fec0c43019c8f9bd7
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Bug 2515 - Jersey to support JAX-RS 2.0

* migrate Jersey to version 2.8
* remove the singleton implementations
* join life cycle for Servlet and OSGi bundle to dep.
    only for OSGi Bundle lifecycle.
* ignore tests that fail

This was derived from https://git.opendaylight.org/gerrit/#/c/24500.

Change-Id: I7807b07c6614f023fa2bad9894e6a756a6ac06d3
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Missing white-space character between module name
and rest of the error message text.

Change-Id: Ib6cbfce03ae660ae82a3ad3a947d37cc8aff6d78
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Fix non-initialized keepalive executor when configured.

Change-Id: Ia7803777e90c93adfbc11f2945a7c8617c931b94
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge changes from topic 'netconf-clustering'

* changes:
  BUG 2920: Extend and simplify netconf connector topology model.
  Add clustered node status to netconf-node model

Add missing required-capability

Restconf service config was missing this capability.

Change-Id: I9eb68825ec31ea30a9ea8e4abf542494fb7d4f3d
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fix for bug 4266 (unnecessary concurent map and set in java file).

Change-Id: I1471547fb9fdcee964c84ded142d344022f6f33a
Signed-off-by: rashmitomer <rashmi.tomer@tcs.com>

BUG 2920: Extend and simplify netconf connector topology model.

Add shared schema repository and netconf topology binding.
Create a default schema repository instance.
Add topology config.
Simplifiy netconf connector model to use new netconf
topology with backwards compatibility.
Bump netconf connector schema revision.

Change-Id: I3978a0a7e6e3c08dba52e65912bfe33ad46b4cf8
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add clustered node status to netconf-node model

Change-Id: Ib057066a6449b72a11f6723b327b8f8a55145eea
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge changes from topic 'netconf-clustering'

* changes:
  Add completeable future to NetconfDeviceCommunicator
  Extend netconf-node model

Bug 4425 - netconf-testtool NullPointerException

Use SchemaContext to parse schema sources to capabilities instead of
YangParserListenerImpl. YangParserListenerImpl is not used in migrated
YANG parser.

Change-Id: I95925b5888417dcb814d2cf8681200b747108b45
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Merge "Stop failing discard-changes operation when tx wasn't initialized"

Stop failing discard-changes operation when tx wasn't initialized

Change-Id: Icea5b5830caf4fffd034108eb4e524c3aa5d4397
Signed-off-by: Tomas Cere <tcere@cisco.com>

Better FIXME comment in ietf-netconf-notifications model

Add bug number of related yangtools bug to FIXME comment

Change-Id: I0b82f9913886a5cb154862c806458cf9b9d3ffa9
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Fix shorthand case statement in netconf notifications model

Use normal version of server case statement in server-or-user choice statement
in ietf-netconf-notifications model. Short version is currently not supported
by yangtools.

Change-Id: I043babfc8e70654aed1c8dfdd7486795e49aa2bf
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Add completeable future to NetconfDeviceCommunicator

Add a future that completes when first connection attemp succeeds.

Change-Id: I68c31bb75ed0576a79257a0c6ddb9eef0cd64c74
Signed-off-by: Tomas Cere <tcere@cisco.com>

Extend netconf-node model

Add configuration data that is required for establishing a connection.

Change-Id: Ie0cc38537c2e67778f060f16786c25e8c6996dbf
Signed-off-by: Tomas Cere <tcere@cisco.com>

BUG-4367 Do not transform modules to capabilities

Pre-built capabilities already contain the source retrieved from a
SchemaSourceProvider

Change-Id: If5bb358e411c2ca020092a7ea2b6dbd1faa3a88f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Add mdsal-netconf-notification dependency to features-netconf

Add missing dependency on mdsal-nteconf-notification to netconf-features project

Change-Id: I323765720e935162e8e65355f141edc1e5d26da3
Signed-off-by: JMorvay <jmorvay@cisco.com>

Fix javax.annotation missing package from rest

Change-Id: I56d43c158c14dcb925eafa18b997465f9baa2fe0
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Merge "Bug 3999: Create internal service to access restconf"

Merge "Bug 3863 - Milestone: Add support for netconf notifications in MD-SAL netconf northbound"

Merge "YangInstanceIdentifier::toInstance() -> build()"

Bug 3863 - Milestone: Add support for netconf notifications in MD-SAL netconf northbound

Add support for netconf-capability-change notification.

Change-Id: Ib05f0d57c744275dbf569e3b26821274671f6787
Signed-off-by: JMorvay <jmorvay@cisco.com>

Removed use of toInstance in NETCONF.

Change-Id: Ibbea950159f32a9ed6d053be7f015489f2a82acd
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

YangInstanceIdentifier::toInstance() -> build()

::toInstance() is gone, which breaks the build.

Change-Id: Ic81def83cc7ac371e4d4fcc7db4382c1a0702739
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Set proper keepalive delay for netconf testtool"

Merge "Add a missing commons-lang3 dependcy to features-restconf"

Introduced additional commandline option --initial-config-xml-file retrievable
via the Simulated get-config rpc.  This supports testing a client with any
specific config without first "pushing" a config via edit-config.  This is useful
for some test scenarios such as testing with malformed configs.

Change-Id: If0da1ba310177687b76ff417ba246182e5e99b77
Signed-off-by: jameshall03885 <ghall@brocade.com>

Mark config substystem NotificationManager

Mark NotificationManager, that is auto wired netconf endpoint for config
subsystem

Change-Id: I51ec53ba122aa0a3dd79e4d71e07422fac1b8ffc
Signed-off-by: JMorvay <jmorvay@cisco.com>

Add a missing commons-lang3 dependcy to features-restconf

Change-Id: I891d755ef530ec9e257acdf451ccfc68cf6f3adf
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 3999: Create internal service to access restconf

There are use cases for invoking restconf from internal code. However
issuing an HTTP request is problematic as one would need to know the
credentials and scheme (http or https).

So I added a JSONRestconfService interface and implementation with CRUD
methods that call the JSON readers/writers and RestconfImpl internally.
The implementation is advertised as an OSGi service via the config
system for consumption by clients.

I only added a service for JSON - an XML service could be added as well
later.

Change-Id: Ia3753846756ace29bc28aa0a1fe9d474a60f80ce
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Set proper keepalive delay for netconf testtool

The keepalive was set to -1 in generated configs for simulated devices. However
the type for keepalive delay is an unsigned integer. So it should be 0.

Change-Id: I8ab53097bce484837b8721a954a749a87090642a
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Remove duplicate dependency declaration

This emits a maven warning, so remove the duplicate.

Change-Id: I7cfdee854a5e8a67a17eed5acb5d7692e7b85c0c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix features not pulling all its dependencies

odl-message-bus requires messagebus-netconf, but does not pull it in.

Change-Id: I85da9727c89dd14dfb52b411ca6ce5f109f3ba4b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Update aaa-authn-odl-plugin to use updated aaa bindings

Change-Id: I9db1888763dbf4d052367a248b07ea03e8039ea0
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 3822: Improve error reporting for restconf PUT

A runtime exception can be emitted by the netconf mount point which
should be reported to the user, otherwise you get a 500 response with
no error info which isn't very helpful.

Also the fucntionality to output the error-info field was ommitted with
the conversion from CompositeNode to NormalizedNode so I re-implemeneted
it. It was originally ommitted with a TODO b/c the
NormalizedNodeStreamWriters validate against the schema and error-info
is defined as an empty container in the restconf yang. So there's no way
to create a ContainerNode to represent the error-info data that conforms
to the schema. To work around this, I created a leaf node and special-cased
error-info in the stream writer to elide schema validation.

I also added a regression unit test for the case where the URL contains
an identityref.

Change-Id: I93b4aea25c829af1232d539180f02dd61e252d50
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Signed-off-by: JMorvay <jmorvay@cisco.com>

Merge changes Iad68eda5,Ie962aa4b

* changes:
  BUG-865: use new JSONNormalizedNodeStreamWriter methods
  BUG-865: remove use of yang.model.util.repo

Add the ability to edit running in stress-client

Change-Id: I1aa1c3bbcae86af328ffc85815ceb48748ab9201
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fixed features-netconf to use feature test and correct versions

Previous patches were assuming that single feature test was working
for features-netconf, which is was not - test was commented out
due to controller - aaa - netconf cycle dance.

- Reenabled single feature test
- fixed version of odl-netconf-mdsal

Change-Id: I47f5a52b96b07f94e8823968b90934b435aa5a2b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-865: use new JSONNormalizedNodeStreamWriter methods

JSONNormalizedNodeStreamWriter.create() family of methods is deprecated,
do not use it.

Change-Id: Iad68eda5efcd191e7cba03785b7ef9e2e550dd9a
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-865: remove use of yang.model.util.repo

This package is deprecated and about to be removed. Remove all
references to it.

Change-Id: Ie962aa4bdc6400b70def7f2486356b123ff19eb4
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 4306: Refer to the correct version of features-netconf-connector

features-netconf-connector's POM inherits netconf-features-parent's
version, 1.0.0-SNAPSHOT; but netconf-artifact's POM uses
${mdsal.version} for features-netconf-connector (1.3.0-SNAPSHOT).

This patch uses ${project.version} instead, which is 1.0.0-SNAPSHOT.

Without this sfc fails to build in a clean environment.

Change-Id: Icad267d3e502233243eb10b4a7274b23feff0c31
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Migration to use MD-SAL Project

Change-Id: Iafdfbcf553978717be7ec80b488f94b64f688eea
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Ignore failing tests

These tests are relying on ordering of hash-based objects,
ignoring for now to prevent job failures.

Change-Id: Ie467c1f06924a6699e20ace71baa5825cbb48198
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Add .gitreview"

Merge "MD-SAL netconf northbound now relies on AAA for authentication"

Merge "Rename netconf-ssh test packages"

MD-SAL netconf northbound now relies on AAA for authentication

Change-Id: I58ff18fbcc230c7391617c435897673169052aa9
Signed-off-by: Tomas Cere <tcere@cisco.com>

Rename netconf-ssh test packages

Change-Id: I0a19631cdb4ce567f6d8a2f222b49b38641751a9
Signed-off-by: Tomas Cere <tcere@cisco.com>

BUG 4010:Reintroduce inventory code into sal-netconf-connector

Change-Id: I946907d9ef835d3e5ffdd198d1ec39158ff91feb
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fix integration tests imports and checkstyle violations

Change-Id: Id016e581f0018c2aa47f6fc371fb85f6ad341950
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Enable authn on odl-restconf feature"

Merge "Make test-tool advertise candidate capability"