Merge "Add logging for RPC calls."

Merge "Cleanup features a bit"

Add logging for RPC calls.

Change-Id: I97503fc2e098e3c048e10041d8f3de4b65a1e4f6
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Fix yang source provisioning from MD-SAL netconf northbound

Change-Id: Iab11d3780379e681d2d6228868e8b96cd894cb56
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Merge "Revert "BUG 2594 - PUT method returns wrong status on create""

Revert "BUG 2594 - PUT method returns wrong status on create"

This reverts commit 93816f7aeacd89785f083a82036bf6a7d90c316a.

Change-Id: I741add04db100359087d89537744d027a2c4fb6f
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Make mdsal datastore persist through different sessions"

Make mdsal datastore persist through different sessions

Each device needs cached set of datastore operations.

Change-Id: Ib0d846d6e3b118c55890f4e76e19174849b68115
Signed-off-by: Tomas Cere <tcere@cisco.com>

BUG-4709 Fix first keepalive execution

Change-Id: I6afcf70ec6b0b46cad861755e13ad33a2a692d19
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Cleanup features a bit

Use artifacts imports in pom.xmls (partial conversion) and use odl-netty
feature.

Change-Id: Id50719e7e1b84fcd7b9048d3fb7d6476793b12ce
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Merge "BUG 3015 - restconf: Un-helpful error message presented when no service provider is there to handle the RPC call."

Merge "BUG 2594 - PUT method returns wrong status on create"

Merge "BUG 3274 - Generate multiple configs for same port"

Merge "Bug 4709 - Add keepalive response timeout to KeepaliveSalFacade of netconf connector."

Merge changes from topic 'netconf-clustering'

* changes:
  Move mount point registration after schema resolution
  Cluster schema resolution pipeline
  Clustered sources resolution
  Change onNodeUpdated to first cleanup previous state
  Use normal identify messages first
  Use lock in topology node writer
  Prevent NPE's on failures
  RemoteDeviceDataBroker proxy

Merge "Fix empty revision handling in NETCONF capability"

Merge "Bug 4846 odl-mdsal-apidocs swagger UI uses deprecated TokenAuthFilter"

Remove unused jersey properties

Jersey dependencies are inherited from odlparent.  This
removes some now unused jersey properties.

Change-Id: I2b64dc279e8070554e5a4f0f2ad9ece0dc16bff3
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Bug 4846 odl-mdsal-apidocs swagger UI uses deprecated TokenAuthFilter

Switches from TokenAuthFilter, a ContainerRequestFilter, to AAAFilter, a
javax.servlet.Filter.  This allows use of Shiro Realms including LDAP.

Change-Id: I4956d773da4128b5bbae92b3438154eff3e76367
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Bug 4709 - Add keepalive response timeout to KeepaliveSalFacade of netconf connector.

Change-Id: Ie6c7593eebd62c85430b2b219921fa7d28e63024
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

BUG 3274 - Generate multiple configs for same port

Change-Id: I1fdf43efa6b0abf3df9e8844b06d30ace2425b50
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Formatted code for Bug-3890"

BUG 3015 - restconf: Un-helpful error message presented when no service
provider is there to handle the RPC call.

* added catch in checkRpcResponse when cause of error is unimplemented
rpc service

port of :
https://git.opendaylight.org/gerrit/#/c/23277/2

Change-Id: I12a457bf948bf13040c41e393284e0748b1bcaed
Signed-off-by: Tomas Cere <tcere@cisco.com>

BUG 2594 - PUT method returns wrong status on create

Port of:
https://git.opendaylight.org/gerrit/#/c/19009/

Change-Id: Ic225f9290c49fde29be3fbf7c51ef4cc36d8e532
Signed-off-by: Tomas Cere <tcere@cisco.com>

Move mount point registration after schema resolution

Also a couple other minor bugfixes.

Change-Id: Id1e412a748225f4194f0b9c5e39d45f6bf58db4c
Signed-off-by: Tomas Cere <tcere@cisco.com>

Cluster schema resolution pipeline

Change-Id: Ia469fedd25d1511308e52328be925845827968c0
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Clustered sources resolution

Change-Id: I9fe167ab4185a8ac959b5e1aa6737d1eaff1d90c
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Pull in com.typesafe:config from odlparent

Change-Id: I42b74d58b3e522c141ede246911b35e59f6ce734
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Change onNodeUpdated to first cleanup previous state

Change-Id: Ied3a631466753663601905d0b1d7f138e6fc6542
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fix empty revision handling in NETCONF capability

If a capability exposed by a netconf server contains revision parameter
but has no value there e.g.
<capability>some-namespace=some-module&amp;revision=</capability>

connection would fail with NPE in netconf connector.

Change-Id: I74a2548dffc524b06c2bcca04e9bd267ed8c7201
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Merge "Fix non ietf-netconf* mounted RPC invocation from Restconf"

Use normal identify messages first

Prevents crashing akka if bundles containing our messages
weren't loaded on remote node yet.
Add resyncs on remote node's coming up.

Change-Id: I2c6076c1c09ad4a839f4e5e60e172805bdb45ad6
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Make test tool work with schemas with no revision"

Merge "Make test tool expose submodule sources"

Fix non ietf-netconf* mounted RPC invocation from Restconf

Invoked RPCs from modules other than iet-netconf* were executed on ODL itself
instead of a mountpoint regardless of whether they were aimed at a mountpoint
or not.

Change-Id: I2586ad77ec17c7542ba3ffd931684fb6f7c12685
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Add copyright headers to sal-rest-connector

Change-Id: Icba51049b68d23093dca4f315b26016baa3861e8
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Formatted code for Bug-3890

Change-Id: I7b6c481104ec4445c034cc5a9e560a641e7df93c
Signed-off-by: Shivani Pathak <shivani.pathak@tcs.com>

Use lock in topology node writer

Prevents race conditions from akka callbacks.
Prevent NPE's when deleting node that's not connected.

Change-Id: I0e46083fe98c88cae7dc836c98f9eb4e22026579
Signed-off-by: Tomas Cere <tcere@cisco.com>

Prevent NPE's on failures

Change-Id: I7f69aa4f9a695c7d03cd7db6cd5c539bfd255cdd
Signed-off-by: Tomas Cere <tcere@cisco.com>

RemoteDeviceDataBroker proxy

Change-Id: Ifdb7b905f95dc2af5e31003e59405ebc446d85d3
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 4773 Package uses conflict between authn and restconf

Add in the javax.annotation dependencies, and make the bundles private
so there is no package uses conflict.

Change-Id: Ic6b3cc7906179ae63524035eff4e8d9faa33c61b
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Merge "Bug 3896 - direct usage of == instead of .equals"

Bug 3896 - direct usage of == instead of .equals

Change-Id: If0b7ba7c8cecc9dffc036b4cadfd2654034674a6
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Merge "Formatted code Bug-3894."

Merge "Remove DelegatingNormalizedNodeStreamWriter"

Merge changes I24adce35,Ia5947ae6

* changes:
  Revert "Fix shorthand case statement in netconf notifications model"
  Revert "Better FIXME comment in ietf-netconf-notifications model"

Merge "Bug 4700 - RestPerfClient spits NumberFormatException and hangs"

Merge "Remove unnecessary uses of odlparent properties"

Merge "Bug 4719 Shiro integration into restconf"

Formatted code Bug-3894.

Change-Id: I9cc580133250c12592e8eb2d64629c54fc3d78f0
Signed-off-by: Shivani Pathak <shivani.pathak@tcs.com>

Bug 4719 Shiro integration into restconf

Switches from TokenAuthFilter, a ContainerRequestFilter, to AAAFilter, a
javax.servlet.Filter.  This allows use of Shiro Realms including LDAP.  In
order to run restconf without AAA, you can can still utilize the
odl-restconf-noauth feature.  AAAFilter is disabled by default, and only
enabled when the odl-shiro-act bundle is activated.

Change-Id: I628967886c8b999761a71a632dc34294b45292df
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Merge "Bug 4712 - Fix Keepalive task to check the response of a keepalive request"

Merge "Fix missing NetconfNotificationCollector service"

Fix missing NetconfNotificationCollector service

Change-Id: Icac4957a2e68499cc2a438e4ea3b516d725a4854
Signed-off-by: Tomas Cere <tcere@cisco.com>

Remove unnecessary uses of odlparent properties

${bouncycastle.version} and ${jersey.version} are no longer
necessary.

This depends on Ifb388ce08e1870b50ce720061550e72137bce798 in
oldparent.

Change-Id: If8581e2299bfe9984e71bcfca5560580f65f5c12
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 4725 - RestPerfClient: Add support for authentication.

Add HTTP basic authentication support to RestPerfClient.

Change-Id: Idc9537b1e4018abe672bec38a3291a40251d53e8
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Bug 4700 - RestPerfClient spits NumberFormatException and hangs

Validate destination argument and exit if destination does not start with '/'.

Change-Id: Ic2dcfb9876cffebfae02c0756eda93416b19a284
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Bug 4712 - Fix Keepalive task to check the response of a keepalive request

If response is null, tear down the session.

Change-Id: I11bda91a346e833eff4003eaec7c677a1f1733d3
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Make test tool work with schemas with no revision

Change-Id: I9be0c3397288a55a422ef631d1a73378236382a9
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Make test tool expose submodule sources

Change-Id: If614ee052175f6f1ce60609aa0696788c216c247
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Revert "Fix shorthand case statement in netconf notifications model"

This reverts commit da1abe40ffbc95f53149797f7aff46a4510b5db3.

Since BUG 4414 is fixed, use shorthand version of case statement

Change-Id: I24adce3584caada676b91ddc9865e69bfc6eb67e
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Revert "Better FIXME comment in ietf-netconf-notifications model"

This reverts commit 9940f0ef33ebc84294f278423d33b031c3da1c72.

Since BUG 4414 is fixed, use shorthand version of case statement

Change-Id: Ia5947ae6b133f691d65034c0607898c270d427c7
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Remove DelegatingNormalizedNodeStreamWriter

We already have ForwardingNormalizedNodeStreamWriter
in yangtools.

Needs to be merged after:
https://git.opendaylight.org/gerrit/#/c/30914/

Change-Id: I4eb17f41dd086976045da2981397008f2cd75f93
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fix changed version

Inadvertently changed version while cleaning up features.
This reverts it.

Change-Id: Id273a7feaf82d08a6be105b591b195e2fef7cbd6
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Fix NormalizedNodeStreamWriter implementation"

Fix NormalizedNodeStreamWriter implementation

Add startYangModeledAnyXmlNode() implementation to DelegatingNormalizedNodeStreamWriter

Change-Id: I1f189eff88dd9c2365760f21ac61826bac9c4666
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Bug 4713: Handle "missing-element" in RESTCONF."

Merge "Add payload along with the log.trace message for REST call"

Merge "Add netconf test to verify key ordering in output"

Add payload along with the log.trace message for REST call

Also add the log.trace for the POST request

Change-Id: I2aec41e37f4a70849fa2e71d8b53b6feecb6ef15
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Cleanup features

Migrate to features-parent
Use {{VERSION}} where appropriate

Change-Id: I74d36d75a44bd646127bc3ef339cd57ccf05ea87
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 4713: Handle "missing-element" in RESTCONF.

RESTCONF should return HTTP status 400 (Bad Request) if "missing-element"
is found in RPC error tag.

Change-Id: Iaca7d219b656e86f43f1a7f297ea3c10d24ed410
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Clustered topology module

Extract common code from both topology implementations.
Add Netconf specific topology callback implementations.
Change the clustered pipeline slightly as needed for clustering
implementation.

Change-Id: I6f9e424083423cf7491569ada35f4729e3af63f7
Signed-off-by: Tomas Cere <tcere@cisco.com>

Merge "Bug4698 netconf features.xml has dated documentation about a dependency loop with AAA"

Merge "Bug 4355 - Data Tree: Enforce case uniqueness and 'mandatory true' leaf presence"

Bug4698 netconf features.xml has dated documentation about a dependency loop with AAA

Just removes the documentation to help readers avoid confusion.

Change-Id: I622e6ca47aa6c79966e73223669d5d8949966c88
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Merge changes from topic 'netconf-clustering'

* changes:
  Abstract topology base implementation
  Abstract topology framework apis

Bug 4355 - Data Tree: Enforce case uniqueness and 'mandatory true' leaf presence

- quickfix of netconf unit tests after yangtools changes

Change-Id: I325d52eb984c49a7640094faee82b7a474dbeb5e
Signed-off-by: Peter Kajsa <pkajsa@cisco.com>

Use odlparent-lite as artifacts parent

We created odlparent-lite to provide a minimal pom which allows projects
to publish to the correct server. Without this ${project}-artifacts may
fail to deploy to Nexus.

Change-Id: Iede1f0d105e29b7a8659b1331b3e81ee8d5c1da2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Generate configs for beryllium path."

Abstract topology base implementation

Change-Id: I52b5d2f309789402dc72319d59fb75a3ac4c8df1
Signed-off-by: Tomas Cere <tcere@cisco.com>

Abstract topology framework apis

Change-Id: Ib3d8b9fab7132a25313094fe31c9a77028bb4ea0
Signed-off-by: Tomas Cere <tcere@cisco.com>

Add netconf test to verify key ordering in output

Change-Id: Ife737433c720ea5da4ff35e849644d7df8237c70
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Merge "Fix get and get-config ordering for netconf-mdsal"

Generate configs for beryllium path.

Make testtool generate configs for beryllium paths with lithium fallback.
Also add keepalive executor to prevent warnings.

Change-Id: I63f5530e89fd024a0a1bb025ae9ba20bc8ee81ed
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 3897 - Arguments can be made final patch

Change-Id: I4c82829758b7b6509c9bd7331ceea4e31ffe0393
Signed-off-by: pande.gaurav <pande.gaurav@tcs.com>

Fix get and get-config ordering for netconf-mdsal

Change-Id: Ia0975226e62bdcf56dc30c0182fd8528653c80f9
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Fix javadocs and remove jdk8+ profile

Fixup the few errors from javadoc and remove the JDK8 profile which
turns off validation. Flushes out deficiencies in javadocs.

Change-Id: Iea1af1778179eb1da1650847de30a07d4a753547
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4638: handle StringTypeDefinition properly

This patch adds the path for StringTypeDefinition, so we do not lose the
length restrictions. I do not believe their mapping is accurate, though.

Change-Id: If400f97f9440dab5e5f77cdc2c1eaddcdb2979f8
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4638: use interface instead of concrete types

The parser is bound to switch its implementation of TypeDefinitions. As
a first step, look at the implemented type interface instead of looking
for a concrete implementation class.

Change-Id: I86b3b03d30e9098cbbd99bc61c23bc859ef02302
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Add the ability to edit running in stress-client"

BUG-3884: add exception cause

Add the exception which cause the documented exception.

Change-Id: Iedf5ec8f6f914d7a701cdbf257d8a2d7b33b14c5
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4351: remove commons-lang3 from features

RESTCONF no longer needs it, remove it.

Change-Id: I0f7bdbb210566ab687edbb85cb269a87853b47e0
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4351: remove use of commons-lang3 in tests

the use in assert is easily removed.

Change-Id: Ic734f28583217e491ecdb8ec901e91c50649f1b2
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4351: remove use of commons-lang from sal-rest-connector

Use CharMatcher instead. Also make private methods static.

Change-Id: I4e06a79ee84387472b71abce9e7b7e344c51cfda
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4351: remove use of commons-lang from sal-rest-docgen

Simple internal use of null-for-true. Fixup methods and also make
potentially-static methods static.

Change-Id: I1d3d3e48332e24b0b667a7ac189e72e213f95d81
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Remove use of commons-io in tests

Guava provides equivalent utilities, so use those.

Change-Id: Ieb8a86d4a9081413e6b75e7e84c323c6e8e36f51
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Fix BindingRuntimeContext stubbing

This test was broken by a refactor in controller, fix it up. Also make
methods static while we're in the area.

Change-Id: I06e5ca31ab05303ea45ac06e981dc7abd0c47f68
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Merge "Remove explicit version"

Merge "BUG-4521 Support milliseconds in event-time notification format"