Remove superfluous this. qualifier

We have some unnecessary verbosity here, ditch it to simplify access.

Change-Id: Idf94706a60169741e7e5a4deec0f17cf87a313d8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Centralize NetconfNode/InetSocketAddress conversion

The process of creating a RemoteDeviceId and/or the target
InetSocketAddress is duplicated in a number of places, each slightly
different.

Centralize conversion in netconf.topology.spi and use it from there,
which leads us to topology-singleton being able to use non-IP addresses.

JIRA: NETCONF-875
Change-Id: I5c4a610eb4f4b3cd6586198d5e9a4b84b476d351
Signed-off-by: Rohini.Ambika <rohini.ambika@infosys.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup ActorProxyNetconfServiceFacade

Use Futures.immediateFuture(), but mark a FIXME, where we should really
be getting a response.

Change-Id: I73e1f1620df83b76d266ed8980d86bb40634a614
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Prefer java.time.Duration

Use Java 8 Duration instead of Scala's version. Actors then convert
to Scala as needed.

Change-Id: Id1301c9c67a8a301aa20aafafdbd387865c2cf3b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix PATCH request issue with top-level container as target

PATCH request to the data root with a top-level container as
target does not work because JsonPatchBodyReader and
XmlPatchBodyReader expect a parent statement in the stack.

Address the issue by setting target schema node to the path
schema context when stack is empty and add test cases for
JsonPatchBodyReader and XmlPatchBodyReader.

JIRA: NETCONF-877
Change-Id: Ibb65ccdf3f03d8a9a9023d75bf288e5e4416ca50
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Bump json-unit-assertj to 2.35.0

No explicit release notes.

Change-Id: I7f8236f2784984d0913e505fddcb2fbaa65f00d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8d6fa34398b79786d92cb5ba707edd74a63b9ec2)

Bump upstream versions

Adopt:
- odlparent-10.0.2
- infrautils-3.0.1
- yangtools-8.0.5
- mdsal-9.0.3
- controller-5.0.5
- aaa-0.15.4

Change-Id: I9d78b5a9538801854910a0621a9ebab60fac0414
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8030cefc9a73619d4a06ff0e5251b3817650cba1)

Fix checkstyle

There are a few violations, fix them up.

Change-Id: I2c6b766692725975e216c714f7d46b2e833cf80e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2ae7e8a14d82519cc500aea570e3bc8f496944b7)

Bump argparse4j to 0.9.0

https://github.com/argparse4j/argparse4j/releases/tag/argparse4j-0.9.0

Change-Id: Iba7c6c0612ab39060ec0a7e4672d4b6a1b584477
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 465720aa537e95d51540529e8fed773a345e87eb)

Do not access model context multiple times

InstanceIdentifierContext has a capture of the model context, use it
from there instead of accessing it multiple times.

Change-Id: Ia29bf5a3e80d164c08ef338649080cb4f48ce4a5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove Bierman02 support from sal-rest-docgen

sal-rest-docgen still has references to bierman02, remove them. Since we
are touching blueprint, ditch ODL extension reference.

JIRA: NETCONF-837
Change-Id: If9b89c40779dc9a87e9e26b38ca2bc2ba0dc5500
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstream versions

Adopt:
- controller-5.0.3
- aaa-0.15.3

Change-Id: I3de5aed583bd97806c54a314d91f1efd96ff5f25
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize sal-rest-docgen tests a bit

Add an abstract base class to reuse EffectiveModelContext and schema
service. Also use static imports and simplify assertions.

Change-Id: Ib1558ca32efbf5fe9862ff41c5214d090eeedd6c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix docgen for action types

When we are processing actions we need to adjust the stack to enter
each of them for the duration of traversal. Also add the corresponding
test.

JIRA: NETCONF-872
Change-Id: I5aae78380073c4d5c876b888b22cd41a2657db2d
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move streams support classes

All these classes are used only by the streams/listeners package,
make sure to relocate them to the same package and are a properly-hidden
implementation detail.

JIRA: NETCONF-837
Change-Id: Ib9d979ef408c36e8c5b9d2cf617dc07c887fa622
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move OperationsContent

This is a purely server-side implementation thing, move it to its sole
user.

JIRA: NETCONF-837
Change-Id: I545f9f444c548a8366b6cf6bb0ac85c859ef632c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move SimpleUriInfo

This class is used only in tests, move it and hide it. Also rename it to
LocalUriInfo and mark its sole user for future evolution, e.g. use
mocks.

JIRA: NETCONF-837
Change-Id: If3ecdbf332cd3c18bdb8822d2f5396c3d59df3b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove restconf-nb-bierman02

We have a replacement in RFC8040 northbound and this implementation has
been deprecated for a long time. Remove it now. Also remove parts of
restconf-common which are no longer used.

JIRA: NETCONF-837
Change-Id: I5430bbbe398e2ea23e510726259f2f5ffaae936d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.0-SNAPSHOT

This starts the next major development iteration.

Change-Id: If406715f7d02b9d3d7f093f371e2d3efa3382fe7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 3.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: If73d3e904751ad95cac65395a3ade3d680c5ea22
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- yangtools-8.0.3
- mdsal-9.0.2
- controller-5.0.2
- aaa-0.15.2

Change-Id: I085f1c8f3e6cc694ae43a3d43dc38c726c8a0f0e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use RestUtil.resolveBaseTypeFrom()

Derived types have been using their proper type for a long time now
and there is essentially cannot be a semantic difference between a
derived/restricted type which would make any difference during
resolution. Ditch the base type lookup and just use the type at hand.

JIRA: NETCONF-837
Change-Id: I21afc3ac15c954358f62070065531e75ff360924
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove RestCodec

Inline the final simple type handling into prepareValueByType(),
rendering RestCodec superfluous.

JIRA: NETCONF-871
Change-Id: Ie649e28d4333e3c57b49a3593c639474a0c930ad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move StringModuleInstanceIdentifierCodec

Peel the instance-identifier case from RestCodec to prepareValueByType()
and move StringModuleInstanceIdentifierCodec to be co-located with its
sole user.

JIRA: NETCONF-871
Change-Id: If731522204427b5467c3575c91944737fc18e1bc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove RestCodec's identityref handling

The sole caller is intercepting IdentityrefTypeDefinition before
invoking this method, so this code is dead. Remove it.

JIRA: NETCONF-871
Change-Id: I1f2a9b2f343c7b802e8c61c755a9f2a4c5b56394
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove IdentityrefCodecImpl and rename ObjectCodec

IdentityrefCodecImpl is not referenced anywhere and removing it makes
RestCodec empty. Move ObjectCodec into its place instead and squash it
to a single static method.

JIRA: NETCONF-871
Change-Id: Idbb072c1dcfbeebfd80cdc73751adf81ad9816f5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove IdentityrefCodecImpl

This class is completely unreferenced, remove it.

JIRA: NETCONF-871
Change-Id: Ifbeedeebe8d3f308a3405ce0eddf7ce5f0a1ce27
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove InstanceIdentifierCodecImpl

This class is completely unused now. Remove it along all utility methods
it is referencing.

JIRA: NETCONF-871
Change-Id: I549293c108a1a2f92dc9204b843bb1e803ce7166
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Propagate invariants of ObjectCodec callers

The serialize() method is never called, hence we can just remove it.
The deserialize() method always gets a String, hence we can just bypass
the dance with references and whatnot.

JIRA: NETCONF-871
Change-Id: I405306e5e5aacf2f15f9a936f77b3ab841cc98d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

ObjectCodec does not need a mount point

There is only one caller and that caller is not passing a mount point,
propagate that invariant.

JIRA: NETCONF-871
Change-Id: I4a5a312cce87be3176b9757e5bfdde6538c229d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move ObjectCodec to its own file

This the beef of RestCodec, make sure it is a top-level construct.

JIRA: NETCONF-871
Change-Id: I314cc3f91ca3c5e7e2d4e6d7310507541e1cd843
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix CCE in DefinitionGenerator

decimal64 is mapped to its own type, not BigDecimal. Adjust the cast
and convert to BigDecimal.

JIRA: NETCONF-870
Change-Id: Idce468ed2728f472431ed325ab8dcb2a1e449118
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify SSE mocking

The springboard through interface default method does not quite work,
rework the mock to not use it.

Change-Id: Iec36b42762c901ae7f0fc83072abbb6c2e12c553
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unused spying

KeepaliveSalFacadeTest has a bit of useless mocking/spying. This is
failing with JDK17. While we would want to mock the behavior exactly
without delays, use real executor for now.

Change-Id: I462852fb8ed56ed5370d7036bc2c3c862129dce1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use SoftSchemaSourceCache

GuavaSchemaSourceCache is deprecated, use SoftSchemaSourceCache instead.

Change-Id: Ie7334e28eafefc60e3e4b7521b8c685df3b25e97
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Trim NodeIdentifierWithPredicates from post path

The identifier we are getting from DataSchemaContextTree does not have
correct predicates filled it. Make sure to trim it, as we are restoring
it properly after parse.

JIRA: NETCONF-869
Change-Id: Ia5103e25d0c2790c5c31bea356a29b69f43618b6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 3.0.1-SNAPSHOT

This starts the next development iteration.

Change-Id: Ic2634d0b2f04a17f2b451f7004783475a8ce421b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reject consecutive slashes

Tweak are default handling of consecutive slashes to be compliant with
RFC8040.

JIRA: NETCONF-867
Change-Id: Iff654d24d6107bdd9dc1e670e51dca6d042d0574
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams to SNAPSHOTs

Adopt:
- odlparent-10.0.0
- infrautils-3.0.0
- yangtools-8.0.2
- mdsal-9.0.1
- controller-5.0.1
- aaa-0.15.1

This also ditches last references to SchemaNode.getPath(), replacing
such references with SchemaInferenceStack.Inference and related
operations.

JIRA: NETCONF-818
Change-Id: I99a02e3b4e831d32013fa722d2bda3932c873ffc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>

Fixup processing reporting

We need to report the events as done even if the downstream writer does
not accept the object model. If we do not, we will get confused about
how the node should be processed.

JIRA: NETCONF-868
Change-Id: I5a76c5a2af79ecaaf4c80f832774b08d60d03379
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Support AnydataNode in ParameterAwareNormalizedNodeWriter

AnydataNode is not processed in ParameterAwareNormalizedNodeWriter
throwing IllegalStateException. Add a step to check/process AnydataNode
in wasProcessAsSimpleNode().

JIRA: NETCONF-868
Change-Id: I637890ff6779d0a532ee6d4182e4c36baa4f5231
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>

Reconstruct inference stack during normalization

Centralize allocation of Inference, adjusting tests to take advantage of
this facility. This also hides the public InstanceIdentifierContext, so
that we get clarity as to the actual context in which we are executing.

AbstractFieldsTranslatorTest is refactored to remove mocking and
correctly bind to the undelying model.

This temporarily picks up yang-model-util-7.0.15 for
restconf-{common,nb-rfc8040}, so as to gain access to new methods of
DataSchemaContext{Node,Tree}.

JIRA: NETCONF-818
Change-Id: Iaf3362877261f3caaebfb4ec98ef6de792139f12
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not re-acquire global schema context

The context is bound at NormalizedNodeContext creation time, let's
make sure we do not change that.

JIRA: NETCONF-818
Change-Id: I7ec6296c2703b3689aa0c464874ede37695d9065
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Peel rfc8040 tests from InstanceIdentifierContext constructor

Migrate more callers to replacement methods.

JIRA: NETCONF-818
Change-Id: Iac89d4cfa19d15ff525078776ce73a9ee2bfc7df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not expose YangInstanceIdentifier on output

Output codecs do not care about this information, do not fill it in.

JIRA: NETCONF-818
Change-Id: I6aeaa68d244958960ac455d34247816852220d5a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use Builders.containerBuilder()

Ditch the direct reference to implementation and use Builders
indirection instead.

Change-Id: Ic05d64b63100e9e8b6eb5dacafa787ad2b49e52d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

No not create YangInstanceIdentifier for a response

In the output path nobody cares about the instance identifier, simplify
the code instead.

Change-Id: Ib8ec7d8a27d295724d994f3f855b6e0062188435
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Finish bierman02 test migration

Eliminate last callers of public InstanceIdentifierContext constructor.

JIRA: NETCONF-818
Change-Id: I175c9d556c1922b0fdfee611517c8a47d52826d7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Peel another RPC invocation site

Another site with pure RPCs, make sure to peel it off.

JIRA: NETCONF-818
Change-Id: I7d5e3aa473b5641a6efa902394b6d9f39a8e7278
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Peel of RPC invocation InstanceIdentifierContext

Here is a confusing site, which could ned up holding an
InstanceIdentifier, which is not valid. Peel it off.

JIRA: NETCONF-818
Change-Id: I2184afd2d5e750b60b471f7d5d009e038b4b7017
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve RFC8040 tests

We have a few tests using @Test(expected), improve them by using
assertThrows() and performing some assertions.

Change-Id: I378c1108c43e42f7af2b0dc54bab23263a2acae3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add two more InstanceIdentifierContext conversions

We have two more callers which can we easily migrated, do that.

JIRA: NETCONF-818
Change-Id: I8aa8563de7cd82300abb026cfd706257e55a1efb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not propagate mountpoint in RestconfImpl.getModules()

The mount point reference is ignored, just do not propagate it.

JIRA: NETCONF-818
Change-Id: Ibdd27795725357c41b19cd942a4f701aab3f88ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Peel DataSchemaNode-only users of InstanceIdentifierContext

A number of callers are not providing a YangInstanceIdentifier, peel
them off into a separate instantiation method.

JIRA: NETCONF-818
Change-Id: Ic92cbc469d66e3e8ad957bde73c2f858b0daa8f2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Peel bierman02 local RPC test invocations

We have a few callers dealing with RPCs. Peel them to a new factory
method. Also fixes and enables a previously-disabled test.

JIRA: NETCONF-818
Change-Id: I888069dee94307003905bfa615b03ecccc202c11
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify RestconfImplTest mocking

Mocking here is ... interesting. Simplify to base interfaces.

JIRA: NETCONF-818
Change-Id: I6cf6be6f53a7085019798e048dc202adb79bdf7c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate DataNormalizationOperation with SchemaInferenceStack

This is a backport of changes made for YANGTOOLS-1412, adjusted to the
legacy code in bierman02. These will allow us to use a proper inference.

JIRA: NETCONF-818
Change-Id: Ia3234443e26ff985b823e92d942262dfdeeef29e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix Stackoverflow in sal-rest-docgen

Add escaping of chars which underlying library
consider as special characters (and we do not).

JIRA: NETCONF-713
Change-Id: Ife63c31cd9c4912a74db10562b9f927623bc4695
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>

Improve DataNormalizer performance

We are using ImmutableList.Builder and build() at each step to pass
arguments down to checkArgument(). That's wasteful, let's rather pay
the cost of a single ImmutableList.copyOf() -- which breaks even at
three path arguments.

Change-Id: I586761f5e8f8e39f1be3c85bc5e9181c1681e6fd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix DataNormalizationOperation with nested choices

This is a port of YANGTOOLS-1411 to the legacy codebase.

Change-Id: Iff3ac515f4bd763c1c7b7905508fca3b5dc277c7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not shuffle PathArguments needlessly

There is no point in creating a separate collection if we are not
doing anything with it.

Change-Id: I3199c7232c63464b315eff8f69aac98181946ebd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix notification serialization with odl-leaf-nodes-only

Rather than attempting to roll a SchemaPath from PathArguments, use the
provided tool to perform that function -- in a centralized manner.

Add tests to cover serialization of augmentation and choice nodes.

JIRA: NETCONF-848
Change-Id: I9f6dffd9532bd3d52021bbac58473c3cf3b58937
Signed-off-by: Peter Puškár <ppuskar@frinx.io>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Consider RPC/Actions terminal nodes

Our treatment of RPCs and Actions is rather funky, disregarding
namespaces and not stopping intepretation when we bind a request path
step to one of them. Such request URIs are strictly illegal, so reject
them and clean up internal structure to not go off into unexplained
states.

JIRA: NETCONF-866
Change-Id: Iae23db7e48b21309757fbaa1ad0dea627e6ea533
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Separate out more constructor callers

We have four call sites which create a new InstanceIdentifierContext
with equal state, but with a concatenated YangInstanceIdentifier.

Centralize that concat operation, which will makes things easier down
the line.

JIRA: NETCONF-818
Change-Id: I2d0da91756cd9ebf451343454f20485d0d8b0978
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove use of DOMRpcRouter.create()

We should be using plain constructor, migrate away.

Change-Id: Idef7be1ba633c2d54e5f7f0a62e7e3996edf0813
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch use of RpcDefintion.getOutput().getPath()

This does not solve much, but reduces clutter a bit.

JIRA: NETCONF-818
Change-Id: I2028703449459f1fac7ee8774dd26125420b7308
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Revert "Replace #getPath in processInstanceIdentifierType""

This reverts commit 91ca58fe53758c0909f3e2ebea9c206768348410,
reinstating 445e898b86ffe443776037e0fc769ddce3d19f58.

Change-Id: I656a50b3f1d38511ebb432f294611f0a788820c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate public InstanceIdentifierContext

We need to reign in semantics of what different combinations of callers
we have and what are they trying to achieve. Deprecate the public
constructor and expose static methods to create instances with
appropriate shape.

JIRA: NETCONF-818
Change-Id: I452e92cd5e7f46bccb9b00799894aa7ee375cc48
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make InstanceIdentifierContext final

In order to deal with SchemaNode.getPath() going away, we have to keep
a very good handle on InstanceIdentifierContext and what the actual
possibilities are. As a first step, make it final and do not allow it to
be mocked.

JIRA: NETCONF-818
Change-Id: I1666e28c3d1801943f623d80a934079d5ff08b51
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Build Absolute schema node identifier along with YangInstanceIdentifier

The nested notification transformation algorithm is rather lacking -- it
does not really deal with anything but 'container' and 'list'. This
makes it borderline-trivial to eliminate the use of SchemaNode.getPath()
by keeping a List<QName> which is a companion to
YangInstanceIdentifierBuilder.

JIRA: NETCONF-817
Change-Id: I95290d7399ae1d729bb68e76e3bf902a930add4f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move SchemaNodeIdentifier construction

We allocate the Absolute identifier in the context where we should
have equivalent information. Also clean up field names a make proper
assertions on element type.

JIRA: NETCONF-817
Change-Id: I70fe78c079d50eaa73e1038d001c3c6abb8a0ecc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rework NetconfMessageTransformer.toNotification()

The logic here is quite convoluted, separate out the individual
concern, which makes is easy to see we need getPath() only for nested
notifications. For those we are already creating a
YangInstanceIdentifier, hence adding the proper path should be a breeze.

JIRA: NETCONF-817
Change-Id: Iea59a24d485f138064063dc92e2862dbd21a69b1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove a superfluous groupId declaration

We are inheriting groupId from parent, remove the declaration.

Change-Id: I1264e314cb47855331f0add3f2f12b57bc92600d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

AbstractNotificationsData.writeNormalizedNode() should take inference

We have pretty much all the moving bits ready here, require callers to
provide the correct context. Also ditches some amount of SchemePath
wrangling.

Change-Id: I18a8366cffb9c4f45434ee505f767ad38d799f0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded warning suppressions

Baselines have lost some generic arguments, leading to cleaner code.
Eclipse is pointing out some superfluous suppressions -- remove them.

Change-Id: Ide247a3f88f0ae866794b22a7ab81fc5e81fe66c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

InstanceIdentifierContext does not take generics

The generic attribute here is completely useless and only has the
function of tying EffectiveModelContext to being a SchemaNode -- nothing
else. Remove the argument and adjust callers.

Change-Id: Ic70482786ad1141bb20123ecca2f25c40e83eaf8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not reference SchemaNode.getPath() for operation results

The request is either an RPC or an action. We have the path for the
latter readily-available and construct it for the former. Update the
dispatch and clean up the source code a bit as well.

JIRA: NETCONF-817
Change-Id: Ie4e273e0eb499498c0d6b833fb11e4ca115ca989
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rework action indexing

Rather than relying on SchemaNode.getPath(), maintain a stack of QNames
representing the SchemaNodeIdentifier path.

JIRA: NETCONF-817
Change-Id: I8f224bb2c319a6f47e74b3590205c300e93031a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Remove SchemaNode#getPath usage from RestconfImplTest"

This reverts commit b962a56278c0d0ad060cfbd02387821a878ee98f. The
proposed transformation is not valid.

Change-Id: I82be944a90cfef738a41efd86dbed0a936c5999e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit da2fd498afd99d94002f76681fe00b09f98f1583)

Revert "Replace #getPath in processInstanceIdentifierType"

This reverts commit 445e898b86ffe443776037e0fc769ddce3d19f58. The
proposed transformation is not valid.

Change-Id: I6479f27151191c2211682bcea8253b0439e9103e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 349b7feaaf62630e9221017d72d65d369072a8d7)

Revert "Remove SchemaNode#getPath usage from JsonNormalizedNodeBodyReader"

This reverts commit ec6ea24581c692b474fafe17fb27259dbe94026d. The
proposed transformation is not valid.

Change-Id: I291ff37a932cd074fb4a2467fbaa37748bf64fb6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit dc2ca9d4e73d6b110d6cb4a00051e1b03b95fc82)

Revert "Remove SchemaNode#getPath from JSON reader in rfc8040"

This reverts commit d3403542792afb6f6a6525a088b27163236070f2. The
proposed transformation is not valid.

Change-Id: I73453f4f196fc64919f08b165b382a2df69d3a5e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5cb901dc8be360d836abee8f8a222a981689e2f2)

Revert "Remove SchemaNode#getPath from XML writer in rfc8040"

This reverts commit d21d2fe3c6e1784e6ec407b86c6eac75ba3bba66. The
proposed transformation is not valid.

Change-Id: Ib5798243764106e2ce270fa995d1abfc0ef4499b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9c6d80b35d29969d989b2173120bde2daae56568)

Revert "Remove SchemaNode#getPath from XML writer test in rfc8040"

This reverts commit ed024cc0db69c3f026f5e109af680e162a484572. The
proposed transformation is not valid.

Change-Id: Ia56b7cd18d940d418b2f52f280b4545811dde8cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 3d20b6b9e8a69584859acae0c6ef92e888596e99)

Revert "Remove SchemaNode#getPath usage from JsonPatchBodyReader"

This reverts commit ca56779056f1e1c4edb89e689b07a88105421cae. The
assumptsions being made are just not correct.

Change-Id: I720bffc847713198d3016be4f17d896fb9ba815b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Remove SchemaNode#getPath usage from ListenerAdapter"

This reverts commit 98ff16cef35edce6fe6f53fe4023a2d24edbee1b. The
assumptsions being made are just not correct.

Change-Id: Ia7d4f7b9ce1340025820de8023b53b350f9a6c79
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Remove SchemaNode#getPath from JSON writer in rfc8040"

This reverts commit 5534751c2768eb8c866f1278e5647639ae5bff81. The
assumptsions being made are just not correct.

Change-Id: I2dcbda5e7e1b03a6c1cc24b6117a4a138e39c20e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Remove SchemaNode#getPath usage from XmlToPatchBodyReader"

This reverts commit ccf915302c1183a9963c5165f525ee762188126a. The
assumptsions being made are just not correct.

Change-Id: I006eef6c4174b6de91383c607b291e669c7bde1e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Remove SchemaNode#getPath usage from XmlPatchBodyReader"

This reverts commit 4be37ba18758aa2f52cadec3166a6477605b8303. The
assumptsions being made are just not correct.

Change-Id: I3f654e87bc6b82393baece2caaef33d46e563264
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Remove SchemaNode#getPath usage from JsonToPatchBodyReader"

This reverts commit b395c683332c037acec4eecde1b079811ab5d2a3. The
assumptsions being made are just not correct.

Change-Id: Ic7abe61c7b74383f9f8891ac0acdb281188f8b6c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Remove SchemaNode#getPath usage from RestconfDocumentedExceptionMapper"

This reverts commit 0f99f8d6a6aaa6db06a50e123f1395b5a9254638. The
assumptsions being made are just not correct.

Change-Id: I2eea7580fde537c701bb2773da1dcc2783aa1296
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Remove SchemaNode#getPath from NormalizedNodeJsonBodyWriter"

This reverts commit ea9227ab54fe59853e13e0e5833fe6c0795cb87e. The
assumptsions being made are just not correct.

Change-Id: Ie50e8054df0f3b52bc07047dfb565a05fe4a1a60
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Remove SchemaNode#getPath from NormalizedNodeXmlBodyWriter"

This reverts commit c77a96371f41f180bf4e2f0eb030d847b54ef2cf. The
assumptsions being made are just not correct.

Change-Id: I0e96e50f13ab8e407506aae55eb21c9a0f306a4f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Remove SchemaNode#getPath from ControllerContext"

This reverts commit 7815d63f3d34f7a7664a2e551d2bdfdb844b6a95. The
assumptsions being made are just not correct.

Change-Id: I8d45c765f5f24a72ce5f43e511c8f8fb0b4978d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Do not parse YIID to put together a SchemaPath"

This reverts commit b792380644d076274abf500df3a0e1cb1aae1366. This is a
precondition to backing out an invalid patch.

Change-Id: Idb9a49e68d961c0e8c9c0be04286192ae2b9f75d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Fix rfc8040 rpcs not working"

This reverts commit 4bcdbecb30803ed0182d1f096f8bb38f8fe4d3c4. This is
preconditioned on a patch that is being reverted.

Change-Id: Iea09481d3117bf0c4d526e2c2b1c87fa52baa0c3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Eliminate use of SchemaNode.getPath() in TestRestconfUtils"

This reverts commit f2a340f0a8ec957382fb48ab7694d9c20d916a7f. The
assumptsions being made are just not correct.

Change-Id: Ib1a44afa3f344376633bf414b8dfdace724c0d8b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Eliminate use of SchemaNode.getPath() in XML reader"

This reverts commit 2ae92283fd3541479e454b73e64767813e2dbf5b. The
assumptsions being made are just not correct.

Change-Id: Icd5bd52fecd9321ff6ac50865620cc0eee44333a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Eliminate use of SchemaNode.getPath() in YII deserializer"

This reverts commit d8990ef41881d91b816e9a7ed430a3e18bf250e0. The
assumptsions being made are just not correct.

Change-Id: I77d609579882c6fea208cae4fb7fd964cffb18ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Eliminate use of SchemaNode.getPath() in sal-netconf-connector"

This reverts commit 01394e68302417fca3498151bc8e70a652e88d5d. The
assumptsions being made are just not correct.

Change-Id: Ide2fd243c27b4e94869cca369585aceb74478bff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>