netconf.git
5 years agoRemove test dependency on xerces 96/77296/1
Robert Varga [Fri, 26 Oct 2018 09:25:05 +0000 (11:25 +0200)]
Remove test dependency on xerces

The test is mucking into a concrete implementation, use normal
API method to acquire the value for assertion.

Change-Id: I32699f6e37f922ca43d1791d0fa2604dd0aa9412
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit cc20caf752d137f0cfef2cdb3daa9083697b6f42)

5 years agoFix mounting logic in clustered topology 54/77154/5
Jakub Morvay [Thu, 25 Oct 2018 17:28:58 +0000 (19:28 +0200)]
Fix mounting logic in clustered topology

https://git.opendaylight.org/gerrit/#/c/75655/ prepared netconf
southbound plugin to support action statements, but it missed to adjust
clustered netconf topology MasterSalFacade to the changes.

Fix that.

JIRA: NETCONF-575
Change-Id: I0b2fa9258cf362d1227f62127c2c3b44126677f3
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
5 years agoFix callhome start problem 27/77227/2
Luis Gomez [Tue, 23 Oct 2018 18:10:08 +0000 (11:10 -0700)]
Fix callhome start problem

Make sure we align bootstrap class with the service factory.

Change-Id: I84baad3d7ab816ec67f50c8445c38e7f2433eae4
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoBump to odlparent 3.1.4 and yangtools 2.0.12 58/76858/6
Stephen Kitt [Thu, 11 Oct 2018 09:49:43 +0000 (11:49 +0200)]
Bump to odlparent 3.1.4 and yangtools 2.0.12

Change-Id: Iecbabe3e9a975b6d1e394d09179c4340f9993709
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRelease the buffer only after we are done with it 83/77083/1
Robert Varga [Thu, 18 Oct 2018 15:25:55 +0000 (17:25 +0200)]
Release the buffer only after we are done with it

We may end up touching the buffer after we have release()'d it,
which means it may have been recycled by the time we call
resetReaderIndex().

Move the release() call to after the check so we do not end up
releasing it prematurely.

Change-Id: I43156dbe2e6c53a552a322e7b5ea27f8da3873c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix Fluorine docs version 84/76884/1
Lorand Jakab [Thu, 11 Oct 2018 15:08:56 +0000 (17:08 +0200)]
Fix Fluorine docs version

Change-Id: I51919b420a9f1b5145d53baf1e2e787b3483b397
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
5 years agoMerge "Remove use of ThreadPools in sal-netconf-connector" into stable/fluorine
Jakub Morvay [Tue, 2 Oct 2018 07:43:16 +0000 (07:43 +0000)]
Merge "Remove use of ThreadPools in sal-netconf-connector" into stable/fluorine

5 years agoMerge changes I629c0bbd,Ia47c3163 into stable/fluorine
Jakub Morvay [Tue, 2 Oct 2018 07:43:05 +0000 (07:43 +0000)]
Merge changes I629c0bbd,Ia47c3163 into stable/fluorine

* changes:
  Use a dedicated no-op listener class
  Do not retain the list of RPCs

5 years agoRemove use of ThreadPools in sal-netconf-connector 54/76554/2
Robert Varga [Mon, 1 Oct 2018 16:20:15 +0000 (18:20 +0200)]
Remove use of ThreadPools in sal-netconf-connector

We really just need a {Listening,Scheduled}ExecutorService, nothing
else. Propagating this outwords from NetconfDevice(Builder), eliminates
the need for per-session ListeningDecorator and proxies, saving us
at least 56 bytes for each connected device.

Change-Id: Ide69bd1a8f36eca1473313e3fd2cafb76d754464
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ec116112a7ac49a718ca81a21484201dbfa1c836)

5 years agoAbstractEdit: improve error message on missing schema node 82/75382/2
Marek Gradzki [Tue, 21 Aug 2018 13:47:45 +0000 (15:47 +0200)]
AbstractEdit: improve error message on missing schema node

Include node name in the error message.

Change-Id: Ife8f95cb333e2e1065c2c27d51acb406710cc375
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
(cherry picked from commit 16996157a9a6f0360b11f1caeb91dbde855360c5)

5 years agoUse a dedicated no-op listener class 48/76548/1
Robert Varga [Mon, 1 Oct 2018 16:50:17 +0000 (18:50 +0200)]
Use a dedicated no-op listener class

This saves a few bytes per session by not retaining anything
but the listener implementation.

Change-Id: I629c0bbd686ec734f36d8e8d307df3f1f733fa1c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit cf5c624854874f3603b20d296233485b37b99abd)

5 years agoDo not retain the list of RPCs 47/76547/2
Robert Varga [Mon, 1 Oct 2018 16:45:43 +0000 (18:45 +0200)]
Do not retain the list of RPCs

These RPCs are only used when a listener registers, there is simply
no point to retain them in a transformed collection. We can always
re-create them as needed from the SchemaContext.

Change-Id: Ia47c3163bff5232d079f8768420bfa6360fe3b49
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 354472dc8d3afa557522c8ea18634b11b4bea20b)

5 years agoCleanup SimulatedCreateSubscription 34/76534/1
Robert Varga [Thu, 27 Sep 2018 12:04:11 +0000 (14:04 +0200)]
Cleanup SimulatedCreateSubscription

Using .get().get() twice is ugly, create a local variable.

Change-Id: I0c18c9138146c349c4c1c4003b5c53439893354e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit a4ac79f5adaceb503100ba3bb0a45edf7e2cc363)

5 years agoMerge "Fix config-only thinko" into stable/fluorine
Tom Pantelis [Wed, 26 Sep 2018 11:59:50 +0000 (11:59 +0000)]
Merge "Fix config-only thinko" into stable/fluorine

5 years agoMerge "Allow SshProxyServer to share AsynchronousChannelGroup" into stable/fluorine
Jakub Morvay [Wed, 26 Sep 2018 11:54:45 +0000 (11:54 +0000)]
Merge "Allow SshProxyServer to share AsynchronousChannelGroup" into stable/fluorine

5 years agoHonor EXI flag in testtool 55/76455/1
Robert Varga [Wed, 26 Sep 2018 09:47:19 +0000 (11:47 +0200)]
Honor EXI flag in testtool

NETCONF test tool should honor the exi flag and translate it to
proper capabilities.

Change-Id: I50acf9188eb5fd2aea60d593dfd9713e54badda4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoAllow SshProxyServer to share AsynchronousChannelGroup 53/76453/1
Robert Varga [Tue, 25 Sep 2018 17:51:33 +0000 (19:51 +0200)]
Allow SshProxyServer to share AsynchronousChannelGroup

For testing purposes it is good to have the ability to share a single
thread group, as ach of them implies a dedicated thread. This patch
exposes an alternative constructor and allows multiple SshProxyServers
to share that group -- lowering resources needed significantly, both
in terms of threads, memory and file descriptors used.

Change-Id: I237ab0790e9a70c26288a116c59f5a541f236a74
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix config-only thinko 51/76451/1
Robert Varga [Tue, 25 Sep 2018 13:07:24 +0000 (15:07 +0200)]
Fix config-only thinko

This fixes JSON template thinko, so that the variable matches
XML.

Change-Id: Ief03b46dc61a0be733a4f139837d19c8c981da7f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoBump yangtools-2.0.11 42/76142/2
Robert Varga [Mon, 17 Sep 2018 09:06:27 +0000 (11:06 +0200)]
Bump yangtools-2.0.11

This brinsg in the latest fixes.

Change-Id: I39bb25417e4331d32db8985901083cadb38f3a8e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMigrate netconf docs to project repo 90/76190/1
Thanh Ha [Mon, 17 Sep 2018 16:41:56 +0000 (12:41 -0400)]
Migrate netconf docs to project repo

Issue: DOCS-69
Change-Id: I2941d5aa1ea90ee99c9ffe9269b118ea70648fcb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoBootstrap netconf documentation 89/76189/1
Thanh Ha [Mon, 17 Sep 2018 16:38:37 +0000 (12:38 -0400)]
Bootstrap netconf documentation

Issue: DOCS-69
Change-Id: I131c540aca45c6ad742565193801204227554d43
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix missing support of actions in KeepaliveSalFacade 04/75804/1
Jakub Tóth [Thu, 6 Sep 2018 09:23:38 +0000 (11:23 +0200)]
Fix missing support of actions in KeepaliveSalFacade

Change-Id: I1696a92d699debbd5d97219769f9beabc6ef8624
Signed-off-by: Jakub Tóth <jakub.toth@pantheon.tech>
5 years agoPrepare netconf to support YANG 1.1 actions 55/75655/1
Jakub Tóth [Mon, 6 Aug 2018 14:11:29 +0000 (16:11 +0200)]
Prepare netconf to support YANG 1.1 actions

This allows implementation of a factory for creating of DOMActionService
of a connected device. This service is going to be part of services provided
by the device's mountpoint.

Change-Id: I1c79b4bc8f1b1c63f7ffb2306f07ea9872f15882
Signed-off-by: Jakub Tóth <jakub.toth@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit fc71e17ca46e029ad6535613498842ff2854868d)

5 years agoDo not instantiate NormalizedNodes for filter 26/75526/3
Robert Varga [Mon, 27 Aug 2018 10:43:27 +0000 (12:43 +0200)]
Do not instantiate NormalizedNodes for filter

Using ImmutableNodes.fromInstanceId() does not work for leaf nodes,
as we do not have a value, which violates LeafNode contract -- leading
to an IllegalStateException when a user attempts to read() a single
leaf via a transaction.

As it turns out, this is completely unnecessary, as all we are doing
is iterating through the temporary NormalizedNode and creating
NormalizedNodeStreamWriter events based on that.

This patch replicates ImmutableNodes.fromInstanceId() logic, but
simplifies it for this particular task, short-cutting NormalizedNode
creation and emitting events directly as we are iterating over
the YangInstanceIdentifier.

JIRA: NETCONF-563
Change-Id: I0781e81d812ee979deaafb9dfa811e143866f4af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 1c545b9883f64305983a9c0ef73acdaa97866cc7)

5 years agoBump versions by x.y.(z+1) 84/75584/1
jenkins-releng [Thu, 30 Aug 2018 16:51:20 +0000 (16:51 +0000)]
Bump versions by x.y.(z+1)

Change-Id: I30584a64ca197d765c2a2c28dd31f74529850cef
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
5 years agoUpdate .gitreview to stable/fluorine 77/74977/1
Anil Belur [Thu, 9 Aug 2018 12:12:25 +0000 (17:42 +0530)]
Update .gitreview to stable/fluorine

Change-Id: Ia5f20a21419c93881462945c04dac63fa3101474
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoBump yangtools to 2.0.10 81/74881/1
Robert Varga [Mon, 6 Aug 2018 15:45:12 +0000 (17:45 +0200)]
Bump yangtools to 2.0.10

This fixes an issue with actions, hence we need it in Fluorine.

Change-Id: Ic6b2c3e7f118512f04bce3d223b480e2ab784098
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMerge "NECONF-524 : Setting the netconf keepalive logic to be more proactive."
Jakub Morvay [Mon, 6 Aug 2018 14:50:23 +0000 (14:50 +0000)]
Merge "NECONF-524 : Setting the netconf keepalive logic to be more proactive."

5 years agoMerge "Improve error message on <validate> failure"
Jakub Morvay [Mon, 6 Aug 2018 08:01:19 +0000 (08:01 +0000)]
Merge "Improve error message on <validate> failure"

5 years agoUse Controller's MappingCheckedFuture 28/74828/3
Robert Varga [Sat, 4 Aug 2018 01:14:22 +0000 (03:14 +0200)]
Use Controller's MappingCheckedFuture

This class is being moved from mdsal to controller, adjust for that.

Change-Id: I0b680405789a8bc230cfac54f8cf23ecde768494
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoBump exificient to 1.0.1 20/74820/6
Robert Varga [Fri, 3 Aug 2018 22:35:19 +0000 (00:35 +0200)]
Bump exificient to 1.0.1

https://github.com/EXIficient/exificient/compare/exificient-0.9.7...exificient-1.0.0
https://github.com/EXIficient/exificient/compare/exificient-1.0.0...exificient-1.0.1
https://github.com/EXIficient/exificient-core/compare/exificient-core-0.9.7...exificient-core-1.0.0
https://github.com/EXIficient/exificient-core/compare/exificient-core-1.0.0...exificient-core-1.0.1

Change-Id: Id811993f3232f6e96dd4c3c4da95c86db9038c24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove unneeded version declaration 19/74819/1
Robert Varga [Fri, 3 Aug 2018 22:34:02 +0000 (00:34 +0200)]
Remove unneeded version declaration

We are getting aaa versions from dependencyManagement, do not repeat
them again.

Change-Id: I860d63075e5fb004518c1c5955cb96d88f24cc55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoImprove error message on <validate> failure 96/74796/2
Marek Gradzki [Fri, 3 Aug 2018 12:28:56 +0000 (14:28 +0200)]
Improve error message on <validate> failure

Change-Id: I1af1c918c0a21645380ce3ce55c608729365f140
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoBump yangtools to 2.0.9 74/74574/2
Robert Varga [Fri, 27 Jul 2018 12:09:39 +0000 (14:09 +0200)]
Bump yangtools to 2.0.9

This patch bumps yangtools to latest release.

Change-Id: I9b170a51f632a9ef059cdfd3a434c909d46d1cb2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoNETCONF-551 : Invalid CSS URI in apidocs explorer 90/74590/1
Richard Kosegi [Fri, 27 Jul 2018 16:02:27 +0000 (18:02 +0200)]
NETCONF-551 : Invalid CSS URI in apidocs explorer

Change-Id: Iaabea829d3fa03be019075045ee86bdd233ed066
Signed-off-by: Richard Kosegi <richard.kosegi@gmail.com>
5 years agoMerge "Simplify code using Java 8 features"
Jakub Morvay [Fri, 27 Jul 2018 14:27:16 +0000 (14:27 +0000)]
Merge "Simplify code using Java 8 features"

5 years agoSimplify code using Java 8 features 86/74486/3
Stephen Kitt [Thu, 26 Jul 2018 08:35:02 +0000 (10:35 +0200)]
Simplify code using Java 8 features

* method references
* lambda expressions
* Map::computeIfAbsent

Change-Id: Icbfa5c0a76b5b6f2b4339dbbd49b8a44e7b14fb2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoBump to odlparent 3.1.3 00/74200/2
Stephen Kitt [Wed, 18 Jul 2018 16:06:41 +0000 (18:06 +0200)]
Bump to odlparent 3.1.3

Change-Id: I8e2d3a5dd33195daaf2884e2093a5720fd31a7f1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoMerge "Remove unused exceptions"
Jakub Morvay [Wed, 25 Jul 2018 10:35:45 +0000 (10:35 +0000)]
Merge "Remove unused exceptions"

5 years agoMerge "Remove netconf-it"
Jakub Morvay [Wed, 25 Jul 2018 10:35:34 +0000 (10:35 +0000)]
Merge "Remove netconf-it"

5 years agoMerge "Use moved BindingReflections"
Tom Pantelis [Tue, 24 Jul 2018 17:01:12 +0000 (17:01 +0000)]
Merge "Use moved BindingReflections"

5 years agoRemove netconf-it 09/74409/1
Robert Varga [Tue, 24 Jul 2018 16:43:12 +0000 (18:43 +0200)]
Remove netconf-it

This does not build and we are not using it. Remove it.

Change-Id: I2827d1b430036d2c41f44827cba0b66b0ad3ba7b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove unused exceptions 96/74396/3
Stephen Kitt [Tue, 24 Jul 2018 13:10:43 +0000 (15:10 +0200)]
Remove unused exceptions

This drops exception declarations which are never used. If nothing
else, it allows simplifying declarations in upstream projects too.

Change-Id: I692a50ebb43e76c15a3a57ad88138be53184ce7b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoUse moved BindingReflections 87/74387/1
Robert Varga [Tue, 24 Jul 2018 11:10:07 +0000 (13:10 +0200)]
Use moved BindingReflections

BindingReflections are being evacuated from yang-binding, use them
from their new location.

Change-Id: Icb0a53635dee002f14ed9ddfe779fde198db8fc8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoUse minimal ietf-topology 21/74221/2
Robert Varga [Thu, 19 Jul 2018 08:33:02 +0000 (10:33 +0200)]
Use minimal ietf-topology

We do not need the examples, just the baseline topology.

Change-Id: I7f19c8fc5a6b20d2b8cc7c659edf4dea305756da
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoUse union's stringValue() 12/74212/4
Robert Varga [Wed, 18 Jul 2018 17:10:19 +0000 (19:10 +0200)]
Use union's stringValue()

With the union codegen improvement we can use stringValue() to
directly bind to generated code.

JIRA: MDSAL-364
Change-Id: Ic210e2a86831ddc5b78601928cc02ac8e32cbbe5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove use of powermock 84/74184/2
Robert Varga [Wed, 18 Jul 2018 11:11:39 +0000 (13:11 +0200)]
Remove use of powermock

Rather than mocking a static method setup the class properly.

Change-Id: Idfd4c0c655c708f5c0e8c83287051b77a4544774
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoodl-restconf-base should import odl-mdsal-model feature 88/74088/1
Robert Varga [Mon, 16 Jul 2018 20:56:46 +0000 (22:56 +0200)]
odl-restconf-base should import odl-mdsal-model feature

Rather than re-packaging restconf here, use upstream feature.

Change-Id: I9c0b8789ef4b166f0b056193a5156871d888156f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoDepend on yanglib feature 84/74084/2
Robert Varga [Mon, 16 Jul 2018 20:08:59 +0000 (22:08 +0200)]
Depend on yanglib feature

yanglib is package upstream, use that packaging.

Change-Id: I260e9e213b964da7c839bc7ce904073cb5066af2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoodl-netconf-connector needs only clemm-ietf-topology 87/74087/1
Robert Varga [Mon, 16 Jul 2018 20:42:32 +0000 (22:42 +0200)]
odl-netconf-connector needs only clemm-ietf-topology

We do not need all mdsal models, only the topology model, express
that in a minimal dependency.

Change-Id: I30125a6b3f9e5be48948ddcd15fddf382ff7c145
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoodl-restconf-common requires ietf-yang-library only 86/74086/1
Robert Varga [Mon, 16 Jul 2018 20:46:50 +0000 (22:46 +0200)]
odl-restconf-common requires ietf-yang-library only

Rather than depending on all models, pull it the bare minium
required so we can speed up startup.

Change-Id: I490343232ffd48c8112719a6008f44ce6ca162f7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoDo not package jars multiple times 83/74083/1
Robert Varga [Mon, 16 Jul 2018 18:46:54 +0000 (20:46 +0200)]
Do not package jars multiple times

odl-restconf-nb-rfc8040 has a dependency on netconf-api, use
odl-netconf-api to resolve that (and other) dependencies.

Change-Id: If9fe9600f13838af229c7f5f7c2587e0d863fa22
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoUse ConcurrentDataBrokerTestCustomizer in UTs 86/73486/6
Tom Pantelis [Mon, 25 Jun 2018 03:37:10 +0000 (23:37 -0400)]
Use ConcurrentDataBrokerTestCustomizer in UTs

... to do the DataBroker wiring.

Change-Id: I32060a8d17343a6b3818cab3ec9caf03e7f0bb09
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
5 years agoUse DOMExtensibleService.getExtensions() 40/73940/7
Robert Varga [Wed, 11 Jul 2018 13:44:37 +0000 (15:44 +0200)]
Use DOMExtensibleService.getExtensions()

getExtensions() provides a better return value, so we can arrive
at individual extensions in a type-safe manner.

Change-Id: If52c0d9c5a05a70953fd17e27c3f2af155fcb3ee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMerge "Remove netconf-node-inventory"
Jakub Morvay [Thu, 12 Jul 2018 08:24:47 +0000 (08:24 +0000)]
Merge "Remove netconf-node-inventory"

5 years agoMerge "Add explicit getExtensions()"
Jakub Morvay [Thu, 12 Jul 2018 08:14:31 +0000 (08:14 +0000)]
Merge "Add explicit getExtensions()"

5 years agoMerge changes from topic 'no-chararray'
Jakub Morvay [Thu, 12 Jul 2018 08:12:59 +0000 (08:12 +0000)]
Merge changes from topic 'no-chararray'

* changes:
  Rely in ietf-inet-util to convert IpAddress to string
  Do not rely on union char[] values

5 years agoAdd explicit getExtensions() 60/73960/1
Robert Varga [Wed, 11 Jul 2018 22:23:11 +0000 (00:23 +0200)]
Add explicit getExtensions()

getExtensions() will become a mandatory method, make sure we are
ready for that.

Change-Id: Idca41be7d2a14c836345ea5d4b77857f6bbeca76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove netconf-node-inventory 47/73947/5
Robert Varga [Wed, 11 Jul 2018 15:43:29 +0000 (17:43 +0200)]
Remove netconf-node-inventory

This model is not used anywhere, remove it and simplify RemoteDeviceId
so that it is purely topology-based.

Change-Id: Ia4d6738ceab8c1ed9864dd0f6277ea462377e584
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRely in ietf-inet-util to convert IpAddress to string 53/73953/2
Robert Varga [Wed, 11 Jul 2018 18:48:42 +0000 (20:48 +0200)]
Rely in ietf-inet-util to convert IpAddress to string

Union-based getValue() is char[]-based for JMX, do not use it.

Change-Id: I67f913e01ee06e26714eaf6554ec2623391cf1b8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoDo not rely on union char[] values 52/73952/2
Robert Varga [Wed, 11 Jul 2018 18:47:21 +0000 (20:47 +0200)]
Do not rely on union char[] values

This removes the dependency on synthetic getValue() and the union
constructor for JMX.

Change-Id: I46eaa2922e8cc83505a3198a9b29561f8ab1b32a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMerge "Remove redundant code constructs"
Jakub Morvay [Wed, 11 Jul 2018 17:30:36 +0000 (17:30 +0000)]
Merge "Remove redundant code constructs"

5 years agoRemove redundant code constructs 23/73923/2
Jakub Morvay [Wed, 11 Jul 2018 10:36:00 +0000 (12:36 +0200)]
Remove redundant code constructs

- Remove redundant type arguments
- Remove redundant type casts

Change-Id: I943060df1f465ff019b62abd5e72bc9ff7bc8ef9
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
5 years agoMigrate sal.core.api.mount.MountProvisionListener users 88/73888/5
Robert Varga [Tue, 10 Jul 2018 18:03:32 +0000 (20:03 +0200)]
Migrate sal.core.api.mount.MountProvisionListener users

DOMMountPointListener is the replacement interface, use it.

Change-Id: I51222f1f2bc133d90dd59a029fe538826dde48c0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoNECONF-524 : Setting the netconf keepalive logic to be more proactive. 85/68285/5
Balaji Varadaraju [Thu, 15 Feb 2018 07:53:20 +0000 (01:53 -0600)]
NECONF-524 : Setting the netconf keepalive logic to be more proactive.

https://jira.opendaylight.org/browse/NETCONF-524

When a NETCONF device loses connection with the controller in exceptional
conditions such as the management interface going down, underlying TCP
connection would not be closed as there will be no fin packet exchange or
reset. At this point NETCONF state will be set as connected until the
underlying OS determines the connection is stale which can happen after
considerable amount of time. This fix makes the Keepalive packets more
proactive to determine such conditions.This fix also sets the listener
properly which is required for this fix as well.

Change-Id: I781469ae7865e949e9f2c55e53240341f0b10bdd
Signed-off-by: Balaji Varadaraju <bvaradar@luminanetworks.com>
5 years agoRemove unneeded check 40/73840/3
Robert Varga [Mon, 9 Jul 2018 10:53:50 +0000 (12:53 +0200)]
Remove unneeded check

The size of the collection is checked before we allocate
the transaction, hence conditional commit does not make sense.

Change-Id: Iada5db72f2fcf51528c8b1791f2b5ae9d7f51c6a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMigrate netconf users of submit() to commit() 39/73839/3
Robert Varga [Mon, 9 Jul 2018 10:52:02 +0000 (12:52 +0200)]
Migrate netconf users of submit() to commit()

This is the next round of conversions, covering most of netconf.

Change-Id: Ic3caa8ed0879ad547940ff09d034adb5d6d6f687
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix warnings in mdsal-netconf-connector 38/73838/1
Robert Varga [Mon, 9 Jul 2018 10:47:09 +0000 (12:47 +0200)]
Fix warnings in mdsal-netconf-connector

- potentially-static methods
- deprecated use of Throwables.propagate()
- raw use of NormalizedNode

Change-Id: I06bc1f56c90d7c4fddce262ef2c63eec72492274
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoAdd serialVersionUIDs 37/73837/1
Robert Varga [Mon, 9 Jul 2018 10:42:41 +0000 (12:42 +0200)]
Add serialVersionUIDs

Exceptions are serializable and should therefore define
serialVersionUID. This patch adds backwards-compatible generated
values.

Change-Id: I742e123df5b694b2ec132a6e48a73f3a501dde66
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoEliminate use of SchemaService 58/73758/7
Robert Varga [Wed, 4 Jul 2018 17:06:54 +0000 (19:06 +0200)]
Eliminate use of SchemaService

SchemaService has been deprecated in favor of DOMSchemaService,
migrate to it.

Change-Id: If1b6d3c9d821c6c5bea1476c08a61ed0c320b8ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoConvert users from submit() to commit() 54/73754/6
Robert Varga [Wed, 4 Jul 2018 15:06:27 +0000 (17:06 +0200)]
Convert users from submit() to commit()

This gets rid of CheckedFutures and allows us to use FluentFuture
features.

Change-Id: Ie95bb9ce0d0bb6195f9c6355e644a8563165a953
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMigrate shell components to new APIs 57/73757/3
Robert Varga [Wed, 4 Jul 2018 16:42:42 +0000 (18:42 +0200)]
Migrate shell components to new APIs

Karaf has refactored its shell-related APIs, this patch updates
netconf-console to use them.

Change-Id: I8669c19c874d3e851379301712987ada626ef086
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoEliminate implicit boxing 56/73756/4
Robert Varga [Wed, 4 Jul 2018 15:36:06 +0000 (17:36 +0200)]
Eliminate implicit boxing

There is no need to box values, use Boolean.TRUE/FALSE as needed.

Change-Id: I2a71106d7281f5b22e5d14f893f5a67c913e49f3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove unneeded use of CheckedFuture 48/73748/4
Robert Varga [Wed, 4 Jul 2018 14:32:34 +0000 (16:32 +0200)]
Remove unneeded use of CheckedFuture

These callsites can live with ListenableFuture, so use that to
reduce clutter.

Change-Id: I4bea70e8f62b06cfdc1d7a3dfa5d7552178fa4c4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix ScaleUtil warnings 55/73755/1
Robert Varga [Wed, 4 Jul 2018 15:28:39 +0000 (17:28 +0200)]
Fix ScaleUtil warnings

Callable is a generic type, use it accordingly.

Change-Id: I5f947fc4cce9ef4244684013f5980dde439baf64
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMake methods static 49/73749/4
Robert Varga [Wed, 4 Jul 2018 14:39:21 +0000 (16:39 +0200)]
Make methods static

These methods are private without touching object state,
make them static.

Change-Id: I01d675a02098426917e019fb66761b13cacf3d4a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMigrate to UntypedAbstractActor 51/73751/3
Robert Varga [Wed, 4 Jul 2018 14:40:35 +0000 (16:40 +0200)]
Migrate to UntypedAbstractActor

UntypedActor has been deprecated, migrate to the replacement
bridge UntypedAbstractActor.

Change-Id: Ie4dd16101707a70442bd66bafd4b22190f73d06e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix raw type warnings 50/73750/3
Robert Varga [Wed, 4 Jul 2018 14:39:59 +0000 (16:39 +0200)]
Fix raw type warnings

Using IdentifiableItem as a raw type does not make sense here,
add type qualifiers and ditch the warnings.

Change-Id: Ifcbd41b53f0c5989e6fad9fd35ce66e115996224
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoAdopt netconf-node-inventory 56/73656/2
Robert Varga [Mon, 2 Jul 2018 15:16:56 +0000 (17:16 +0200)]
Adopt netconf-node-inventory

This model used to be hosted in controller, but it really should
be hosted in netconf.

Change-Id: I54a6cd90c8e182ade53cba08fdaa301a64a677d5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoCache topology path 64/73664/2
Robert Varga [Mon, 2 Jul 2018 18:43:55 +0000 (20:43 +0200)]
Cache topology path

Instead of creating base InstanceIdentifier over and over, cache
it in a field.

Change-Id: I54d1bb7555a94fc20c5cf406f6f6f6dd69d7fc5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix netconf-node-topology 60/73660/2
Robert Varga [Mon, 2 Jul 2018 18:20:40 +0000 (20:20 +0200)]
Fix netconf-node-topology

Topology types augmentation should be a presence container,
fix that.

Change-Id: Iaef6fd18f590767069a91cada2036f9b02ffa167
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoBump ietf-network(-topology) revision 51/73651/1
Robert Varga [Mon, 2 Jul 2018 13:23:59 +0000 (15:23 +0200)]
Bump ietf-network(-topology) revision

This bumps the revision to RFC8345 versions.

Change-Id: I75748b45af4f91294eebe553f631cd0c23897035
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMerge "Guard against multiple web registration attempts"
JakubToth [Sun, 1 Jul 2018 08:03:24 +0000 (08:03 +0000)]
Merge "Guard against multiple web registration attempts"

5 years agoGuard against multiple web registration attempts 88/73488/2
Tom Pantelis [Wed, 27 Jun 2018 16:35:57 +0000 (12:35 -0400)]
Guard against multiple web registration attempts

If both restconf-auth and noath features are installed, both
try to register the web context and PAX web fails and renders
restconf unusable.

JIRA: CONTROLLER-1844

Change-Id: Ie488c792d849616efa806e82121883fe73fb9c6e
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
5 years agoBump to yangtools 2.0.7 52/73452/4
Stephen Kitt [Tue, 26 Jun 2018 16:10:47 +0000 (18:10 +0200)]
Bump to yangtools 2.0.7

Change-Id: Ie48b991bc023cce78a3147371a9a33a627bc8ba1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoRemove duplicate ietf-yang-library models 21/73521/8
Robert Varga [Thu, 28 Jun 2018 09:32:35 +0000 (11:32 +0200)]
Remove duplicate ietf-yang-library models

ietf-yang-library is provided by MD-SAL, along with bridge utilities
to work with that model.

Remove the two versions hosted in netconf and consume the version from
mdsal.

Change-Id: If43f159ebac4fedbb267a85fd9df6d46897a5330
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoCleanup NetconfStateSchemasResolverImpl 23/73523/3
Robert Varga [Thu, 28 Jun 2018 10:51:24 +0000 (12:51 +0200)]
Cleanup NetconfStateSchemasResolverImpl

We are using a constant QName in lookups, use a constant for that.
Also mark a FIXME for netconf-monitoring/yang-library preference.

Change-Id: Ia30ece91868b55e811e734b817ffaa71d86da0a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoBump odlparent to 3.1.2 90/72490/3
Stephen Kitt [Wed, 30 May 2018 13:44:44 +0000 (15:44 +0200)]
Bump odlparent to 3.1.2

Change-Id: Id85c9aa0038633cbec58f747841121fd31067eab
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoReference BindingNormalizedNodeSerializer in MountPointEndToEndTest 88/73388/1
Tom Pantelis [Sun, 24 Jun 2018 21:58:33 +0000 (17:58 -0400)]
Reference BindingNormalizedNodeSerializer in MountPointEndToEndTest

... instead of referencing BindingToNormalizedNodeCodec

Change-Id: Idc4db9f7c35271ec5c458248727b0f3387fa373f
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
5 years agoAdvertise :validate:1.0 capability if DOMDataTransactionValidator is supported 35/73035/1
Marek Gradzki [Fri, 15 Jun 2018 11:54:41 +0000 (13:54 +0200)]
Advertise :validate:1.0 capability if DOMDataTransactionValidator is supported

Change-Id: I193ba007f32114aa1d43375bfdc6772be173db7c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoMerge "Remove CSS yang reference from UT"
Tom Pantelis [Fri, 15 Jun 2018 01:52:32 +0000 (01:52 +0000)]
Merge "Remove CSS yang reference from UT"

5 years agoRemove CSS yang reference from UT 19/73019/1
Tom Pantelis [Fri, 15 Jun 2018 00:59:29 +0000 (20:59 -0400)]
Remove CSS yang reference from UT

CSS is being removed...

Change-Id: I0e7ad682ed0f7ad1dc815af4b35afe7baa57c5bd
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
5 years agoMake RuntimeRpc revision aware 97/72997/1
Marek Gradzki [Wed, 13 Jun 2018 19:12:16 +0000 (21:12 +0200)]
Make RuntimeRpc revision aware

Do not use SchemaContext.findModule(URI),
which looks for a module instance with specified namespace
and no revision.
Such lookup fails for modules with revision defined.

Instead (as already done in AbstractEdit)
use SchemaContext.findModules and take the newest module
if more than one module with the same namespace is found.

Change-Id: I7b6bdcb9156669645e19a6395e1b74995328154d
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
(cherry picked from commit 69c92b2bee54681ebb5c0bfaf89d269877e0b747)

5 years agoRemove AsyncWriteTransaction.submit() impls 82/71582/5
Tom Pantelis [Mon, 30 Apr 2018 14:39:23 +0000 (10:39 -0400)]
Remove AsyncWriteTransaction.submit() impls

The submit() method is now defaulted in the interface
so implementations don't need to implement it.

Change-Id: Ibdb988739df9ea309c2debd9c31dc1b9bf18e83d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
5 years agoRemove unused references to BindingAwareBroker 06/72806/1
Tom Pantelis [Fri, 8 Jun 2018 18:08:30 +0000 (14:08 -0400)]
Remove unused references to BindingAwareBroker

Change-Id: I2a6d5e06f9b357737b37779b7e294731f79ba833
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
5 years agoFix default schema cache failures 75/72775/1
Tom Pantelis [Fri, 8 Jun 2018 02:45:55 +0000 (22:45 -0400)]
Fix default schema cache failures

We've these seen intermittent failures on jenkins:

 Caused by: java.lang.IllegalArgumentException: Unable to create cache directory at cache/schema
     at com.google.common.base.Preconditions.checkArgument(Preconditions.java:210)
     at org.opendaylight.yangtools.yang.model.repo.util.FilesystemSchemaSourceCache.<init>(FilesystemSchemaSourceCache.java:74)
     at org.opendaylight.netconf.topology.AbstractNetconfTopology.<clinit>(AbstractNetconfTopology.java:149)

In FilesystemSchemaSourceCache"

  if (!storageDirectory.exists()) {
      checkArgument(storageDirectory.mkdirs(), "Unable to create cache directory at %s",
              storageDirectory);
  }

mkdirs returns false if the dir/file already exists - this seems the likely reason
in this case even though it checks exists() just prior. This scenario could happen
if there's a race where some other component interleaves and creates the dir in
between the exists and mkdirs calls.

To protect against this sceniario, AbstractNetconfTopology and NetconfTopologyUtils
were changed to retry if FilesystemSchemaSourceCache throws an IAE. Also they no
longer fail class initialization on failure.

Change-Id: I9f7ec134e7fd817aa753f0db175bf5620cc52ff4
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
5 years agoBump yangtools to 2.0.5 59/72359/7
Robert Varga [Mon, 28 May 2018 10:16:53 +0000 (12:16 +0200)]
Bump yangtools to 2.0.5

This includes latest fixes.

Change-Id: Ib91a42e74323a99ce378744114071c7268fec3a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMerge "Convert ProxyDOMDataBroker tx creation to async"
Jakub Morvay [Tue, 5 Jun 2018 15:34:09 +0000 (15:34 +0000)]
Merge "Convert ProxyDOMDataBroker tx creation to async"

5 years agoRemove sal-dom-config dependency 65/72665/2
Tom Pantelis [Mon, 4 Jun 2018 15:13:32 +0000 (11:13 -0400)]
Remove sal-dom-config dependency

It's not needed and is going away.

Change-Id: I2fb0ed7ddca920756a07ba61f900fdff47715e67
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
5 years agoRemove config features from protocol-framework feature 95/72595/4
Tom Pantelis [Sat, 2 Jun 2018 11:20:33 +0000 (07:20 -0400)]
Remove config features from protocol-framework feature

CSS remnants that aren't needed.

Change-Id: I1e510da5c07c0dddfb602a5abbbc46349288f5eb
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>