Bump versions to 1.13.9-SNAPSHOT

This starts the next development iteration.

Change-Id: I5d3112dee4dc8ac5f00e094dca5e936eff60197a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstream versions

Adopt:
- odlparent-8.1.9
- yangtools-6.0.12
- infrautils-1.9.15
- mdsal-7.0.14
- controller-3.0.16
- aaa-0.13.11

Change-Id: I3de6acbf3621f51af29bbb9e4c21eea9f25f0869
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not reuse inactive handler

We have a simple event dispatch handler here, which is stateless and can
be reused, except Netty's defences are rejecting such reuse. Since it is
a very simple object, just do not bother with its reuse.

JIRA: NETCONF-852
Change-Id: I40b48b0a8e14a0a271043bb9fb4b471cfd56a8e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 438ed86b4a3e80cd18f52b40e6faf4260e14d6ac)

Bump versions to 1.13.8-SNAPSHOT

This starts the next development iteration.

Change-Id: Ib1fd2f7ec5f1ffcb4d5eb56f5cb9af19348203df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstream versions

Adopt:
- odlparent-8.1.8
- yangtools-6.0.11
- infrautils-1.9.14
- mdsal-7.0.13
- controller-3.0.15
- aaa-0.13.10

Change-Id: I18e693ff8d1688767c9cca7f93f3b1a417ab52d9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 1.13.7-SNAPSHOT

This starts the next development iteration.

Change-Id: I03e4203404368f59091c80301e73c6274375ee73
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstream versions

Adopt:
- odlparent-8.1.6
- yangtools-6.0.10
- infrautils-1.9.12
- mdsal-7.0.12
- controller-3.0.14
- aaa-0.13.9

Change-Id: I0045e320299b4ce30569977d4ae092a4768a74e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix the showing up mounted devices in apidocs Swagger

Currently all mounted devices show up in the drop down list as
"topology-netconfnode". If there are many mounted devices
there is no way to find the mounted node you are looking for
without clicking on each selection on the list. Fix this to
show up particular node ID instead of "topology-netconfnode".

JIRA: NETCONF-843
Change-Id: Iecbc2e27f66719d2a9a7024ab9813077ff7cfdb3
Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>
(cherry picked from commit b67affb6c2694fffa9f99ca3abc6a657068002c1)

Bump upstream versions

Adopt:
- odlparent-8.1.5
- yangtools-6.0.9
- infrautils-1.9.11
- mdsal-7.0.11
- controller-3.0.13
- aaa-0.13.8

Change-Id: I64fd04bb95749e3d3d726ad5c44f3269ac8309ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor NETCONF node defaults

In fact, the difference between devices connected by call-home and
created manually in NETCONF topology is that call-home devices do
not have any data in configuration data-store.

Configuration data is used during the connection setup.

We can create full default configuration node for call-home connected
device to unify the processing of both kind of devices.

In addition, MDSAL now supports default values in data-store so we
can remove those values from AbstractNetconfTopology.

JIRA: NETCONF-832
Change-Id: Ib58ca344a7d74612cb7d049805a3e3c9279986d4
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2dfc7efb77c6704a0cd397dbd82c2709b14d29ee)

Package jquery internally

We are referencing code.jquery.com, but we can load a minified
version internally. Package jquery-3.6.0.min.js and refer to it.

JIRA: NETCONF-764
Change-Id: Id9abaed8a8bc732066778dad2025ebba5c6a9b0f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 05cc8a3f5839d4138e3ba1f50227c09368385ddb)

Bump sshd to 2.8.0

https://github.com/apache/mina-sshd/blob/master/docs/changes/2.8.0.md

Change-Id: I60f9f5476a07966f69bfbb0842ba785f1362704a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f6348732702a2f262c4626d97b4093cf5f1a82b7)

Do not leak Promises

We want to propagate only a read-only view of the connection process,
return a Future, not a Promise.

Change-Id: Iccfa83a20c3dd2a33ac4871ad58670256a068c66
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 12a453bb73bae5b6583790ebc4f5a7bdc3fb5812)

Upgrade automaton to 1.12-3

Fixed RegExp.toString() and built for Java 11.

Change-Id: I5d02a7cde7811904383cc67a5307a43753744968
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 09c370d3cf0b1eb81312c017bd742dafa029c2e9)

Cleanup ReconnectPromise a bit

ClosedChannelHandler is really a stateless object used by
ReconnectPromise wiring. Acknowledge that fact by removing the class in
favor of a field initialized by an anonoymous inner class.

While we are here, also document locking rules and generally tighten
things up, eliminating a SpotBugs suppression in the process.

Change-Id: I6abc0ddf296dd9e2f5ea6de5a709003cf14edc7a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 82f3e83d6e777a5e76b8b6bca5a8c2646a4b82be)

Rework createReconnectingClient()

We seem to have competing interests going on, where we want some
information from the first connection attempt propagated outwards.

JIRA: NETCONF-784
Change-Id: I232d523b60c36de85fea909c6405b1d7cac39c57
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unused dependency

netconf-util is not using netty-common, ditch that dependency.

Change-Id: I77053e25d6aef62fca78a2b635e1d58c9eb26c9d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 42b3ec4cf9b285c5f1fefd9c9dc8c2cea69aa413)

Bump sshd to 2.7.0

https://github.com/apache/mina-sshd/blob/master/docs/changes/2.7.0.md

JIRA: NETCONF-829
Change-Id: I8ff777f3f8ec97d710e743bb5486b31ec54fe27f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 09c20c1cd62407e13abf3d13490884faef68673c)

Implement NodeContainerProxy.getPath()

getPath() is being used for diagnostics in XML parser, let's implement
it in the obviously-correct way to get some more information.

Also modermize NodeContainerProxyTest and move it netconf-util, so it
is co-located with the class it is testing.

JIRA: NETCONF-828
Change-Id: Idfac9d779366d3465db29dcadc27af51dc16b956
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 1.13.6-SNAPSHOT

This starts the next development iteration.

Change-Id: I2886c3e0c3de95640a0a07e121f676430552b621
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve StreamingContext diagnostics

When we encounter a wrong nested child we end up throwing an opaque
ClassCastException. Add an explicit check to improve diagnostics.

JIRA: NETCONF-820
Change-Id: I3c5a24c1ff4d12a56dfd5fd6d8cd3f940af330a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5ca9d3ee04aa5464f81be533f8b4d9b675e7da96)

Bump MRI upstreams

Adopt following versions:
- odlparent-8.1.4
- infrautils-1.9.10
- yangtools-6.0.8
- mdsal-7.0.8
- controller-3.0.12
- aaa-0.13.7

Change-Id: I60dd18eb02a97a21a69055fe5e13d44dc6d30f0b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use simple concat in createParsingException()

String.format() is wasteful as we can use JEP280 to make things
a lot more performant.

Change-Id: Iab3d462b7133e656d30e50c6a08f58e798fa4b9f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve YangInstanceIdentifierDeserializer.checkValid()

The current implementation is slow due to always playing with arguments,
even when we do not use them. As it turns out, a bit of restructuring
allows us to make this a lot saner and performant.

Change-Id: Ic5de0d473fe203703470252b32e54b2e3c325f5e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce use of StringModuleInstanceIdentifierCodec

JsonPatchBodyReader internally does not really need the entire codec,
just the underlying DataSchemaContextTree.

Change-Id: I6c2bca6609e10eb9f801e1e5ac1aab439eed3b8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 1b62971373c6cd68a86821cb6513c64937a2e10e)

Fix patch target parsing

Our tests were not updated for RFC8040, hence they are written with
weird codecs which utterly do not match RFC8072 definition of
yang-patch.

The problem is that patch edit's target is interpreted in terms of an
extension to the URL, i.e. it does NOT follow JSON nor XML parsing
rules, nor is it anything in-between -- we must use ParserIdentifier's
facilities.

Update the parsers and the test suites, ditching a lot of complexity
in process of doing so.

JIRA: NETCONF-804
Change-Id: If9d9c77e0e2397ffdcb8e8c0f0fef0b9b02bac8b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 845f511527e22741a1cf1053b04250d16bf7f6a0)

Fix XmlPatchBodyReader revision handling

There is a nullness bug around the conversions through string and
calling Revision.of(). Our current interfaces allow us to do better,
with fewer objects.

Change-Id: I68163b7b8766e6063a27d280bae9c049a675ac76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c75fc716f8c60dfdf267d078df66346c95dae7a4)

Lower codec instantiation scope

Do not instantiate codec until we really need it. This also
short-circuits some of the other setup code.

Change-Id: I1b38951699395f18fe961e3c752a8bd8dde5eac5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d6785007a5ed83553aef2b01d8585047e0102671)

Cleanup StringModuleInstanceIdentifierCodec a bit

Compact the implementation a bit by reusing code paths. Also we do not
really allow null defaultPrefix, but check for it being empty.

Make this.defaultPrefix nullable, which allows us to simplify the check
in moduleForPrefix() down to a simple null check.

JIRA: NETCONF-804
Change-Id: Ifa01017613761466a32e371d56b0bb6521145115
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 63eba7f355bacfe2aa1f20112cf2a7f98bd2928c)

Cleanup ObjectCodec a bit

Use a return expression and do not use the useless this.obviously
field references.

Change-Id: I2144d8e855ff56269118df505c43741bb292e282
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 96f7049b19b910561cce75d1b27e950c86dbd5df)

Report bad document on empty body

If we do not get a PatchContext report a 400 bad request instead
of 500 server failure.

JIRA: NETCONF-803
Change-Id: Ic314273cfa6074da16cf0b9182c94641358ccf38
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 3467bab21a5a061fe00e4f5cb9826da4e60d8e53)

Bump versions to 1.13.5-SNAPSHOT

This starts the next development iteration.

Change-Id: I64767325a405d2d718f0511d95350e11edbd212f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

mdsal-7.0.9
controller-3.0.10
aaa-0.13.5

Change-Id: I79f248eeaee7c02ab566b2ce05e11fd905979ce7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Report data-missing when an invalid stream is requested

We should not be throwing a random IAE, but rather use a
RestconfDocumentedException to report the correct status.

JIRA: NETCONF-802
Change-Id: I4ac0a24f0acb059f08d14ab0abd4021e91b0d07b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 587da7df15b8d971bb434a5e96023cb982b09939)

Do not use YIID parser for writing

We are using instance identifier parser in contexts which have
a fixed structure. Use a simple YangInstanceIdentifier factory
instead.

JIRA: NETCONF-726
JIRA: NETCONF-800
Change-Id: Idff625265f5240e8331a7eb289b3098916d10c98
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 4eba0cde9be1d0767679bd365a8de27844c50554)

Close transaction chain on failures

If the transaction fails we end fail to close it. Fix it by using
try-with-resources.

Change-Id: I863c40903c3dba16b661aff1bda6459ba23c0997
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use well-known Status enumeration

Response.status() can be used with an int, but that ends up walking all
Status.values() in an attempt to find the corresponding constant. While
we end up hitting the first element, use Status.OK explicitly to speed
things up a bit.

Change-Id: I7c72a88602c95ec4c7274369a9e5c613c3ce3b9b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit fdf3ba286a9fd8312abf6e4e5547fe8004987d61)

Do not report failure on empty action output

When an action invocation results in an empty container
we should be emitting a normal 204 response, not go through
the error path -- as per RFC8040 section 6.3.

JIRA: NETCONF-799
Change-Id: Ie8f3d098fc65828998b088bfed5ca89e2f438828
Signed-off-by: PeterSuna <Peter.Suna@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 916a6a5cb7e3ac5148f9cf6bb1a24bf7298ea9f6)

Log full exception when we are missing errors

Our current logging does not identify the source of the offending
exception. Make sure we log the entire input exception, so that
offenders may be fixed up.

JIRA: NETCONF-789
Change-Id: I30a24a615ce221a838e1ad95f6b11263e2d6f8f5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8dc035c90ba706efceb66ced5fa51408b4c494f9)

Make ListenersBroker.getInstance() lockless

While this is a huge antipattern in terms of retained global state,
we do not need to bounce a global lock to access it.

Use Initialization-on-demand holder idiom to make the access completely
lockless.

Change-Id: I374737f2dc5b3b07226eb7bbffcaaf2665cc8967
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 27c8ce3272443809c6607e8c5da347c41970f6f1)

Fix checkArgument() use

We do not want to concat the strings here, use a proper formatting
string -- speeding things up.

Change-Id: I0585752e07a4e58abf22d3e0facc93d0623ee198
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit af9355cc26d14fcb1d5c725496d440bfced8c10b)

Fix field count check

This is a simple copy&paste error which slipped past review, fix it up.

Change-Id: Ia381754abc7ec9d3adf53066ab2f8910e5554123
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7c7e349b1e459e67465d42b496b287253256e5da)

Bump versions to 1.13.4-SNAPSHOT

This starts the next development iteration.

Change-Id: Ia5c89be62f3d73d1ade397a2fe39e3da4fcb37af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.1.3
- infrautils-1.9.8
- yangtools-6.0.7
- mdsal-7.0.8
- controller-3.0.9
- aaa-0.13.4

Change-Id: I4ca6c2cbaf9415b53576638d4168f6c3540a9f92
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update RESTCONF error mapping

yang.common.YangError is an attachment used to propagate RFC6020-defined
failure modes enforced by YANG Tools as exceptions. One such example is
YangInvalidValueException, which is reporting YANG constraint
violations.

Recognize these when mapping to RestconfDocumentedException, so that
their error-app-tag and error-message are properly propagated.

JIRA: NETCONF-786
Change-Id: Id6ea1877e03f42fc193942a4e2b83ecb6daeb631
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d09a589e9a4ac5134083cf7c09a8e5370142f3ca)

Fix multiple keys path in RFC8040 swagger

ListPathBuilder for RFC8040 needs to change its state
when processing multiple keys (= to ,) thus we have
to create it before the iteration over all list keys.

JIRA: NETCONF-708
Change-Id: If617ff1508e63b1001ab7857e3b3fdebff287f74
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f17385e68a590b369cec43752af7f5b42943908b)

Handle NetconfDocumentedExceptions correctly

These need to be wrapped in TransactionCommitFailedException
so they are handled correctly, so restconf can map these and
return correct status code on failure.

JIRA: NETCONF-777
Change-Id: Id4833bfe46da6f97a216163452dd2a44af599063
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 6003f0788533a61a3e2a0f16dff94f618379677b)

Reuse MD-SAL transation for existence check

We should not be allocating a new transaction for the existence
check, but rather reuse the existing transaction.

JIRA: NETCONF-781
Change-Id: I8daca2bda91dfe8e99ef3e29686e10276a77387d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable TCP_NODELAY for SSH client/server

Both NETCONF northbound (SshProxyServer) and southbound
(AsyncSshHandler) plugins exhibit latencies caused by Nagle's algorithm.
These are superfluous, as we typically work in request-response manner,
with reasonable level of buffering going on in the intermediate layers.

Set TCP_NODELAY flag to get rid of these artifacts.

JIRA: NETCONF-776
Change-Id: I68a87cc2bef4f0032e104833b8d241f5b1f7566b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 726ee92c6052437074062ffe790743eab58de2af)

Add support for RFC8072 media types

The media type assignments have changed in draft-ietf-netconf-yang-patch-09,
make sure we support the new assignements.

JIRA: NETCONF-780
Change-Id: I00484ccf2536c598bca54207154025006742aea8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch to using SseEventSink

JAX-RS 2.1 has a standard way of working with SSE, do not use
Jersey-specific APIs (except in test).

JIRA: NETCONF-775
Change-Id: I46c2b80be52d2313ab9193361da788f41923c175
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c2baf51aa870d005561658057b0674d66177d813)

Use MediaType.SERVER_SENT_EVENTS

We are using JAX-RS 2.1, hence we have SSE support built-in. Reduce
dependency surface by using MediaType constant instead of Jersey's
Feature.

JIRA: NETCONF-775
Change-Id: I27338775dd3cd92681a4c1f953f71145100f24ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 40ee93670e3e1eba406b2a22cd96de03a0b77dd0)

Improve event fragmentation

Rather than instantiating String objects, use StrinBuilder's ability to
append CharSequence parts.

Change-Id: I1283791c50a9e41fd1703786cbf2aefe71e75484
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7cb9ad91a15a7ff09b3017b39ea27a2a8e6068a6)

Use a simple isEmpty() check

Rather than checking size() == 0, use isEmpty(), which is clearer
and potentially fasterUse a simple isEmpty() check

Rather than checking size() == 0, use isEmpty(), which is clearer
and potentially faster.

Change-Id: I0aadff4a55258f2fbb0bd60c26993b08b3b8e7b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 3ba1f3fea3d6e54d5dd3fd7ad074217d8b1972bb)

Do not use schema-aware builders in RestconfMappingNodeUtil

These builders are going away as they bring little to the table for the
cost they force upon us.

Change-Id: I2359ab28dd6c3632cd0a4f6eeaadf62af517d72d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update RestconfDataServiceImpl stream lifecycle

This is a follow-up patch to cleanup more checkExist() invocations,
which are no longer needed, as the datastore handles container/list
lifecycle.

Change-Id: I8c9ad9b0718a3854af553ea1a20eea1812a8c9f6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 330737a5a8b048bf8306035e25a108065403bea1)

Minimize another set of dependencies

MWe are not exposing the repo as part of running contrary to upstream.
Each to their own.

Change-Id: I301ff878ea7f4a1d01ecefbaf3a39804fee3cf13
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 1.13.3-SNAPSHOT

This starts the next development iteration.

Change-Id: Iad0085c6bf0eed251ead9622c4aee4e56ad926db
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Added full YIID to ietf-restconf-monitoring DS

- Currently local-name of the QName is used as key to the list
  of created streams - that is a bug because local-name doesn't
  have to be unique in scope of one module or whole schema context.
- This fix puts the whole serialized YIID to DS as stream name.

JIRA: NETCONF-726
Change-Id: I28012a478b958b933af993c2ede5f91c2eb8e211
Signed-off-by: Jaroslav Tóth <jtoth@frinx.io>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup datastore interactions

Datastore handles lifecycle of non-semantic portions, hence we do not
need utterly ugly special-cases dealing with container/list
initialization. This removes a chunk of crud, makes things more
type-safe and more straightforward.

Change-Id: I7fe72a0c37cd0a1ef94f2921fb3c66800eccfa26
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Further dependency cleanups

We have two other unused dependencies, remove them as well.

Change-Id: I2870ffd2450ce7783609bf58b1b26209adbde0fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup dependencies a bit

There are a number of unnecessary dependencies we are using, which are
getting flagged by odlparent-9. Clean the most obvious ones, reducing
our footprint.

Change-Id: I0881d82f4928505998254088c4c729057c86bb7d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix infrautils version

We have a misaligned version here, make sure it is 1.9.8, as it should
be.

Change-Id: I677f9f0ad89e61e6664bb239e09a844f970e2c8a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade restconf-nb-rfc8040 to use RFC8525

Ditch the old yang library and just use the new one instead.

JIRA: NETCONF-725
Change-Id: I99c9678146ef58d525dda626087a5e74b0e270e4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use schemaless builders in RestconfMappingNodeUtil

The code here is extremely flaky, relying very much on declared layout
of ietf-yang-library -- which is utterly wrong, as we should be using
effective model.

Schema-aware builders are going away anyway, so just use normal
builders, forgoing all the unneeded complexity.

JIRA: NETCONF-725
Change-Id: I2454a7872341fb2a977463513a5a1a6a3937c8d1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Added doc for fields filtering

- User guide - using fields query parameter to leverage NETCONF
  subtree filtering with selected multiple subtrees.
- Developer guide - tutorial for using:
  a. NetconfDOMDataBrokerFieldsExtension
  b. NetconfDataTreeService with added methods

JIRA: NETCONF-735
Change-Id: I8fed93dc45b626ddc99447f0656e671890ad8f17
Signed-off-by: Jaroslav Tóth <jtoth@frinx.io>

Integration of RESTCONF fields to NETCONF filters

Added:
- NETCONF subtree filtering aware parser (ParserFieldsParameter)
- check if get request is for mountpoint data (ReadDataTransactionUtil)
- new mountpoint fields parameter (WriterParameters)

JIRA: NETCONF-735
Change-Id: I293993958893df866908fa5f16992bf38bd6b085
Signed-off-by: mhurban <mar.hurban@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Jaroslav Tóth <jtoth@frinx.io>

Rework mdsal-netconf-yang-library

The primary intent here is elimination of blueprint, but while we
are at it, we also remove duplicated code and unify the two exporters
into a single class.

JIRA: NETCONF-770
Change-Id: I70bba28b1776001d6c71e367b10d87d59399c13a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge OSGiCredentialServiceAuthProvider

We now have OSGi R7, hence we can safely use constructor injection,
eliminating the need for an extra class.

Change-Id: I41a1bc06d6aec1be89979327e9b530952cd673ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update testtool arguments

1. Remove edit-content argument. Instead of using node config template
in form of file node config will be created, modified by corresponding
Java models and than converted to request body string with GSON.
2. Split auth argument to controller-auth-username,
controller-auth-password. Add default value(admin) for them.
3. Split controller-destination argument to controller-ip,
controller-port.

JIRA: NETCONF-758
Change-Id: Iccf19c9482727b88d3f21a85008d13f554a8da08
Signed-off-by: Illia <illia.ihushev@pantheon.tech>

Add GSON models for device registration

Intention is to use the PATCH method for node registration(no matter if
that's a single node registration or multiple nodes).

JIRA: NETCONF-758
Change-Id: Ia624cfe2f953f6f5dc7a4ebd0d7cfbb0c0185f1a
Signed-off-by: Illia <illia.ihushev@pantheon.tech>

EndToEnd test tool

Added EndToEnd test tool for adding routes to test device using REST.
Part of feature: features-netconf-testing.

Test tool implements endpoint from ncmount.yang, finds device from
provided payload, transforms and sent routes from payload to target device.

Write route processing provides by REST endpoint:
/rests/operations/ncmount:write-routes
with a payload which contains the device name and route.

JIRA: NETCONF-759
Change-Id: Iba141c91a315b3d13d1890b8315dd17bb899cda9
Signed-off-by: Iaroslav <iaroslav.kholiavko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use Optional.isEmpty()

Java 11 introduced Optional.isEmpty(), which allows us to convert
!Optional.isPresent() callsites. Perform this conversion across the
entire repostitory.

Change-Id: I515a550bb6aa56b6d89cea020f5399ca27884833
Signed-off-by: Jaroslav Tóth <jtoth@frinx.io>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use ReadOperations.exists() to check existence

There is no point transferring all the data, just invoke the exists()
operation instead.

Change-Id: I54db6026ee641703196b6a8120245c4e60a60aa2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate javax.inject artifact references

We are using GuicedEE instead of the ancient (and broken) javax.inject
jar. Migrate references.

Change-Id: I262c155b97aefced7a834de3db0efd839cf45fbf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate osgi.core references

OSGi R7's core artifact has been renamed, use that as the dependency.

Change-Id: Idbf50537a9e2f9ea9a486d2bb76f37752caa496e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate JSONRestconfService

This service is type-unsafe and does not have users in OpenDaylight
proper. The contract is actively hurtful as it seeks to steer users
towards opaque blobs, not expressing their service and data
dependencies. Furthermore the implementation structure forces an ugly
interface on the actual RESTCONF services, preventing reasonable
refactors.

Deprecate the service for removal, so that we can get rid of this burden
in the next major release.

Change-Id: I96d3fd86ba773fa8986454d1ac4825723b15152d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.1.2
- infrautils-1.9.8
- yangtools-6.0.6
- mdsal-7.0.7
- controller-3.0.8
- aaa-0.13.3

Change-Id: Ib48792875c6c54a1f328e466a5de47d7d2af8850
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use project.version for all artifact declarations

We have a coordinated version for all artifacts, hence we can use a
simple project.version -- making things a tad more consistent.

Change-Id: I16f07a512bcf2facd33a2272f8397539a9480407
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Binary data shall be emitted in the form of hexa numbers.

Added converter character->to HEX in AsyncSshHandlerWriter class logging.

JIRA: NETCONF-135
Change-Id: I462baf94eecbc67221ca349f2b900eedf80ea483
Signed-off-by: Iaroslav <iaroslav.kholiavko@pantheon.tech>

Stream name should be used instead of BASE_STREAM_NAME

Refactored onNotification method to use stream parameter instead of "BASE_STREAM_NAME".
Fix ConcurrentModificationException while closing listeners/publishers.

JIRA: NETCONF-306
Change-Id: I3f08a294adf53e34c31dd23ca8d9627a46fb585c
Signed-off-by: Iaroslav <iaroslav.kholiavko@pantheon.tech>
Signed-off-by: Vladyslav Marchenko <vladyslav.marchenko@pantheon.tech>

Reduce memory usage of perf-client

Moved payload creation from test tool start to message send. It will
prevent store huge amount of the objects and reduce memory usage.

JIRA: NETCONF-762
Change-Id: I4932f259391af5770edf8d941f9dc27f022f2277
Signed-off-by: Iaroslav <iaroslav.kholiavko@pantheon.tech>

Missing notification model.

In case server provides schema it should check if notifications
supported by the remote session. According to this it should provide schema
with notifications or without.

JIRA: NETCONF-754
Change-Id: Ifc37ebded7051aabf9150f9f49ecadaf81746261
Signed-off-by: Iaroslav <iaroslav.kholiavko@pantheon.tech>

Bump versions to 1.13.2-SNAPSHOT

THis starts the next development iteration.

Change-Id: I49f970edb50f658cc5f1534c09351d9dae584f7a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add diffie-hellman-group14-sha1 to the list of default key exchange algorithms

The list of key exchange algorithms enabled by default has been changed
with a Mina SSHD uplift to the version of 2.6.0, leaving some of the
SHA1 algorithms disabled by default. Some the devices might still use
this algorithm, so this change brings back the
'diffie-hellman-group14-sha1' algorithm to the list.

JIRA: NETCONF-765
Change-Id: Iea58448981e19f1632799d05dbda8784415ebf1f
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>

Fix lock/unlock/commit issues for the NetconfRestconfTransactions

- Fix the problem when one transaction could suddenly remove
configuration-lock created by another one.
- Fix the problem when transaction without successful lock operation
could execute edit-config operations
- Fix the problem when failure to acquire a lock on a candidate could
lead to unexpected unlocking of the running configuration
- Fix the problem when commit didn't take into account results of
previous operations
- Execute operation futures in a chain to guarantee the correct order of
operations inside the transaction
- Fix the problem when commit operation was executed for yang-patch even
if some operations failed (JIRA: NETCONF-746)

JIRA: NETCONF-705
Change-Id: I588c6e2788983aef20b92726463930038abde3c9
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix permanent lock on the running configuration via RESTconf

This resolves the issue when the NETCONF device with both
:writable-running and :candidate capabilities gets permanently
locked after the commit happens via RESTconf.

JIRA: NETCONF-705
Change-Id: I90c6ec104a9309dd25fc66cd74f469c2f033ee5f
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.1.1
- infrautils-1.9.6
- yangtools-6.0.5
- mdsal-7.0.6
- controller-3.0.7
- aaa-0.13.2

Change-Id: Id8e35132aeb7eb902514e3373ef14c6d2b26cd18
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use java.nio.file for file operations

java.nio.file is more expressive than java.io.File, use it to
perform reads and atomic renames.

Also clean up constant use and assertions a bit.

JIRA: NETCONF-756
Change-Id: Ia42c61f8cca4253a7db297e188053fcf2b63ec35
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix futures handling in the NetconfRestconfTransaction

This change solves the problem when the NetconfDataTreeService.lock()
returns an immutable list of futures, and the NetconfRestconfTransaction
wrapper can't change items on the list.

JIRA: NETCONF-705
Change-Id: Ie98f23382660683e269d3c1cdad6419be72545e5
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>

Bump versions to 0.13.1-SNAPSHOT

This starts the next development iteration.

Change-Id: I0802546c10d5c845869a19bb7b150fe8c823aa21
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add feature-parent

This centralizes a feature-parent pom.xml for reuse in single
feature artifacts.

Change-Id: I7153166a86721dea9d732e5a13174f82865e24c4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump project version

This bumps project version to 1.13.0-SNAPSHOT in preparation for unifying
artifact versions.

Change-Id: I4a230e8e0cadb23e34ba57ed77c365ae302cea6b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixed reading whole list/leaf-list using GET/GET-CONFIG RPC

- The source of the issue was in skipping of empty list/leaf-list
  nodes in XMLStreamNormalizedNodeStreamWriter - the NETCONF
  filter structure was created correctly, but it wasn't correctly
  serialized into XML. However, in NETCONF, it is valid to read
  whole list/leaf-list - we must be able to build NormalizedNode
  structure from subtree-filter which "ends" by list/leaf-list.
- Fixed by introduction EmptyListXmlWriter which is responsible
  for serialization of empty list/leaf-list. Other operations
  are delegated to XMLStreamNormalizedNodeStreamWriter
  implementation.

JIRA: NETCONF-744
Change-Id: Id4b665aa45a397ab25a53e12f4eb7c1a6539d428
Signed-off-by: Jaroslav Tóth <jtoth@frinx.io>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Added schemaless creation of filter structure

- Added procedure for creation of filter structure for schemaless
  mountpoints.
- Added two unit tests that cover most of the cases.

JIRA: NETCONF-735
Change-Id: Ib276ddaf79e5306ff6c2193a03a8b0f57f005991
Signed-off-by: Jaroslav Tóth <jtoth@frinx.io>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Explicit reading of list keys using subtree filtering

- According to RFC-6241, section 6.2.5, NETCONF server doesn't
  have to provide values of list keys, if NETCONF client doesn't
  ask for these fields; see following statement:

  o  If any sibling nodes of the selection node are instance
     identifier components for a conceptual data structure (e.g.,
     list key leaf), then they MAY also be included
     in the filter output.

JIRA: NETCONF-735
Change-Id: I9bb048010578fd89190f616664e2175c3d3326ae
Signed-off-by: Jaroslav Tóth <jtoth@frinx.io>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Implement subtree filtering using fields

- Fields are used for selection of specific subtrees under
  parent path - this way it is possible to limit requested
  data to specific entities without the necessity to send
  multiple get/get-config RPCs.
- Look at added unit tests to understand the functionality.

JIRA: NETCONF-735
Change-Id: I17cd364e11f8c8e61e5537fcff71a7ecedefdba3
Signed-off-by: Jaroslav Tóth <jtoth@frinx.io>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

File should be closed before rename

Rename file will make clone of file with new name and remove initial
file. This file not closed while removing so it will make impossible
file deletion on Windows due to default locking.

JIRA: NETCONF-756
Change-Id: I0f81507285811607a7ee8d40c0b50018603dd557
Signed-off-by: Iaroslav Kholiavko <iaroslav.kholiavko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add tool to measure southbound notification performance

This is an updated version of the tool existed in coretutorials project,
aligned with the latest API changes
- Tool is packaged into a new feature odl-netconf-test-tools
- For the testing purposes models from the original coretutorials
project are used
- Tool listens for mounted devices with prefix "perf-"
- Notification counter is only applied for devices that end with the following
pattern '*-notif-([0-9]+)', and the number after notif suffix indicates
how many notifications should be counted
- Once the mounted device is ready tool invokes create subscription
  request towards device, and counts incoming notifications

JIRA: NETCONF-759
Change-Id: I5a584032dca9a40e90dec23186562543f8752bad
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade sshd to 2.6.0

Upgrade sshd to version 2.6.0

JIRA: NETCONF-752
Change-Id: Iaf6fd1ab232458aeb58636590bc84d3d8d2036f6
Signed-off-by: Iaroslav <iaroslav.kholiavko@pantheon.tech>