Exceptions while running DC-GW Floating-ips Jobs

JIRA: NETVIRT-1668

Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Change-Id: I9f272183261d6d5451dc4931f9dba76d47a8661a

diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalRoutersListener.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalRoutersListener.java
index 1aaac13b3f0c0b9742e4e29c13af83503881d1eb..bbaebf4ed9482a30098b8710f9e215d5ede33a67 100644 (file)
--- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalRoutersListener.java
+++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalRoutersListener.java
@@ -1019,6 +1019,7 @@ public class ExternalRoutersListener extends AsyncDataTreeChangeListenerBase<Rou
         // FLAT/VLAN case having external-subnet as VPN
         String externalSubnetVpn = null;
         if (externalSubnetList != null && !externalSubnetList.isEmpty()) {
+            Boolean isExternalIpsAdvertized = Boolean.FALSE;
             for (Uuid externalSubnetId : externalSubnetList) {
                 Optional<Subnets> externalSubnet = NatUtil
                     .getOptionalExternalSubnets(dataBroker, externalSubnetId);
@@ -1028,10 +1029,15 @@ public class ExternalRoutersListener extends AsyncDataTreeChangeListenerBase<Rou
                     advToBgpAndInstallFibAndTsFlows(dpnId, NwConstants.INBOUND_NAPT_TABLE,
                         externalSubnetVpn, routerId, routerName,
                         externalIp, networkId, router, confTx);
+                    isExternalIpsAdvertized = Boolean.TRUE;
                 }
             }
-            return;
+            if (isExternalIpsAdvertized) {
+                LOG.trace("External Ips {} advertized for Router {}", router.getExternalIps(), routerName);
+                return;
+            }
         }
+
         // VXVLAN/GRE case having Internet-VPN
         final String vpnName = NatUtil.getAssociatedVPN(dataBroker, networkId);
         if (vpnName == null) {