git.opendaylight Code Review - neutron.git/commit

author	Tom Pantelis <tompantelis@gmail.com>
	Wed, 17 Jan 2018 20:40:50 +0000 (15:40 -0500)
committer	Tom Pantelis <tompantelis@gmail.com>
	Wed, 17 Jan 2018 20:42:28 +0000 (15:42 -0500)
commit	a0221a546391fd27156d5c37f90c8acfe2bc5fca
tree	4fa300127e615362bc6845f2063c1ef0f8460a07	tree \| snapshot
parent	5d93eeee7331c6405d607be4b30f57b7d7744039	commit \| diff

Fix FindBugs violations

- Confusing to have methods with similar names
- Class implements same interface as superclass
- Non-transient non-serializable instance field 'segments' in serializable class
- Method invokes toString() method on a String
- Boxed value is unboxed and then immediately reboxed
- Method ignores exceptional return value

Change-Id: If5bc9c997e879cffd44a4e3390e59a9cfabaf42e
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

79 files changed:

.gitignore		diff \| blob \| history
neutron-hostconfig/vpp/src/main/java/org/opendaylight/neutron/hostconfig/vpp/NeutronHostconfigVppListener.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronAdminAttributes.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronBaseAttributes.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronBgpvpn.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronFirewall.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronFirewallPolicy.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronFirewallRule.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronFloatingIp.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronL2gateway.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronL2gatewayConnection.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronL2gatewayDevice.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronLoadBalancer.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronLoadBalancerHealthMonitor.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronLoadBalancerListener.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronLoadBalancerPool.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronLoadBalancerPoolMember.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronMeteringLabel.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronMeteringLabelRule.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronNetwork.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronObject.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronPort.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronQosBandwidthLimitRule.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronQosDscpMarkingRule.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronQosMinimumBandwidthRule.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronQosPolicy.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronRouter.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronRouterInterface.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSFCFlowClassifier.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSFCPortChain.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSFCPortPair.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSFCPortPairGroup.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSecurityGroup.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSecurityRule.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSubnet.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronTapFlow.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronTapService.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronTrunk.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronVpnIkePolicy.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronVpnIpSecPolicy.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronVpnIpSecSiteConnection.java		diff \| blob \| history
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronVpnService.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronBgpvpnRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFirewallPolicyRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFirewallRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFirewallRuleRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFloatingIpRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronL2gatewayConnectionRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronL2gatewayRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerHealthMonitorRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerListenerRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerPoolMemberRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerPoolRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronMeteringLabelRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronMeteringLabelRuleRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronNetworkRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronPortRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronQosPolicyRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronRouterRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCFlowClassifierRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCPortChainRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCPortPairGroupRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCPortPairRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSecurityGroupRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSecurityRuleRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSubnetRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronTapFlowRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronTapServiceRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronTrunkRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnIkePolicyRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnIpSecPolicyRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnIpSecSiteConnectionRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnServiceRequest.java		diff \| blob \| history
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/PaginatedRequestFactory.java		diff \| blob \| history
transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronL2gatewayConnectionInterface.java		diff \| blob \| history
transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronL2gatewayInterface.java		diff \| blob \| history
transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronLoadBalancerHealthMonitorInterface.java		diff \| blob \| history
transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronSecurityRuleInterface.java		diff \| blob \| history

Neutron Northbound

RSS Atom