Fix FindBugs violations 53/67253/1
authorTom Pantelis <tompantelis@gmail.com>
Wed, 17 Jan 2018 20:40:50 +0000 (15:40 -0500)
committerTom Pantelis <tompantelis@gmail.com>
Wed, 17 Jan 2018 20:42:28 +0000 (15:42 -0500)
- Confusing to have methods with similar names
- Class implements same interface as superclass
- Non-transient non-serializable instance field 'segments' in serializable class
- Method invokes toString() method on a String
- Boxed value is unboxed and then immediately reboxed
- Method ignores exceptional return value

Change-Id: If5bc9c997e879cffd44a4e3390e59a9cfabaf42e
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
79 files changed:
.gitignore
neutron-hostconfig/vpp/src/main/java/org/opendaylight/neutron/hostconfig/vpp/NeutronHostconfigVppListener.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronAdminAttributes.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronBaseAttributes.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronBgpvpn.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronFirewall.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronFirewallPolicy.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronFirewallRule.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronFloatingIp.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronL2gateway.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronL2gatewayConnection.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronL2gatewayDevice.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronLoadBalancer.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronLoadBalancerHealthMonitor.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronLoadBalancerListener.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronLoadBalancerPool.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronLoadBalancerPoolMember.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronMeteringLabel.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronMeteringLabelRule.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronNetwork.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronObject.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronPort.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronQosBandwidthLimitRule.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronQosDscpMarkingRule.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronQosMinimumBandwidthRule.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronQosPolicy.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronRouter.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronRouterInterface.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSFCFlowClassifier.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSFCPortChain.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSFCPortPair.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSFCPortPairGroup.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSecurityGroup.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSecurityRule.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronSubnet.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronTapFlow.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronTapService.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronTrunk.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronVpnIkePolicy.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronVpnIpSecPolicy.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronVpnIpSecSiteConnection.java
neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronVpnService.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronBgpvpnRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFirewallPolicyRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFirewallRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFirewallRuleRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFloatingIpRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronL2gatewayConnectionRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronL2gatewayRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerHealthMonitorRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerListenerRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerPoolMemberRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerPoolRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronMeteringLabelRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronMeteringLabelRuleRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronNetworkRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronPortRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronQosPolicyRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronRouterRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCFlowClassifierRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCPortChainRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCPortPairGroupRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCPortPairRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSecurityGroupRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSecurityRuleRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSubnetRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronTapFlowRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronTapServiceRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronTrunkRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnIkePolicyRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnIpSecPolicyRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnIpSecSiteConnectionRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnServiceRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/PaginatedRequestFactory.java
transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronL2gatewayConnectionInterface.java
transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronL2gatewayInterface.java
transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronLoadBalancerHealthMonitorInterface.java
transcriber/src/main/java/org/opendaylight/neutron/transcriber/NeutronSecurityRuleInterface.java

index a2903aeafcbac73855fb19e740db9ac4c945d5be..6740902df704ab84a7e8be5bb1444d2c88f22e3c 100644 (file)
@@ -28,3 +28,5 @@ yang-gen-config
 yang-gen-sal
 maven-metadata-local.xml
 .factorypath
+.fbExcludeFilterFile
+
index 7faa9aaa079fe90c6aae697c6cabe44b8d2b6dbd..205ac3542a28b076c4b58616a3b546b184acef54 100644 (file)
@@ -80,7 +80,7 @@ public class NeutronHostconfigVppListener implements ClusteredDataTreeChangeList
     @Override
     public void onDataTreeChanged(@Nonnull Collection<DataTreeModification<Node>> changes) {
         LOG.info("onDataTreeChanged: Received Data Tree Changed ...", changes);
-        executorService.submit(() -> {
+        executorService.execute(() -> {
             for (DataTreeModification<Node> change : Preconditions.checkNotNull(changes, "Changes may not be null!")) {
                 processDataTreeModification(change);
             }
index bd81eef88f78845f1fdae9c240f08d421d0d3ce2..0a93ffcf26245f3f45e5e1547ccbd720fa18da7c 100644 (file)
@@ -9,7 +9,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -17,8 +16,8 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public abstract class NeutronAdminAttributes<T extends NeutronAdminAttributes> extends NeutronBaseAttributes<T>
-        implements Serializable, INeutronAdminAttributes<T> {
+public abstract class NeutronAdminAttributes<T extends NeutronAdminAttributes<T>> extends NeutronBaseAttributes<T>
+        implements INeutronAdminAttributes<T> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(defaultValue = "true", name = "admin_state_up")
@@ -30,18 +29,29 @@ public abstract class NeutronAdminAttributes<T extends NeutronAdminAttributes> e
     public NeutronAdminAttributes() {
     }
 
+    @Override
     public Boolean getAdminStateUp() {
         return adminStateUp;
     }
 
+    public boolean isAdminStateUp() {
+        if (adminStateUp == null) {
+            return true;
+        }
+        return adminStateUp;
+    }
+
+    @Override
     public void setAdminStateUp(Boolean adminStateUp) {
         this.adminStateUp = adminStateUp;
     }
 
+    @Override
     public String getStatus() {
         return status;
     }
 
+    @Override
     public void setStatus(String status) {
         this.status = status;
     }
index e6ca2c99d6a306a61ceaaf46000937cca55338f3..f4d274d028730a9ad58007b758ca93176e12a83f 100644 (file)
@@ -9,7 +9,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -17,8 +16,8 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public abstract class NeutronBaseAttributes<T extends NeutronBaseAttributes> extends NeutronObject<T>
-        implements Serializable, INeutronBaseAttributes<T> {
+public abstract class NeutronBaseAttributes<T extends NeutronBaseAttributes<T>> extends NeutronObject<T>
+        implements INeutronBaseAttributes<T> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "name")
index dd7a57a46c05c1c1d644c20eec036c7f8c9cd126..1684d5b0603e499ba03cc89e33620f14c15a0522 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,7 +16,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement(name = "bgpvpn")
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronBgpvpn extends NeutronAdminAttributes<NeutronBgpvpn> implements Serializable {
+public final class NeutronBgpvpn extends NeutronAdminAttributes<NeutronBgpvpn> {
     // See OpenStack Network API v2.0 Reference for description of
     // annotated attributes
 
@@ -60,6 +59,7 @@ public final class NeutronBgpvpn extends NeutronAdminAttributes<NeutronBgpvpn> i
     public NeutronBgpvpn() {
     }
 
+    @Override
     public void initDefaults() {
         super.initDefaults();
         if (type == null) {
@@ -70,10 +70,6 @@ public final class NeutronBgpvpn extends NeutronAdminAttributes<NeutronBgpvpn> i
         }
     }
 
-    public boolean isAdminStateUp() {
-        return adminStateUp;
-    }
-
     public boolean isAutoAggregate() {
         return autoAggregate;
     }
index ca384d596d00cb7ddc9497baaf12010c2c569d49..659293d5d623820fa3fafa7423a1452766327fde 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -33,7 +32,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronFirewall extends NeutronBaseAttributes<NeutronFirewall> implements Serializable {
+public final class NeutronFirewall extends NeutronBaseAttributes<NeutronFirewall> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(defaultValue = "true", name = "admin_state_up")
index 5e9cfb969fa3f408c6723a23659a96b47546c0da..ff44a5a8329cdb23ea1bea56ae89b361fc633a63 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -32,7 +31,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronFirewallPolicy extends NeutronBaseAttributes<NeutronFirewallPolicy> implements Serializable {
+public final class NeutronFirewallPolicy extends NeutronBaseAttributes<NeutronFirewallPolicy> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(defaultValue = "false", name = "shared")
index 3fe580b3a81998ea20e260920e67168440f839e5..6bcd09faa126de7b94c793c3726403c78abec761 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -44,7 +43,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronFirewallRule extends NeutronBaseAttributes<NeutronFirewallRule> implements Serializable {
+public final class NeutronFirewallRule extends NeutronBaseAttributes<NeutronFirewallRule> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(defaultValue = "false", name = "shared")
index cff693525db7a38f1d28fa88338387bc49cdef2b..73bf637a9015f4a8efc878430da82f3ec18a2025 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -16,8 +15,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronFloatingIp
-        extends NeutronObject<NeutronFloatingIp> implements Serializable, INeutronObject<NeutronFloatingIp> {
+public final class NeutronFloatingIp extends NeutronObject<NeutronFloatingIp> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Network API v2.0 Reference for description of
index 22321bb4b729d2a2a1aef431bdbd9e48071851ca..28c68d3e0f309b16aaa4f4735c0e3a4663f10f01 100644 (file)
@@ -8,15 +8,13 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.List;
 import javax.xml.bind.annotation.XmlElement;
 import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement(name = "l2gateway")
-public final class NeutronL2gateway extends NeutronBaseAttributes<NeutronL2gateway>
-        implements Serializable {
+public final class NeutronL2gateway extends NeutronBaseAttributes<NeutronL2gateway> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "devices")
index d8b2b87af08f390a8e4643b78a2fe0361a5e544d..e7befef39c37f14e267119a84120bef9eff8e90d 100644 (file)
@@ -8,7 +8,7 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -16,8 +16,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement(name = "l2gatewayConnection")
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronL2gatewayConnection extends NeutronBaseAttributes<NeutronL2gatewayConnection>
-            implements Serializable {
+public final class NeutronL2gatewayConnection extends NeutronBaseAttributes<NeutronL2gatewayConnection> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "gateway_id")
@@ -56,10 +55,14 @@ public final class NeutronL2gatewayConnection extends NeutronBaseAttributes<Neut
         this.segmentID = segmentID;
     }
 
+    // getPortID differ only by capitalization with NeutronTrunk.getPortId but it's not worth changing the API and
+    // disrupting downstream users just for that reason.
+    @SuppressFBWarnings("NM_CONFUSING")
     public String getPortID() {
         return portID;
     }
 
+    @SuppressFBWarnings("NM_CONFUSING")
     public void setPortID(String portID) {
         this.portID = portID;
     }
index 755e41fb6ee33df1d151471d07ae8fa13252fbe0..ee72891038577ded953e359cc1ffc6f9c9cb84a6 100644 (file)
@@ -8,11 +8,10 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.List;
 import javax.xml.bind.annotation.XmlElement;
 
-public final class NeutronL2gatewayDevice extends NeutronID implements Serializable {
+public final class NeutronL2gatewayDevice extends NeutronID {
 
     private static final long serialVersionUID = 1L;
 
index 9b4dff1741792ac207ab0a42a0472b1021c16bf1..2436956ae3c4ad4a856d9a662f1d71ef119c9789 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -32,7 +31,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronLoadBalancer extends NeutronAdminAttributes<NeutronLoadBalancer> implements Serializable {
+public final class NeutronLoadBalancer extends NeutronAdminAttributes<NeutronLoadBalancer> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "vip_address")
index 768dbf17146c9421de914129b2d4e6bcadd4ba05..325f0c6b843ba377962ae7d0413f029100788be7 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -38,8 +37,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronLoadBalancerHealthMonitor extends NeutronObject<NeutronLoadBalancerHealthMonitor>
-        implements Serializable, INeutronObject<NeutronLoadBalancerHealthMonitor> {
+public final class NeutronLoadBalancerHealthMonitor extends NeutronObject<NeutronLoadBalancerHealthMonitor> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "type")
index ac9cb5a77bfe38e7619026e319e2ba3d950c1399..bd1bf5d47f67dbe238a96b72e981b48dc733afa1 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -39,8 +38,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronLoadBalancerListener extends NeutronBaseAttributes<NeutronLoadBalancerListener>
-        implements Serializable {
+public final class NeutronLoadBalancerListener extends NeutronBaseAttributes<NeutronLoadBalancerListener> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "default_pool_id")
index 8d9ccca78a2ca244000562bbc7f69045537ea0ac..bcfdeda2975a3b03aff3cbfc7edf3462cb8aa595 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
@@ -37,8 +36,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronLoadBalancerPool extends NeutronBaseAttributes<NeutronLoadBalancerPool>
-        implements Serializable {
+public final class NeutronLoadBalancerPool extends NeutronBaseAttributes<NeutronLoadBalancerPool> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "protocol")
index f0687bb05e5b9d53443dc1d67e5ca0338005744c..38915c0c6bba599a10fc00a8acb5f6a7b59927b8 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -17,8 +16,7 @@ import javax.xml.bind.annotation.XmlTransient;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronLoadBalancerPoolMember extends NeutronObject<NeutronLoadBalancerPoolMember>
-        implements Serializable, INeutronObject<NeutronLoadBalancerPoolMember> {
+public final class NeutronLoadBalancerPoolMember extends NeutronObject<NeutronLoadBalancerPoolMember> {
     private static final long serialVersionUID = 1L;
 
     /**
index 5b434bb5e122a4ea924b3cbd4b3053b8263b77bb..36c7ce4814fabafb6c1aa85dfea4857c98f3975e 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -16,7 +15,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronMeteringLabel extends NeutronBaseAttributes<NeutronMeteringLabel> implements Serializable {
+public final class NeutronMeteringLabel extends NeutronBaseAttributes<NeutronMeteringLabel> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(defaultValue = "false", name = "shared")
index 6ee9f552b43a0310a7fa51e3fe4701e1a38be059..2acbf768ca8c2236b6542587bbc1e0b585fc1c7d 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -16,8 +15,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronMeteringLabelRule extends NeutronObject<NeutronMeteringLabelRule>
-        implements Serializable, INeutronObject<NeutronMeteringLabelRule> {
+public final class NeutronMeteringLabelRule extends NeutronObject<NeutronMeteringLabelRule> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "direction")
index 5c48228eeb6ccb7b169d03554aca86ff3817f6c7..174575163d8a8dc8e0a0face6c34ffaef93b1760 100644 (file)
@@ -8,7 +8,7 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,7 +17,10 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement(name = "network")
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronNetwork extends NeutronAdminAttributes<NeutronNetwork> implements Serializable {
+// Non-transient non-serializable instance field 'segments' - we have to assume/hope users will set a Serializable List
+// instance.
+@SuppressFBWarnings("SE_BAD_FIELD")
+public final class NeutronNetwork extends NeutronAdminAttributes<NeutronNetwork> {
     // See OpenStack Network API v2.0 Reference for description of
     // annotated attributes
 
@@ -75,11 +78,11 @@ public final class NeutronNetwork extends NeutronAdminAttributes<NeutronNetwork>
         }
     }
 
-    public boolean isAdminStateUp() {
-        return adminStateUp;
-    }
-
     public boolean isShared() {
+        if (shared == null) {
+            return false;
+        }
+
         return shared;
     }
 
@@ -92,6 +95,10 @@ public final class NeutronNetwork extends NeutronAdminAttributes<NeutronNetwork>
     }
 
     public boolean isRouterExternal() {
+        if (routerExternal == null) {
+            return false;
+        }
+
         return routerExternal;
     }
 
@@ -163,7 +170,7 @@ public final class NeutronNetwork extends NeutronAdminAttributes<NeutronNetwork>
     public boolean extractField(String field, NeutronNetwork ans) {
         switch (field) {
             case "shared":
-                ans.setShared(shared);
+                ans.setShared(isShared());
                 break;
             case "external":
                 ans.setRouterExternal(this.getRouterExternal());
index cfd4302f5c875babac49b1d65cf8575f3a47909c..d138cc4a39c406c3d3d910c21b28f28443791740 100644 (file)
@@ -9,7 +9,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.lang.reflect.ParameterizedType;
 import java.lang.reflect.Type;
 import java.util.List;
@@ -24,8 +23,7 @@ import org.slf4j.LoggerFactory;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public abstract class NeutronObject<T extends NeutronObject> extends NeutronID
-        implements Serializable, INeutronObject<T> {
+public abstract class NeutronObject<T extends NeutronObject<T>> extends NeutronID implements INeutronObject<T> {
     // T extends NeutronObject as 0th type argument. Used by extractFields()
     private static final int NEUTRON_OBJECT_CLASS_TYPE_INDEX = 0;
 
index f990d371480395ef747ce02f1d207f9f0c7137fa..4de5dffd0f7dde90a805b41550861264d23f905b 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
@@ -21,7 +20,7 @@ import javax.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronPort extends NeutronAdminAttributes<NeutronPort> implements Serializable {
+public final class NeutronPort extends NeutronAdminAttributes<NeutronPort> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Network API v2.0 Reference for description of
@@ -90,13 +89,6 @@ public final class NeutronPort extends NeutronAdminAttributes<NeutronPort> imple
         this.networkUUID = networkUUID;
     }
 
-    public boolean isAdminStateUp() {
-        if (adminStateUp == null) {
-            return true;
-        }
-        return adminStateUp;
-    }
-
     public String getMacAddress() {
         return macAddress;
     }
index bbc64df5761cc5a5135c37c599882cfd24165fe1..52c4a1e9f866797d8d05cf9f94d6337e04a1b847 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.math.BigInteger;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,8 +16,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronQosBandwidthLimitRule extends NeutronObject<NeutronQosBandwidthLimitRule>
-        implements Serializable, INeutronObject<NeutronQosBandwidthLimitRule> {
+public final class NeutronQosBandwidthLimitRule extends NeutronObject<NeutronQosBandwidthLimitRule> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "max_kbps")
index abc68ec8bddcbbcd5520ce9c3df1031a2118aef8..6e69e579abf4f4ce8a72a5445f6ace2b25c6bf04 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -16,8 +15,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronQosDscpMarkingRule extends NeutronObject<NeutronQosDscpMarkingRule>
-        implements Serializable, INeutronObject<NeutronQosDscpMarkingRule> {
+public final class NeutronQosDscpMarkingRule extends NeutronObject<NeutronQosDscpMarkingRule> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "dscp_mark")
index 3f7df0989c604f5f36400fcbde75f5dc74e8a3b1..6c056c0df933fd65078dac20c772a04dd0fb976a 100644 (file)
@@ -7,7 +7,6 @@
  */
 
 package org.opendaylight.neutron.spi;
-import java.io.Serializable;
 import java.math.BigInteger;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,8 +16,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronQosMinimumBandwidthRule extends NeutronObject<NeutronQosMinimumBandwidthRule>
-    implements Serializable, INeutronObject<NeutronQosMinimumBandwidthRule> {
+public final class NeutronQosMinimumBandwidthRule extends NeutronObject<NeutronQosMinimumBandwidthRule> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "min_kbps")
@@ -66,4 +64,4 @@ public final class NeutronQosMinimumBandwidthRule extends NeutronObject<NeutronQ
                 + '\'' + ", qosMinimumBandwidthDirection='" + direction + '\''
                 + '}';
     }
-}
\ No newline at end of file
+}
index 97965796caf09c96df2042e348e68b8a0a733c3a..b17181ae2b5bda7d1f4d281d1a0f9f74147d73f2 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
@@ -18,7 +17,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronQosPolicy extends NeutronBaseAttributes<NeutronQosPolicy> implements Serializable {
+public final class NeutronQosPolicy extends NeutronBaseAttributes<NeutronQosPolicy> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(defaultValue = "false", name = "shared")
index e9a1e328fcc9b3b33ad10219d5909e80c9d5d053..cf49da79e51beef93b165f93bd207918114d9188 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,8 +16,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronRouter extends NeutronAdminAttributes<NeutronRouter>
-        implements Serializable {
+public final class NeutronRouter extends NeutronAdminAttributes<NeutronRouter> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Network API v2.0 Reference for description of
@@ -38,13 +36,6 @@ public final class NeutronRouter extends NeutronAdminAttributes<NeutronRouter>
     public NeutronRouter() {
     }
 
-    public boolean isAdminStateUp() {
-        if (adminStateUp == null) {
-            return true;
-        }
-        return adminStateUp;
-    }
-
     public NeutronRouterNetworkReference getExternalGatewayInfo() {
         return externalGatewayInfo;
     }
index 99e2b953f3c3bcd7ea1b04acc065efe2aabab5d3..2961bc996f614114906fd0c1947353e00ee8d01f 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -16,8 +15,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronRouterInterface extends NeutronObject<NeutronRouterInterface>
-        implements Serializable, INeutronObject<NeutronRouterInterface> {
+public final class NeutronRouterInterface extends NeutronObject<NeutronRouterInterface> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Network API v2.0 Reference for description of
index f9c629c646a34eec1e107152a3edd987bf792a65..9e01a1db8a9d601d3ed23ab577b4d83914ff1a4d 100644 (file)
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.HashMap;
 import java.util.Map;
 import javax.xml.bind.annotation.XmlAccessType;
@@ -18,8 +17,7 @@ import javax.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronSFCFlowClassifier extends NeutronBaseAttributes<NeutronSFCFlowClassifier>
-        implements Serializable {
+public final class NeutronSFCFlowClassifier extends NeutronBaseAttributes<NeutronSFCFlowClassifier> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Networking SFC (networking-sfc) API v1.0 Reference for description of
index 4db17cdf0954d0f80275414851e10e4a18c703dc..9caa8e16c618011b62df023c24a780ff37907922 100644 (file)
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.List;
 import java.util.Map;
 import javax.xml.bind.annotation.XmlAccessType;
@@ -18,7 +17,7 @@ import javax.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronSFCPortChain extends NeutronBaseAttributes<NeutronSFCPortChain> implements Serializable {
+public final class NeutronSFCPortChain extends NeutronBaseAttributes<NeutronSFCPortChain> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Networking SFC (networking-sfc) Port Chain API v1.0 Reference
index da291dcbab148e8a0f9540fb4e0436884c07bbc8..faeb9c5c8566a2923789f40a28fbc5b8eefb0488 100644 (file)
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.HashMap;
 import java.util.Map;
 import javax.xml.bind.annotation.XmlAccessType;
@@ -18,7 +17,7 @@ import javax.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronSFCPortPair extends NeutronBaseAttributes<NeutronSFCPortPair> implements Serializable {
+public final class NeutronSFCPortPair extends NeutronBaseAttributes<NeutronSFCPortPair> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Networking SFC (networking-sfc) Port Pair API v1.0 Reference
index ecf4c5459f1d31b566a5043397a7b413216611f9..319b82f25b8f00626a0c14293bfc1750de296cc9 100644 (file)
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -16,8 +15,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronSFCPortPairGroup extends NeutronBaseAttributes<NeutronSFCPortPairGroup>
-        implements Serializable {
+public final class NeutronSFCPortPairGroup extends NeutronBaseAttributes<NeutronSFCPortPairGroup> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Networking SFC (networking-sfc) Port Pair Group API v1.0
index c876ae3930122b55830d13b0aa85aed1c8937568..591e8927409c1369ab37e114c4efed53e2f554fc 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlRootElement;
@@ -26,7 +25,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronSecurityGroup extends NeutronBaseAttributes<NeutronSecurityGroup> implements Serializable {
+public final class NeutronSecurityGroup extends NeutronBaseAttributes<NeutronSecurityGroup> {
     private static final long serialVersionUID = 1L;
 
     public NeutronSecurityGroup() {
index bdfb2021048e28227d5925abe3ae988ad243a0bf..20de13342e4e51e37de9b9a78f648c0640d0dd81 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -33,8 +32,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronSecurityRule extends NeutronObject<NeutronSecurityRule>
-        implements Serializable, INeutronObject<NeutronSecurityRule> {
+public final class NeutronSecurityRule extends NeutronObject<NeutronSecurityRule> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "direction")
index f3e848b6c9a3d719f4124200cad55fab96a36e04..ba70c250b63627c4f4bbf2a44e95045011433000 100644 (file)
@@ -9,7 +9,6 @@
 package org.opendaylight.neutron.spi;
 
 import com.google.common.net.InetAddresses;
-import java.io.Serializable;
 import java.math.BigInteger;
 import java.net.Inet6Address;
 import java.util.ArrayList;
@@ -25,7 +24,7 @@ import org.slf4j.LoggerFactory;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronSubnet extends NeutronBaseAttributes<NeutronSubnet> implements Serializable {
+public final class NeutronSubnet extends NeutronBaseAttributes<NeutronSubnet> {
     private static final Logger LOG = LoggerFactory.getLogger(NeutronCRUDInterfaces.class);
 
     private static final long serialVersionUID = 1L;
@@ -234,12 +233,12 @@ public final class NeutronSubnet extends NeutronBaseAttributes<NeutronSubnet> im
             // convert to byte array
             byte[] addrBytes = ((Inet6Address) InetAddresses.forString(parts[0])).getAddress();
             for (int index = length; index < IPV6_LENGTH; index++) {
-                if (((((int) addrBytes[index / IPV6_LENGTH_BYTES]) & IPV6_LSB_MASK)
-                        & (1 << (IPV6_BYTE_OFFSET - (index % IPV6_LENGTH_BYTES)))) != 0) {
-                    return (false);
+                if ((addrBytes[index / IPV6_LENGTH_BYTES] & IPV6_LSB_MASK
+                        & 1 << IPV6_BYTE_OFFSET - index % IPV6_LENGTH_BYTES) != 0) {
+                    return false;
                 }
             }
-            return (true);
+            return true;
         }
         return false;
     }
@@ -280,7 +279,7 @@ public final class NeutronSubnet extends NeutronBaseAttributes<NeutronSubnet> im
                 try {
                     SubnetUtils util = new SubnetUtils(cidr);
                     SubnetInfo info = util.getInfo();
-                    if (gatewayIp == null || ("").equals(gatewayIp)) {
+                    if (gatewayIp == null || "".equals(gatewayIp)) {
                         gatewayIp = info.getLowAddress();
                     }
                     if (allocationPools.size() < 1) {
@@ -305,7 +304,7 @@ public final class NeutronSubnet extends NeutronBaseAttributes<NeutronSubnet> im
                 BigInteger mask = BigInteger.ONE.shiftLeft(length).subtract(BigInteger.ONE);
                 String highAddress = NeutronSubnetIpAllocationPool
                         .bigIntegerToIp(lowAddressBi.add(mask).subtract(BigInteger.ONE));
-                if (gatewayIp == null || ("").equals(gatewayIp)) {
+                if (gatewayIp == null || "".equals(gatewayIp)) {
                     gatewayIp = lowAddress;
                 }
                 if (allocationPools.size() < 1) {
@@ -338,14 +337,14 @@ public final class NeutronSubnet extends NeutronBaseAttributes<NeutronSubnet> im
             byte[] cidrBytes = ((Inet6Address) InetAddresses.forString(parts[0])).getAddress();
             byte[] ipBytes = ((Inet6Address) InetAddresses.forString(ipAddress)).getAddress();
             for (int index = 0; index < length; index++) {
-                if (((((int) cidrBytes[index / IPV6_LENGTH_BYTES]) & IPV6_LSB_MASK) & (1 << (IPV6_BYTE_OFFSET
-                        - (index % IPV6_LENGTH_BYTES)))) != (
-                            (((int) ipBytes[index / IPV6_LENGTH_BYTES]) & IPV6_LSB_MASK)
-                            & (1 << (IPV6_BYTE_OFFSET - (index % IPV6_LENGTH_BYTES))))) {
-                    return (false);
+                if ((cidrBytes[index / IPV6_LENGTH_BYTES] & IPV6_LSB_MASK & 1 << IPV6_BYTE_OFFSET
+                        - index % IPV6_LENGTH_BYTES) != (
+                            ipBytes[index / IPV6_LENGTH_BYTES] & IPV6_LSB_MASK
+                            & 1 << IPV6_BYTE_OFFSET - index % IPV6_LENGTH_BYTES)) {
+                    return false;
                 }
             }
-            return (true);
+            return true;
         }
         return false;
     }
index e58b8dfafe1c46e03fa405cf786863901a883305..8cf9796b3a67739dfb707365b408a3c95f1f2a2b 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -16,7 +15,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronTapFlow extends NeutronBaseAttributes<NeutronTapFlow> implements Serializable {
+public final class NeutronTapFlow extends NeutronBaseAttributes<NeutronTapFlow> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "tap_service_id")
index 5072ea3f0195a6546ee929b501a4ee66e8de94a2..f4b45e4d59db6da232926fa98f002e7122808e86 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -16,7 +15,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronTapService extends NeutronBaseAttributes<NeutronTapService> implements Serializable {
+public final class NeutronTapService extends NeutronBaseAttributes<NeutronTapService> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "port_id")
index 5530223ba32cc22e9f3b4329992a7ed1ce2c59a7..832470485e10691623cdaabc661a6cf57efb0339 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
@@ -18,7 +17,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement(name = "trunk")
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronTrunk extends NeutronAdminAttributes<NeutronTrunk> implements Serializable {
+public final class NeutronTrunk extends NeutronAdminAttributes<NeutronTrunk> {
     private static final long serialVersionUID = 1L;
 
     @XmlElement(name = "port_id")
index 307aa2459e372c10e009686a195a086b4727d00b..b6339825e32548b2eb40d5acfdeccc3499d3b39e 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -16,7 +15,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronVpnIkePolicy extends NeutronBaseAttributes<NeutronVpnIkePolicy> implements Serializable {
+public final class NeutronVpnIkePolicy extends NeutronBaseAttributes<NeutronVpnIkePolicy> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Network API v2.0 Reference for description of
index aa097adc43267725367c6fea66e48bd4f3c6d932..e8b697c2603367c88ab04f003923c61c2f9cec41 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -16,7 +15,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronVpnIpSecPolicy extends NeutronBaseAttributes<NeutronVpnIpSecPolicy> implements Serializable {
+public final class NeutronVpnIpSecPolicy extends NeutronBaseAttributes<NeutronVpnIpSecPolicy> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Network API v2.0 Reference for description of
index 2555e23d3327e8c9014e56c20a0e654f2fbdc4b0..ff685769cd21be6377fc13d05d004af95cff5d1d 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,8 +16,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronVpnIpSecSiteConnection extends NeutronAdminAttributes<NeutronVpnIpSecSiteConnection>
-        implements Serializable {
+public final class NeutronVpnIpSecSiteConnection extends NeutronAdminAttributes<NeutronVpnIpSecSiteConnection> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Network API v2.0 Reference for description of
index 458300f80cabe3a6eb65a9a3370fffef51a8f4fc..e7264933d48d4c279aadfaa642958e65cb666511 100644 (file)
@@ -8,7 +8,6 @@
 
 package org.opendaylight.neutron.spi;
 
-import java.io.Serializable;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
@@ -16,7 +15,7 @@ import javax.xml.bind.annotation.XmlRootElement;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
-public final class NeutronVpnService extends NeutronAdminAttributes<NeutronVpnService> implements Serializable {
+public final class NeutronVpnService extends NeutronAdminAttributes<NeutronVpnService> {
     private static final long serialVersionUID = 1L;
 
     // See OpenStack Network API v2.0 Reference for description of
index 320463f97cd2591c88e49b484b32d59e80fe19e5..46601b10692066f526c66b33c02675ef1c0bbbd1 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronBgpvpn;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronBgpvpnRequest implements INeutronRequest<NeutronBgpvpn> {
     // See OpenStack Network API v2.0 Reference for description of
     // annotated attributes
index 2ea5ce1225402fb080a5e0780e3cbf280f6e56be..b971c7a4b5c5d52ff234ed5d120e5bb8d163ce6d 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronFirewallPolicy;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronFirewallPolicyRequest implements INeutronRequest<NeutronFirewallPolicy> {
     /**
      * See OpenStack Network API v2.0 Reference for description of the following link.
index 9f95fcc9660f0e876ba01ab89c1df0f1b293f3cb..35bb0b528b590e4d7865249a4ccb25ad71d945ab 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronFirewall;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronFirewallRequest implements INeutronRequest<NeutronFirewall> {
     /**
      * See OpenStack Network API v2.0 Reference for description of the following link.
index 0f3d7be0248f5ad0d4c9b161832e34e25ded2d20..c5bab0b374b7dae6018f657cab773e8bb83aa213 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronFirewallRule;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronFirewallRuleRequest implements INeutronRequest<NeutronFirewallRule> {
     /**
      * See OpenStack Network API v2.0 Reference for description of the following link.
index ee0cf7bab268a2d136fa00c497c831d6dc17e98d..9487703d977bc78044785f3cf993ed970b13b77c 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronFloatingIp;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronFloatingIpRequest implements INeutronRequest<NeutronFloatingIp> {
     // See OpenStack Network API v2.0 Reference for description of
     // annotated attributes
index d3acbb6d4595d29e53614e5dfebb92c9bb576758..74552472ca8956b50c4367c9433b6577bfbc5dfe 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronL2gatewayConnection;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronL2gatewayConnectionRequest implements INeutronRequest<NeutronL2gatewayConnection> {
     @XmlElement(name = "l2gateway_connection")
     NeutronL2gatewayConnection singleton;
index 72ffcbb456a1e6cffccc901b8f3dc93712b81458..d568ad4ba1001f9994a943adde61106d8a90a073 100644 (file)
@@ -8,10 +8,12 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlElement;
 import org.opendaylight.neutron.spi.NeutronL2gateway;
 
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronL2gatewayRequest implements INeutronRequest<NeutronL2gateway> {
     @XmlElement(name = "l2_gateway")
     NeutronL2gateway singleton;
index b587ea19d15bc3c1a452ee10e9ba61e808e201d7..a23c74e408ee69a7ade97de14a8955149c5453a7 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronLoadBalancerHealthMonitor;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronLoadBalancerHealthMonitorRequest
     implements INeutronRequest<NeutronLoadBalancerHealthMonitor> {
     /**
index 191f652bb92ee6c0e4966cb28f4980f68cd2ad47..47756c27ae1a15fb5d69c6e8a5e554bf3eb29034 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronLoadBalancerListener;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronLoadBalancerListenerRequest implements INeutronRequest<NeutronLoadBalancerListener> {
     /**
      * See OpenStack Network API v2.0 Reference for description of the following link.
index 800c317410a1913b7f8958ec2d08b121afcb23cc..f9724cd43b4ef6cd07ccc23c34450a543e9508b5 100644 (file)
@@ -8,10 +8,12 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlElement;
 import org.opendaylight.neutron.spi.NeutronLoadBalancerPoolMember;
 
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronLoadBalancerPoolMemberRequest implements INeutronRequest<NeutronLoadBalancerPoolMember> {
     /**
      * See OpenStack Network API v2.0 Reference for description of the following link.
index 49dde24bf16ebfd82919d71713e9b7da0dbecd0a..2bfd997b66fea5d45261567d9ff0d560e9bc7fcf 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronLoadBalancerPool;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronLoadBalancerPoolRequest implements INeutronRequest<NeutronLoadBalancerPool> {
     /**
      * See OpenStack Network API v2.0 Reference for description of the following link.
index 4b4c96ec4627db5980a1955aa35b4498f9e8ec01..1df94a6540a35e52b31e794971a0dfb6c6a6c5b8 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronLoadBalancer;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronLoadBalancerRequest implements INeutronRequest<NeutronLoadBalancer> {
     /**
      * See OpenStack Network API v2.0 Reference for description of the following link.
index d179b8b8121628aa2082a0ac2ef023dd09f86096..750bf5d63609736d03dc8d0d219c4654bf94a7d6 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronMeteringLabel;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronMeteringLabelRequest implements INeutronRequest<NeutronMeteringLabel> {
     // See OpenStack Network API v2.0 Reference for description of
     // annotated attributes
index dc61ce23490f0bc8bdac30d40968538294492420..42a1046014fbd80f72b0e0fa9a11076eebfc5120 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronMeteringLabelRule;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronMeteringLabelRuleRequest implements INeutronRequest<NeutronMeteringLabelRule> {
     // See OpenStack Network API v2.0 Reference for description of
     // annotated attributes
index ec77e90690e8e4f272ef5181c137b62d84ab2e65..83578c39d2abfbe5675323e1167b3967bdd3eabc 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronNetwork;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronNetworkRequest implements INeutronRequest<NeutronNetwork> {
     // See OpenStack Network API v2.0 Reference for description of
     // annotated attributes
index fda8a35410fe57bc5a25e16ef5070da70bfb2e96..c891c34aedb026d47f19c00dd572ac2cad341dba 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronPort;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronPortRequest implements INeutronRequest<NeutronPort> {
     // See OpenStack Network API v2.0 Reference for description of
     // annotated attributes
index 29f53dc168a75b7498e032bc8f25dd1c52c69d0d..1d270e454b9c6011dc5d531cb2218976210ac582 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronQosPolicy;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronQosPolicyRequest implements INeutronRequest<NeutronQosPolicy> {
     @XmlElement(name = "policy")
     NeutronQosPolicy singleton;
index d4c404d6b826e83139ac483e35826a618a4cb69d..4a07cad16105f5e08e765ae780060867d10e8ddd 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronRouter;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronRouterRequest implements INeutronRequest<NeutronRouter> {
     // See OpenStack Network API v2.0 Reference for description of
     // annotated attributes
index e026ce9b8de73140063c33d293d62b4e15c8eadb..865b5c6ae68451dae8d1ed435520cde7563e89a6 100644 (file)
@@ -7,6 +7,7 @@
  */
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -16,6 +17,7 @@ import org.opendaylight.neutron.spi.NeutronSFCFlowClassifier;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronSFCFlowClassifierRequest implements INeutronRequest<NeutronSFCFlowClassifier> {
     // See OpenStack Networking SFC (networking-sfc) API v1.0 Reference for description of
     // annotated attributes
index 910085c62e959c2271281feb3e0d06d179b82aa5..5a6eba03e3b2764c11cd665eb2bbbb0fee24b5e0 100644 (file)
@@ -7,6 +7,7 @@
  */
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -16,6 +17,7 @@ import org.opendaylight.neutron.spi.NeutronSFCPortChain;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronSFCPortChainRequest implements INeutronRequest<NeutronSFCPortChain> {
     // See OpenStack Networking SFC (networking-sfc) Port Chain API v1.0 Reference
     // for description of annotated attributes
index 844e4458020225c26c33dd4834601103d059edf6..d54cecb99cfed7e3c57ea3a6a19f48b98cdf03e2 100644 (file)
@@ -7,6 +7,7 @@
  */
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -16,6 +17,7 @@ import org.opendaylight.neutron.spi.NeutronSFCPortPairGroup;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronSFCPortPairGroupRequest implements INeutronRequest<NeutronSFCPortPairGroup> {
     // See OpenStack Networking SFC (networking-sfc) Port Pair Group API v1.0 Reference
     // for description of annotated attributes
index 587fd06d8a18f2bb52c7276cf6ae81f4d9f71aa8..30382fd85ed723f1a71d3592995b2557182e3c7e 100644 (file)
@@ -7,6 +7,7 @@
  */
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -16,6 +17,7 @@ import org.opendaylight.neutron.spi.NeutronSFCPortPair;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronSFCPortPairRequest implements INeutronRequest<NeutronSFCPortPair> {
     // See OpenStack Networking SFC (networking-sfc) Port Pair API v1.0 Reference
     // for description of annotated attributes
index 0a8771bd3fcdd892fa4bf556068e4be870bd0ec6..3ef3e40f90f8b2239e97adc044cf36ef6170d97f 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronSecurityGroup;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronSecurityGroupRequest implements INeutronRequest<NeutronSecurityGroup> {
     /**
     * See OpenStack Network API v2.0 Reference for a
index da12fd38a3c8e7de4de88f73a6f6d62c636db130..ec91da7350138b752a2d8886d5f447f1458f8de8 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronSecurityRule;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronSecurityRuleRequest implements INeutronRequest<NeutronSecurityRule> {
     /**
      * See OpenStack Network API v2.0 Reference for a
index 2a5806c0a5680478d88eaefddf98b2d136df2dc0..aebf5454b8654845193f4fa2fc145f3a79918498 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronSubnet;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronSubnetRequest implements INeutronRequest<NeutronSubnet> {
     // See OpenStack Network API v2.0 Reference for description of
     // annotated attributes
index d124d821a051c871b08d007800cc09c10d7ae048..b09e1e97e36f4841a52f105e8daa7e58e0b30f5a 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronTapFlow;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronTapFlowRequest implements INeutronRequest<NeutronTapFlow> {
     @XmlElement(name = "tap_flow")
     NeutronTapFlow singleton;
index 456e5dd2b8e95cc8a913343fc0134bb3238f8183..98335293205dbaebe24b13a8103a8384353e713d 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronTapService;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronTapServiceRequest implements INeutronRequest<NeutronTapService> {
     @XmlElement(name = "tap_service")
     NeutronTapService singleton;
index 884611152cb817a55359a508cdf00d7325b74033..4e925eb3169ebf0fd50e893f606c2503726c8eb1 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronTrunk;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronTrunkRequest implements INeutronRequest<NeutronTrunk> {
 
     @XmlElement(name = "trunk")
index 3ab9b90b68e8bf7dfefdc89d390312d7b30d381e..e46a368e0073d85b62689f7c31e6cb27c4c40a1f 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronVpnIkePolicy;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronVpnIkePolicyRequest implements INeutronRequest<NeutronVpnIkePolicy> {
     @XmlElement(name = "ikepolicy")
     NeutronVpnIkePolicy singleton;
index 276293d6cb465e706daa8abd3de6fc0b2ea37a3b..07fafda9f43a8f6c7ba96776e0449db2039410a4 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronVpnIpSecPolicy;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronVpnIpSecPolicyRequest implements INeutronRequest<NeutronVpnIpSecPolicy> {
     @XmlElement(name = "ipsecpolicy")
     NeutronVpnIpSecPolicy singleton;
index c632aea811e667e60eca1efc456c74fcdd87458a..a2337bc605c526b15bd54b19d191a5f5f4d66759 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronVpnIpSecSiteConnection;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronVpnIpSecSiteConnectionRequest implements INeutronRequest<NeutronVpnIpSecSiteConnection> {
     @XmlElement(name = "ipsec_site_connection")
     NeutronVpnIpSecSiteConnection singleton;
index 809a354c9527d222d96ca869f0b309d15eab4dd3..374a6d44ee70a6bfbdf4042ddb457e98b59bddc7 100644 (file)
@@ -8,6 +8,7 @@
 
 package org.opendaylight.neutron.northbound.api;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
@@ -17,6 +18,7 @@ import org.opendaylight.neutron.spi.NeutronVpnService;
 
 @XmlRootElement
 @XmlAccessorType(XmlAccessType.NONE)
+@SuppressFBWarnings("URF_UNREAD_FIELD")
 public final class NeutronVpnServiceRequest implements INeutronRequest<NeutronVpnService> {
     @XmlElement(name = "vpnservice")
     NeutronVpnService singleton;
index 12953631291b41184281136a6ef55e68f37edda4..78ae301c6600c6ee98d4e4fe9e46d0a6606e83eb 100644 (file)
@@ -21,12 +21,8 @@ import org.opendaylight.neutron.spi.NeutronSubnet;
 
 public final class PaginatedRequestFactory {
 
-    private static final Comparator<INeutronObject> NEUTRON_OBJECT_COMPARATOR = new Comparator<INeutronObject>() {
-        @Override
-        public int compare(INeutronObject o1, INeutronObject o2) {
-            return o1.getID().compareTo(o2.getID());
-        }
-    };
+    private static final Comparator<INeutronObject<?>> NEUTRON_OBJECT_COMPARATOR =
+        (o1, o2) -> o1.getID().compareTo(o2.getID());
 
     public static class PaginationResults<T extends INeutronObject<T>> {
         List<T> collection;
@@ -38,8 +34,9 @@ public final class PaginatedRequestFactory {
         }
     }
 
-    private static final class MarkerObject extends NeutronObject<MarkerObject>
-            implements INeutronObject<MarkerObject> {
+    private static final class MarkerObject extends NeutronObject<MarkerObject> {
+        private static final long serialVersionUID = 1L;
+
         private final String id;
 
         MarkerObject(String id) {
index 67eafbd237dd83339c36614f2afc85cb5b87e107..3bbcdb486c4d73fbfa4558dbf00d27f56f1e86f7 100644 (file)
@@ -43,7 +43,7 @@ public final class NeutronL2gatewayConnectionInterface
             result.setNetworkID(String.valueOf(l2gatewayConnection.getNetworkId().getValue()));
         }
         if (l2gatewayConnection.getSegmentId() != null) {
-            result.setSegmentID(Integer.valueOf(l2gatewayConnection.getSegmentId()));
+            result.setSegmentID(l2gatewayConnection.getSegmentId());
         }
         if (l2gatewayConnection.getPortId() != null) {
             result.setPortID(String.valueOf(l2gatewayConnection.getPortId().getValue()));
@@ -63,7 +63,7 @@ public final class NeutronL2gatewayConnectionInterface
             l2gatewayConnectionBuilder.setNetworkId(toUuid(neutronObject.getNetworkID()));
         }
         if (neutronObject.getSegmentID() != null) {
-            l2gatewayConnectionBuilder.setSegmentId((neutronObject.getSegmentID()));
+            l2gatewayConnectionBuilder.setSegmentId(neutronObject.getSegmentID());
         }
         if (neutronObject.getPortID() != null) {
             l2gatewayConnectionBuilder.setPortId(toUuid(neutronObject.getPortID()));
index bed0b6dea63484d04d24e718259f5d385007cf93..a8658dc3116eb7914f066bedf15c4a3f3803de79 100644 (file)
@@ -47,7 +47,7 @@ public final class NeutronL2gatewayInterface
                 final NeutronL2gatewayDevice neutronL2gatewayDevice = new NeutronL2gatewayDevice();
                 final List<NeutronL2gatewayDeviceInterface> neutronL2gatewayDeviceInterfaces = new ArrayList<>();
                 if (device.getDeviceName() != null) {
-                    neutronL2gatewayDevice.setDeviceName(device.getDeviceName().toString());
+                    neutronL2gatewayDevice.setDeviceName(device.getDeviceName());
                 }
                 if (device.getUuid() != null) {
                     neutronL2gatewayDevice.setID(device.getUuid().getValue());
@@ -59,7 +59,7 @@ public final class NeutronL2gatewayInterface
                         String interfaceName = null;
                         final List<Integer> segmentationIds = new ArrayList<>();
                         if (deviceInterface.getInterfaceName() != null) {
-                            interfaceName = deviceInterface.getInterfaceName().toString();
+                            interfaceName = deviceInterface.getInterfaceName();
                         }
                         if (deviceInterface.getSegmentationIds() != null) {
                             for (final Integer segmentId : deviceInterface.getSegmentationIds()) {
index 959e2cce4e8462453d71ecae4d3027fc7494ac7c..71f9f821674212036b6367d4b44558d60b01a28c 100644 (file)
@@ -63,7 +63,7 @@ public final class NeutronLoadBalancerHealthMonitorInterface
             healthmonitorBuilder.setHttpMethod(healthMonitor.getLoadBalancerHealthMonitorHttpMethod());
         }
         if (healthMonitor.getLoadBalancerHealthMonitorMaxRetries() != null) {
-            healthmonitorBuilder.setMaxRetries(Integer.valueOf(healthMonitor.getLoadBalancerHealthMonitorMaxRetries()));
+            healthmonitorBuilder.setMaxRetries(healthMonitor.getLoadBalancerHealthMonitorMaxRetries());
         }
         if (healthMonitor.getLoadBalancerHealthMonitorPools() != null) {
             final List<Uuid> listUuid = new ArrayList<>();
@@ -103,7 +103,7 @@ public final class NeutronLoadBalancerHealthMonitorInterface
             answer.setLoadBalancerHealthMonitorHttpMethod(healthMonitor.getHttpMethod());
         }
         if (healthMonitor.getMaxRetries() != null) {
-            answer.setLoadBalancerHealthMonitorMaxRetries(Integer.valueOf(healthMonitor.getMaxRetries()));
+            answer.setLoadBalancerHealthMonitorMaxRetries(healthMonitor.getMaxRetries());
         }
         if (healthMonitor.getPools() != null) {
             final List<NeutronID> list = new ArrayList<>();
index 4808007bbc9255149e2b6f1dbce2814362695da4..63d4d1ce280f13c67c67c03dd4ad2c2642539cea 100644 (file)
@@ -76,10 +76,10 @@ public final class NeutronSecurityRuleInterface extends
             answer.setSecurityRuleEthertype(ETHERTYPE_MAP.get(rule.getEthertype()));
         }
         if (rule.getPortRangeMin() != null) {
-            answer.setSecurityRulePortMin(Integer.valueOf(rule.getPortRangeMin()));
+            answer.setSecurityRulePortMin(rule.getPortRangeMin());
         }
         if (rule.getPortRangeMax() != null) {
-            answer.setSecurityRulePortMax(Integer.valueOf(rule.getPortRangeMax()));
+            answer.setSecurityRulePortMax(rule.getPortRangeMax());
         }
         return answer;
     }
@@ -119,10 +119,10 @@ public final class NeutronSecurityRuleInterface extends
                     .setEthertype(mapper.get(securityRule.getSecurityRuleEthertype()));
         }
         if (securityRule.getSecurityRulePortMin() != null) {
-            securityRuleBuilder.setPortRangeMin(Integer.valueOf(securityRule.getSecurityRulePortMin()));
+            securityRuleBuilder.setPortRangeMin(securityRule.getSecurityRulePortMin());
         }
         if (securityRule.getSecurityRulePortMax() != null) {
-            securityRuleBuilder.setPortRangeMax(Integer.valueOf(securityRule.getSecurityRulePortMax()));
+            securityRuleBuilder.setPortRangeMax(securityRule.getSecurityRulePortMax());
         }
         return securityRuleBuilder.build();
     }