Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Ib07b2546170bf31f393e3a4e92208d8fa93bebba

Bump odlparent/yangtools/mdsal to 4.0.14/2.1.14/3.0.13

Adopts upstream upgrades and fixes.

Change-Id: I14c1f3f3420f20c5a0dc090fb4941e3435afd812
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent-4.0.13/yangtools-2.1.13/mdsal-3.0.7

This picks up latest upgrades and fixes.

Change-Id: Ic268f6fa4ccd963af771c39dbcf6a5b455e353b5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I060c3125b51da5b961fafae6937a06c4dad13f32

Bump mdsal to 3.0.10

This brings in latest fixes/improvements.

Change-Id: Ida49ef543f765fd8f828761d7804e5b51a93b1b3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 3.0.9

This picks up latest fixes and improvements.

Change-Id: Ic926c6016b4463933a289878587f6748bb2e8455
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 4.0.11

This adopts latest upgrades.

Change-Id: I4a31d25a13f7aa88b6d221bf3e7715a6f06b2bb9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.y.(z+1)

Change-Id: I0104e47ffa1a097226daf7a8d4acb2d8799c58e1
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Bump mdsal to 3.0.8

This brings in latest fixes and enhancements.

Change-Id: If168277b488c5a12c349452a4db94499522566a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 4.0.10

This brings in latest updates.

Change-Id: I4e403cecccbc25f33d4f16483c6ca517ff97de5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.y.(z+1)

Change-Id: If88fdb0b4e8765bc45ae86a090036efc86d49747
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Update .gitreview to stable/neon

Change-Id: I0d55908b0e0dfba5aa4156a356ab9a7a163e5b8e
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Adjust to the ovsdb MdsalUtils change

ovsdb’s MdsalUtils switched to the mdsal DataBroker, to continue using
the controller DataBroker we need to switch to ControllerMdsalUtils.

Change-Id: I502f2a7bea412f35c84c69d991d8a91e90aee7ec
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Bump mdsal to 3.0.6"

Bump mdsal to 3.0.6

This aligns with odlparent-4.0.9 and yangtools-2.1.8.

Change-Id: I16645d4f375df632d67ddc26cd375dd11ba604cb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump to odlparent 4.0.9

Change-Id: I955f4b8ac971070ea29d6e48aaf377a17b393921
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Migrate enunciate annotations

Enunciate has moved from org.codehaus to com.webcohesion, upgrade
the annotations to their new place.

Change-Id: Ia6665da922e63a6a77ef7e1984ef20277e79a20f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Bump mdsal to 3.0.4"

Merge "Bump to odlparent 4.0.8"

Bump mdsal to 3.0.4

This realigns odlparent/yangtools/mdsal and brings in the latest
improvements. Also remove unneeded version declarations.

Change-Id: I166861805b5a70ca83753a2b36067d1f4d427adc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent 4.0.8

Change-Id: I6b62bee4b1d6af23960d453bd747db7b2caf6278
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix standalone test with JDK11

javax.activation is no longer part of JDK in Java9+, add it as
an explicit dependency.

Change-Id: I6ce3df30f06188958d454484c42b904e74020333
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix JDK11 deprecations

Explicit integral constructors have been deprecated, as was
Class.newInstance(). Adjust to that.

Change-Id: Ia78e6a0347c2b0264afc722f00acc716899e661f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix compilation with JDK11

This adds javax.activation and JAXB dependencies as needed.

Change-Id: I466c9ee11aef7e14686bfb02da2c95e5f2640331
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 4.0.7

Change-Id: Ic41cf08373e99ee65a631ee79720d02eb9e1a3cd
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump mdsal to 3.0.3

This brings in latest fixes and alignes with odlparent-4.0.5.

Change-Id: Ie852cb085db8a78c7722ef45646ce950900e6926
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent 4.0.5

Change-Id: If17faeb6c6378666dd0d8a0ff4e6191bb930ea45
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add service-provider-feature for bgpvpn-vni

This feature is added to communicate to OpenDaylight driver that vni
attribute is supported in bgpvpn resource in OpenDaylight.

This review depends on the following reviews.
https://git.opendaylight.org/gerrit/#/c/63405/
https://git.opendaylight.org/gerrit/#/c/77250/
https://review.openstack.org/#/c/614428/

Change-Id: I3bfb0b7844455fb908955d3949e52b71125c7826
Signed-off-by: Ashik Alias <ashik.alias@ericsson.com>

Support for vni attribute in BGPVPN

- This change renames vnid attribute to vni
Change in openstack: https://review.openstack.org/#/c/505496/
- vni attribute was introduced during Queens release of openstack
and was not used previously. Hence this change will not impact use of ODL
with older version of networking-bgpvpn.

Change-Id: I6927b9b4a51d373d19b8a14d535611ae15c4b575
Signed-off-by: Ashik Alias <ashik.alias@ericsson.com>
Signed-off-by: Deepthi V V <deepthi.v.v@ericsson.com>

Bump to mdsal-3.0.2

This bumps mdsal to 3.0.2.

Change-Id: Ic0b2a217da235a4f532b1916ccea1253ad96a1df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Neutron MTU extension in network model"

enable SpotBugs

incl. fixing wrong logger in NeutronObject and missing placeholders in
logs of NeutronHostconfigOvsListener and NeutronHostconfigVppListener.

Change-Id: If61b3cdfd59f92689937e219490f813e73084c3e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

use LOG.isInfoEnabled() in (expensive!) NeutronLogger

and add @SuppressFBWarnings("SLF4J_FORMAT_SHOULD_BE_CONST")
to prepare for enabling SpotBugs for all of Neutron.

Change-Id: Ic548ddcdfe65bc7aa40b4fd53716aef5a8d8bc7c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Neutron MTU extension in network model

1)adds the model for Neutron MTU.
2)Populates a the MTU extension and augment it  to neutron network

Change-Id: Ib11a78eeed7cda529197164e42b3b9f94dbc4366
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>

Restore odl-infrautils-inject dependency

This partially reverts 946fd9e3c7700dbd0df9924a70c0fa5477db981e

odl-neutron-northbound-api ends up pulling in javax.inject, so the
dependency on odl-infrautils-inject is warranted.

Change-Id: I8344609aacb4453e48af4290ca76c8c94c3c02fb
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "improve error logs due to IllegalArgumentException to include full input"

Merge "clean up post Neon-MRI: un-ignore Test and rm blueprint-maven-plugin"

minor clean-up after previous change

Change-Id: I524dd9b77722a9ffdef0551e85f2fdaa18b17f7b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Websocket pre-registration for port status update

Due to load balancing between networking-odl
and ODL the registration REST calls do not
always hit the same ODL node as the actual
websocket connection. This causes the websocket
connection to fail. This patch pre-registers
the websockets on each ODL node during
initialization time.

Change-Id: I0b1f574c2735de0426a16c4473add99f2e512680
Signed-off-by: Josh <jhershbe@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

improve error logs due to IllegalArgumentException to include full input

This requires, and adds, a working toString() for all *Request classes,
which is always useful for future logging of requests elsewhere.

This introduction of a NeutronRequest (an ABC instead of an interface)
could in the future also allow a follow-up change to get rid of the
reflection in INeutronRequest, by having a (generic) "singleton" and a
"bulkRequest" field in NeutronRequest instead of in each *Request class.
(The problem with that idea, and why it is how it currently is, are the
@XmlElement annotations for singleton and bulkRequest in each *Request;
those would have to be moved to new getters.)

Change-Id: I9769a3825632dd2bd2f9e2875b91d06a4f781616
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "minor simplification in INeutronRequest"

clean up post Neon-MRI: un-ignore Test and rm blueprint-maven-plugin

xbean-finder-shaded version bump work around should no
longer be needed now that we are on odlparent 4.0.2.

JIRA: ODLPARENT-167
Change-Id: I909cff034aa996c1e4285960ddcdd30c8d0386fa
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Restore duplicate check

With the recent odlparent and yangtools bumps in Neon, the
handling of jaxb-api and activation changed; for features, this is
dealt with by excluding the relevant artifacts from generated
features, but other tests end up with duplicates since the artifacts
include classes which are also present in the JVM’s rt.jar.

This patch excludes jaxb-api and activation, and restores the
duplicate check.

JIRA: INFRAUTILS-59
Change-Id: Ifa8f0fd86c8b65655cc50261f198d3deb2411499
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 4cfb487ceacbe9a21b845f98d4f01b59e0e94926)

minor simplification in INeutronRequest

let isSingleton() delegate to getSingleton()

PS: Looking at this, I have an idea for a more fundamental improvement.

Change-Id: I84d87f9d687af213f08b89dd5fe6c6a3f5044e05
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Neon MRI changes

incl. adjusting an already more outdated odlparent version
features/production/odl-neutron-model/pom.xml

based on https://wiki.opendaylight.org/view/Neon_platform_upgrade

This was a huge mess due to EclipseLink Moxy & javax.json; perhaps more
to be done about this in the future, see NEUTRON-200.

JIRA: NEUTRON-197
Change-Id: I9b00ba0badaecb299e7d79b92feedf27fabe4fb8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add an exception mapper

Change-Id: I16a73b43627e09b4bbebbf6fbb467e572ad61d30
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

make tenantID in NeutronObject a private field and use through getter()

just... to be sure - re. the NEUTRON-159 mess.

JIRA: NEUTRON-159
Change-Id: I763016a1d535e9778d4497389f190be7227e690c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

use an EmptyStringAsNullAdapter in NeutronObject re. null tenant_id

perhaps in JAXB it's better to place such special empty/null logic in
such an adapter instead of directly into the getter.. at worst, it
shouldn't hurt.  See also some public posts re. this in general, e.g.
https://stackoverflow.com/questions/10869748/jaxb-return-null-instead-empty-string

background: https://bugs.opendaylight.org/show_bug.cgi?id=4775 (and its
old https://git.opendaylight.org/gerrit/#/c/31324 and
https://git.opendaylight.org/gerrit/#/c/31361/)

JIRA: NEUTRON-159
Change-Id: I47ec8270ba42e787d21adff51d89052c4442f2b7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

fix JAXB usage/design bug in NeutronObject re. null tenant_id

@XmlElement on a (package visible..) field and then special logic in the
getter was perhaps an unholy combination.  I can't quite explain why it
worked most of the time but not always.  One would think that the tests
going through the getter should also execute that special logic, but
alas, clearly in some of the test runs (and perhaps in production...)
they did not, see the recurring NEUTRON-159 problem.

background: https://bugs.opendaylight.org/show_bug.cgi?id=4775 (and its
old https://git.opendaylight.org/gerrit/#/c/31324 and
https://git.opendaylight.org/gerrit/#/c/31361/)

JIRA: NEUTRON-159
Change-Id: I986dc6f4bea2f08becea21936bedd831643d212e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Return Set instead of Iterable in test

Method signature will be changed to Set to define equality, prepare
for that.

Change-Id: I9f0bf9a40b6082de5fb7d651dafe9c3b1f32f0af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Remove references to mdsal-model-artifacts"

Merge "add dependency check for qosPolicyId to NeutronNetworkInterface"

Remove references to mdsal-model-artifacts

This artifact is going away, migrate to mdsal-artifacts.

Change-Id: Ib70f055d3cfd85aacaa294789f1eb09f01fa637e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.(y+1).z for next dev cycle

Change-Id: Ic377f1c6fcdf2a131bdc679ec4b42dfc5244e27d
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

add dependency check for qosPolicyId to NeutronNetworkInterface

JIRA: NEUTRON-178
Change-Id: I50c668659ad87bc53f370f584408867dc0625f70
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "suppress warn log if replying 500 just for OptimisticLockFailedException"

Bump to odlparent 3.1.3

Change-Id: I1e7e61333d8ed6c5535e98129662410761de414f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use moved BindingReflections

BindingReflections are being evacuated from yang-binding, use them
from their new location.

Change-Id: Ib2d132dc43d70e46491b5043595ec77e528a570d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Migrate to stringValue()"

suppress warn log if replying 500 just for OptimisticLockFailedException

Change-Id: Ia311b340e993f5210223f11616a7d1fac70c66ad
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Migrate to stringValue()

This eliminates the use of char[]-based instantiation and conversion.

Change-Id: Ic9024531f138e52848fd0531c9a4d479b120af86
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Factor out odl-neutron-model

The model is being packaged by two features, create a feature
to hold it.

Change-Id: I48fc29f823bb8f6e004cc207f6813e0e9711e83b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Depend on minimal mdsal models

Rather than pulling all the models available, just pull in the
minimum required.

JIRA: MDSAL-363
Change-Id: Ifebc7fd2253faa36e0b60dbc4bdd6a99df06a50b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

add missing warn log to AbstractNeutronNorthbound for 442

In I2c55e707c9d48f78fd60a8e22af6a799976d86bf this was only done for the
bulk operation code path, but forgotten for the single create.

Change-Id: I15943679a9a2ff40de84ba43a01233869465acf9
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Revert "bump EclipseLink Moxy JAXB implementation from 2.6.2 to 2.7.1"

This reverts commit d40a0ef257d79fc3a3b21dede57da65ca36e0ab4.

because just a few months after I38f0285643ca0a1aea99a5e7f9e2b158bb86168c
we finally have an odlparent (3.1.2) which includes that and which neutron
meanwhile bumped to; we therefore don't need to override the version here anymore.

Issue: NEUTRON-160
Change-Id: I04e9b69389dd33c785a5165eb3e72016b76b56cc
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

return HTTP_CONFLICT (409) from POST create() in case of AlreadyExists

see https://lists.opendaylight.org/pipermail/neutron-dev/2018-June/001702.html

Change-Id: Idd0d65e720d209afbf993db2c202b7710ef6c9db
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

add warn log with cause to AbstractNeutronNorthbound for 442 and 500

Just in case the Neutron Driver does not log what we propagate to it
nicely for operators to find in debugging, it perhaps does not hurt if
we put a WARN log on the ODL side in case of problems due to both the
new dependency check mechanism and datastore exceptions propagate
(including mandatory YANG validation).

JIRA: NEUTRON-157
Change-Id: I2c55e707c9d48f78fd60a8e22af6a799976d86bf
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

make security group rule ID mandatory in YANG model

To simplify the dependency check - it is not really the role of the new
areAllDependenciesAvailable() method to enforce required properties
programmatically - doing that declaratively in the YANG model is the
ODL way.

This lets us re-activate a test which covers this scenario which we had
to temporarily comment out in the previous to previous commit for "add
dependency check for security rule's group update(), not just add()";
we need the previous commit re. "propagate datastore exceptions all the
way to northbound" for YANG mandatory constraints to actually have any
effect (because before that, we basically just stupidly ignored ANY
problem when commiting the transaction!).

Changing this also reveals a subtle mistake in an existing test:
Modifying an existing entity without required fields is not actually
working / supported (never was; it's not that this break it) - an MD SAL
put() is does *NOT* apply a delta, but replaces the existing object.  A
few Neutron Northbound classes override the updateDelta() method of
AbstractNeutronNorthbound with custom logic which seems to attempt to
"compensate" for this be doing e.g. delta.setID(uuid); etc. but this is
implemented inconsistently in existing code (e.g. many including the
NeutronSecurityRulesNorthbound do not do this).

Many more fields in the model which in truth are mandatory should
ideally be so declared in follow-up changes imitating this one now.

JIRA: NEUTRON-158
Change-Id: I077906a682225ac87caf1c4c933f01bdf40c1353
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

propagate datastore exceptions all the way to northbound

Instead of logging but ultimately ignoring them, as they currently are.

Stumbled across this wile working on (not directly related) NEUTRON-158.

This will also fix the problem raised in NEUTRON-157: We are,
intentionally, changing the OptimisticLockFailedException WARN log to a
DEBUG only.  If it still didn't go through after RETRY_MAX (currently 2)
then it will be rethrown, and that, with this, will go back up to the
driver.

JIRA: NEUTRON-157
Change-Id: I10b7dea0b5698db40ee7cfaa63593fb6b3c573c7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

add dependency check for security rule's group update(), not just add()

JIRA: NEUTRON-158
Change-Id: I249d8a3898641baaf9b92699da41eac523a22b36
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump odlparent to 3.1.2

Change-Id: I472712975bfbc783649310e40252d8005b2249e3
Signed-off-by: Stephen Kitt <skitt@redhat.com>

clean-up to remove un-used three WebApplicationException subclasses

and minor JavaDoc clean up in the two remaining ones

The removed null check in NeutronRoutersNorthbound is (now) pointless.

Change-Id: If3bfac610b1dc9563651ac8bba3513e58637265f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

remove apparently un-used methods in AbstractTranscriberInterface

These methods seems left overs; they have functionality comparable to
other existing methods which are actually used, but these do not have
the dependency checks hooks I've added; so just remove them:

* addMd()
* updateMd()
* removeMd()

JIRA: NEUTRON-158
Change-Id: If53bb7bce6c9cfcc2bd9fa640de3fd11e76c6513
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

use (new) INeutronCRUD.Result instead of boolean in update()

JIRA: NEUTRON-158
Change-Id: Ia94844c13f823ae169ae8e2295b3d4f89c2f3b91
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

improve NeutronSecurityRuleTests to cover 404 on modify of non-existant

in preparation of supporting 442 not just for create but also modify.

JIRA: NEUTRON-158
Change-Id: I84c1656fdd84d9e1e6adf5f10a4ccb5414507ced
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "implement dependency checking for security rule's group"

clean up features

avoid bundle dependencies to other projects in features.xml;
instead depend on the features of the projects that provide
those as dependencies.

see https://lists.opendaylight.org/pipermail/neutron-dev/2018-June/001693.html

Change-Id: Ia4c7c4a8f9acded8cd1c5e6e985005644831ef0d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

add myself to <developer> in POM ;)

Change-Id: Ia2d8b662d028c1f637fb67077f3788bb9e6eb20c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

implement dependency checking for security rule's group

JIRA: NEUTRON-158
Change-Id: Ie0454543f7a5707aac6eb1583b3fd3ec55cbdfe1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

add transaction to exists()

make AbstractTranscriberInterface exists() public

This allows one *Interface implementation (say
NeutronSecurityRuleInterface) to check for the existence of others (say
NeutronSecurityGroupInterface) in dependency checks.

JIRA: NEUTRON-158
Change-Id: I351c219f6784180aa918c818fd10bd1cca85afc3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

introduce INeutronCRUD.Result, instead of boolean

and for now use it in add(T input), later remove() & update().

A future follow-up change will extend INeutronCRUD.Result with a 4th
additional enum value to signal "DependencyMissing" to callers.

JIRA: NEUTRON-158
Change-Id: I5f312008b899862e4957c0ab950b4939fd5b7369
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

QoS: Add support for direction

* Add direction support for Bandwidth Limit rules

JIRA: NETVIRT-1242
Change-Id: I3a42344e909213ba6af10f5b7d7250ad7a8213b7
Signed-off-by: Vishal Thapar <vthapar@redhat.com>

Merge "Fixup Augmentable and Identifiable methods changing"

Merge "NEUTRON-162: vlan_transparent attribute is missing in network_attributes"

TSC-115: Fix MinimumBandwidthRule direction

minimumbandswidth-rule-attributes has wrongly
defined direction to be constants:direction-minimum-base.
constants:direciton-minimum-base is not reqired at all
as there are already ingress/egress defined.

Changes it to remove the redundant and wrong yang attribute
and fix rest of the code to use the correct direction classes.

Change-Id: I93febb29a77aa19428a3211eaf1712d84388a7d7
JIRA:NEUTRON-163
Signed-off-by: Vishal Thapar <vthapar@redhat.com>

Fixup Augmentable and Identifiable methods changing

This is a fixup of the change in binding codegen, adjusting:
- getKey() -> key()
- setKey() -> withKey()
- getAugmentation() -> augmentation()

Change-Id: I449489503c6c9811b7b1fe97eabbe37b46ab7473
JIRA: TSC-101
Signed-off-by: Stephen Kitt <skitt@redhat.com>

convert to Jersey 2

Modified the WebInitializer to use the new AAA Servlet API based on Jersey 2.

JIRA: TSC-113
Change-Id: I1c495087c278debec6e04a6cf920ca10632dd3f7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

reduce copy/paste between HttpUtils's test_create() methods

Change-Id: I2eed44ead7b7b05f6b178c5a0b34b9641c223615
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

singleton_sg_create(String securityGroupID) in NeutronSecurityGroupTests

and make all _test methods in NeutronSecurityGroupTests private

Change-Id: I1f53a8a30be4d9c0c86d5291fe95d70261aec97e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

make all _test methods in NeutronSecurityRuleTests private

only constructor and public runTest() method are used by NeutronAllTests

TBD in follow-up changes: apply same to all *Tests classes

Change-Id: Iee66ab307bbc2b5a46e3218dff1f22e1bda17941
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "Add feature identity for qos rule types"

NEUTRON-162: vlan_transparent attribute is missing in network_attributes

Added support for vlan_transparent in network_attributes

Change-Id: I9006f3a63baa8edf9d72eafef866793451720036
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>

NETVIRT-1121: Add IGMP Protocol types

Add IGMP Protocol type definitions to neutron.

Change-Id: I2be35241b2732852a6e22cffeba35567b2a03d35
Signed-off-by: Victor Pickard <vpickard@redhat.com>

Remove AbstractDataChangeListenerTest derivation

AbstractDataChangeListenerTest is going away so change
HostconfigsDataBrokerTest to derive from AbstractConcurrentDataBrokerTest.

Change-Id: I5b0feabc70b9cafee7104857f569d5cdc87ba368
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Add feature identity for qos rule types

This patch is preperation for supporting some
qos features and more specifically the feature
negotiation of those features.

See https://review.openstack.org/#/c/558554/ for details.

Change-Id: I18423ba66cd62b1b099c81cb545412a317a8520c
Signed-off-by: Josh <jhershbe@redhat.com>

Revert "Add Karaf build profile"

This reverts commit 8a28ebe52608c50ca2dfdf8e79698b05f0f91176.

Per Thanh here: https://git.opendaylight.org/gerrit/#/c/70537/

Change-Id: I58b8f10abb428a9fca39b27a9258697fde3c016e
Signed-off-by: Josh Hershberg <jhershbe@redhat.com>

Merge "comment out integration/test ITNeutronE2E"

comment out integration/test ITNeutronE2E

until we can figure out how to make it always pass

because it fails more often than not, see e.g.
https://lists.opendaylight.org/pipermail/neutron-dev/2018-April/thread.html
because Pax Exam based OSGi Integration Tests (IT)
just don't seem to be work reliably enough for us.

The equivalent new non-IT NeutronE2ETest introduced
in I9a2bcb8d6bb095993eec64714648944b25bcaaa4 can take the
place of ITNeutronE2E for future development in neutron.

Change-Id: I92068073b20d199fa2e71421d99b160224177fbc
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump EclipseLink Moxy JAXB implementation from 2.6.2 to 2.7.1

This is done (a) in the hope it may help with the weird spurious
test failures seen in NEUTRON-159, and (b) because it's generally
not a bad idea to bump versions of 3rd-party dependencies in major
releases.

Issue: NEUTRON-160
Change-Id: I27c44479d0755ae30eb191bff6f275033ff31fe3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

remove org.osgi.core dependencies which are now no longer required - yay!

Change-Id: I4f2ad5e86f622537554b3df308dc02557c83a09e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>