summary |
shortlog | log |
commit |
commitdiff |
review |
tree
first ⋅ prev ⋅ next
Tejas Nevrekar [Mon, 3 Aug 2020 06:41:08 +0000 (06:41 +0000)]
Merge "Add committers as Ravi and Nikhil"
Tejas Nevrekar [Sat, 25 Jul 2020 04:03:42 +0000 (09:33 +0530)]
Add committers as Ravi and Nikhil
Signed-off-by: Tejas Nevrekar <tejas.nevrekar@gmail.com>
Change-Id: Ie6134d600761b85c789ec73c4e65a1779cf5f0a7
VenkataSatya Jonnadula [Wed, 29 Jul 2020 08:53:23 +0000 (14:23 +0530)]
Guice extensions are not added to artifacts.
The following guice extensions are not added as a part of artifacts.
inject.guice.extensions.closeable
inject.guice.extensions.injection
inject.guice.extensions.closeable
JIRA: ODLGUICE-8
Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: Icf66334e542351b7c187acdc44dcb3fac7a4f689
VenkataSatya Jonnadula [Thu, 23 Jul 2020 16:18:02 +0000 (21:48 +0530)]
Change all the package names from infrautils to odlguice
Change all the package names from infrautils to odlguice
JIRA: ODLGUICE-6
Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: Iac1d721ee9a6d6d8587ff64cb4efcbfa5563d722
Tejas Nevrekar [Thu, 23 Jul 2020 15:35:35 +0000 (15:35 +0000)]
Merge "Add Mycilla code to odlguice"
VenkataSatya Jonnadula [Fri, 17 Jul 2020 03:32:15 +0000 (09:02 +0530)]
Add Mycilla code to odlguice
Add the mycila-guice implementation from github to odlguice.
The odl-micro uses Guice as a DI framework. However, there
are a few extensions needed to Guice to support things like
object lifecycle hooks via jsr250 and CloseableInjector.
Looking at the commit history https://github.com/mycila/guice,
the last commit was ~3 years ago. There have been concerns
raised on its supportability in the past. Adding this code to
ODL allows the community to still benefit from these Guice
extensions and reduce the impact of recent inactivity in
the mycila project.
JIRA: ODLGUICE-5
Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: I139a24e38b58e43cf84ea2e0571444ed9b79520f
Anil Belur [Sun, 12 Jul 2020 01:06:12 +0000 (11:06 +1000)]
Add INFO.yaml for odlguice
Change-Id: I3c731e8cc9e56cdc494fb53e20b4f77a36b6bf97
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Tejas Nevrekar [Fri, 17 Jul 2020 03:52:49 +0000 (03:52 +0000)]
Merge "Add Infrautils guice inject code to odlguice"
VenkataSatya Jonnadula [Mon, 13 Jul 2020 14:34:26 +0000 (20:04 +0530)]
Add Infrautils guice inject code to odlguice
This patch is to move Infrautils guice inject code to odlguice.
JIRA: ODLGUICE-2
Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: Id7d42463a55ff1a8b130d18d3edd06b6aef9abcd
Tejas Nevrekar [Thu, 16 Jul 2020 17:23:36 +0000 (17:23 +0000)]
Merge "Add .gitreview file for odlguice"
Anil Belur [Fri, 10 Jul 2020 01:44:17 +0000 (11:44 +1000)]
Move the src under folder infrautils/inject.
JSD-Ticket: IT-20068
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I6d24b4d8008ecb3702b06e50b753695a64f41bd8
Anil Belur [Wed, 8 Jul 2020 01:20:04 +0000 (11:20 +1000)]
Add .gitreview file for odlguice
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I53aee4fa3b292e0aa32ef2ef29cbb97aad3ea6a3
Anil Belur [Wed, 8 Jul 2020 01:16:49 +0000 (11:16 +1000)]
Merge branch 'master' of ../infrautils
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Anil Belur [Wed, 8 Jul 2020 00:24:18 +0000 (10:24 +1000)]
Add .gitreview file for odlguice
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I6e082cfba2de0719fb8c59b047f9cb2923562e62
Robert Varga [Wed, 10 Jun 2020 20:24:13 +0000 (22:24 +0200)]
Bump odlparent to 7.0.3
Pick up latest fixes from upstream.
Change-Id: Ia94adac077d56d048e636bd78e85c4fe312a7c5f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 30 May 2020 11:16:57 +0000 (13:16 +0200)]
Bump odlparent to 7.0.2
Pick up latest upgrades from upstream.
Change-Id: I6ba0b55a74b60624f49904be4aa78a243551b6c1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Anil Belur [Fri, 29 May 2020 05:37:20 +0000 (05:37 +0000)]
Initial empty repository
Robert Varga [Tue, 31 Mar 2020 14:38:57 +0000 (16:38 +0200)]
Bump odlparent to 7.0.1
Update odlparent in preparation for Aluminium MRI, also adopting
Guice dependency versions.
Some updates are needed around Truth, but since we are using only
primitive assert, adopt plain JUnit asserts as needed.
Change-Id: I74495579c8d9a7b867b4058d5f2430425d6b190e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
jenkins-releng [Sat, 22 Feb 2020 04:30:16 +0000 (04:30 +0000)]
Bump versions by x.y.(z+1)
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I0c4b15e27c85d09a29a9c2a150e10a3ca8a4de5a
Robert Varga [Thu, 16 Jan 2020 15:51:11 +0000 (16:51 +0100)]
Update odlparent to 6.0.4
This picks up latest updates.
Change-Id: I07249816ecd2d4252760151eba893a1761e22acb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 22 Nov 2019 09:39:57 +0000 (10:39 +0100)]
Bump to odlparent-6.0.3
This picks up the latest upgrades.
Change-Id: I8359aa6a9326ce0264d6101cb8af490b0502fcf4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 6 Nov 2019 14:08:23 +0000 (15:08 +0100)]
Bump to odlparent-6.0.1
This picks up latest upgrades and fixes.
Change-Id: I8db358b0af81394a561071d98bffea168dda47cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 21 Aug 2019 12:11:54 +0000 (14:11 +0200)]
Bump odlparent to 6.0.0
This bumps odlparent to 6.0.0 as part of Magnesium MRI.
Change-Id: I19505dd80b832cd6ed8b68daf471d9e90d3dfdd2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 21 Aug 2019 12:11:23 +0000 (14:11 +0200)]
Bump odlparent to 5.0.2
This bumps odlparent to pick up latest references.
Change-Id: Ica16c98bd6eeeb2530bdc9cee4bb7f198e4a6ab0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
jenkins-releng [Mon, 12 Aug 2019 16:14:12 +0000 (16:14 +0000)]
Bump versions by x.y.(z+1)
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Ib57798ae70c24d686e0ef66ca07aab01e94092d8
Robert Varga [Thu, 18 Jul 2019 10:32:49 +0000 (12:32 +0200)]
Bump odlparent to 5.0.1
This picks up the latest upgrades.
Change-Id: If6006a94197839a9718cd5eae16b0a025913af93
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 15 Mar 2019 15:31:14 +0000 (16:31 +0100)]
Bump odlparent to 5.0.0
This bumps the version to MRI, adding JSR305 dependencies where
needed.
Change-Id: I5d4ad0a4c31a31bd0ef36ab6adb2eade6c9fb0a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 8 Apr 2019 15:40:40 +0000 (17:40 +0200)]
Fix annotation positions
errorprone is complaining a bit about non-TYPE_USE annotations
being in the wrong place. Fix up most of the violations, omitting
@Nullable, as that is pending migration to JDT, which will fix
those warnings.
Change-Id: I3a8f076f64192b675168af462656576f085a5522
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 15 Mar 2019 16:17:36 +0000 (17:17 +0100)]
Remove post-odlparent-4.0.9 changes
javax.annotation-api version is declared by odlparent, do not
repeat it here.
Change-Id: I88518900c7c79887e8fc74276b98f02bad3133ed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
jenkins-releng [Fri, 1 Feb 2019 13:06:29 +0000 (13:06 +0000)]
Bump versions by x.y.(z+1)
Change-Id: Iad90fad64275055fb499d8382227330d53df26a5
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Robert Varga [Sun, 27 Jan 2019 18:25:27 +0000 (19:25 +0100)]
Change inject-guice-testutils packaging
This artifact should never end up being loaded into OSGi, hence
package it as a jar, not as a bundle.
Change-Id: I3db5a8c3ce191f89876d0df15f009b6da1b7cec1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 27 Jan 2019 18:25:00 +0000 (19:25 +0100)]
Fix inject-guice-testutils with Java 11
We need to have an explicit dependency on javax.annotation.
Change-Id: I932b96df8816d098738e30963852ce1751823174
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Fri, 18 Jan 2019 15:32:48 +0000 (16:32 +0100)]
Bump to odlparent 4.0.9
Change-Id: I84a781c028b0ed9e9fb3b660ef8777c319c6d51b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Sat, 22 Dec 2018 03:09:48 +0000 (04:09 +0100)]
introduce inject.guice.AutoWiringModule
It lets tests use classpath scanning based "auto-wiring" (à la Spring).
This comes out of https://github.com/vorburger/opendaylight-simple
Change-Id: I0c71be4930ec3158c1fb8213913fe693d4ccdec3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Wed, 9 Jan 2019 14:54:53 +0000 (15:54 +0100)]
Bump to odlparent 4.0.8
Change-Id: I788dc0ffa71b2728e1cdbd6650b60dd2952f1b87
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Sat, 22 Dec 2018 02:33:14 +0000 (03:33 +0100)]
let GuiceRule notify SystemReadyMonitor registered listeners
It lets tests which rely on a fully working (not stubbed)
SystemReadyMonitor implementation simply bind one by using the
ReadyModule.
This comes out of https://github.com/vorburger/opendaylight-simple
Change-Id: I64892b0fcb1bb5de4ba8689b73239781be189fef
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Thu, 3 Jan 2019 23:30:26 +0000 (00:30 +0100)]
Add javax.annotation-api dependencies
Java 11 is shipping without these, hence we need to add dependecies.
Change-Id: Ie99cc82c2c565e0539e03fdc5e64cf09d72731ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 3 Jan 2019 15:23:02 +0000 (16:23 +0100)]
Cleanup dependency structure
Our parent should import our artifacts, so we can freely refer
to them with proper versions and scope -- otherwise it is extremely
easy to leak things like infrautils-testutils to runtime.
Change-Id: I79bf9a04ec87d50e1434f317d926168980d71b69
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 1 Jan 2019 21:47:47 +0000 (22:47 +0100)]
Bump odlparent to 4.0.7
This fixes SFT/JDK11 compatibility.
Change-Id: Ibec02d9a65a7587633a423b0babc4e8fcbaf2655
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Fri, 21 Dec 2018 09:10:17 +0000 (10:10 +0100)]
Bump to odlparent 4.0.5
Change-Id: I2adeaf4ba7b3e0dac43a9685912eb9757b26ad29
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Mon, 6 Aug 2018 19:01:46 +0000 (21:01 +0200)]
Bump odlparent to 4.0.2
This bumps to Neon-targeted odlparent.
Change-Id: Id376a54639daf286aaef5486a9a82b6f762c5c3c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Anil Belur [Thu, 9 Aug 2018 12:40:15 +0000 (18:10 +0530)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: Iefeaa1909c4bcce65fac47f523e1f46c518ad8f3
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Stephen Kitt [Wed, 18 Jul 2018 16:06:39 +0000 (18:06 +0200)]
Bump to odlparent 3.1.3
Change-Id: I9b2c6f8a6b9f22c1bf64864c710f9767cc46c170
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 30 May 2018 13:43:31 +0000 (15:43 +0200)]
Bump odlparent to 3.1.2
Change-Id: Ib384fc3c04deef61b106751aac7a28791acbf8b7
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 22 Mar 2018 17:24:32 +0000 (18:24 +0100)]
Bump to odlparent 3.1.0 and yangtools 2.0.3
Change-Id: Ic40708ad8cc3f52111d0da6080e70331ed8f4dfc
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Wed, 7 Mar 2018 11:32:56 +0000 (12:32 +0100)]
add checkIsRunning() to AbstractLifecycle
Change-Id: Ic417843de7b0c736fb6a9de7ded77d652b661732
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Anil Belur [Mon, 26 Feb 2018 07:41:43 +0000 (17:41 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I43d4438c6e1c8f4756cc9bfb08bb8d7b45fdade7
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Stephen Kitt [Wed, 6 Dec 2017 12:39:33 +0000 (13:39 +0100)]
Adjust for odlparent 3
* Update Karaf dependencies.
* Update feature dependencies (odl-guava-23).
Change-Id: I56fc628b26d51a9b1342249f363142cf64282af7
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 19 Dec 2017 04:26:21 +0000 (05:26 +0100)]
Make x3 more useful error-prone rules errors instead of warnings
* http://errorprone.info/bugpattern/IntLongMath
* http://errorprone.info/bugpattern/FloatCast
* http://errorprone.info/bugpattern/ClassNewInstance
* http://errorprone.info/bugpattern/ConstructorInvokesOverridable
* http://errorprone.info/bugpattern/ThreeLetterTimeZoneID
* http://errorprone.info/bugpattern/UnsafeFinalization
and handle their impacts
Change-Id: I87d7cd5f4fe3f5b810acaab421ac9e5da8fb9c0b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 19 Dec 2017 00:50:36 +0000 (01:50 +0100)]
Bump error-prone from 2.1.2 to 2.1.3
and some code changes now required by enabling a few extra checks which
in the first round I could not enable because of un-fixable violations
in Immutables.org generated code (which could possibly have affected
YANG generated code as well later)
With with the new XepExcludedPaths, see
https://github.com/google/error-prone/issues/821 (instead of
https://github.com/google/error-prone/issues/808), we can ignore
/target/ so that's not a problem, anymore.
The disabled StaticOrDefaultInterfaceMethod is because I've hit it
during the build of caches/ but learnt its very Android specific, we
don't care, see
http://errorprone.info/bugpattern/StaticOrDefaultInterfaceMethod
The added FutureReturnValueIgnored is GREAT.
Change Log on
https://groups.google.com/forum/#!msg/error-prone-announce/-ExdzeDOURY/7cQqwSezCQAJ
Change-Id: I05d5497626240d1a30cc54ee3014f1dbe367fcb5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Sun, 5 Nov 2017 11:13:36 +0000 (12:13 +0100)]
new parent POM with Checkstyle, FindBugs & Truth
switched utils, inject, guice-testutils, diagstatus & ready to using it.
other artifacts will be switched later, once they are FindBugs enabled
Change-Id: Icddbd9b5482401ddd1f71f600d3c5fbe3dd5a72c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Wed, 27 Sep 2017 13:36:29 +0000 (15:36 +0200)]
Bump odlparent 2.0.4 to 2.0.5
Change-Id: Icfc01c9e41e7ec58436c02093b2c76c4ba6c651d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Fri, 2 Dec 2016 11:59:30 +0000 (12:59 +0100)]
Bug 8300: Caches v1.0 incl. CLI commands (see demo video)
see https://www.youtube.com/watch?v=h4HOSRN2aFc
The main interface APIs are CacheProvider, Cache and CacheFunction.
The SampleServiceWithCachingImpl class illustrates the intended usage.
Actual cache implementations are pluggable; Guava for now, more later.
Change-Id: Ie46f481077283524789212ee48b059fdb8988a62
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Thanh Ha [Mon, 14 Aug 2017 17:26:42 +0000 (13:26 -0400)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: Iadde1500ab522dab0cf333cd9a7ce51c82fea13b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Michael Vorburger [Thu, 10 Aug 2017 10:14:57 +0000 (15:44 +0530)]
Bump odlparent 2.0.2 to 2.0.4
This include a temporary hack / work-around in ready/impl/pom.xml for
the problem which will be properly fixed the next odlparent release by
https://git.opendaylight.org/gerrit/#/c/61489/
Change-Id: Ia0fd1da9d4ae5eb01d719badcf03aeef91a44dc3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Thanh Ha [Tue, 13 Jun 2017 20:36:49 +0000 (16:36 -0400)]
Remove executable bit from xml files
XML files are not executable files. They do not need the executable
bit set.
Change-Id: I6d160aa4960207bd1df1f912a2887bc595ab6527
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Stephen Kitt [Fri, 21 Jul 2017 08:43:27 +0000 (10:43 +0200)]
Migrate to odlparent 2.0.2
Change-Id: If612c5fbfaafd11714632a27e8be1c2feab94108
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Tue, 20 Jun 2017 12:55:50 +0000 (14:55 +0200)]
Upgrade to odlparent 2.0.0 & handle its impacts
Change-Id: Ie492292379a3f7b8927a1f1c0b5f0a32f9255058
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Thanh Ha [Tue, 13 Jun 2017 18:42:57 +0000 (14:42 -0400)]
Migrate to odlparent 1.9.0
Change-Id: Icfdf12404682a4ec8a2c372568fcae49da14f573
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Michael Vorburger [Thu, 1 Jun 2017 05:01:02 +0000 (07:01 +0200)]
Add bind2ToInstance to AbstractGuiceJsr250Module
This is already used in ElanServiceTestModule, and also needed in
FibManagerTestModule, so instead of copy/pasting it, being move up
refactored here.
Change-Id: I3b5e11236c1e756ba98fbe9ee10b1dcfe9dd6f98
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Thanh Ha [Tue, 6 Jun 2017 20:33:28 +0000 (16:33 -0400)]
Migrate to odlparent 1.8.0-Carbon
Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.
Jira: RELENG-159
RT: 41406
Change-Id: Ie31fdf84ae45b2f0e1865394726178f14376b6c3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Fri, 12 May 2017 04:11:55 +0000 (06:11 +0200)]
Bug 8438: New integration test utilities (itestutils)
see Bugzilla description for more background re. what this is all about
Change-Id: I1d2524c874a371a7c7d63ebd8cbb9dfb0678bc44
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 9 May 2017 13:44:37 +0000 (15:44 +0200)]
inject.guice.testutils javax.inject <optional>false
see https://git.opendaylight.org/gerrit/#/c/56723/
Change-Id: I9433fb7c314edcc672973fc3b989731097ce87e6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Anil Belur [Tue, 11 Apr 2017 01:45:37 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I14dd4017ca7c8c80b81d2fc1b0b50b35d9c15447
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Thanh Ha [Fri, 3 Mar 2017 01:51:41 +0000 (20:51 -0500)]
Add missing <name> fields for pom.xml files
This is used by autorelease scripts to automatically parse which project
is failing a build and report to the mailing list automatically. We need
names in the format:
ODL :: <groupId> :: <artifactId>
This patch formats in the same format as found in the startup archetypes
patch found here: https://git.opendaylight.org/gerrit/52522
Change-Id: Ie80fe4341e0e52ef93a560a56d2553e3f40ddfbb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Michael Vorburger [Thu, 24 Nov 2016 23:59:19 +0000 (00:59 +0100)]
AbstractGuiceJsr250Module configureBindings() throws Exception
Change-Id: I9e18b423d2dcf6230536cab04abf62e3d31a79c0
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 17 Nov 2016 16:12:48 +0000 (17:12 +0100)]
Fix broken build of inject-guice-testutils
see https://git.opendaylight.org/gerrit/#/c/48442/ for full background.
Change-Id: I2d5527366795c0ad2e9de8d6dd17143537777088
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Mon, 10 Oct 2016 11:40:01 +0000 (13:40 +0200)]
Fix broken GuiceModule, and rename it to AbstractGuiceJsr250Module
Bug: final configure() forgot to call the abstract configureBindings()
The self test has also been improved to actually detect this problem.
(Before it was too simplistic; without an interface, there was actually
no need at all for a binding, so the problem went undetected.)
Change-Id: I25ff3ccfb84d4179e50befd898e4e911d854f795
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 7 Oct 2016 13:40:50 +0000 (15:40 +0200)]
Add missing copyright headers in pom.xml as req. by Alexis
I had actually done this but forgot to git push it to
https://git.opendaylight.org/gerrit/#/c/46041/ before the merge..
Change-Id: I9c1c13556b7fea9b6553a76586131295d189324b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 22 Sep 2016 10:57:43 +0000 (12:57 +0200)]
Introducing new @Rule GuiceRule guice = new GuiceRule(*Module.class)
This simplifies & standardizes setting up Guice for tests with a JUnit
rule. -- For an existing example, please consult the AclServiceTest in
netvirt/vpnservice/aclservice/impl; the TODO there will get replaced
with a @Rule based on the GuiceRule introduced here.
Change-Id: I931037e859c76ad06525cbd359056a7639179afe
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 6 Sep 2016 15:20:06 +0000 (17:20 +0200)]
Remove SingletonWithLifecycle, because @Singleton is not inherited
and move @PostConstruct & @PreDestroy from interface Lifecycle to class
AbstractLifecycle, because method annotations are only inherited from
classes, not interfaces
See
http://stackoverflow.com/questions/
7761513/is-there-something-like-annotation-inheritance-in-java,
http://stackoverflow.com/questions/
5536583/the-mystery-of-java-ee-6-annotations-inheritance,
http://stackoverflow.com/questions/
13015831/can-guices-singleton-annotation-be-inherited,
http://stackoverflow.com/questions/
10596744/is-it-possible-for-class-to-inherit-the-annotaions-of-the-super-class,
http://stackoverflow.com/questions/
4745798/why-java-classes-do-not-inherit-annotations-from-implemented-interfaces,
http://stackoverflow.com/questions/
23973107/how-to-use-inherited-annotation-in-java,
http://stackoverflow.com/questions/
10082619/how-do-java-method-annotations-work-in-conjunction-with-method-overriding
Note that none of the annotations in question here have an @Inherited
annotation themselves. For @PostConstruct & @PreDestroy it works anyway
with the blueprint-maven-plugin (I've now fully tested this end-to-end
in the netvirt aclservice-impl), and should be the same with Guice +
Mycila from what I can tell looking at that implementation.
Unrelated to above, this also fixes up the features.xml which I
originally forgot.
Change-Id: I1848838fa3123cd5fd7892445d26c89cc07a476c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 23 Aug 2016 13:59:43 +0000 (15:59 +0200)]
@Inject convenience helper (org.opendaylight.infrautils.inject)
Introduces the Lifecycle interrface with the LifecycleSupport and
SingletonWithLifecycle convenience base classes, with a
ModuleSetupRuntimeException, to standardize the use of @Inject (in
@Singleton) in the ODL code base for projects using the
blueprint-maven-plugin to generate wiring XML from these Java
annotations instead of hand writing it.
Change-Id: I88313940370e6cbef30bd471b2cda8238be5beb8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Code Review / odlguice.git / log