Jetty 9.2 upgrade: add h2 to dependency management

This allows the Jetty upgrade to be driven from odlparent, without
requiring synchronised commits to odlparent and aaa (once aaa starts
using this dependency management).

Change-Id: I99f9086497706a321380d32f7cbc194895cf6abf
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Checkstyle: no space inside parentheses

Fix violations of ParenPad rule so it can be enabled at a later point.

Change-Id: I17968e48ca25b09be9dea7dac355612b81c7e606
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Revert "Checkstyle: no space inside parentheses"

This reverts commit 28204b1caf363e7f7ae8d184ad305cf958a24608.

Breaks controller, we certainly do not need any more breakage at this point.

Change-Id: I3ee127e638a1adcbdf295ee7ab3e7328c6fd5777
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Downgrade javax.mail version

Installing both jdbc and jetty-8 features causes a conflict on
which version of javax.mail to use, as they pull in 1.4.4 and 1.4.5
respectively.

Resolve this by downgrading the version in jetty-8.

Change-Id: Icfa2fe3d5f87b7fc97405f94fe7bf33113178a75
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unneeded groupId

Maven plugins have an implied groupId, there is no need to be
explicit.

Change-Id: I6c0d3aa532be7c1c3255e2a1cc5e927a96bb66c4
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add version declaration for maven-remote-resources-plugin

Fixes a warning about undeclared version.

Change-Id: I47118df48ee7f3b7d0d09c090228a46d70acbd68
Signed-off-by: Robert Varga <rovarga@cisco.com>

Pull in karaf's enterprise repository for jdbc

This seems to be causing downstream grief, while passing SFT here.
Pull in the repository explicitly.

Change-Id: I963fa67fe7470f155bae459ba2b2cdf8a2f874fa
Signed-off-by: Robert Varga <rovarga@cisco.com>

Checkstyle: no space inside parentheses

Add the ParenPad check to odl_checks.xml, which makes sure there is no
space after a left parenthesis and before a right parenthesis. Fix the
violations in odlparent.

Change-Id: Ib6cf36f05598f68ad034af67be17b8963bafba07
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Add odl-karaf-feat-jetty and odl-karaf-feat-feature

Jetty is yet another feature we are using, provide a proxy for it.
Also note that we should be upgrading it.

feature service is needed by config-adaptor in controller, so add
that as well.

Change-Id: Idb5049ca822f9fb2a7383e79ca04d40c37eaa8eb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add single features wrapping karaf features

Auto-generated features have no way of referring to core
karaf features, hence we need to wrap them. This provides
jdbc and war needed for aaa project.

Change-Id: Ia3a9cc3a926b6f7d00a001f604adda9cae551851
Signed-off-by: Robert Varga <rovarga@cisco.com>

Karaf 4: make odl-akka-leveldb-0.7 use the Guava feature

The LevelDB feature ends up pulling in Guava, so make it use our Guava
feature explicitly.

Change-Id: I53b8bcd9a93f0a1ac952718f47c6315167989e7d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Karaf 4: exclude artifacts provided by our distribution

This is a first pass, covering all the controller features'
dependencies which are (now) provided by our Karaf distribution: Aries
Blueprint, Aries Quiesce, jline, sshd, and the core Karaf JAAS and
shell bundles.

Change-Id: I2ab260d367c8acb4805b1480c60ad34f5c2692d4
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "FindBugs' full :annotation instead of :jsr305 artifact sub-set"

This reverts commit 4647724a79fbf7db440716f93f1067d17ecd8dda.

It breaks yangtools' and bgpcep's SFT, I suspect it breaks others
as well.

Change-Id: I880c3835958edac14a608fb8f7346c2274298c83
Signed-off-by: Robert Varga <rovarga@cisco.com>

FindBugs' full :annotation instead of :jsr305 artifact sub-set

This will require that all downstream projects first switch their
<dependency><groupId>com.google.code.findbugs from <artifactId>jsr305 to
<artifactId>annotations in all pom.xml.  They will NOT have to adapt any
code, because the actual Java types are exactly the same (just from a
different Maven artefact).

see also discussion in https://git.opendaylight.org/gerrit/#/c/46914/

Change-Id: Idedc9203f99dd012f10945f2f8f69c88e5f541a2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

SFT: avoid testing aggregator features

Feature repositories built by the Karaf Maven plugin contain an
aggregator feature which pulls in all the features in the relevant
POM. It's pointless to test this, and very expensive, so we now skip
them: the rule is that, in repositories with more than one feature,
any feature with the same name as the repository is skipped.
(Repositories containing a single feature are tested, so that single
features can be checked in -Psft mode.)

Change-Id: I8ca11e9ff18663e62cee94e3203b5a0e0db17742
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use equinox instead of felix for SFT

Default felix has some problem with attaching optional imports,
breaking downstream features. Switch to using equinox, which is
actually what we package.

Change-Id: I6813f2a5e3d9343fb59ec52d12e0367ca07f71b9
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bump pax-exam to 4.10.0

Just an usual upgrade.

Change-Id: Ie642793bb1388a1bb700a9e0859c301f86567b2a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix karaf's aries-blueprint feature

quiesce.api is something we are using and since blueprint-core has
it as an optional dependency, we end up refreshing blueprint when
we install it. That leads to pax-exam thinking the test during SFT
has ended and proceeds to the next test -- wreaking havoc in process
of doing so.

Patch the upstream feature file so quiesce.api is installed
unconditionally, so we do not have to install it from a feature,
hence we won't trigger blueprint refresh.

Change-Id: I14ad8b70d1dc8a961944da9087a54242ba017195
Signed-off-by: Robert Varga <rovarga@cisco.com>

Ignore ow2.asm, it's provided

Change-Id: I815efb3e6e274a908f683bf0b5bd0ce7a7d5904b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix maven-site-plugin not working with JDK9

site plugin pulls in old velocity, which in turn pulls in
old commons-lang, which breaks with new Java versioning
scheme. Bump the dependency to 2.6 to make it work.

Change-Id: I37f11858fafccf02eb8c17581fa5c44214bcfdd4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-compiler-plugin to 3.6.1

Updates compiler plugin to 3.6.1, needed for JDK9 support.

Change-Id: I04515d84ee427479de56aad451bbd485dfe36421
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix jar plugin inconsistency

maven-jar-plugin should be at 3.0.2, not 3.0.0.

Change-Id: Iea0742bf05e18a3e6998b96c56d82ad5b6364cf3
Signed-off-by: Robert Varga <rovarga@cisco.com>

Update deploy-site.xml versions

- wagon-webdav-jackrabbit to 2.12
- maven-site-plugin to 3.6

Change-Id: Ia693d45ac7fb5c63d99dfe0a485862bb228726c3
Signed-off-by: Robert Varga <rovarga@cisco.com>

Update maven-site-plugin to 3.6

Bump the site plugin to uniform 3.6.

Change-Id: I520230fa1ebaffb7fef49d8c6f40c833d0225f95
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove maven.jar.version

The property is no longer used anywhere, remove it and inline
the version declaration.

Change-Id: Ibe7b8a9e4807434848185adcf4b03191b63eeec7
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove maven.antrun.plugin.version

No autorelease projects are using this property, inline it.

Change-Id: Ib7fe05d1c17865707e426960466eafde6fce59d6
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make SingleFeatureTest getKarafDistroVersion() throw clear IOException

instead of a confusion NullPointerException, as e.g. on
https://jenkins.opendaylight.org/releng/job/odlparent-distribution-check-boron/27/console
(and I've seen this before... even on master, not just stable/boron)

Change-Id: I256fccc5a48444c4c8f79a90e129d3641779f45a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Improve the SFT log for features.xml/feature.xml

Instead of logging an error when features.xml or feature.xml aren't
found, check whether we find any test children and log an error if
there aren't any globally.

Change-Id: I21fe04911cbf350b33c28e2fcb79422f631c6ac4
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-6236: bump to official xtend 2.11.0 release

This changes xtend-related things so they use 2.11.0 instead of
RC2 versions.

Change-Id: I36bc6a97331ecb6eb1d6a18d198593931b11cb2b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Skip Jacoco in SingleFeatureTest

There's no point in checking code coverage in SingleFeatureTest, and
it increases memory usage substantially. This patch disables Jacoco in
single-feature-parent and feature-repo-parent.

Change-Id: If004e4b4f79f0e2e728ec2f9a76aa7458df05e7f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Upgrade lmax disruptor 3.3.4 → 3.3.6

See https://github.com/LMAX-Exchange/disruptor/releases/tag/3.3.5 and
https://github.com/LMAX-Exchange/disruptor/releases/tag/3.3.6 for the
changes.

Change-Id: Ia625a38e669d2ce9542bda4b4ea7144d7c34109d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Upgrade commons-io 2.4 → 2.5

See https://commons.apache.org/proper/commons-io/upgradeto2_5.html for
the changes.

Change-Id: I6c127eaa5012479cda3a74b5331a07e227dae492
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Upgrade logback 1.1.7 → 1.1.9

See https://logback.qos.ch/news.html for the changes.

Change-Id: Ie5622690a8c62500415da5f3d17ee5abea213600
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-6236: bump xtend version to 2.11.0

This bumps xtend dependency to 2.11.0.RC2. This is a preparation
patch, will be updated to official 2.11.0 release once that is out.

Change-Id: I5cb8365d6541f5878bbc9fcfb02d29be0524122f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bump netty to 4.1.7

Follow-up to previous bump, major changes detailed
at http://netty.io/news/2016/05/26/4-1-0-Final.html.

Change-Id: I56ab3a5edc59ce1c36f356b052f332bb49fd3b45
Signed-off-by: Robert Varga <rovarga@cisco.com>

Sync the Karaf 4 SFT blacklist

Bug: 7584
Change-Id: Ia588fbc9ea3ef812bb9a4e0bcb69c96657a27d4d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Karaf 4: exclude jcl-over-slf4j

We need to exclude this for dlux.

Change-Id: I03450bd5803b43004a9202b77c31c2e5fdea7486
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Sync sft.diag.force for Karaf 4

Change-Id: I3e8c97d8f43f016e5b1cead856012bed74f6aac2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump netty to 4.0.43

http://netty.io/news/2016/07/01/4-0-38-Final-4-1-2-Final.html
http://netty.io/news/2016/07/15/4-0-39-Final-4-1-3-Final.html
http://netty.io/news/2016/07/27/4-0-40-Final-4-1-4-Final.html
http://netty.io/news/2016/08/29/4-0-41-Final-4-1-5-Final.html
http://netty.io/news/2016/10/14/4-0-42-Final-4-1-6-Final.html
http://netty.io/news/2017/01/12/4-0-43-Final-4-1-7-Final.html

Change-Id: Ib9bd686dbb645128a093f4f934710e19ba6e3fca
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Re-bump akka netty to 3.10.6

It seems that the original bump,
https://git.opendaylight.org/gerrit/44231/, was lost during reorg
done in https://git.opendaylight.org/gerrit/39539. Reinstate the bump.

Change-Id: Idb6a52475181d4fd0bebe157adc331a012ea8a03
Signed-off-by: Robert Varga <rovarga@cisco.com>

SFT diag: add a force option

Add a sft.diag.force property to force diag even on blacklisted
features (this makes it easier for downstreams to check whether they
really have fixed their blacklisted features).

Change-Id: I7f23c5767293ffc55d0a269071235b08c815caba
Signed-off-by: Stephen Kitt <skitt@redhat.com>

odlparent pom.xml only doc (only) re. mockito-core VS mockito-all

to prevent NoSuchMethodError: org.hamcrest.Matcher ...

Bug 7662 related
Change-Id: I7decc16bf70b0b1c09455872776cda07950e573e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove the aaa Cassandra back-end from the blacklist

aaa no longer provides odl-aaa-authn-cassandra-cluster
(https://git.opendaylight.org/gerrit/50450).

Bug: 7584
Change-Id: If69b78da84c51eda142ab9516e0eebf64b631b50
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-7473: add Karaf 4 features

Instead of switching wholesale to Karaf 4 only, this patch adds
duplicate features for Karaf 4:

* feature-repo-parent is the new parent for Karaf 4 feature
  repositories (the Karaf 3 parent is now feature3-repo-parent, used
  only in odlparent);
* single-feature-parent is the new parent for Karaf 4 features (the
  Karaf 3 parent is now single-feature3-parent, used only in
  odlparent);
* features4-akka is the new odlparent Karaf 4 feature repository for
  Akka (dropping the old, backwards-compatible features);
* features4-odlparent is the new odlparent Karaf 4 feature repository
  for all other features (again, dropping the old,
  backwards-compatible features).

For the time being, we use Karaf 4.0.7 as the container (otherwise we
run into issues caused by
https://issues.apache.org/jira/browse/FELIX-5450 at least in
controller), and our own release of 4.0.9-SNAPSHOT, called 4.0.8-odl,
for the Karaf Maven plugin (we need upcoming 4.0.9 features when
generating our feature descriptors).

features-parent isn't duplicated for Karaf 4, downstreams are
encouraged to use at least feature-repo-parent instead.

This patch includes the following changes too:
* bundle uninstall failures are ignored in SingleFeatureTest;
* the deprecated features are reduced to delegates for their
  replacement features (e.g. odl-akka-scala simply pulls in
  odl-akka-scala-2.11);
* karaf4-parent only pulls in standard and war (these two features
  include all the other features that were explicitly listed);
* Pax Exam is upgraded to 4.9.2 (necessary to build with Karaf 4, but
  backwards-compatible with Karaf 3);
* Jacoco is upgraded to 0.7.7.201606060606 (as above);
* pax-url is upgraded to 2.5.1 (as above);
* the Protobuf tweaking for clustering is no longer necessary and is
  removed;
* bundles-test needs wrap as a pre-requisite, which requires wrapping
  it in a feature (odl-bundles-test) and using that in the Karaf 4
  SingleFeatureTest;
* karaf4-parent supports karaf.localFeature again.

Change-Id: I251aa7aefe6d3d7f93a73b5256bad6e596147c66
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use generated-test-sources for xtend

IntelliJ expects test sources in generated-test-sources (which also
matches other programs' expectations, e.g. annotation processors).
Building test sources in generates-sources causes issues because the
classpaths don't match up. This patch moves generated xtend sources to
generates-sources/xtend for main code and generated-test-sources/xtend
for test code.

Change-Id: I8bc657c7cc06b0c7d2b8deeb7a970fe504a7d144
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 7586: Remove lispflowmapping features from eSFT blacklist

Can be merged once https://git.opendaylight.org/gerrit/#/c/50736/ is
merged.

Change-Id: I13017c7a78a4ef1f8a41f11f1c958875c9537bc6
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove BGPCEP features related from BLACKLISTED_BROKEN_FEATURES

Remove BGPCEP features related from BLACKLISTED_BROKEN_FEATURES

Change-Id: I698f996bdb5bd727c3a867602407e5c1cdae8cd8
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Add -Dsft.diag.timeout=... option to SingleFeatureTest BundleDiagInfos

This is useful when locally debugging issues, and you don't want to wait
too long for the bundle convergence to eventually succeed (because you
already know there is a problem).  The worst case default of 5 minutes
for the build is still a good idea, though.

This also tunes the pollInterval from 250ms to 1s, which is sufficient,
and leads to less noise in the log.

This also fixes -Dsft.diag.skip=true, which didn't actually work
(becaues of a missing PropagateSystemPropertyOption).

Change-Id: I8c7bae10295ddef57c0869628789949d991456e3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump immutables.org to 2.4.2

Simple update to get the latest version.

Change-Id: I3f90eb355feca4f925021dfed6bda54ac49d2458
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add metainf-services dependencyManagement section

This is a simple annotation processor for generating META-INF/services
entries. Useful for libraries and plugins which need to provide services
outside of the OSGi container.

Change-Id: I4747ce29f7da984bbfa48e7e8b8a6979d33e9440
Signed-off-by: Robert Varga <rovarga@cisco.com>

SingleFeatureTest BLACKLISTED_BROKEN_FEATURES link Bug 7595

Bug: 7595
Change-Id: I3eb4a9aa4c0fae739b5f43189110565427536753
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

SingleFeatureTest BLACKLISTED_BROKEN_FEATURES bugs links (only)

Bug: 7582
Change-Id: Ibd0c0feb1d8c0318461c9d71d4b737bcecae25fe
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove version.properties from karaf resources

This file lacks support from build jobs for a long time,
it mentions controller while appearing in every distribution,
and it tends to cause confusion instead of providing information.

Change-Id: I87548cec6d00502b52c900207cf337bba73ed844
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Update LISP config in default Karaf resources

The lisp.mappingOverwrite configuration option was removed in the LISP
code, and the new option lisp.mappingMerge was added. Update
etc/custom.properties accordingly.

Change-Id: Ifaf9888a36e2b5ac90e8c82122e8d4db96a02b18
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

BUG-7446: package released Guava 21

This updates the packaged version to 21.0 release.

Change-Id: I15fb97019667401bac201cc95a7f3540e0b9c177
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove BGPCEP from SingleFeature Test Black List

Remove BGPCEP from SingleFeature Test Black List

Change-Id: I5fb8bd7a826b3b6f2b14ea2275636c948f2d666a
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

SingleFeatureTest now fails if diag CLI command would have failed

This will help us detect a whole range of issues, notably any
blueprint related problems, much earlier in our development cycle than
we currently are.

The log contains details re. OSGi missing and available services.

NB: This change includes a (surprisingly long!) "black list" of features
known to be broken right now.  These ideally should all be fixed, and
the black list removed.

IMPL: The new bundles-test was introduced here because I ran into Pax
Exam related ClassNotFoundException, which I could not to resolve any
other way.  Basically, the problem is that the "probe" bundle which Pax
Exam creates on the fly includes the SingleFeatureTest class, and not
classes it references.  In other tests like IT this works, possibly
because Pax Exam somehow finds them in src/test/java; but not from
features-test.  (The currently existing utility classes next to
SingleFeatureTest in features-test probably only work because those run
outside the probe?)

This also did not help, because it's never called, because the
ClassNotFoundException happened earlier, on loading of the class
already:

import org.osgi.framework.Constants;

@ProbeBuilder
public TestProbeBuilder probeConfiguration(TestProbeBuilder probe) {
    LOG.info("probeConfiguration()");
    probe.setHeader(Constants.DYNAMICIMPORT_PACKAGE, "*");
    probe.setHeader(Constants.EXPORT_PACKAGE,
"org.opendaylight.odlparent.featuretest");
    probe.setHeader(IMPORT_PACKAGE,
"org.opendaylight.odlparent.featuretest");
    return probe;
}

Change-Id: I328e503703770aab539fdf1f0a7804ba676596ac
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

SingleFeatureTest java.security.egd /dev/urandom

This prevents SingleFeatureTest getting blocked on Karaf start-up e.g.
in netconf/features/netconf-connector which I just ran into on a build
server, due to very low entropy (cat
/proc/sys/kernel/random/entropy_avail); it was like 40 or so.

Bug: 6790
Change-Id: Iad71b3b3afb3dad64eeebcce2838e88f2f580606
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump aeron/agron to 1.0.5/0.9.1

Bring in the latest bugfix releases for artery.

Change-Id: I182206de5d7062b039d79338271217a492c6f46b
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-7446: Package Guava 21-rc2

Bump the packaged version to rc2.

Change-Id: If46bb289bd426a391aa68c1abe770295ae5f2d0b
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-7446: introduce odl-guava-21 feature

This is a preparatory patch, bringing in 21-rc1 artifact. This
will be followed-up with a patch to switch the build-time version.

Change-Id: If1eebe54190cfd5a7f97937b0b6b0b7a9624c78b
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-7183: Bump akka to 2.4.16

This is the first build available for scala 2.12
with working OSGi and therefore is a prerequisite
for upgrade.

Change-Id: I73d7b3322fe72fe6814f81ed52006dc7866e4848
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-7183: Bump aeron/Agrona to latest versions

This is a bump to latest versions, which require leak of
com.sun.media.sound from the boot class path to work.

Change-Id: I5a7bbf8b1cf8c28e14af9a8d92a03be0072022b4
Signed-off-by: Robert Varga <rovarga@cisco.com>

Exclude slf4j-api from generated features

This avoids issues with features depending on slf4j-api, without
needing to fix all the bundle dependencies to avoid pulling it in.

Change-Id: I765f2ab4d34ae39a878605ac4b2b70398febfca5
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump aeron/agrona to newer versions

This is a compatible upgrade for testing out artery.

Change-Id: Ibec7b6c263d0c650472b4bdc2aa93046babad332
Signed-off-by: Robert Varga <rovarga@cisco.com>

Revert "Upgrade Servlet API 3.0.1 -> 3.1.0"

This reverts commit 48e2f345b347dbca7f8b94df40adb6666ac4e017, which breaks at least AAA.

Change-Id: I398ededd9f77107fb9a191ea9c587e46b5e0784a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Upgrade Servlet API 3.0.1 -> 3.1.0

This is part of Java EE 7 and adds non-blocking I/O and WebSocket
support. See https://jcp.org/en/jsr/detail?id=340 for details.

Change-Id: Ia615749593971421b9388d37700b957f847cbb6b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix jacoco and sonar exclusions for yang-generated files

Jacoco and Sonar exclusions lists were missing some yang-generated
files that should be excluded. Also update the jacoco and sonar
exclusions to match.

Change-Id: Iff7f68102d66724a86d1654fd59145e9bc22e66a
Signed-off-by: AbdulRahman AlHamali <a.alhamali93@gmail.com>

Add maven-help-plugin and exec-maven-plugin

This just defines the versions, so they can be used
downstream without specifying versions.

Change-Id: I186b326e4d69403888074c30e7c92f6d8a2e69eb
Signed-off-by: Robert Varga <rovarga@cisco.com>

git-commit-id-plugin skipped on mvn -Pq, because it slows down a little

Change-Id: I5570855a6de43858f5f7305e7c2a53da778f1ad2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

[eclipse] git-commit-id-plugin ignored in M2E by lifecycle-mapping

The recently git-commit-id-plugin likely was the culprit for the
recently very badly dropped Build Workspace performance issue I've
started noticing in Eclipse... there is really no need at all to produce
the new META-INF/git.properties during incremental in-IDE build (as
useful as it is on CLI build) - so ignore it!

Change-Id: I1a5a8282cdee236a5911560b80b1193522173c1d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 6523: Use opendaylight-karaf-empty for SingleFeatureTest

This makes feature-parent to use the same karaf container
as integration/distribution uses for testing its features.

The downside is developers experiencing
daily download of a big snapshot artifact.

A solution which replaces org.apache.aries.proxy.impl
in maven-surefire-plugin default (non-snapshot) karaf container would be preferable.

Change-Id: I6cd4f0ee4c9883e0376f262bd2f09d1bc1c29911
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Bug 7285 - CENTINEL Carbon Autorelease Build Failure

guice dependency shouldn't be targeted with scope test
as downstream consumer of that dependency needs it during
some other lifecycle state (compile).

Centinel is pulling graylog2-plugin that requires guice at
compile time, and does pull it as transitice dependency.
But since odlparent provide it with the scope test, and centinel
isn't speficically defining that dependency, odlparent overwrite
the transitive dependency of graylog2-plugin

Change-Id: I9c109f942804637463113db56d0bce45d4cf65ae
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

git-commit-id-plugin cannot fail build for new projects w.o. .git/

Change-Id: I5483524047476b9fcf3562dde55b07c79efbea0b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-4219: eliminate odlparent-version

Since karaf4-parent is derived from odlparent,
we can just add branding and conf to our artifacts
and not specify the version. Hence we can eliminate
odlparent.version.

Change-Id: Ic62f80cca737cfc386a428d33ccac2b4ab43c395
Signed-off-by: Robert Varga <rovarga@cisco.com>

Checkstyle Windows EOL single message instead of each line

The current configuration prints a Checkstyle violation for EACH LINE in
a file with Windows (CR+LF) instead of UNIX (LF) end of line (EOL)
delimiters.

This change adjusts that to cause only 1 violation per such file.

This leads to clearer and shorter logs.

Change-Id: I4ef2825608966e3dbd714f73fbc462e10cc5d8d8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add akka-distributed-data to akka features

Change-Id: I2548ab02df746dc076dc5a7153accd54b39e22ba
Signed-off-by: Tomas Cere <tcere@cisco.com>

git-commit-id-plugin to put a META-INF/git.properties in all built JAR

see https://github.com/ktoso/maven-git-commit-id-plugin for background

This automatically works for all ODL JARs without any changes needed in
any other POM (unlike buildnumber-maven-plugin which needs SCM info).

This required https://git.opendaylight.org/gerrit/#/c/48447/ before.

Change-Id: I43f9692b4a3ae83a90cdfbeaf20bd2cba323bce8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Upgrade commons-fileupload from 1.3.1 to 1.3.2 (security vulnerability)

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-3092

http://mail-archives.us.apache.org/mod_mbox/www-announce/201606.mbox/%3C6223ece6-2b41-ef4f-22f9-d3481e492832@apache.org%3E

https://bugzilla.redhat.com/show_bug.cgi?id=1349475

Change-Id: Ifc63c3b6021d8a8b3a906905fee96ce7287fd96b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Upgrade Spring Framework from 3.2.14 to 3.2.17 (security vulnerability)

and org.springframework.security from 3.2.8 to 3.2.9 just while we're at
it

https://pivotal.io/security/cve-2015-5211

Change-Id: I6896c592803a105c2c44ea9f4a9fcfd7ff50f595
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Checkstyle suppressions XML to completely avoid checking target/

This is the only reliably way that I found to avoid checking generated
code and resources.  See also e.g.
http://stackoverflow.com/questions/2362652/excluding-classes-in-maven-checkstyle-plugin-reports
and my comment on that page.

Change-Id: I8b2ec5ee6d46dc108e781031996a1022b8c5330a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-6577: package fixed TrieMap

Until upstream releases a fix, we need a private package,
which has been populated to nexus.

Change-Id: I709f3516c80fb06fd41dc29eed4bcb56df92cf72
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-4219: disable filtering in opendaylight-karaf4-resources

We *don't* want any filtering in the resources here. Hopefully this
will fix the patching issue during merges (and avoid any future
problems with filtered values).

Change-Id: I77301bf76772c0487ec2a27b6f1398f429608a27
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-4219: add karaf4-plugin

Change-Id: Ic7c497521b5683f452100dddd243b7513573d48f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-4219: Add wrap as a boot feature

In Karaf 4, wrapped bundles aren't supported by default. Features
containing wrapped bundles are supposed to declare a prerequisite
dependency on the "wrap" feature; until that's done, we simply add
"wrap" as a boot feature to enable loading old features.

Change-Id: If4fe6da367915c6c5474a5f87b062c71226b2a3a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-4219: copy ODL branding and configuration [WIP]

This applies patches to the upstream-provided startup scripts, instead
of replacing them wholesale — this helps identify the changes we're
interested in, allows upstream improvements to be picked up
automatically, and fails the build if our changes can no longer be
applied (but this will only happen with a Karaf upgrade, so a working
build can't start failing for outside reasons).

Change-Id: I677d18403800ff5ee5aac665ba040dd1ceb43962
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-4219: Add basic Karaf 4 artifacts

This patch adds karaf4-parent and opendaylight-karaf4-empty, currently
only equivalent to apache-karaf-minimal, as groundwork for the Karaf 4
migration.

Change-Id: I699ace7247cea4544857288313822571b97d9460
Signed-off-by: Stephen Kitt <skitt@redhat.com>

LICENSE bundled in all built OSGi bundle JARs

Work was done a while ago (by Thanh) to put a LICENSE into
target/classes expecting that to end up in all built JARs, but it
actually never did, which I stumbled upon in the context of
https://git.opendaylight.org/gerrit/#/c/48443/.  This remedies that by
explicitly instructing the maven-bundle-plugin to additionally bundle
the LICENSE text file (and the META-INF/git.properties after this is
merged).

Change-Id: If382d763b5fabe21cfed9e7c51fa3d4f9b31e47a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add Google Guice to dependencyManagement

Actually we already have it anyway, through mycila, but in
https://git.opendaylight.org/gerrit/#/c/48077/ for
https://git.opendaylight.org/gerrit/#/c/48078/ I'd like to depend only
on Guice directly, because there I don't need anything from mycila, so I
need the adjustment proposed here.

Change-Id: Ia1fcc56c3e650759dc483c8d8c36091e047efde7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Immutables.org in dependencyManagement

https://immutables.github.io is really great IMHO.  So far I've used it
to write a few structs for test data, have made some small contributions
to it (bug reports & testing; no code) but I'd like to start using it
more in ODL work, and thus am proposing it into odlparent.  It's a fast
moving project, so having a single place (odlparent) for the version and
keep moving it forward is useful from the start IMHO, instead of
plastering it across projects.

I do realize this code. gen. could be seen under the YANG lens, but IMHO
it's complementary and has a different sweet spot (YANG for persistent
data store, remotable objects) and this Immutables.org for private
in-bundle code for tests and configuration data - notably anything
threading related such as https://git.opendaylight.org/gerrit/#/c/48373/
discussion, where easy true immutability is of interest (YANG gen. code
is NOT immutable; it pretends to be, but it's actually not at all).

Change-Id: I1bc87c3d11316aa42002eb1a4b1f49f820058860
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-7183: bump scala-java8-compat to 0.8.0

This is the first build available for scala 2.12
and is a prerequisite.

Change-Id: I399a5d2d8e623caca7e649c2aa07020ecb1c16b7
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 6236: Add mdsal.skip.verbose to -Pq Quick profile

see https://git.opendaylight.org/gerrit/#/c/47036/

Change-Id: I47286b9a9bc3bf69594b74add275a24251d0e924
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Introduce awaitility utility for asynchronous testing

see https://github.com/awaitility/awaitility for awaitility details

Already used in netconf/netconf/netconf-topology/pom.xml, and about to
be introduced in https://git.opendaylight.org/gerrit/#/c/48061/ and
https://git.opendaylight.org/gerrit/#/c/48077/

Change-Id: I555ceaeae9007e33ce4c8c8d851558e68da0ce2f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Use target-ide/ instead of target/ as output folder under M2E in Eclipse

Change-Id: I884ce4854509fb4b474a86c82449e600b6f639ed
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Checkstyle enforce space-instead-tab control for *.xtend

https://git.opendaylight.org/gerrit/#/c/47975/ must be merged before
this one, otherwise the build will break (because that affects a project
which is already enforcing CS compliance).

I've verified, using a simplified version of the
https://wiki.opendaylight.org/view/EvolvingCheckstyle procedure, that
this tightening of CS rules has no impacts anywhere else (other than
c/47975).

Change-Id: I772391310907b5890b5e64e5039f689a2f91e520
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump akka to 2.4.11

http://akka.io/news/2016/09/30/akka-2.4.11-released.html, brings
options to use alternative remoting transport, potentially increasing
performance and stability.

Change-Id: Ib26f8557ccca278c1057b91bbe3bd4236ed4e46b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Revert "BUG-7053: bump findbugs annotations"

This reverts commit b5739e344964ea69474f43c15e6b85d350c8171c.

Change-Id: I9931a183d1293af56b6b56fb51ce374bdbd2aec6
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-7053: bump findbugs annotations

Bumps findbugs annotations to latest version.

Change-Id: I55626a2b7b28f39f460e4208f12dede683684ae1
Signed-off-by: Robert Varga <rovarga@cisco.com>

Upgrade xtend 2.9.2 -> 2.10.0

Change-Id: I95352c6ab2a95f43517672a839ee3c0322ad511d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

target-ide/ on .gitignore

Change-Id: Ibcbd701bf3b9c7fd19261678ee1378f6ea076af5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>