Thanh Ha [Thu, 12 Feb 2015 21:44:28 +0000 (16:44 -0500)]
Remove unncessary Sonar variables
These variables are managed server side or in Jenkins with the latest
Sonar release so should not be configured in project pom.xml files.
Change-Id: I34dc5a64569a1aaf2ca65f0cff2aa87a9f9b1b6f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Martin Uhlir [Fri, 6 Feb 2015 14:41:38 +0000 (15:41 +0100)]
Added option to initiate connection to device
- as this feature was missing (according to OF specification)
- added integration test
Change-Id: I0f7346195999170a74975ee3438bc948fd685e61
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>
Martin Uhlir [Mon, 9 Feb 2015 16:23:18 +0000 (17:23 +0100)]
Removed <repository> tags
- according to future plans mentioned here:
https://lists.opendaylight.org/pipermail/tsc/2015-February/002497.html
Change-Id: Ieb48b5a1348a3de2c3cabf62a009934ba552d2c8
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>
Robert Varga [Mon, 9 Feb 2015 09:06:53 +0000 (10:06 +0100)]
Remove unneeded dependencyManagement declarations
All of these declarations already exist in odlparent, no need to
redefine them here.
Change-Id: Iacebf45d5b8054f6656ea102f5755eaf713c7440
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 9 Feb 2015 08:55:44 +0000 (09:55 +0100)]
Do not override versions from odlparent
All of these properties/plugins are define din odlparent, no need to
hard-code them here.
Change-Id: I33e5d01ba9fe0ca31e7a9c2c7e041efaac82b0c0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Martin Uhlir [Fri, 30 Jan 2015 12:33:29 +0000 (13:33 +0100)]
NXM (de)serializers deleted
Change-Id: I51e279fea8cc8cc619fd2b46a2dfe135be1d24b8
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>
Martin Uhlir [Wed, 28 Jan 2015 08:58:55 +0000 (09:58 +0100)]
Bug 2245 - fixed multiple types of issues
Issues solved:
1. Objects should be compared with "equals()"
2. Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList"
3. Modifiers should be declared in correct order
4. Avoid commented-out lines of code
5. Unused private fields should be removed
Change-Id: I4ca2224a9fd272dd2deb25f6f36db2ed7bd8bb99
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>
Marian Adamjak [Wed, 29 Oct 2014 15:18:05 +0000 (16:18 +0100)]
Bug 2245 Fixed Avoid cycle between java packages
- move all classes from protocol.api.experimenter into api.keys
- move Message*key.java from protocol.api.extensibility into api.keys
Change-Id: I509c57ecdd41ddfa48b224c87d762571639b0b8a
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Martin Uhlir [Mon, 26 Jan 2015 14:18:17 +0000 (15:18 +0100)]
Bug 2245 - Synchronized classes and data structures replaced by unsynchronized.
Change-Id: Ie5aeeb28c74757d1a8bac21ce611a403a0fb6f57
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>
Martin Uhlir [Fri, 23 Jan 2015 12:54:24 +0000 (13:54 +0100)]
Bug 2245 - Changed type parameters to comply with naming conventions
Change-Id: I0593538542f6e4ee295b12b19b60058a666a8b04
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>
Martin Uhlir [Mon, 26 Jan 2015 12:36:06 +0000 (13:36 +0100)]
Bug 2245 - Added private constructors to utility classes, in order to hide the implicit one.
Change-Id: I9c0c0d0e2e91f87ca24c5ac5b7edb8931dbc7a2f
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>
Thanh Ha [Fri, 9 Jan 2015 20:53:27 +0000 (15:53 -0500)]
Set root pom.xml <name> for Sonar
As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname.
https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html
Change-Id: I51859978242e4d93ba434890a12a1014b286dd30
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Michal Polkorab [Fri, 9 Jan 2015 08:43:25 +0000 (09:43 +0100)]
Features updated (odl-mdsal-common)
- features.xml updated with mdsal repository as odl-mdsal-common feature
had been moved to new location
- added dependency into features-openflowjava pom.xml
(new odl-mdsal-common feature location)
- introduced new property (mdsal.version)in parent pom.xml
Change-Id: I9854b88b6db970f0446fe5bb57057568ee118ce1
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Robert Varga [Fri, 28 Nov 2014 15:03:49 +0000 (16:03 +0100)]
Remove trailing whitespace
Trailing whitespace generates a lot of warnings -- mass-remove it.
Change-Id: I9b73bc873685576daa80a998a58d1ce55e475c35
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 28 Nov 2014 14:59:46 +0000 (15:59 +0100)]
Mass replace CRLF->LF
Windows EOLs generate a checkstyle warning. Eliminate them to silence
the build a bit.
Change-Id: I16281420a51e237f516decd64ed46bbe7b4b1461
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 28 Nov 2014 15:26:13 +0000 (16:26 +0100)]
Static fields should be accessed via class
This emits a warning in eclipse, so get rid of it.
Change-Id: I92734c32e76cfc6320340de714689aa6c235f34e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 28 Nov 2014 15:07:41 +0000 (16:07 +0100)]
Make sure to pick up junit version from odlparent
Fixes 4.10/4.11 inconsistency reported by maven. Also migrates imports
of Assert to the new place.
Change-Id: Id0953e69207ac9507b6baa0cc47bfaa938d86655
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 28 Nov 2014 15:17:06 +0000 (16:17 +0100)]
Do not override versions supplied by odlparent
Remove overrides which cause downgrades.
Change-Id: I7c55209cfce404368bfa732543197a9e1db91539
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 28 Nov 2014 14:58:54 +0000 (15:58 +0100)]
Reference odlparent to get common settings
Change-Id: If12f2a59b039d43fd8f325445a4246ef578c45a2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Michal Polkorab [Tue, 25 Nov 2014 12:10:50 +0000 (13:10 +0100)]
Test updated according to yangtools string validation change
Change-Id: I61a5a215721ef9d2d98e92a0fa0b15fcf1e43440
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 18 Nov 2014 09:41:42 +0000 (10:41 +0100)]
Statistics loadable / installable in Karaf
- created new feature odl-openflowjava-stats in order to ensure correct
module start
- created new project openflowjava-config to properly store and delagate
statistics config file
- removed stats-collection as a service from configuration xml
Change-Id: If2b94c4ec9bf2a2c8157eaad546672df6e1d1500
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 13 Nov 2014 15:20:44 +0000 (16:20 +0100)]
JConsole support for statistics collection
- sevice identity moved to spi
- removed unnecessary methods
- toString() renamed to getStat()
Change-Id: I84d8c2f333f11c202b3cbb82f55578ea3f7961f9
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Marian Adamjak [Fri, 7 Nov 2014 13:17:10 +0000 (14:17 +0100)]
Statistics collection added
- added statistics counters and tests
- collection configurable through configSubsystem
Change-Id: I0b292174789fbb39ff7abd25fec9b53b35ff7927
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Marian Adamjak [Wed, 5 Nov 2014 06:51:27 +0000 (07:51 +0100)]
Statistics collection - initial change
Change-Id: I0f252a08a40b93c5ee280d289b28bdd9c88d8419
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Marian Adamjak [Wed, 29 Oct 2014 13:59:47 +0000 (14:59 +0100)]
Bug 2245 - Fixed Avoid cycle between java packages
- between protocol.impl.core and protocol.impl.connection
Change-Id: Ieb3a5a495fffc679852245b0a70e17c57023d3b1
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Wed, 29 Oct 2014 12:06:57 +0000 (13:06 +0100)]
Maintaining code - Move buildRpcError method into AbstractRpcListener
- remove unused method from ConnectionAdapterImpl
Change-Id: I4d25b566fafd28a307345ebdffadcd14e844f2ee
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Wed, 29 Oct 2014 08:45:55 +0000 (09:45 +0100)]
Maintaining code - remove unused class SslTrustManagerFactory
Change-Id: I24a35c5c3ad6a06a27599f689f3de72ab1a47cc1
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Wed, 29 Oct 2014 08:22:47 +0000 (09:22 +0100)]
Maintaining code - review log levels
Change-Id: Ic43628ee1067e112e8c6e1cf21ff9f9a32b0e000
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Tue, 28 Oct 2014 09:02:15 +0000 (10:02 +0100)]
Maintainig code - OFDatagramPacketDecoder, UdpConnectionMap
Change-Id: I7485108109145b48f605d8f9dce1fee87fad9688
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Michal Polkorab [Mon, 27 Oct 2014 16:59:11 +0000 (17:59 +0100)]
Bug 2245 - Fixed critical issues
- Array is stored directly
- Wait not in loop
- Naked notify
Change-Id: Ifa9f431b84298d724351c89e8c330a69b8ab1ff3
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 23 Oct 2014 14:56:10 +0000 (16:56 +0200)]
Fixed cache logging
- successful rpc is no more logged as discarded
- rpc is discarded only when it exceeds specified timeout
Change-Id: I60b334958e76a428c7fa1eebe9a4910c90ef5a8d
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Marian Adamjak [Mon, 27 Oct 2014 14:38:02 +0000 (15:38 +0100)]
BUG 2245 - Fixed Magic Number
Change-Id: Ic725d3604d8901c8fd43e31a2f59544df71fe724
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Mon, 27 Oct 2014 10:11:06 +0000 (11:11 +0100)]
BUG 2245 - Fixed Collapsible If Statements
Change-Id: Idee4d65869ed7041fde16706b4fb8bea2f77bfdd
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Mon, 27 Oct 2014 10:02:05 +0000 (11:02 +0100)]
BUG 2245 - Fixed Modifier Order
Change-Id: Iba652fb7afe982613c5c5519160c8714de00d1ba
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Mon, 27 Oct 2014 09:57:38 +0000 (10:57 +0100)]
BUG 2245 - Fixed Singular Field
Change-Id: I9489b5e8c9cb221cf7a29e7e41d4c909204ed9c7
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Mon, 27 Oct 2014 09:33:24 +0000 (10:33 +0100)]
BUG 2245 - Fixed Constant Name
Change-Id: I2401601e84f1255212cad3b09f4eaba65df430e9
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Mon, 27 Oct 2014 09:19:32 +0000 (10:19 +0100)]
BUG 2245 - Fixed Redundant Modifier
Change-Id: Iabdb33c37646cd3bff16c978abac73914875aeb5
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Fri, 24 Oct 2014 12:49:12 +0000 (14:49 +0200)]
BUG 2245 - Fix Unnecessary Local Before Return
Change-Id: I6fc4762d8af5cced96e82529cf23d75bb017dffa
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Fri, 24 Oct 2014 12:20:18 +0000 (14:20 +0200)]
BUG 2245 - Fixed Parameter Name
Change-Id: I06b083325c4c6755ae21afd50f19b970a1a1d69a
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Fri, 24 Oct 2014 11:19:40 +0000 (13:19 +0200)]
BUG 2245 - Fixed Avoid cycle between Java package (TypeToClassKey only)
Change-Id: I4496cd238824b1b1430805775e30665a7c199c11
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Fri, 24 Oct 2014 06:37:28 +0000 (08:37 +0200)]
BUG 2245 - Fixed 'Preserve Stack Trace'
Change-Id: I53a451b1d2f0691a1de44f671f71b2cd8024076d
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Thu, 23 Oct 2014 12:03:26 +0000 (14:03 +0200)]
BUG-2245 - Fixed Magic Number
Change-Id: I2b1ce6948edb411531ad93a3a85986d97534ae9a
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Thu, 23 Oct 2014 12:03:26 +0000 (14:03 +0200)]
BUG-2245 Sonar technical debt
- correct Local Final Variable Name
Change-Id: I4fde8e15edc8893fd9871a268465eb39da5b92b9
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Michal Polkorab [Thu, 23 Oct 2014 10:33:30 +0000 (12:33 +0200)]
Bug 2245 - Fixed 'Hide Utility Class Constructor'
- also fixed 'Method Type(Generic) Parameter Name'
Change-Id: I4323326dba8a371c65a5d9c1bfeefe867dbcbd4e
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 23 Oct 2014 10:33:30 +0000 (12:33 +0200)]
Bug 2245 - Fixed 'Unused formal parameter'
Change-Id: I4feaab675be5cd3459e1f0907c4dffa73da37a32
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Marian Adamjak [Thu, 23 Oct 2014 13:05:23 +0000 (15:05 +0200)]
BUG 2245 - Fixed Loose coupling
Change-Id: I0328d47b3817b4c8aa1f64e81b1e1aea304e97c0
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Thu, 23 Oct 2014 12:31:50 +0000 (14:31 +0200)]
BUG 2245 Fixed Local Variable Names
Change-Id: Iae8a14c08d5a2d902a0be56bb0a1752132e0e3ab
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Thu, 23 Oct 2014 07:25:43 +0000 (09:25 +0200)]
Change local names of local variables in FeaturesReplyMessageFactory and OxmIpv6ExtHdrDeserializer
Change-Id: Id55fae5958725e9526f9a5633f8ea7fde8ac9c5b
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Thu, 23 Oct 2014 07:02:32 +0000 (09:02 +0200)]
EnhancedMessageTypeKey add hash(), ChannelOutboundQueue change address to final and modify constructor
Change-Id: I732e81ff1949a8f9a9c4aa42579d20287faf5e03
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Wed, 22 Oct 2014 14:31:08 +0000 (16:31 +0200)]
Created unit tests for OFDatagramPacketDecoder, OFDatagramPacketHandler
Change-Id: I4984189ebc2e93fb186a718bce6e8d787095ed76
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Michal Polkorab [Thu, 23 Oct 2014 10:09:49 +0000 (12:09 +0200)]
Bug 2245 - Fixed 'If Stmts Must Use Braces'
Change-Id: Ibef534ef02ef6058ec34dbca7ec172a03612d8d1
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Marian Adamjak [Wed, 22 Oct 2014 11:05:11 +0000 (13:05 +0200)]
Add unit test for OF13SetFieldActionSerializer (experimenter)
Change-Id: Ib058979325b75cc8972648360b99069d8007db32
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Wed, 22 Oct 2014 05:55:28 +0000 (07:55 +0200)]
Fix HelloMessageFactory - repair handling message with bad HelloElementType
- when message has bad HelloElementType empty list of elements will return
- modifying test to follow fix HelloMessageFactory
- add test for message with padding
Change-Id: Ie6a97f79a4d133b9da07b15023cda60ba74eec2f
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Michal Polkorab [Tue, 21 Oct 2014 12:36:29 +0000 (14:36 +0200)]
Increased unit test coverage of serialization factories
Change-Id: Ia284e5e9050b4ab19deb3ba0e5dfa3d0317e2c38
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 21 Oct 2014 10:36:46 +0000 (12:36 +0200)]
Increased unit test coverage for the rest of deserialization factories
Change-Id: I6dcf3094071fcb8013084469574dc0af48f293bf
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Marian Adamjak [Tue, 21 Oct 2014 10:20:19 +0000 (12:20 +0200)]
Add unit test ChannelOutboundQueue, tested by closed and read only channel
Change-Id: I7ac6d35c8c2fd09fc53d2cf7974b77a717743aaf
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
michal rehak [Tue, 21 Oct 2014 06:58:06 +0000 (06:58 +0000)]
Merge "Increased unit test coverage for some deserialization factories"
Michal Polkorab [Mon, 20 Oct 2014 12:25:09 +0000 (14:25 +0200)]
Increased unit test coverage for some deserialization factories
Change-Id: If770094c17a7c2988602d17a7463243cbce63fee
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Wed, 15 Oct 2014 11:06:19 +0000 (13:06 +0200)]
Removed EnhancedKeyRegistryHelper
- as it is no longer used
Change-Id: I3f9643cb94f022fd4d784f4afd038af0221aa636
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Marian Adamjak [Fri, 17 Oct 2014 12:26:41 +0000 (14:26 +0200)]
Add unit test - fully covered SwitchConnectionProviderImpl, ConnectionAdapterImpl
Change-Id: I038649bd02d95ab8b37888f3a3c22daeaac99caa
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Thu, 16 Oct 2014 13:21:52 +0000 (15:21 +0200)]
Add unit tests for ExperimenterIdSerializerKey, ExperimenterIdDeserializerKey
Change-Id: Iaf2ad17a1b6ceee6ed1ec040cb12943f0964f582
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Thu, 16 Oct 2014 13:10:21 +0000 (15:10 +0200)]
Add unit tests for EchoInputMessageFactory, EchoReplyInputMessageFactory
Change-Id: I519e6cf4cb5657be3f506716c999da611079a1d6
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Fri, 17 Oct 2014 10:50:17 +0000 (12:50 +0200)]
Added unit tests for MultipartReply message factory
Change-Id: I5de66ba1a4ae97e527342b7d8de31512d2be5d5a
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Fri, 17 Oct 2014 15:18:20 +0000 (17:18 +0200)]
Fixed MultipartReply - MeterFeatures capabilities bitmap translation
- meter features test moved into separate file
- updated name conversion in TableFeatures translation
Change-Id: Iaa85dd176e02cb9d7bd99dd1bce347252de08180
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Fri, 17 Oct 2014 10:01:02 +0000 (12:01 +0200)]
Bug 2212 - Fixed MultipartReply - GroupFeatures action bitmap translation
+ added unit test for GroupFeatures type
Change-Id: I3a4dbcdfe274a960dbf26231637324298220602d
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 16 Oct 2014 14:00:30 +0000 (16:00 +0200)]
Added unit tests for Error and Vendor/Experimenter message factories
- + covered AbstractInstructionDeserializer
Change-Id: I80804f7e38b42d0b53200e8e06ed41f415152605
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 16 Oct 2014 11:13:07 +0000 (13:13 +0200)]
Increased unit test coverage for keys
- removed check in DeserializationFactory as it is done in DeserializerRegistry
- also updated DeserializerRegistryImplTest
Change-Id: I4baa4fea035104827b34ec7e1b99e1ca4056dd44
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Wed, 15 Oct 2014 13:29:38 +0000 (15:29 +0200)]
Improved unit test coverage for openflowjava/protocol/impl/util/* classes
Change-Id: Ic1d68de6e59e61eb245acdce9499202b07647840
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Marian Adamjak [Wed, 15 Oct 2014 11:58:53 +0000 (13:58 +0200)]
Add new tests, fix several mistakes, add and edit copyright comments
Change-Id: Ied68bd5c0f1c713ee7a1d819756101ccf4026181
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Marian Adamjak [Tue, 14 Oct 2014 14:03:58 +0000 (16:03 +0200)]
Added test
Change-Id: I2d70d80894a7b7c3f87cf778588a3ce4cf89c119
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Michal Polkorab [Tue, 26 Aug 2014 08:55:25 +0000 (10:55 +0200)]
Improved unit test coverage (covered some untested branches)
- Fixed a typo in EncodeConstants javadoc
- added access to Cache in ConnectionAdapterImpl (only for testing purposes)
- removed check from SerializationFactory#messageToBuffer
as it is done in SerializerRegistryImpl
Change-Id: I2e752a883a296f6e097084243aca0b109dd62c27
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Marian Adamjak [Mon, 13 Oct 2014 13:42:57 +0000 (15:42 +0200)]
Added key unit tests
Change-Id: Icc1c59f32eb5004860273512bbf1588d388ff4e3
Signed-off-by: Marian Adamjak <marian.adamjak@pantheon.sk>
Michal Polkorab [Tue, 16 Sep 2014 12:28:54 +0000 (14:28 +0200)]
Added unit tests
Change-Id: I1b6b771d5748d348e8420d33ee05676dbac4fed3
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 16 Sep 2014 12:28:54 +0000 (14:28 +0200)]
Bug 2177 - Updated SwitchConnectionProviderImpl
- added test packaging - to be able to use ConnectionConfigurationImpl in both
spi and impl
SwitchConnectionProviderImpl:
- skipped checks for null and already running serverFacade as those are no longer
needed when using ConfigSubsystem (startup())
- added check for unknown transport protocol received (createAndConfigureServer())
ExperimenterMessageFactory:
- fixed EXPERIMENTER_ID_INDEX constant
MessageFactoryInitializer:
- added Experimenter message deserializers registration
Change-Id: I382d7fed0b626050847dafd47e691b7c9c902285
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Mon, 6 Oct 2014 15:14:52 +0000 (17:14 +0200)]
Incrementing versions by 0.1.0 for post-helium master branch
Change-Id: If5011d280b4053c5db9ed3b3d7df671e4f5a6a11
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Wed, 17 Sep 2014 09:34:40 +0000 (11:34 +0200)]
Removed unused extensibility bundles
- functionality of removed bundles is present in openflowplugin
Change-Id: I073d2de7e0a3c0dee92511e47c45e44e9be12e16
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Wed, 17 Sep 2014 09:06:40 +0000 (11:06 +0200)]
Bug 1935 - Double fireConnectionReady notification
- in case of communication over TCP protocol the fireConnectionReady
notification was incorrectly triggered twice
Change-Id: I23373a6130ebd30f4f183568e4ddda354976df3f
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 9 Sep 2014 13:22:17 +0000 (15:22 +0200)]
Improved test coverage
Change-Id: I0846432b14d880b17ccf1dad5759b3a1c1dcf2af
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Fri, 5 Sep 2014 12:05:26 +0000 (14:05 +0200)]
Fixed incorrect exception type on deserializer lookup
- removed .toString() call from log
- updated test to match functionality
- lowered log level on (de)serializer overwriting
Change-Id: Ie58dc4e4d9bac76532a4df55170ed52e0a0e5fbc
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 22 Jul 2014 12:25:27 +0000 (14:25 +0200)]
Added warn log on same key registration
Change-Id: I7a42f674fa1e2fa4c027a480884ba785b6264646
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 22 Jul 2014 11:29:30 +0000 (13:29 +0200)]
SwitchConnectionProvider javadoc updated
Change-Id: I1a724de6b0abcbf42ee2bdf666aea8a4961d0386
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Robert Varga [Wed, 3 Sep 2014 09:46:40 +0000 (11:46 +0200)]
BUG-1675: bump netty version
This patch depends on https://git.opendaylight.org/gerrit/10679.
Change-Id: Iafec7084afd6c364f9852b7ff76f7cb2f947a637
Signed-off-by: Robert Varga <rovarga@cisco.com>
Michal Polkorab [Wed, 3 Sep 2014 12:29:18 +0000 (14:29 +0200)]
Added missing extension registration methods + keys (serialization part)
Change-Id: I44bd91a975c8bd6e56e9c13aa152999d34c8546f
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 2 Sep 2014 13:23:08 +0000 (15:23 +0200)]
Added missing extension registration methods + keys (deserialization part)
Change-Id: Id997a3fc52ab8e4491ee74ba61bddec20d23c2d9
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 7 Aug 2014 09:54:00 +0000 (11:54 +0200)]
UDP support implementation
- unit tests will be added in another change
Change-Id: I8b6fba59a82febf60c0ddfb97ef8e2e9267aff56
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Mon, 4 Aug 2014 14:04:10 +0000 (16:04 +0200)]
Allow to configure number of threads used by Netty's EventLoopGroups
Change-Id: I07e95b45069bcc3437add607cf5dc990f263eb0d
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Martin Sunal [Sat, 2 Aug 2014 17:24:09 +0000 (19:24 +0200)]
Added a get method for InetSocketAddress of a remote OF switch
Signed-off-by: Martin Sunal <msunal@cisco.com>
Rob Adams [Fri, 18 Jul 2014 16:53:10 +0000 (09:53 -0700)]
Fixed FIXME on MAC address serialization
+ Fix incorrect log message formatting
Change-Id: Ifc523e1e67e1e29ee3c1271995ca79d6edc8b223
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
michal rehak [Wed, 27 Aug 2014 08:35:09 +0000 (08:35 +0000)]
Merge "Improve unit test coverage"
Michal Polkorab [Tue, 19 Aug 2014 13:45:29 +0000 (15:45 +0200)]
Improve unit test coverage
Change-Id: I374bcf2c76a4a3b6cba441dc0c0570be7855d8a9
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 26 Aug 2014 08:54:26 +0000 (10:54 +0200)]
Features.xml update
- removed odl-yangtools-binding-generator feature as it is not needed
Change-Id: Ia6a31f0fd235536a87d86fbd3b47305aab44460c
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Ed Warnicke [Wed, 20 Aug 2014 16:09:15 +0000 (11:09 -0500)]
Fix karaf features, and add testing for them.
Change-Id: I272e0b92099d68e72f30138fe42935495ddf7d94
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Robert Varga [Wed, 6 Aug 2014 11:55:41 +0000 (13:55 +0200)]
More updates to sonar
- per-test reports
- integration test support
- findbugs reports
Change-Id: Ie6a8865551f3d4957be87ccef4b4820d30a1cbd1
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 6 Aug 2014 04:56:27 +0000 (06:56 +0200)]
Fix UT coverage not reported in sonar
Just a couple of properties and making sure jacoco runs.
Change-Id: I75aeae7b74f5c7e94a0a237728dc2b6f0c4df090
Signed-off-by: Robert Varga <rovarga@cisco.com>
Martin Sunal [Tue, 29 Jul 2014 10:21:56 +0000 (12:21 +0200)]
Created experimenter subtype for vendor's actions
ExperimenterActionSerializerKey has a new parameter which is type of vendor's action.
It allows to select right serializer directly in OFJava so a vendor does not need to care about it.
- created codec for Nicira match nxm_of_eth_type
Change-Id: Id9bc0f06820cab7b897eb710a70ddc3d6af13a45
Signed-off-by: Martin Sunal <msunal@cisco.com>
Martin Sunal [Mon, 14 Jul 2014 12:27:09 +0000 (14:27 +0200)]
Nicira extensions in OpenFlowJava library
- creates and registers codecs(serializers & deserializers) for:
actions:
reg-load
reg-move
matches:
NXM_NX_REG(0-7)
NXM_NX_TUN_ID
NXM_NX_ARP_SHA
NXM_NX_ARP_THA
NXM_OF_ARP_OP
NXM_OF_ARP_SPA
NXM_OF_ARP_TPA
NXM_NX_TUN_IPV4_DST
NXM_NX_TUN_IPV4_SRC
NXM_OF_ETH_SRC
NXM_OF_ETH_DST
- moved CoSS config to appropriate place
- added revision to ietf-yang-types
Change-Id: If847b9098722337318109d3ffe34ddaca8b6b363
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Martin Sunal [Wed, 23 Jul 2014 22:17:22 +0000 (00:17 +0200)]
Corrected equals & hashcode methods in extension keys
- corrected equals & hashcode methods in keys
- tests for equals & hashcode methods in keys
Signed-off-by: Martin Sunal <msunal@cisco.com>
Michal Polkorab [Tue, 22 Jul 2014 09:58:45 +0000 (11:58 +0200)]
Added switch TLS keys
- this allows to finish exemplary TLS configuration
- selfSignedSwitch and selfSignedController keystores were moved to src/test/resources
as they are used only in test
- other keystores located in src/main/resources were updated with "exemplary-" prefixes
to clearly mark them for exemplary usage
Change-Id: I821f79e1af8b50fc59e3e5067841a017ec9c1282
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Mon, 7 Jul 2014 12:10:50 +0000 (14:10 +0200)]
Simplified Multipart TableFeatureProperties serialization
Change-Id: Ifdf3936b5985beba23c94bc1e64dde738a844ca2
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Mon, 7 Jul 2014 14:28:18 +0000 (16:28 +0200)]
Replaced usage of BytebufUtils.padBuffer() as it is deprecated
- replaced with buffer.writeZero()
Change-Id: Ica7ef6d244fc531419c42d4055f0d42b09e7ebf0
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Code Review / openflowjava.git / log