Robert Varga [Wed, 4 Jun 2014 09:15:17 +0000 (11:15 +0200)]
Optimize time checking in flush()
Pre-calculate deadline and do not do timeunit conversions while checking
if we should yield.
Change-Id: Ie315a9650f6f7cdbd1bbd2ac611df2a3dfda4975
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 3 Jun 2014 20:59:49 +0000 (22:59 +0200)]
Optimize macAddressToBytes()
Using raw string parsing has some significant overhead. For parsing a
MAC address, we can employ hand-coded routing which has does not
allocate objects and is much more (~140x) more efficient.
Change-Id: Iad1e6bc1618dd1eedcdfbc9f1e55ac49d03ea4aa
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 3 Jun 2014 16:13:45 +0000 (18:13 +0200)]
Optimize mask creation utilities
This introduces a simpified fillBitMask(), which is much simpler to use
and also much faster.
Change-Id: I5519032e3a83a3ace73c1b383784b1e372870782
Signed-off-by: Robert Varga <rovarga@cisco.com>
Brent Salisbury [Tue, 3 Jun 2014 09:47:42 +0000 (05:47 -0400)]
Adding tunnel ipv4 src/dst openflow augmentations
Augments the low-level openflowjava models and
OF13 implementation to support flow based tunnels
rather then port based tunnels only which is ovsdb
specific thus making a more generic TEP implementation.
I used the v4 parent serializer
AbstractOxmIpv4AddressSerializer since its pretty
class agnostic except for the v4 OpenflowBasic
match but it that is abstracted from the DP and
I don't see any glaring issues uses it. If you
guys would prefer an NXM1Class/NXM0Class specific
ipv4 super just say the word. I have both
implementations local with the same result in the DP.
Output of tests and ovs integration is posted here:
https://gist.github.com/
22f0749bba00df1a3cf6
Change-Id: I0f3ebed560bba0137553944fe342704456b4658e
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
Robert Varga [Tue, 3 Jun 2014 10:46:40 +0000 (12:46 +0200)]
Optimize macAddressToString and padBuffer
Optimizes macAddressToString to prevent multiple object allocations and
do a straightforward coversion -- speedup of ~6x.
padBuffer() is deprecated in favor of writeZero(), and uses it
internally.
Change-Id: I98264fe1744b66363b8b3fcae4d54b4b78814cc8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 3 Jun 2014 09:16:00 +0000 (11:16 +0200)]
Flush all entries on channel shutdown
This just makes sure we flush out outstanding queue quickly.
Change-Id: Ib1f7262545f012fe8c418cbe980cc63467a4f654
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 3 Jun 2014 10:48:56 +0000 (12:48 +0200)]
Pre-cache key makers
These are essentially constants, so there is no need to allocate them
over and over again -- just create a single instance and reuse it. Save
CPU and GC cycles.
Change-Id: I77670f4465d8139c6f218bd6f7dab13b66a5b8fc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 2 Jun 2014 15:53:18 +0000 (17:53 +0200)]
Do not instantiate Joiner/Splitter
This patch centralized Splitter and Joiner instances to ByteBufUtils,
from where they are used -- reducing object allocation and CPU usage
(due to checks).
As a bonus, this optimizes splitters on single characters to the
simplest possible form, further reducing overhead.
Change-Id: If635656af49967cd17333ebbeef3452091edd5d5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 2 Jun 2014 16:52:09 +0000 (18:52 +0200)]
Do not instantiate key in fast path
This is a constant lookup for each packet -- let's just use a static
key to prevent useless allocations.
Change-Id: I4a81fc04e29607ace710c7a35671420271836066
Signed-off-by: Robert Varga <rovarga@cisco.com>
Michal Polkorab [Mon, 2 Jun 2014 10:58:50 +0000 (12:58 +0200)]
Used Splitter instead of String.split() - performance improvement
- removed ending whitespace characters from .buildBuffer method as those hexStrings should be ended with a hex character
Change-Id: If1e53d7bbcc81293aa7a231b24b1b7a7746cb5c7
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Robert Varga [Sat, 17 May 2014 07:59:58 +0000 (09:59 +0200)]
Introduce ChannelOutboundQueue
This patch introduces a tunable queue for outstanding requests. The core
idea is to maintain a limited queue between the message produces and the
IO threads. The producers place their pre-made messages to the queue,
where the IO thread picks them up and pushes them down the pipeline.
Should the queue be empty, the caller is informed of this fact and can
choose a recovery strategy -- current implementation reports
RejectedExecutionException.
The flush task is placed in the IO pool only when the channel is
writable and the queue is non-empty. A single run of the flush task is
time-limited, so a single channel which is being churned by producer
does not end up monopolizing a particular thread for extended periods of
time -- after a tunable time the flush task will re-insert itself on the
task queue and exit.
Change-Id: If6f09c60cf2cf5a69e9f051e2dfe2bae3bb90b5d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Brent Salisbury [Tue, 27 May 2014 09:17:38 +0000 (05:17 -0400)]
Added augmentations for TCP_Flag reads and low level models
Extensions are supered under OFPXMC_NXM_1 code point 0x0001
Once this and the high-level controller patches merge
I will commit the openflowplugin conversion patch since
openflowplugin will fail its build until the yang bindings
are generated.
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
Michal Polkorab [Tue, 20 May 2014 13:26:09 +0000 (15:26 +0200)]
Bug 1048 - Removed dependency on model-flow-service
Change-Id: Ie2065b47e02b7cd203227213b66050957f0760a9
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Robert Varga [Sat, 17 May 2014 07:16:32 +0000 (09:16 +0200)]
DelegatingInboundHandler.consumer is mandatory
The consumer is mandatory and constant, make it final and check for
nulls.
Change-Id: I44585c03284669033639ecf5dd9bd61ab48fedf7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 17 May 2014 07:12:33 +0000 (09:12 +0200)]
PublishingChannelInitializer.allChannels is final
Add final keyword as appropriate.
Change-Id: Idfbadf4f1cc6f296fddcaaf49a2fb18775d63671
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Robert Varga [Sat, 17 May 2014 07:05:59 +0000 (09:05 +0200)]
Optimize checkListeners()
This changes the use of StringBuffer to StringBuilder. Also use
Preconditions.checkState().
Change-Id: I378cc84d7b70010cd9559ad6ef3a278ce5f07c90
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Robert Varga [Sat, 17 May 2014 07:00:16 +0000 (09:00 +0200)]
Share cache RemovalListener
The removal listener can be easily be shared among instances -- so
create only one shared instance for all ConnectionAdapterImpls.
Change-Id: I3d47d30eb537b86a35f42a69ff590b623a99e035
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Robert Varga [Sat, 17 May 2014 06:56:29 +0000 (08:56 +0200)]
Remove ExitingDataObject
This class is unused -- remove it.
Change-Id: Ia1587c0318f7b98638c316a61bc7a41b18a541da
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Robert Varga [Sat, 17 May 2014 06:41:59 +0000 (08:41 +0200)]
ConnectionAdapterImpl fields should be private
This reduces visibility of protected fields to private, allowing us to
reason about their interactions.
Change-Id: Ie3954ad548c4fe20f98bda13cedf657513bd7d11
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Robert Varga [Sat, 17 May 2014 06:35:13 +0000 (08:35 +0200)]
ConnectionAdapterImpl is always bound to a channel
ConnectionAdapterImpl needs to have a channel -- so require it in the
costructor and make it final.
Change-Id: Id170afd055460c24b851cdb3969286c62eee22d0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Robert Varga [Fri, 16 May 2014 08:26:38 +0000 (10:26 +0200)]
Improve cache interactions
Do not interact with the XID request cache until the request completes.
Change-Id: I39a8b0bac94474a5a52ef461ed596e70bddfd087
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Ed Warnicke [Tue, 6 May 2014 18:24:18 +0000 (13:24 -0500)]
Initial openflowjava Karaf feature file
PatchSet2: Stop using wrap when unneeded.
PatchSet3: Removed spurious config-all feature
Change-Id: Ibe67d9debb841bf93dd846e1f694019dea3c43b2
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Michal Polkorab [Wed, 30 Apr 2014 10:26:24 +0000 (12:26 +0200)]
OF10ActionDeserializer and ActionDeserializer split into separate classes
- updated deserializer initializers
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 29 Apr 2014 13:50:04 +0000 (15:50 +0200)]
InstructionDeserializer split into separate deserializers
- created List deserialization classes
- added default experimenter deserializer intialization
- created default experimenter instruction deserializer
- MessageDeserializerRegistryHelper renamed to SimpleDeserializerRegistryHelper
+ unified its use for simple (MessageCodeKey) deserializers
- updated unit tests
Change-Id: I3f428fdd81f39a4cf96a826e208fee067e9c0b6f
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Mon, 28 Apr 2014 08:49:18 +0000 (10:49 +0200)]
InstructionSerializer split into separate serializers
- updated initialization of default Action and Instruction experimenter serializers
- CodingUtils replaced by ListSerializer
- added EnhancedTypeKeyMaker classes to create lookup keys
- added InstructionConstants
- updated unit tests
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: If27b8273aadc84ec93e90fbb08326cf7baeb3645
Michal Polkorab [Thu, 24 Apr 2014 14:56:32 +0000 (16:56 +0200)]
OF10ActionsSerializer and OF13ActionsSerializer split into separate actions (to allow easier action extensibility)
- OF13MatchEntriesRegistryHelper renamed to EnhancedKeyRegistryHelper
+ used also in ActionsInitializer
- added serializeActions into CodingUtils
- created static ActionConstants class
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I61b11f3acf8d961757e3753a40d26cb77dc02615
Michal Polkorab [Wed, 23 Apr 2014 12:37:31 +0000 (14:37 +0200)]
Added default experimenter serializers
- updated unit tests
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I5663f61d83ca40dad8a8c8dee42061175e817ec7
Michal Polkorab [Tue, 22 Apr 2014 11:07:02 +0000 (13:07 +0200)]
Extensibility refactoring
- RegistryInjector renamed to SerializerRegistryInjector
- EnhancedMessageTypeKey moved to api project to be visible outside library implementation
- SerializerRegistryImpl - unified Exception message
- MessageTypeKey - updated hashCode()
- also updated SerializationFactory key to .getImplementedInterface() instead of .getClass()
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Wed, 9 Apr 2014 06:19:47 +0000 (08:19 +0200)]
Extensibility support (deserialization part)
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ic73091b01614e76087b30ad79dbf9b6f8b39545c
Michal Polkorab [Thu, 3 Apr 2014 12:59:20 +0000 (14:59 +0200)]
Extensibility support (serialization part)
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I51778a009f9a20d6ba1f29b74ca1e3fc1350d8bd
Michal Rehak [Mon, 14 Apr 2014 16:35:03 +0000 (18:35 +0200)]
changes for config subsystem - BUG 754
integration - issue with initialization pending
added sal generator
changed SPI - SwitchConnectionProvider has 1:1 bound with ServerFacade
extended yang model of SwitchConnectionProvider configuration
restored exported packages for osgi
restored documentation generator
changed API in order to use ListenableFuture instead of plain Future
Change-Id: Ic21e3a0c1fd64584d98485567c26095674291548
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Polkorab [Thu, 27 Mar 2014 15:57:02 +0000 (08:57 -0700)]
Bumped Netty to 4.0.17.Final (to match controller's version)
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Tue, 25 Mar 2014 15:59:52 +0000 (08:59 -0700)]
ExperimenterAction length computation added
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 20 Mar 2014 10:53:59 +0000 (11:53 +0100)]
Added byte[] into ExperimenterAction
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Adam Brcek [Mon, 17 Feb 2014 14:23:44 +0000 (14:23 +0000)]
Merge "Fix for Bug#239"
Adam Brcek [Mon, 17 Feb 2014 14:21:12 +0000 (14:21 +0000)]
Merge "Bumped to SNAPSHOT dependencies - some dependencies moved to <dependencyManagement> - also bumped netty version to 4.0.15 Final (as there was a lot of fixes since 4.0.10 Final)"
Michal Polkorab [Mon, 17 Feb 2014 13:59:15 +0000 (14:59 +0100)]
Fix for Bug#239
Keys in models replaced by config false (as library does not use the models as configuration)
- rebased
Change-Id: I9e6311d912ce0fc89d8d71789366752f3764e86c
Signed-off-by: SahilShah <sahil4.s@tcs.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 13 Feb 2014 02:32:17 +0000 (18:32 -0800)]
Bumped to SNAPSHOT dependencies
- some dependencies moved to <dependencyManagement>
- also bumped netty version to 4.0.15 Final (as there was a lot of fixes since 4.0.10 Final)
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ib636921c0dd099b90f451c44d33ab1d00e4455bb
Michal Polkorab [Tue, 4 Feb 2014 00:19:40 +0000 (16:19 -0800)]
Minor model refactor
- added "-grouping" to groupings to distinguish structures
- moved match-grouping into openflow-extensible-match.yang
- fixed actions structure (list action-list)
- updated identities bases with "-base"
MERGE AFTER: https://git.opendaylight.org/gerrit/#/c/5109
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ie2bf3d446f8f5912796bd751e512189d6bf06018
Michal Polkorab [Mon, 3 Feb 2014 20:30:11 +0000 (12:30 -0800)]
Model updated with descriptions
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I32124b20c03f1b103ae7fec48437bd29ccaddeb1
Robert Varga [Tue, 28 Jan 2014 00:16:33 +0000 (01:16 +0100)]
Get rid of duplicate release repository
Change-Id: Ice6994f85130be3edae4d422d3c19d043ac56955
Signed-off-by: Robert Varga <rovarga@cisco.com>
jenkins-openflowjava [Tue, 28 Jan 2014 00:13:12 +0000 (00:13 +0000)]
[maven-release-plugin] prepare for next development iteration
jenkins-openflowjava [Tue, 28 Jan 2014 00:13:11 +0000 (00:13 +0000)]
[maven-release-plugin] prepare release openflow-protocol-parent-0.4
Adam Brcek [Tue, 28 Jan 2014 00:05:45 +0000 (00:05 +0000)]
Merge "Removed explicitly defined maven-deploy-plugin"
Michal Polkorab [Tue, 28 Jan 2014 00:03:01 +0000 (01:03 +0100)]
Removed explicitly defined maven-deploy-plugin
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
jenkins-openflowjava [Mon, 27 Jan 2014 23:01:43 +0000 (23:01 +0000)]
[maven-release-plugin] prepare for next development iteration
jenkins-openflowjava [Mon, 27 Jan 2014 23:01:42 +0000 (23:01 +0000)]
[maven-release-plugin] prepare release openflow-protocol-parent-0.3
jenkins-openflowjava [Mon, 27 Jan 2014 22:28:23 +0000 (22:28 +0000)]
[maven-release-plugin] prepare for next development iteration
jenkins-openflowjava [Mon, 27 Jan 2014 22:28:23 +0000 (22:28 +0000)]
[maven-release-plugin] prepare release openflow-protocol-parent-0.2
Michal Polkorab [Mon, 27 Jan 2014 21:52:18 +0000 (22:52 +0100)]
Updated controller versions
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ib532bb5c9485ffcc39beb6ae4eff9becc21365ec
Michal Polkorab [Mon, 27 Jan 2014 17:35:45 +0000 (18:35 +0100)]
Yangtools version bump
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ia8c9e0deb4bdede4c59c696ba0dd1af8cbef5c96
jenkins-openflowjava [Mon, 27 Jan 2014 13:18:34 +0000 (13:18 +0000)]
[maven-release-plugin] prepare for next development iteration
jenkins-openflowjava [Mon, 27 Jan 2014 13:18:33 +0000 (13:18 +0000)]
[maven-release-plugin] prepare release openflow-protocol-parent-0.1
Michal Polkorab [Sat, 25 Jan 2014 15:35:38 +0000 (16:35 +0100)]
Temporary fix for OF10 Stats - table
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I2077e06028cf53d93a13ccc0214d9e02a0ece727
Michal Polkorab [Sat, 25 Jan 2014 10:35:35 +0000 (11:35 +0100)]
Added copyright in yang files
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Fri, 24 Jan 2014 15:15:07 +0000 (16:15 +0100)]
Logging updated
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 16 Jan 2014 10:34:42 +0000 (11:34 +0100)]
Added scm and maven-release-plugin to pom.xml
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Wed, 22 Jan 2014 12:13:29 +0000 (13:13 +0100)]
Slf4j version fix (1.7.5 -> 1.7.2)
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Robert Varga [Sun, 19 Jan 2014 20:36:09 +0000 (21:36 +0100)]
Bump yangtools dependency to 0.6.0
Change-Id: I7f6e0b959d221114e839e0b7c3262c78f0e5eac2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ed Warnicke [Fri, 17 Jan 2014 21:38:01 +0000 (15:38 -0600)]
Removed legacy code that wasn't being used.
Change-Id: I502025fed4b1434fb8739b31902d75b464e53340
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Adam Brcek [Thu, 16 Jan 2014 17:59:36 +0000 (17:59 +0000)]
Merge "Updated pom.xml to build documentation only on jenkins merge-job"
Michal Polkorab [Thu, 16 Jan 2014 13:06:20 +0000 (14:06 +0100)]
Updated pom.xml to build documentation only on jenkins merge-job
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 16 Jan 2014 12:16:36 +0000 (13:16 +0100)]
Instructions fix - Write/Apply actions instructions now support sending drop action
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Wed, 15 Jan 2014 14:32:05 +0000 (15:32 +0100)]
MultipartReply Flowstats fix
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Idcc31c1e2b1b1c6e8725fe98cafa83145319984d
Adam Brcek [Tue, 14 Jan 2014 10:24:57 +0000 (10:24 +0000)]
Merge "Updated dependency versions of ODL components"
Michal Polkorab [Tue, 14 Jan 2014 09:47:49 +0000 (10:47 +0100)]
Updated dependency versions of ODL components
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 9 Jan 2014 15:42:20 +0000 (16:42 +0100)]
Experimenter support for TableFeatures
+ deserialization fix
+ MatchIdsReader renamed to MatchIdsDeserializer
+ MatchIdsWriter renamed to MatchIdsSerializer
Change-Id: I86dc16b7cc8c1d83e5212f3c3cd8502bb0f8335d
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Adam Brcek [Tue, 14 Jan 2014 07:26:56 +0000 (07:26 +0000)]
Merge "Removed System.out.println()"
Michal Polkorab [Mon, 13 Jan 2014 14:19:01 +0000 (15:19 +0100)]
Removed System.out.println()
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Mon, 13 Jan 2014 13:01:20 +0000 (14:01 +0100)]
Fix - bug 270
+ replaced Long.Size/Byte.Size with existing constant
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I0541cbb291fd9ec8a88b476316a000fd87c5f704
Michal Rehak [Mon, 13 Jan 2014 09:20:15 +0000 (10:20 +0100)]
replaced multiple repos with group/public repo
multiple (unneccessary) repos were causing nexus to freze
snapshot/release rules added in order to optimize artifact lookup
Change-Id: I0bf54536fb3f577c1c1c1e1b7001c87e5fefe87e
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Polkorab [Thu, 9 Jan 2014 15:52:53 +0000 (16:52 +0100)]
Fixed ByteBuf logging
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ic42ad3849c78ba2454805f4f88ad24f4878a5a41
Daniel Bartos [Thu, 9 Jan 2014 13:33:46 +0000 (13:33 +0000)]
Merge "TableFeatures deserialization fix"
Michal Polkorab [Thu, 9 Jan 2014 07:04:47 +0000 (08:04 +0100)]
TableFeatures deserialization fix
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 9 Jan 2014 07:50:45 +0000 (08:50 +0100)]
PortFeatures constructor fix
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Wed, 8 Jan 2014 12:11:13 +0000 (13:11 +0100)]
TableFeatures fix (partial)
- Instruction props
- NextTable props
- Action props
- Match props
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I2dccbc810a981578064e76310ad58afafcee9507
Michal Polkorab [Wed, 25 Dec 2013 13:25:46 +0000 (14:25 +0100)]
Fixed issues
- MultipartReply message deserialization
- OF10StatsReply message deserialization
- ByteBufUtils decodeNullTerminatedString()
- OF10Stats tests
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I1fecb9f389752e7160794815cd30c842c0394d08
Daniel Bartos [Tue, 7 Jan 2014 11:46:29 +0000 (11:46 +0000)]
Merge "Adding support for the git-review command line tool"
Daniel Bartos [Tue, 7 Jan 2014 10:36:21 +0000 (10:36 +0000)]
Merge "Fixed padding issue with set-field action."
Deepthi V V [Mon, 30 Dec 2013 11:54:54 +0000 (17:24 +0530)]
Fixed padding issue with set-field action.
Signed-off-by: Deepthi V V <deepthi.v.v@ericsson.com>
Colin McNamara [Mon, 30 Dec 2013 03:25:16 +0000 (19:25 -0800)]
Adding support for the git-review command line tool
The OpenStack doc workflow (and entire gerrit workflow) has the
option of using a tool called git-review that automates ChangeID:
creation and management,automates rebasing of local commits
as well as simplifies submiting to gerrit and pulling and
pushing reviews.
Usage of the tool is entirely optional, however it does require
a pointer file named .gitreview in the root of the repository
that is referenced.
I am totally new to this project, if you guys don't want to merge
this then no big deal. However I think this will help with dev's
coming over from OpenStack as it will provide a optional workflow
that is closer to the OpenStack workflow.
It is necessary to run git review -s to append the change-id into
git-hooks the first time you use the tool
Change-Id: Ifc41a637f818cdf8a2d4b6c22a4e6efea27c15ef
Signed-off-by: Colin McNamara <colin@2cups.com>
Ed Warnicke [Thu, 26 Dec 2013 03:53:24 +0000 (19:53 -0800)]
Fixed a bug in PortStatus decoding
PortStatusMessageFactory was neglecting to decode
the port name, and as a result was (among other things)
failing to correctly decode the port state (and actually
everything after port name in the message).
Change-Id: I6940e3255471996a38d8b5deefae520dac24eecc
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Adam Brcek [Mon, 23 Dec 2013 13:18:34 +0000 (13:18 +0000)]
Merge "Fixed decoder table key values"
Michal Polkorab [Sun, 22 Dec 2013 23:36:29 +0000 (00:36 +0100)]
Fixed decoder table key values
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Fri, 20 Dec 2013 09:59:20 +0000 (10:59 +0100)]
Match (de)serialization fixed + tests added
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ic948380dc99725fd169b620403f5aa7bf7bd3273
Daniel Bartos [Thu, 19 Dec 2013 10:10:09 +0000 (10:10 +0000)]
Merge "Fixed ipv6 address deserialization in match"
Daniel Bartos [Thu, 19 Dec 2013 08:30:55 +0000 (08:30 +0000)]
Merge "Removed enumeration ALL from FlowWildCardsV10"
Michal Polkorab [Thu, 19 Dec 2013 08:24:53 +0000 (09:24 +0100)]
Fixed ipv6 address deserialization in match
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Wed, 18 Dec 2013 15:04:32 +0000 (16:04 +0100)]
Added buffer clearing on failed serialization (prevents from sending incomplete messages)
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Wed, 18 Dec 2013 13:09:39 +0000 (14:09 +0100)]
Removed enumeration ALL from FlowWildCardsV10
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Daniel Bartos [Wed, 18 Dec 2013 09:49:53 +0000 (09:49 +0000)]
Merge "Added more tests"
Michal Polkorab [Tue, 17 Dec 2013 13:50:17 +0000 (14:50 +0100)]
Added more tests
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Thu, 12 Dec 2013 13:53:14 +0000 (14:53 +0100)]
Instructions quickfix + tests
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Iaf943a4e9b6d64628388d7d5809f845872c88d26
Deepthi V V [Sun, 15 Dec 2013 07:29:50 +0000 (12:59 +0530)]
1. Corrected Pbb-Isis match value length to 3 bytes as per OF 1.3 spec.
2. Corrected mac address length in match deserializer.
Signed-off-by: Deepthi V V <deepthi.v.v@ericsson.com>
Change-Id: I5be0c8356d46191bf6430b7b8f855e419d5162f3
Michal Polkorab [Fri, 13 Dec 2013 12:36:15 +0000 (13:36 +0100)]
Added enum table-values
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Michal Polkorab [Mon, 2 Dec 2013 12:05:26 +0000 (13:05 +0100)]
Yang model fixed
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I420b7df2237d1b87b1eb1cde1b98a3bf65c941fc
Michal Rehak [Wed, 11 Dec 2013 15:19:08 +0000 (16:19 +0100)]
added length check for mask
minor refactor
Change-Id: I894e517a211affe3498721d72ace60cc7bf49ff1
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Polkorab [Tue, 10 Dec 2013 09:29:24 +0000 (10:29 +0100)]
Copyright update
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: I44fde82346500c0c054b51b0eb21ef56a97be022
Michal Polkorab [Mon, 9 Dec 2013 15:16:35 +0000 (16:16 +0100)]
GroupId and MeterId used in model (as requested)
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Daniel Bartos [Tue, 10 Dec 2013 07:15:47 +0000 (07:15 +0000)]
Merge "OF1.3 matchSerializer (Ipv6 address) fix + test"
Code Review / openflowjava.git / log