Fix Mockito Generics 96/36196/1
authorandrej.leitner <anleitne@cisco.com>
Mon, 14 Mar 2016 14:54:06 +0000 (15:54 +0100)
committerandrej.leitner <anleitne@cisco.com>
Mon, 14 Mar 2016 14:54:59 +0000 (15:54 +0100)
 *fix Generic for mockito matcher
 *fix testGroupModConvertSortedBuckets

Change-Id: I8148c94cf572440a1cb9be7a0d962c8501cb3f42
Signed-off-by: andrej.leitner <anleitne@cisco.com>
openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsGatheringUtilsTest.java
openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/DeviceInitializationUtilsTest.java
openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/util/MdSalRegistrationUtilsTest.java
openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/ConcurrentSalRegistrationManagerTest.java
openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/OFRpcTaskUtilTest.java
openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/GroupConvertorTest.java
openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/core/session/SessionManagerOFImplTest.java
openflowplugin/src/test/java/org/opendaylight/openflowplugin/openflow/md/util/InventoryDataServiceUtilTest.java

index 4c7aebdcb923c39ce1441ca4af6f6deb7938fcd0..f52a56b54eb64639dc60f3e91dd4360b2ce7020a 100644 (file)
@@ -270,7 +270,7 @@ public class StatisticsGatheringUtilsTest {
         final org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.GroupId storedGroupId = new org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.GroupId(groupIdValue);
         final KeyedInstanceIdentifier<Group, GroupKey> groupPath = dummyNodePath.augmentation(FlowCapableNode.class).child(Group.class, new GroupKey(storedGroupId));
 
-        verify(deviceContext, Mockito.never()).addDeleteToTxChain(Matchers.eq(LogicalDatastoreType.OPERATIONAL), Matchers.any(InstanceIdentifier.class));
+        verify(deviceContext, Mockito.never()).addDeleteToTxChain(Matchers.eq(LogicalDatastoreType.OPERATIONAL), Matchers.<InstanceIdentifier<?>> any());
         verify(deviceGroupRegistry).removeMarked();
         verify(deviceGroupRegistry).store(storedGroupId);
         verify(deviceContext).writeToTransaction(
@@ -434,7 +434,7 @@ public class StatisticsGatheringUtilsTest {
         final KeyedInstanceIdentifier<Flow, FlowKey> flowPath = dummyNodePath.augmentation(FlowCapableNode.class)
                 .child(Table.class, new TableKey((short) 0))
                 .child(Flow.class, new FlowKey(new FlowId("openflow:21")));
-        verify(deviceContext, Mockito.never()).addDeleteToTxChain(Matchers.eq(LogicalDatastoreType.OPERATIONAL), Matchers.any(InstanceIdentifier.class));
+        verify(deviceContext, Mockito.never()).addDeleteToTxChain(Matchers.eq(LogicalDatastoreType.OPERATIONAL), Matchers.<InstanceIdentifier<?>>any());
         verify(deviceFlowRegistry).storeIfNecessary(FlowRegistryKeyFactory.create(flowBld.build()), (short) 0);
         verify(deviceContext).writeToTransaction(Matchers.eq(LogicalDatastoreType.OPERATIONAL), Matchers.eq(flowPath), Matchers.any(Flow.class));
     }
@@ -463,7 +463,7 @@ public class StatisticsGatheringUtilsTest {
                 new org.opendaylight.yang.gen.v1.urn.opendaylight.meter.types.rev130918.MeterId(meterIdValue);
         final KeyedInstanceIdentifier<Meter, MeterKey> meterPath = dummyNodePath.augmentation(FlowCapableNode.class)
                 .child(Meter.class, new MeterKey(meterId));
-        verify(deviceContext, Mockito.never()).addDeleteToTxChain(Matchers.eq(LogicalDatastoreType.OPERATIONAL), Matchers.any(InstanceIdentifier.class));
+        verify(deviceContext, Mockito.never()).addDeleteToTxChain(Matchers.eq(LogicalDatastoreType.OPERATIONAL), Matchers.<InstanceIdentifier<?>>any());
         verify(deviceMeterRegistry).store(meterId);
         verify(deviceContext).writeToTransaction(Matchers.eq(LogicalDatastoreType.OPERATIONAL), Matchers.eq(meterPath), Matchers.any(Meter.class));
     }
index 41e2921358f8a480094a6dea65af81f013b68df6..56850376c181f0803203a55ca16db05121f0cf55 100644 (file)
@@ -14,19 +14,17 @@ import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
-
+import com.google.common.collect.Lists;
+import com.google.common.util.concurrent.CheckedFuture;
+import com.google.common.util.concurrent.FutureCallback;
+import com.google.common.util.concurrent.Futures;
+import com.google.common.util.concurrent.ListenableFuture;
 import java.math.BigInteger;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
 import java.util.Set;
-
-import com.google.common.collect.Lists;
-import com.google.common.util.concurrent.CheckedFuture;
-import com.google.common.util.concurrent.FutureCallback;
-import com.google.common.util.concurrent.Futures;
-import com.google.common.util.concurrent.ListenableFuture;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -147,34 +145,34 @@ public class DeviceInitializationUtilsTest {
     }
     @Test
     public void chainTableTrunkWriteOF10Test() {
-        DeviceState mockedDeviceState = mock(DeviceState.class);
+        final DeviceState mockedDeviceState = mock(DeviceState.class);
 
-        GetFeaturesOutput mockedFeatures = mock(GetFeaturesOutput.class);
+        final GetFeaturesOutput mockedFeatures = mock(GetFeaturesOutput.class);
         when(mockedFeatures.getTables()).thenReturn((short) 2);
         when(mockedDeviceState.getFeatures()).thenReturn(mockedFeatures);
 
         when(mockedDeviceState.getNodeInstanceIdentifier()).thenReturn(DUMMY_NODE_II);
         when(mockedDeviceContext.getDeviceState()).thenReturn(mockedDeviceState);
 
-        RpcResult<List<MultipartReply>> mockedRpcResult = mock(RpcResult.class);
+        final RpcResult<List<MultipartReply>> mockedRpcResult = mock(RpcResult.class);
         when(mockedRpcResult.isSuccessful()).thenReturn(true);
-        List<RpcResult<List<MultipartReply>>> data = new ArrayList<RpcResult<List<MultipartReply>>>();
+        final List<RpcResult<List<MultipartReply>>> data = new ArrayList<RpcResult<List<MultipartReply>>>();
         data.add(mockedRpcResult);
         data.add(mockedRpcResult);
 
         DeviceInitializationUtils.chainTableTrunkWriteOF10(mockedDeviceContext, Futures.immediateFuture(data));
-        verify(mockedDeviceContext, times(3))
-                .writeToTransaction(any(LogicalDatastoreType.class), any(InstanceIdentifier.class), any(FlowCapableNode.class));
+        verify(mockedDeviceContext, times(3)).writeToTransaction(any(LogicalDatastoreType.class),
+                Matchers.<InstanceIdentifier<FlowCapableNode>> any(), any(FlowCapableNode.class));
     }
 
     @Test
     public void testTranslateAndWriteReplyTypeDesc() {
         final ConnectionContext connectionContext = buildMockConnectionContext(OFConstants.OFP_VERSION_1_3);
         Mockito.when(mockedDeviceContext.getPrimaryConnectionContext()).thenReturn(connectionContext);
-        DeviceState deviceState = Mockito.mock(DeviceState.class);
+        final DeviceState deviceState = Mockito.mock(DeviceState.class);
         Mockito.when(mockedDeviceContext.getDeviceState()).thenReturn(deviceState);
 
-        Collection<MultipartReply> multipartReplyMessages = prepareDataforTypeDesc(mockedDeviceContext);
+        final Collection<MultipartReply> multipartReplyMessages = prepareDataforTypeDesc(mockedDeviceContext);
 
         DeviceInitializationUtils.translateAndWriteReply(MultipartType.OFPMPDESC, mockedDeviceContext, DUMMY_NODE_II, multipartReplyMessages);
         verify(mockedDeviceContext)
@@ -183,17 +181,17 @@ public class DeviceInitializationUtilsTest {
 
     @Test
     public void translateAndWriteReplyTypeTableFeatures() {
-        TableFeaturesBuilder tableFeature = new TableFeaturesBuilder();
+        final TableFeaturesBuilder tableFeature = new TableFeaturesBuilder();
         tableFeature.setTableId(DUMMY_TABLE_ID);
-        List<TableFeatures> tableFeatures = new ArrayList<>();
+        final List<TableFeatures> tableFeatures = new ArrayList<>();
         tableFeatures.add(tableFeature.build());
 
-        MultipartReplyTableFeatures multipartReplyTableFeatures = new MultipartReplyTableFeaturesBuilder().setTableFeatures(tableFeatures).build();
-        MultipartReplyTableFeaturesCaseBuilder multipartReplyTableFeaturesCaseBuilder = new MultipartReplyTableFeaturesCaseBuilder();
+        final MultipartReplyTableFeatures multipartReplyTableFeatures = new MultipartReplyTableFeaturesBuilder().setTableFeatures(tableFeatures).build();
+        final MultipartReplyTableFeaturesCaseBuilder multipartReplyTableFeaturesCaseBuilder = new MultipartReplyTableFeaturesCaseBuilder();
         multipartReplyTableFeaturesCaseBuilder.setMultipartReplyTableFeatures(multipartReplyTableFeatures);
 
-        MultipartReplyMessage multipartReplyMessage = new MultipartReplyMessageBuilder().setMultipartReplyBody(multipartReplyTableFeaturesCaseBuilder.build()).build();
-        Set<MultipartReply> multipartReplyMessages = Collections.<MultipartReply>singleton(multipartReplyMessage);
+        final MultipartReplyMessage multipartReplyMessage = new MultipartReplyMessageBuilder().setMultipartReplyBody(multipartReplyTableFeaturesCaseBuilder.build()).build();
+        final Set<MultipartReply> multipartReplyMessages = Collections.<MultipartReply>singleton(multipartReplyMessage);
         DeviceInitializationUtils.translateAndWriteReply(MultipartType.OFPMPTABLEFEATURES, mockedDeviceContext, DUMMY_NODE_II, multipartReplyMessages);
         verify(mockedDeviceContext)
                 .writeToTransaction(eq(LogicalDatastoreType.OPERATIONAL),
@@ -203,19 +201,19 @@ public class DeviceInitializationUtilsTest {
 
     @Test
     public void translateAndWriteReplyTypeMeterFeatures() {
-        DeviceState mockedDeviceState = mock(DeviceState.class);
+        final DeviceState mockedDeviceState = mock(DeviceState.class);
         when(mockedDeviceContext.getDeviceState()).thenReturn(mockedDeviceState);
 
-        MultipartReplyMeterFeaturesBuilder multipartReplyMeterFeaturesBuilder = new MultipartReplyMeterFeaturesBuilder();
+        final MultipartReplyMeterFeaturesBuilder multipartReplyMeterFeaturesBuilder = new MultipartReplyMeterFeaturesBuilder();
         multipartReplyMeterFeaturesBuilder.setBandTypes(new MeterBandTypeBitmap(true, true));
         multipartReplyMeterFeaturesBuilder.setCapabilities(new MeterFlags(true, true, true, true));
         multipartReplyMeterFeaturesBuilder.setMaxMeter(DUMMY_MAX_METER);
 
-        MultipartReplyMeterFeaturesCaseBuilder multipartReplyMeterFeaturesCaseBuilder = new MultipartReplyMeterFeaturesCaseBuilder();
+        final MultipartReplyMeterFeaturesCaseBuilder multipartReplyMeterFeaturesCaseBuilder = new MultipartReplyMeterFeaturesCaseBuilder();
         multipartReplyMeterFeaturesCaseBuilder.setMultipartReplyMeterFeatures(multipartReplyMeterFeaturesBuilder.build());
 
-        MultipartReplyMessage multipartReplyMessage = new MultipartReplyMessageBuilder().setMultipartReplyBody(multipartReplyMeterFeaturesCaseBuilder.build()).build();
-        Set<MultipartReply> multipartReplyMessages = Collections.<MultipartReply>singleton(multipartReplyMessage);
+        final MultipartReplyMessage multipartReplyMessage = new MultipartReplyMessageBuilder().setMultipartReplyBody(multipartReplyMeterFeaturesCaseBuilder.build()).build();
+        final Set<MultipartReply> multipartReplyMessages = Collections.<MultipartReply>singleton(multipartReplyMessage);
         DeviceInitializationUtils.translateAndWriteReply(MultipartType.OFPMPMETERFEATURES, mockedDeviceContext, DUMMY_NODE_II, multipartReplyMessages);
         verify(mockedDeviceContext)
                 .writeToTransaction(eq(LogicalDatastoreType.OPERATIONAL), eq(DUMMY_NODE_II.augmentation(NodeMeterFeatures.class)), any(NodeMeterFeatures.class));
@@ -224,19 +222,19 @@ public class DeviceInitializationUtilsTest {
 
     @Test
     public void translateAndWriteReplyTypeGroupFeatures() {
-        MultipartReplyGroupFeaturesBuilder multipartReplyGroupFeaturesBuilder = new MultipartReplyGroupFeaturesBuilder();
+        final MultipartReplyGroupFeaturesBuilder multipartReplyGroupFeaturesBuilder = new MultipartReplyGroupFeaturesBuilder();
         multipartReplyGroupFeaturesBuilder.setTypes(new GroupTypes(true, true, true, true));
         multipartReplyGroupFeaturesBuilder.setCapabilities(new GroupCapabilities(true, true, true, true));
-        ActionType actionType = new ActionType(true, true, true, true, true, true, true, true, true, true, true, true, true, true, true, true, true);
+        final ActionType actionType = new ActionType(true, true, true, true, true, true, true, true, true, true, true, true, true, true, true, true, true);
         multipartReplyGroupFeaturesBuilder.setActionsBitmap(Lists.newArrayList(actionType));
 
-        MultipartReplyGroupFeatures multipartReplyGroupFeatures = multipartReplyGroupFeaturesBuilder.build();
+        final MultipartReplyGroupFeatures multipartReplyGroupFeatures = multipartReplyGroupFeaturesBuilder.build();
 
-        MultipartReplyGroupFeaturesCaseBuilder multipartReplyGroupFeaturesCaseBuilder = new MultipartReplyGroupFeaturesCaseBuilder();
+        final MultipartReplyGroupFeaturesCaseBuilder multipartReplyGroupFeaturesCaseBuilder = new MultipartReplyGroupFeaturesCaseBuilder();
         multipartReplyGroupFeaturesCaseBuilder.setMultipartReplyGroupFeatures(multipartReplyGroupFeatures);
 
-        MultipartReplyMessage multipartReplyMessage = new MultipartReplyMessageBuilder().setMultipartReplyBody(multipartReplyGroupFeaturesCaseBuilder.build()).build();
-        Set<MultipartReply> multipartReplyMessages = Collections.<MultipartReply>singleton(multipartReplyMessage);
+        final MultipartReplyMessage multipartReplyMessage = new MultipartReplyMessageBuilder().setMultipartReplyBody(multipartReplyGroupFeaturesCaseBuilder.build()).build();
+        final Set<MultipartReply> multipartReplyMessages = Collections.<MultipartReply>singleton(multipartReplyMessage);
 
         DeviceInitializationUtils.translateAndWriteReply(MultipartType.OFPMPGROUPFEATURES, mockedDeviceContext, DUMMY_NODE_II, multipartReplyMessages);
         verify(mockedDeviceContext)
@@ -246,74 +244,74 @@ public class DeviceInitializationUtilsTest {
 
     @Test
     public void translateAndWriteReplyTypePortDesc() {
-        ConnectionContext mockedPrimaryConnectionContext = mock(ConnectionContext.class);
-        FeaturesReply mockedFeatures = mock(FeaturesReply.class);
+        final ConnectionContext mockedPrimaryConnectionContext = mock(ConnectionContext.class);
+        final FeaturesReply mockedFeatures = mock(FeaturesReply.class);
         when(mockedFeatures.getDatapathId()).thenReturn(new BigInteger(DUMMY_DATAPATH_ID));
         when(mockedPrimaryConnectionContext.getFeatures()).thenReturn(mockedFeatures);
         when(mockedDeviceContext.getPrimaryConnectionContext()).thenReturn(mockedPrimaryConnectionContext);
-        DeviceState mockedDeviceState = mock(DeviceState.class);
+        final DeviceState mockedDeviceState = mock(DeviceState.class);
         when(mockedDeviceState.getVersion()).thenReturn(OFConstants.OFP_VERSION_1_0);
         when(mockedDeviceContext.getDeviceState()).thenReturn(mockedDeviceState);
-        MessageTranslator mockedTranslator = mock(MessageTranslator.class);
+        final MessageTranslator mockedTranslator = mock(MessageTranslator.class);
         when(translatorLibrary.lookupTranslator(any(TranslatorKey.class))).thenReturn(mockedTranslator);
         when(mockedDeviceContext.oook()).thenReturn(translatorLibrary);
 
-        MultipartReplyPortDescBuilder multipartReplyPortDescBuilder = new MultipartReplyPortDescBuilder();
+        final MultipartReplyPortDescBuilder multipartReplyPortDescBuilder = new MultipartReplyPortDescBuilder();
 
-        PortsBuilder portsBuilder = new PortsBuilder();
+        final PortsBuilder portsBuilder = new PortsBuilder();
         portsBuilder.setPortNo(DUMMY_PORT_NUMBER);
 
         multipartReplyPortDescBuilder.setPorts(Lists.newArrayList(portsBuilder.build()));
 
-        MultipartReplyPortDescCaseBuilder multipartReplyPortDescCaseBuilder = new MultipartReplyPortDescCaseBuilder();
+        final MultipartReplyPortDescCaseBuilder multipartReplyPortDescCaseBuilder = new MultipartReplyPortDescCaseBuilder();
         multipartReplyPortDescCaseBuilder.setMultipartReplyPortDesc(multipartReplyPortDescBuilder.build());
 
-        MultipartReplyMessage multipartReplyMessage = new MultipartReplyMessageBuilder().setMultipartReplyBody(multipartReplyPortDescCaseBuilder.build()).build();
-        Set<MultipartReply> multipartReplyMessages = Collections.<MultipartReply>singleton(multipartReplyMessage);
+        final MultipartReplyMessage multipartReplyMessage = new MultipartReplyMessageBuilder().setMultipartReplyBody(multipartReplyPortDescCaseBuilder.build()).build();
+        final Set<MultipartReply> multipartReplyMessages = Collections.<MultipartReply>singleton(multipartReplyMessage);
 
         OpenflowPortsUtil.init();
         DeviceInitializationUtils.translateAndWriteReply(MultipartType.OFPMPPORTDESC, mockedDeviceContext, DUMMY_NODE_II, multipartReplyMessages);
-        verify(mockedDeviceContext)
-                .writeToTransaction(eq(LogicalDatastoreType.OPERATIONAL), any(InstanceIdentifier.class), any(NodeConnector.class));
+        verify(mockedDeviceContext).writeToTransaction(eq(LogicalDatastoreType.OPERATIONAL),
+                Matchers.<InstanceIdentifier<NodeConnector>> any(), any(NodeConnector.class));
     }
 
     @Test
     public void createSuccessProcessingCallbackTest() {
-        DeviceState mockedDeviceState = mock(DeviceState.class);
+        final DeviceState mockedDeviceState = mock(DeviceState.class);
         when(mockedDeviceContext.getDeviceState()).thenReturn(mockedDeviceState);
 
         final ConnectionContext connectionContext = buildMockConnectionContext(OFConstants.OFP_VERSION_1_3);
 
-        List<MultipartReply> multipartReplies = new ArrayList<>(prepareDataforTypeDesc(mockedDeviceContext));
-        RpcResult<List<MultipartReply>> result = RpcResultBuilder.<List<MultipartReply>>success(multipartReplies).build();
+        final List<MultipartReply> multipartReplies = new ArrayList<>(prepareDataforTypeDesc(mockedDeviceContext));
+        final RpcResult<List<MultipartReply>> result = RpcResultBuilder.<List<MultipartReply>>success(multipartReplies).build();
         ListenableFuture<RpcResult<List<MultipartReply>>> mockedRequestContextFuture = Futures.immediateFuture(result);
 
         DeviceInitializationUtils.createSuccessProcessingCallback(MultipartType.OFPMPDESC, mockedDeviceContext, DUMMY_NODE_II, mockedRequestContextFuture);
         verify(mockedDeviceContext).writeToTransaction(eq(LogicalDatastoreType.OPERATIONAL), eq(DUMMY_NODE_II.augmentation(FlowCapableNode.class)), any(FlowCapableNode.class));
 
-        RpcResult<List<MultipartReply>> rpcResult = RpcResultBuilder.<List<MultipartReply>>failed().withError(RpcError.ErrorType.PROTOCOL, "dummy error").build();
+        final RpcResult<List<MultipartReply>> rpcResult = RpcResultBuilder.<List<MultipartReply>>failed().withError(RpcError.ErrorType.PROTOCOL, "dummy error").build();
         mockedRequestContextFuture = Futures.immediateFuture(rpcResult);
         DeviceInitializationUtils.createSuccessProcessingCallback(MultipartType.OFPMPDESC, mockedDeviceContext, DUMMY_NODE_II, mockedRequestContextFuture);
         verify(mockedDeviceContext).writeToTransaction(eq(LogicalDatastoreType.OPERATIONAL), eq(DUMMY_NODE_II.augmentation(FlowCapableNode.class)), any(FlowCapableNode.class));
     }
 
     private Collection<MultipartReply> prepareDataforTypeDesc(final DeviceContext mockedDeviceContext) {
-        MultipartReplyDesc multipartReplyDesc = new MultipartReplyDescBuilder().build();
+        final MultipartReplyDesc multipartReplyDesc = new MultipartReplyDescBuilder().build();
 
-        MultipartReplyDescCaseBuilder multipartReplyDescCaseBuilder = new MultipartReplyDescCaseBuilder();
+        final MultipartReplyDescCaseBuilder multipartReplyDescCaseBuilder = new MultipartReplyDescCaseBuilder();
         multipartReplyDescCaseBuilder.setMultipartReplyDesc(multipartReplyDesc);
 
-        MultipartReplyMessage multipartReplyMessage = new MultipartReplyMessageBuilder().setMultipartReplyBody(multipartReplyDescCaseBuilder.build()).build();
+        final MultipartReplyMessage multipartReplyMessage = new MultipartReplyMessageBuilder().setMultipartReplyBody(multipartReplyDescCaseBuilder.build()).build();
         return Collections.<MultipartReply>singleton(multipartReplyMessage);
 
     }
 
-    protected ConnectionContext buildMockConnectionContext(short ofpVersion) {
+    protected ConnectionContext buildMockConnectionContext(final short ofpVersion) {
         when(mockFeatures.getVersion()).thenReturn(ofpVersion);
         when(outboundQueueProvider.reserveEntry()).thenReturn(43L);
         Mockito.doAnswer(new Answer<Void>() {
             @Override
-            public Void answer(InvocationOnMock invocation) throws Throwable {
+            public Void answer(final InvocationOnMock invocation) throws Throwable {
                 final FutureCallback<OfHeader> callBack = (FutureCallback<OfHeader>) invocation.getArguments()[2];
                 callBack.onSuccess(null);
                 return null;
@@ -325,8 +323,8 @@ public class DeviceInitializationUtilsTest {
         when(mockedConnectionAdapter.registerOutboundQueueHandler(Matchers.<OutboundQueueHandler>any(), Matchers.anyInt(), Matchers.anyLong()))
                 .thenAnswer(new Answer<OutboundQueueHandlerRegistration<OutboundQueueHandler>>() {
                     @Override
-                    public OutboundQueueHandlerRegistration<OutboundQueueHandler> answer(InvocationOnMock invocation) throws Throwable {
-                        OutboundQueueHandler handler = (OutboundQueueHandler) invocation.getArguments()[0];
+                    public OutboundQueueHandlerRegistration<OutboundQueueHandler> answer(final InvocationOnMock invocation) throws Throwable {
+                        final OutboundQueueHandler handler = (OutboundQueueHandler) invocation.getArguments()[0];
                         handler.onConnectionQueueChanged(outboundQueueProvider);
                         return null;
                     }
index 1147120edc8a23ffe5a727abe4f6163b6197dea3..0600c6ba0cadfa56b27bd7c93f696af5be038ec6 100644 (file)
 package org.opendaylight.openflowplugin.impl.util;
 
 
-import static org.mockito.Mockito.any;
+import static org.mockito.Matchers.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
-
 import java.math.BigInteger;
 import org.junit.Test;
+import org.mockito.Matchers;
 import org.opendaylight.openflowplugin.api.openflow.connection.ConnectionContext;
 import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext;
 import org.opendaylight.openflowplugin.api.openflow.rpc.RpcContext;
@@ -51,7 +51,7 @@ public class MdSalRegistrationUtilsTest {
         when(mockedDeviceContext.getPrimaryConnectionContext()).thenReturn(mockedConnectionContext);
         MdSalRegistrationUtils.registerMasterServices(mockedRpcContext,mockedDeviceContext, OfpRole.BECOMEMASTER);
         verify(mockedRpcContext, times(NUMBER_OF_RPC_SERVICE_REGISTRATION)).registerRpcServiceImplementation(
-                any(RpcService.class.getClass()), any(RpcService.class));
+                Matchers.<Class<RpcService>> any(), any(RpcService.class));
     }
 
 }
index bf0ba5a297a857edc439e8d45d262f75853d035d..351c566e1515eaf5888b82113b241d669bfd83f5 100644 (file)
@@ -110,7 +110,7 @@ public class ConcurrentSalRegistrationManagerTest {
         Mockito.when(connectionConductor.getVersion()).thenReturn(OFConstants.OFP_VERSION_1_3);
 
         // provider context - registration responder
-        Mockito.when(rpcProviderRegistry.addRoutedRpcImplementation(Matchers.any(Class.class), Matchers.any(RpcService.class)))
+        Mockito.when(rpcProviderRegistry.addRoutedRpcImplementation(Matchers.<Class<RpcService>>any(), Matchers.any(RpcService.class)))
         .then(new Answer<RoutedRpcRegistration<?>>() {
             @Override
             public RoutedRpcRegistration<?> answer(InvocationOnMock invocation) {
index 081b3006bda5121d18381e27fc961d06f5d8bdc1..93324e4a6b685d2dcbf14adf3629bf7efbc42a97 100644 (file)
@@ -71,28 +71,28 @@ public class OFRpcTaskUtilTest {
         when(featuresOutput.getVersion()).thenReturn(OFConstants.OFP_VERSION_1_3);
         when(messageDispatchService.barrier(Mockito.any(BarrierInput.class), Mockito.any(SwitchConnectionDistinguisher.class))).thenReturn(resultListenableFuture);
         when(ofRpcTaskContext.getRpcPool()).thenReturn(executorService);
-        when(executorService.submit(Mockito.any(Callable.class))).thenReturn(updateFlowRpcResultListenableFuture);
+        when(executorService.submit(Mockito.<Callable<RpcResult<UpdateFlowOutput>>> any())).thenReturn(updateFlowRpcResultListenableFuture);
     }
 
 
     @Test
     public void testManageBarrier() throws Exception {
-        Collection<RpcError> rpcErrors = OFRpcTaskUtil.manageBarrier(taskContext, true, connectionDistinguisher);
+        final Collection<RpcError> rpcErrors = OFRpcTaskUtil.manageBarrier(taskContext, true, connectionDistinguisher);
         assertNotNull(rpcErrors);
     }
 
     @Test
     public void testHookFutureNotification() throws Exception {
-        AddFlowInputBuilder flowInputBuilder = new AddFlowInputBuilder();
-        OFRpcTask<AddFlowInput, RpcResult<UpdateFlowOutput>> addFlowInputRpcResultOFRpcTask = OFRpcTaskFactory.createAddFlowTask(ofRpcTaskContext, flowInputBuilder.build(), connectionDistinguisher);
+        final AddFlowInputBuilder flowInputBuilder = new AddFlowInputBuilder();
+        final OFRpcTask<AddFlowInput, RpcResult<UpdateFlowOutput>> addFlowInputRpcResultOFRpcTask = OFRpcTaskFactory.createAddFlowTask(ofRpcTaskContext, flowInputBuilder.build(), connectionDistinguisher);
         OFRpcTaskUtil.hookFutureNotification(addFlowInputRpcResultOFRpcTask, updateFlowRpcResultListenableFuture, notificationProviderService, notificationComposer);
     }
 
     @Test
     public void testChainFutureBarrier() throws Exception {
-        AddFlowInputBuilder flowInputBuilder = new AddFlowInputBuilder();
+        final AddFlowInputBuilder flowInputBuilder = new AddFlowInputBuilder();
         flowInputBuilder.setBarrier(true);
-        OFRpcTask<AddFlowInput, RpcResult<UpdateFlowOutput>> addFlowInputRpcResultOFRpcTask = OFRpcTaskFactory.createAddFlowTask(ofRpcTaskContext, flowInputBuilder.build(), connectionDistinguisher);
+        final OFRpcTask<AddFlowInput, RpcResult<UpdateFlowOutput>> addFlowInputRpcResultOFRpcTask = OFRpcTaskFactory.createAddFlowTask(ofRpcTaskContext, flowInputBuilder.build(), connectionDistinguisher);
         OFRpcTaskUtil.chainFutureBarrier(addFlowInputRpcResultOFRpcTask, updateFlowRpcResultListenableFuture);
     }
 }
\ No newline at end of file
index 47951e6e0dd0bcafa1e20b568ea474493d07487b..5e3ab0843eea9a09bcfdeaa9e5fb46796e1db4b4 100644 (file)
@@ -9,12 +9,13 @@
  */
 package org.opendaylight.openflowplugin.openflow.md.core.sal.convertor;
 
+import com.google.common.collect.ImmutableList;
 import java.math.BigInteger;
 import java.util.ArrayList;
 import java.util.List;
-
 import org.junit.Assert;
 import org.junit.Test;
+import org.opendaylight.openflowplugin.openflow.md.util.OpenflowPortsUtil;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.Uri;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.CopyTtlInCaseBuilder;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.GroupActionCase;
@@ -44,8 +45,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev13
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.GroupModInputBuilder;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.buckets.grouping.BucketsList;
 
-import com.google.common.collect.ImmutableList;
-
 public class GroupConvertorTest {
 
     /**
@@ -54,63 +53,63 @@ public class GroupConvertorTest {
     @Test
     public void testGroupModConvertorwithallParameters() {
 
-        AddGroupInputBuilder addGroupBuilder = new AddGroupInputBuilder();
+        final AddGroupInputBuilder addGroupBuilder = new AddGroupInputBuilder();
 
         addGroupBuilder.setGroupId(new GroupId(10L));
 
         addGroupBuilder.setGroupType(GroupTypes.GroupAll);
-        List<Bucket> bucketList = new ArrayList<Bucket>();
-        List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
-        List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList1 = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
+        final List<Bucket> bucketList = new ArrayList<Bucket>();
+        final List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
+        final List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList1 = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
 
         int actionOrder = 0;
 
         // Action1
-        GroupActionBuilder groupActionBuilder = new GroupActionBuilder();
+        final GroupActionBuilder groupActionBuilder = new GroupActionBuilder();
         groupActionBuilder.setGroup("005");
-        GroupAction groupIdaction = groupActionBuilder.build();
-        ActionBuilder actionsB = new ActionBuilder();
+        final GroupAction groupIdaction = groupActionBuilder.build();
+        final ActionBuilder actionsB = new ActionBuilder();
         actionsB.setOrder(actionOrder++).setAction(new GroupActionCaseBuilder().setGroupAction(groupIdaction).build());
 
         // Action2:
-        GroupActionBuilder groupActionBuilder1 = new GroupActionBuilder();
+        final GroupActionBuilder groupActionBuilder1 = new GroupActionBuilder();
         groupActionBuilder1.setGroup("006");
-        GroupAction groupIdaction1 = groupActionBuilder.build();
-        ActionBuilder actionsB1 = new ActionBuilder();
+        final GroupAction groupIdaction1 = groupActionBuilder.build();
+        final ActionBuilder actionsB1 = new ActionBuilder();
         actionsB1.setOrder(actionOrder++).setAction(new GroupActionCaseBuilder().setGroupAction(groupIdaction1).build());
 
         actionsList.add(actionsB.build());
         actionsList.add(actionsB1.build());
 
 
-        BucketsBuilder bucketsB = new BucketsBuilder();
+        final BucketsBuilder bucketsB = new BucketsBuilder();
 
-        BucketBuilder bucketB = new BucketBuilder();
+        final BucketBuilder bucketB = new BucketBuilder();
         bucketB.setWeight(10);
         bucketB.setWatchPort(20L);
         bucketB.setWatchGroup(22L);
 
         bucketB.setAction(actionsList);
-        Bucket bucket = bucketB.build();
+        final Bucket bucket = bucketB.build();
 
         bucketList.add(bucket); // List of bucket
 
-        BucketBuilder bucketB1 = new BucketBuilder();
+        final BucketBuilder bucketB1 = new BucketBuilder();
         bucketB1.setWeight(50);
         bucketB1.setWatchPort(60L);
         bucketB1.setWatchGroup(70L);
 
         // Action1
-        CopyTtlInBuilder copyTtlB = new CopyTtlInBuilder();
-        CopyTtlIn copyTtl = copyTtlB.build();
-        ActionBuilder actionsB2 = new ActionBuilder();
+        final CopyTtlInBuilder copyTtlB = new CopyTtlInBuilder();
+        final CopyTtlIn copyTtl = copyTtlB.build();
+        final ActionBuilder actionsB2 = new ActionBuilder();
         actionsB2.setOrder(actionOrder++).setAction(new CopyTtlInCaseBuilder().setCopyTtlIn(copyTtl).build());
 
         // Action2:
-        SetMplsTtlActionBuilder setMplsTtlActionBuilder = new SetMplsTtlActionBuilder();
+        final SetMplsTtlActionBuilder setMplsTtlActionBuilder = new SetMplsTtlActionBuilder();
         setMplsTtlActionBuilder.setMplsTtl((short) 0X1);
-        SetMplsTtlAction setMAction = setMplsTtlActionBuilder.build();
-        ActionBuilder actionsB3 = new ActionBuilder();
+        final SetMplsTtlAction setMAction = setMplsTtlActionBuilder.build();
+        final ActionBuilder actionsB3 = new ActionBuilder();
 
         actionsB3.setOrder(actionOrder++).setAction(new SetMplsTtlActionCaseBuilder().setSetMplsTtlAction(setMAction).build());
 
@@ -120,16 +119,16 @@ public class GroupConvertorTest {
 
         bucketB1.setAction(actionsList);
 
-        Bucket bucket1 = bucketB1.build(); // second bucket
+        final Bucket bucket1 = bucketB1.build(); // second bucket
 
         bucketList.add(bucket1);
 
         bucketsB.setBucket(bucketList);// List of bucket added to the Buckets
-        Buckets buckets = bucketsB.build();
+        final Buckets buckets = bucketsB.build();
 
         addGroupBuilder.setBuckets(buckets);
 
-        GroupModInputBuilder outAddGroupInput = GroupConvertor.toGroupModInput(addGroupBuilder.build(), (short) 0X4, BigInteger.valueOf(1));
+        final GroupModInputBuilder outAddGroupInput = GroupConvertor.toGroupModInput(addGroupBuilder.build(), (short) 0X4, BigInteger.valueOf(1));
 
         Assert.assertEquals(GroupModCommand.OFPGCADD, outAddGroupInput.getCommand());
         Assert.assertEquals(GroupType.OFPGTALL, outAddGroupInput.getType());
@@ -139,9 +138,9 @@ public class GroupConvertorTest {
         Assert.assertEquals(20L, (long) outAddGroupInput.getBucketsList().get(0).getWatchPort().getValue());
         Assert.assertEquals((Long) 22L, outAddGroupInput.getBucketsList().get(0).getWatchGroup());
 
-        List<Action> outActionList = outAddGroupInput.getBucketsList().get(0).getAction();
+        final List<Action> outActionList = outAddGroupInput.getBucketsList().get(0).getAction();
         for (int outItem = 0; outItem < outActionList.size(); outItem++) {
-            Action action = outActionList
+            final Action action = outActionList
                     .get(outItem);
             if (action.getActionChoice() instanceof GroupActionCase) {
                 Assert.assertEquals((Long) 5L, ((GroupActionCase) action.getActionChoice()).getGroupAction().getGroupId());
@@ -153,9 +152,9 @@ public class GroupConvertorTest {
         Assert.assertEquals((Integer) 50, outAddGroupInput.getBucketsList().get(1).getWeight());
         Assert.assertEquals((long) 60, (long) outAddGroupInput.getBucketsList().get(1).getWatchPort().getValue());
         Assert.assertEquals((Long) 70L, outAddGroupInput.getBucketsList().get(1).getWatchGroup());
-        List<Action> outActionList1 = outAddGroupInput.getBucketsList().get(1).getAction();
+        final List<Action> outActionList1 = outAddGroupInput.getBucketsList().get(1).getAction();
         for (int outItem = 0; outItem < outActionList1.size(); outItem++) {
-            Action action = outActionList1
+            final Action action = outActionList1
                     .get(outItem);
             if (action.getActionChoice() instanceof GroupActionCase) {
 
@@ -173,13 +172,13 @@ public class GroupConvertorTest {
      */
     @Test
     public void testGroupModConvertorNoBucket() {
-        AddGroupInputBuilder addGroupBuilder = new AddGroupInputBuilder();
+        final AddGroupInputBuilder addGroupBuilder = new AddGroupInputBuilder();
 
         addGroupBuilder.setGroupId(new GroupId(10L));
 
         addGroupBuilder.setGroupType(GroupTypes.GroupAll);
 
-        GroupModInputBuilder outAddGroupInput = GroupConvertor.toGroupModInput(addGroupBuilder.build(), (short) 0X4, BigInteger.valueOf(1));
+        final GroupModInputBuilder outAddGroupInput = GroupConvertor.toGroupModInput(addGroupBuilder.build(), (short) 0X4, BigInteger.valueOf(1));
 
         Assert.assertEquals(GroupModCommand.OFPGCADD, outAddGroupInput.getCommand());
         Assert.assertEquals(GroupType.OFPGTALL, outAddGroupInput.getType());
@@ -193,14 +192,14 @@ public class GroupConvertorTest {
 
         int actionOrder = 0;
 
-        AddGroupInputBuilder addGroupBuilder = new AddGroupInputBuilder();
+        final AddGroupInputBuilder addGroupBuilder = new AddGroupInputBuilder();
 
         addGroupBuilder.setGroupId(new GroupId(10L));
 
         addGroupBuilder.setGroupType(GroupTypes.GroupFf);
-        List<Bucket> bucketList = new ArrayList<Bucket>();
-        List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
-        List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList1 = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
+        final List<Bucket> bucketList = new ArrayList<Bucket>();
+        final List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
+        final List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList1 = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
 
         // Action1: 005
         actionsList.add(assembleActionBuilder("005", actionOrder++).build());
@@ -208,17 +207,17 @@ public class GroupConvertorTest {
         actionsList.add(assembleActionBuilder("006", actionOrder++).build());
         // .. and mr.Bond is not coming today
 
-        BucketsBuilder bucketsB = new BucketsBuilder();
+        final BucketsBuilder bucketsB = new BucketsBuilder();
 
-        BucketBuilder bucketB = new BucketBuilder();
+        final BucketBuilder bucketB = new BucketBuilder();
 
         bucketB.setAction(actionsList);
-        Bucket bucket = bucketB.build();
+        final Bucket bucket = bucketB.build();
 
         bucketList.add(bucket); // List of bucket
 
 
-        BucketBuilder bucketB1 = new BucketBuilder();
+        final BucketBuilder bucketB1 = new BucketBuilder();
 
         // Action1
         actionsList1.add(assembleCopyTtlInBuilder(actionOrder++).build());
@@ -227,34 +226,34 @@ public class GroupConvertorTest {
 
         bucketB1.setAction(actionsList1);
 
-        Bucket bucket1 = bucketB1.build(); // second bucket
+        final Bucket bucket1 = bucketB1.build(); // second bucket
 
         bucketList.add(bucket1);
 
         bucketsB.setBucket(bucketList);// List of bucket added to the Buckets
-        Buckets buckets = bucketsB.build();
+        final Buckets buckets = bucketsB.build();
 
         addGroupBuilder.setBuckets(buckets);
 
-        GroupModInputBuilder outAddGroupInput = GroupConvertor.toGroupModInput(addGroupBuilder.build(), (short) 0X4, BigInteger.valueOf(1));
+        final GroupModInputBuilder outAddGroupInput = GroupConvertor.toGroupModInput(addGroupBuilder.build(), (short) 0X4, BigInteger.valueOf(1));
 
         Assert.assertEquals(GroupModCommand.OFPGCADD, outAddGroupInput.getCommand());
         Assert.assertEquals(GroupType.OFPGTFF, outAddGroupInput.getType());
 
         Assert.assertEquals(10L, outAddGroupInput.getGroupId().getValue().longValue());
 
-        List<Action> outActionList = outAddGroupInput.getBucketsList().get(0).getAction();
+        final List<Action> outActionList = outAddGroupInput.getBucketsList().get(0).getAction();
         for (int outItem = 0; outItem < outActionList.size(); outItem++) {
-            Action action = outActionList
+            final Action action = outActionList
                     .get(outItem);
             if (action.getActionChoice() instanceof GroupActionCase) {
                 Assert.assertEquals((Long) 5L, ((GroupActionCase) action.getActionChoice()).getGroupAction().getGroupId());
             }
         }
 
-        List<Action> outActionList1 = outAddGroupInput.getBucketsList().get(1).getAction();
+        final List<Action> outActionList1 = outAddGroupInput.getBucketsList().get(1).getAction();
         for (int outItem = 0; outItem < outActionList1.size(); outItem++) {
-            Action action = outActionList1
+            final Action action = outActionList1
                     .get(outItem);
             if (action.getActionChoice() instanceof GroupActionCase) {
                 Assert.assertEquals((Long) 6L, ((GroupActionCase) action.getActionChoice()).getGroupAction().getGroupId());
@@ -268,9 +267,9 @@ public class GroupConvertorTest {
     @Test
     public void testGroupModConvertSortedBuckets() {
 
-        int actionOrder = 0;
+        final int actionOrder = 0;
 
-        ArrayList<Bucket> bucket = new ArrayList<Bucket>();
+        final ArrayList<Bucket> bucket = new ArrayList<Bucket>();
 
         bucket.add(new BucketBuilder()
                         .setBucketId(new BucketId((long) 4))
@@ -343,7 +342,7 @@ public class GroupConvertorTest {
                     .build());
 
 
-        AddGroupInput input = new AddGroupInputBuilder()
+        final AddGroupInput input = new AddGroupInputBuilder()
                                     .setGroupId(new GroupId((long) 1))
                                     .setGroupName("Foo")
                                     .setGroupType(GroupTypes.GroupFf)
@@ -352,9 +351,11 @@ public class GroupConvertorTest {
                                                        .build())
                                     .build();
 
-        GroupModInputBuilder outAddGroupInput = GroupConvertor.toGroupModInput(input, (short) 0X4, BigInteger.valueOf(1));
+        OpenflowPortsUtil.init();
+
+        final GroupModInputBuilder outAddGroupInput = GroupConvertor.toGroupModInput(input, (short) 0X4, BigInteger.valueOf(1));
 
-        List<BucketsList> bucketList = outAddGroupInput.getBucketsList();
+        final List<BucketsList> bucketList = outAddGroupInput.getBucketsList();
         Assert.assertEquals( Long.valueOf(1), bucketList.get(0).getWatchGroup());
         Assert.assertEquals( Long.valueOf(3), bucketList.get(0).getWatchPort().getValue());
 
@@ -376,12 +377,12 @@ public class GroupConvertorTest {
     /**
      * @return
      */
-    private static ActionBuilder assembleSetMplsTtlActionBuilder(int actionOrder) {
-        SetMplsTtlActionBuilder setMplsTtlActionBuilder = new SetMplsTtlActionBuilder();
+    private static ActionBuilder assembleSetMplsTtlActionBuilder(final int actionOrder) {
+        final SetMplsTtlActionBuilder setMplsTtlActionBuilder = new SetMplsTtlActionBuilder();
         setMplsTtlActionBuilder.setMplsTtl((short) 0X1);
-        SetMplsTtlActionCaseBuilder setMplsTtlActionCaseBuilder = new SetMplsTtlActionCaseBuilder();
+        final SetMplsTtlActionCaseBuilder setMplsTtlActionCaseBuilder = new SetMplsTtlActionCaseBuilder();
         setMplsTtlActionCaseBuilder.setSetMplsTtlAction(setMplsTtlActionBuilder.build());
-        ActionBuilder actionsB3 = new ActionBuilder();
+        final ActionBuilder actionsB3 = new ActionBuilder();
         actionsB3.setOrder(actionOrder).setAction(setMplsTtlActionCaseBuilder.build());
         return actionsB3;
     }
@@ -389,11 +390,11 @@ public class GroupConvertorTest {
     /**
      * @return
      */
-    private static ActionBuilder assembleCopyTtlInBuilder(int actionOrder) {
-        CopyTtlInBuilder copyTtlB = new CopyTtlInBuilder();
-        CopyTtlInCaseBuilder copyTtlInCaseBuilder = new CopyTtlInCaseBuilder();
+    private static ActionBuilder assembleCopyTtlInBuilder(final int actionOrder) {
+        final CopyTtlInBuilder copyTtlB = new CopyTtlInBuilder();
+        final CopyTtlInCaseBuilder copyTtlInCaseBuilder = new CopyTtlInCaseBuilder();
         copyTtlInCaseBuilder.setCopyTtlIn(copyTtlB.build());
-        ActionBuilder actionsB2 = new ActionBuilder();
+        final ActionBuilder actionsB2 = new ActionBuilder();
         actionsB2.setOrder(actionOrder).setAction(copyTtlInCaseBuilder.build());
         return actionsB2;
     }
@@ -402,12 +403,12 @@ public class GroupConvertorTest {
      * @param groupName name of group
      * @return
      */
-    private static ActionBuilder assembleActionBuilder(String groupName, int actionOrder) {
-        GroupActionBuilder groupActionBuilder = new GroupActionBuilder();
+    private static ActionBuilder assembleActionBuilder(final String groupName, final int actionOrder) {
+        final GroupActionBuilder groupActionBuilder = new GroupActionBuilder();
         groupActionBuilder.setGroup(groupName);
-        GroupActionCaseBuilder groupActionCaseBuilder = new GroupActionCaseBuilder();
+        final GroupActionCaseBuilder groupActionCaseBuilder = new GroupActionCaseBuilder();
         groupActionCaseBuilder.setGroupAction(groupActionBuilder.build());
-        ActionBuilder actionsBld = new ActionBuilder();
+        final ActionBuilder actionsBld = new ActionBuilder();
         actionsBld.setOrder(actionOrder).setAction(groupActionCaseBuilder.build());
         return actionsBld;
     }
@@ -420,30 +421,30 @@ public class GroupConvertorTest {
 
         int actionOrder = 0;
 
-        AddGroupInputBuilder addGroupBuilder = new AddGroupInputBuilder();
+        final AddGroupInputBuilder addGroupBuilder = new AddGroupInputBuilder();
 
         addGroupBuilder.setGroupId(new GroupId(10L));
 
         addGroupBuilder.setGroupType(GroupTypes.GroupAll);
-        List<Bucket> bucketList = new ArrayList<Bucket>();
-        List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
-        List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList1 = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
+        final List<Bucket> bucketList = new ArrayList<Bucket>();
+        final List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
+        final List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actionsList1 = new ArrayList<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action>();
 
         // Action1
         actionsList.add(assembleActionBuilder("005", actionOrder++).build());
         // Action2:
         actionsList.add(assembleActionBuilder("006", actionOrder++).build());
 
-        BucketsBuilder bucketsB = new BucketsBuilder();
+        final BucketsBuilder bucketsB = new BucketsBuilder();
 
-        BucketBuilder bucketB = new BucketBuilder();
+        final BucketBuilder bucketB = new BucketBuilder();
 
         bucketB.setAction(actionsList);
-        Bucket bucket = bucketB.build();
+        final Bucket bucket = bucketB.build();
 
         bucketList.add(bucket); // List of bucket
 
-        BucketBuilder bucketB1 = new BucketBuilder();
+        final BucketBuilder bucketB1 = new BucketBuilder();
 
         // Action1
         actionsList1.add(assembleCopyTtlInBuilder(actionOrder++).build());
@@ -452,25 +453,25 @@ public class GroupConvertorTest {
 
         bucketB1.setAction(actionsList);
 
-        Bucket bucket1 = bucketB1.build(); // second bucket
+        final Bucket bucket1 = bucketB1.build(); // second bucket
 
         bucketList.add(bucket1);
 
         bucketsB.setBucket(bucketList);// List of bucket added to the Buckets
-        Buckets buckets = bucketsB.build();
+        final Buckets buckets = bucketsB.build();
 
         addGroupBuilder.setBuckets(buckets);
 
-        GroupModInputBuilder outAddGroupInput = GroupConvertor.toGroupModInput(addGroupBuilder.build(), (short) 0X4, BigInteger.valueOf(1));
+        final GroupModInputBuilder outAddGroupInput = GroupConvertor.toGroupModInput(addGroupBuilder.build(), (short) 0X4, BigInteger.valueOf(1));
 
         Assert.assertEquals(GroupModCommand.OFPGCADD, outAddGroupInput.getCommand());
         Assert.assertEquals(GroupType.OFPGTALL, outAddGroupInput.getType());
 
         Assert.assertEquals(10L, outAddGroupInput.getGroupId().getValue().longValue());
 
-        List<Action> outActionList = outAddGroupInput.getBucketsList().get(0).getAction();
+        final List<Action> outActionList = outAddGroupInput.getBucketsList().get(0).getAction();
         for (int outItem = 0; outItem < outActionList.size(); outItem++) {
-            Action action = outActionList
+            final Action action = outActionList
                     .get(outItem);
             if (action.getActionChoice() instanceof GroupActionCase) {
                 Assert.assertEquals((Long) 5L, ((GroupActionCase) action.getActionChoice()).getGroupAction().getGroupId());
@@ -479,9 +480,9 @@ public class GroupConvertorTest {
 
         }
 
-        List<Action> outActionList1 = outAddGroupInput.getBucketsList().get(1).getAction();
+        final List<Action> outActionList1 = outAddGroupInput.getBucketsList().get(1).getAction();
         for (int outItem = 0; outItem < outActionList1.size(); outItem++) {
-            Action action = outActionList1
+            final Action action = outActionList1
                     .get(outItem);
             if (action.getActionChoice() instanceof GroupActionCase) {
 
index f26afc70d45a47497db1073ed55e27524b23662c..4deaf1281279a7fb70bc5fbf42767eace2ab5590 100644 (file)
@@ -7,15 +7,14 @@
  */
 package org.opendaylight.openflowplugin.openflow.md.core.session;
 
+import static org.mockito.Matchers.any;
 import com.google.common.util.concurrent.ListeningExecutorService;
 import java.math.BigInteger;
 import java.net.InetSocketAddress;
 import org.junit.After;
-import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
-import org.mockito.ArgumentCaptor;
 import org.mockito.Matchers;
 import org.mockito.Mock;
 import org.mockito.Mockito;
@@ -29,22 +28,15 @@ import org.opendaylight.controller.sal.binding.api.RpcProviderRegistry;
 import org.opendaylight.openflowjava.protocol.api.connection.ConnectionAdapter;
 import org.opendaylight.openflowplugin.api.openflow.md.core.ConnectionConductor;
 import org.opendaylight.openflowplugin.api.openflow.md.core.NotificationEnqueuer;
-import org.opendaylight.openflowplugin.api.openflow.md.core.NotificationQueueWrapper;
 import org.opendaylight.openflowplugin.api.openflow.md.core.session.SessionContext;
 import org.opendaylight.openflowplugin.api.openflow.md.core.session.SessionManager;
 import org.opendaylight.openflowplugin.api.openflow.md.core.session.SwitchSessionKeyOF;
 import org.opendaylight.openflowplugin.openflow.md.core.role.OfEntityManager;
 import org.opendaylight.openflowplugin.openflow.md.core.sal.ModelDrivenSwitchImpl;
 import org.opendaylight.openflowplugin.openflow.md.core.sal.SalRegistrationManager;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowCapableNodeUpdated;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeUpdated;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.GetFeaturesOutputBuilder;
-import org.opendaylight.yangtools.yang.binding.Notification;
 import org.opendaylight.yangtools.yang.binding.RpcService;
 
-import static org.mockito.Matchers.any;
-
 /**
  * test of {@link SessionManagerOFImpl}
  */
@@ -87,19 +79,19 @@ public class SessionManagerOFImplTest {
         Mockito.when(context.getNotificationEnqueuer()).thenReturn(notificationEnqueuer);
 
         // provider context - registration responder
-        Mockito.when(rpcProviderRegistry.addRoutedRpcImplementation(any(Class.class), any(RpcService.class)))
+        Mockito.when(rpcProviderRegistry.addRoutedRpcImplementation(Matchers.<Class<RpcService>> any(), any(RpcService.class)))
         .then(new Answer<RoutedRpcRegistration<?>>() {
             @Override
-            public RoutedRpcRegistration<?> answer(InvocationOnMock invocation) {
-                Object[] args = invocation.getArguments();
-                RoutedRpcRegistration<RpcService> registration = Mockito.mock(RoutedRpcRegistration.class);
+            public RoutedRpcRegistration<?> answer(final InvocationOnMock invocation) {
+                final Object[] args = invocation.getArguments();
+                final RoutedRpcRegistration<RpcService> registration = Mockito.mock(RoutedRpcRegistration.class);
                 Mockito.when(registration.getInstance()).thenReturn((RpcService) args[1]);
                 return registration;
             }
         });
 
         // session listener - prepare registration and notification mockery
-        SalRegistrationManager sessionListener = new SalRegistrationManager();
+        final SalRegistrationManager sessionListener = new SalRegistrationManager();
         sessionListener.setPublishService(notificationProviderService);
         sessionListener.setRpcProviderRegistry(rpcProviderRegistry);
         sessionListener.setDataService(dataService);
@@ -131,7 +123,7 @@ public class SessionManagerOFImplTest {
     @Test
     public void testAddSessionContext() {
         // prepare mocks and values
-        GetFeaturesOutputBuilder featuresBld = new GetFeaturesOutputBuilder().setDatapathId(BigInteger.valueOf(42));
+        final GetFeaturesOutputBuilder featuresBld = new GetFeaturesOutputBuilder().setDatapathId(BigInteger.valueOf(42));
         featuresBld.setVersion((short) 123);
         Mockito.when(context.getFeatures()).thenReturn(featuresBld.build());
         Mockito.when(primaryConductor.getConnectionAdapter()).thenReturn(connectionAdapter);
index bb6964a971880265e16a135e054cfe9234f4bd56..24e3a829e8d847bbc4aa2f20086316c40144d060 100644 (file)
@@ -64,7 +64,7 @@ public class InventoryDataServiceUtilTest {
     @Before
     public void setupEnvironment() {
         when(dataBroker.newReadOnlyTransaction()).thenReturn(readOnlyTransaction);
-        when(readOnlyTransaction.read(Mockito.any(LogicalDatastoreType.class), Mockito.any(InstanceIdentifier.class))).thenReturn(Futures.immediateCheckedFuture(Optional.of(nodes)));
+        when(readOnlyTransaction.read(Mockito.any(LogicalDatastoreType.class), Mockito.<InstanceIdentifier<Nodes>>any())).thenReturn(Futures.immediateCheckedFuture(Optional.of(nodes)));
 
         OpenflowPortsUtil.init();
         OFSessionUtil.getSessionManager().setDataBroker(dataBroker);
@@ -91,7 +91,7 @@ public class InventoryDataServiceUtilTest {
      */
     @Test
     public void testReadNode(){
-        when(readOnlyTransaction.read(Mockito.any(LogicalDatastoreType.class), Mockito.any(InstanceIdentifier.class))).thenReturn(Futures.immediateCheckedFuture(Optional.of(node)));
+        when(readOnlyTransaction.read(Mockito.any(LogicalDatastoreType.class), Mockito.<InstanceIdentifier<Node>>any())).thenReturn(Futures.immediateCheckedFuture(Optional.of(node)));
         InstanceIdentifier<Node> instanceId = InstanceIdentifier.create(Node.class);
         Node node = InventoryDataServiceUtil.readNode(instanceId);
         assertNotNull(node);