jenkins-releng [Fri, 20 Dec 2019 09:34:11 +0000 (09:34 +0000)]
Bump versions by x.y.(z+1)
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Ia380643973a579b4a4ac7249ced28e12a6e46723
Robert Varga [Thu, 5 Dec 2019 21:12:31 +0000 (22:12 +0100)]
Eliminate TransactionInvokerImpl.successfulTransactionQueue
This queue is actually just a hand-off between the datastore callback
thread and the central thread. There is no need for such a queue, as
we can just properly synchronize access to the critical structures.
JIRA: OVSDB-428
Change-Id: Idba05aebfa7fd35dbdb706b8bfef03e3e03d7772
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 5 Dec 2019 20:52:08 +0000 (21:52 +0100)]
Speed up inputQueue interaction
The while() loop here is an open-coded Queue.drainTo(). Read the API
and lead a happy life (knowing the thread contention is much lower
now).
This should help with our ability to drain the input queue more
quickly as we will have less cacheline thrashing.
JIRA: OVSDB-428
Change-Id: I53f3b24fb354dd0b727de26cc55890a70994ae8f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 3 Dec 2019 20:36:44 +0000 (21:36 +0100)]
Get rid of useless (Hwvtep)SouthboundProvider thread
The thread instantiated here is useless and the comment is misleading:
ListenerRegistration.close() is specified to be safe in any context
and idempotent. Just get rid of the thread and close the registration
immediately.
This flushes out an immediate problem, where the test would deadlock
due to base test using directExecutor() for DTCLs -- i.e. simulating
execution which does not happen in production. To deal with that we
switch the test to use asynchronous DTCLs and add a simple synchronization
loop to wait for DTCL to trigger.
JIRA: OVSDB-454
Change-Id: I2e86acb9eb30529fcd5d5675005d6c81bd804ba5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
fc7b41b68a2fb132dc95e3f7688bcf74e647acd4)
Robert Varga [Wed, 4 Dec 2019 10:13:30 +0000 (11:13 +0100)]
Migrate OvsdbDataTreeChangeListenerTest
This migrates to use non-deprecated AbstractConcurrentDataBrokerTest,
which allows proper background processing of DTCLs.
JIRA: OVSDB-454
Change-Id: Ic98369564e3d45fdc38e6bbc992b548fe97ba360
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
64aeaec5e3d0d701dec14a07c8517ff0397b152a)
Robert Varga [Tue, 3 Dec 2019 20:27:35 +0000 (21:27 +0100)]
Eliminate server startup threads
These were necessary to clean up the server loop groups, but that
is no longer necessary as they have separate lifecycle. Now the
threads serve only the purpose for asynchronous start, which is
easily done with ChannelFutureLister.
Change-Id: I4eaff47cabde3c2551a65d288da455701b920485
JIRA: OVSDB-454
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
f86aa7253aadeb117f0a99f93a1a8cb646b2d95b)
Robert Varga [Tue, 3 Dec 2019 15:54:47 +0000 (16:54 +0100)]
Add support for using epoll Netty transport
Since we have GlobalNettyContext, we can easily provide the necessary
glue to select either epoll(7) or java.nio backend based on availability.
JIRA: OVSDB-331
Change-Id: Id79e13e21dd5bc2358b7a9567bd145a4ca166a39
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
13a7d507466f466865f26eb791ddd1543a3bb5eb)
Robert Varga [Tue, 3 Dec 2019 15:26:59 +0000 (16:26 +0100)]
Add NettyBootstrapFactory to hold OVSDB network threads
OvsdbConnectionService is rather bad at using threads efficiently,
as each individual client creates its own EventLoopGroup, which is
not shared with anyone.
This refactors bootstrap generation, so that it is tied to a global
thread factory.
JIRA: OVSDB-411
Change-Id: Ie16e123fa3de87fd4f148c54e610515db3f1de9e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
b49f959e3024f4385af914b8779c0e31a330cf99)
Robert Varga [Tue, 3 Dec 2019 14:27:29 +0000 (15:27 +0100)]
Reuse StringEncoders for all connections
StringEncoder is stateless and therefore can be shared across multiple
channel pipelines. Create a single instance for use by all connections.
Change-Id: I660cb90ac3de0476f5637d6a53a8c49826c71f1d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 3 Dec 2019 13:35:27 +0000 (14:35 +0100)]
Reuse MappingJsonFactory across all sessions
Heap dump analysis shows we are keeping a per-connection
MappingJsonFactory, which also means we have an ObjectMapper
associated with each connection.
Both MappingJsonFactory and ObjectMapper are documented as
thread-safe and noted to be best shared. Make sure we use a single
instance across all connections.
Change-Id: Ic13ea538eecba9a08d4dba9ac617f2f29abeaba7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 2 Dec 2019 14:59:39 +0000 (15:59 +0100)]
Do not use reflection in TransactCommandAggregator
We are using a simple dispatch to instantiate a known list of
commands. Rather than using reflection, we wire the internal array
to point directly to constructors, allowing us to invoke them without
reflection -- speeding them up, as access checking is not performed
at all. Also fixes a deprecation warning with Java 11.
Change-Id: I3061c3f1ae3a1a4dcc5a3887915ddca9ae6cf2c1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
9ad72607d311b7c003611fa0a1cb6d2a15d15ae6)
Robert Varga [Mon, 2 Dec 2019 13:26:52 +0000 (14:26 +0100)]
Fix NPEs in HwvtepOperGlobalListener
A connection may not be available form HwvtepConnectionManager, in
which case we would end up throwing a NPE, which floods logs
in HwvtepDataChangeListenerTest. Fix that by checking for missing
connection.
Change-Id: I61a729266948fa1f7cf5eea1ff9c9a674cbad51e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
a4d38b7bba375c1c4595c5f3ab7484a31e3d04bf)
Robert Varga [Mon, 2 Dec 2019 23:51:41 +0000 (00:51 +0100)]
RowUpdate should be a static class
RowUpdate does not reference any TableUpdate state, hence it should
be static. This allows users to shorten their references, as they
do not need to qualify TableUpdate specialization.
Change-Id: I0be3a88623a43df4eaa8abd74ff2ca6732a88e57
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
172079e11ec143aead9e2c9b63945965145d7977)
Robert Varga [Mon, 2 Dec 2019 01:09:25 +0000 (02:09 +0100)]
Eliminate OvsdbClientImpl duplication
CPD is pointing out a trivial duplication of monitor(). Fix that
by properly reusing the more flexible version().
Change-Id: I6bfd80ada7d8d2b1fe3f20007d933dd9be9c03b5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
ca0b5c323802f0b9d9f88c3df8b648f6e444c605)
Robert Varga [Fri, 29 Nov 2019 11:58:38 +0000 (12:58 +0100)]
Cleanup HwvtepConnectionManager.getHwvtepGlobalTableEntry()
Rework the flow of this method to get rid of unneeded null
initializer, making the results in error paths clearer.
Change-Id: If7361c71aefd78ae08a385dcfa7e312ad22f2d5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
83915d7ac784277b1df79bbc34ffa22a5c74369d)
Robert Varga [Fri, 29 Nov 2019 11:29:08 +0000 (12:29 +0100)]
Do not allow DatabaseSchema name/version to be mutated
The setters to do so are not used anywhere, eliminate them, making
it clear these two fields are final.
Change-Id: I817dfb0cc0791c2ad91671b6d5e637c8ae8a0d92
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
e93883f2dcf0bc9db2aee076ca851932b6549fc1)
Robert Varga [Fri, 29 Nov 2019 11:23:54 +0000 (12:23 +0100)]
Do not allow TableSchema columns to be directly set
This makes it obvious that the collection is largely controlled
by TableSchema, bringing it another step closer to being immutable.
Change-Id: Iacb375c3cafbe687966729626fe30a3d08e8f31e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
6ad4ee4a708a10734161a52afb903e6797991937)
Robert Varga [Fri, 29 Nov 2019 10:47:31 +0000 (11:47 +0100)]
Refactor ColumnType
This factors out the two known implementations, hiding them from
public view in process. Parsing from JSON is factored out so that
we do not have blank singletons just to hook parsing.
Change-Id: I3dd7b110fb0ca3fe18ef879a2c3d24523fc43419
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
a8293448cde818eb893470991b9bc179e181dbce)
Robert Varga [Fri, 29 Nov 2019 10:24:05 +0000 (11:24 +0100)]
Cleanup ColumnSchema
Fields should be private (making it obvious they are final) and
the fromJson() method should be properly generic.
Change-Id: Ic38e4179f1108f41882bd336b3a03b339d435f9c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
347d025f789d5a53f0d24d114905cd6fefd6c311)
Robert Varga [Fri, 29 Nov 2019 10:18:13 +0000 (11:18 +0100)]
Add generated serialVersionUUID to exceptions
Exceptions are serializable and therefore should have a serial
version. Fixes Eclipse warnings pointing this out.
Change-Id: I2cf04412709cf3214b53aa3ac5dc40f332f67295
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
8b8f15eaed3f4ff2e4acba53e04f2c34b6861e2f)
Robert Varga [Fri, 29 Nov 2019 09:27:52 +0000 (10:27 +0100)]
Make GenericTableSchema.fromJson() a factory method
This method is called from precisely one place, which is creating
a new object for the call. Turn allocation around, taking a step
towards immutable schemas.
Change-Id: I97c44da72bc3b63260941bcf7d480a9c0c9e3a4a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
f74cb36d4df75f1fcf20014166061e627849a9b0)
Robert Varga [Fri, 29 Nov 2019 09:08:26 +0000 (10:08 +0100)]
Move ObjectMapper to JsonRpcEndpoint
JSON mapping is an implementation detail of JsonRpcEndpoint, hence
move it to that class, allowing us to shed a field and statically
bind to it.
Change-Id: Ie0a314b3aa6c830d9cc5936eb4ec948823ba351c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
6ea8a455e8f3e1a2a099be256f97257a82dde409)
Robert Varga [Thu, 28 Nov 2019 20:52:24 +0000 (21:52 +0100)]
Improve schemas population
Fetching the schema is an asynchronous process, which means we could
end up with competing requests overwriting the schema. Make sure to
re-check presence when the resolution process completes.
Change-Id: I0a7076b7a476394d4815f3c8f544be7a9ffaddd8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
0faae677b33efe1dd5bec783f8e57c5c0a10cdc4)
Robert Varga [Mon, 8 Apr 2019 23:16:05 +0000 (01:16 +0200)]
Remove use of deprecated Guava methods
Pass down MoreExecutors.directExecutor() to future-proof the code.
Change-Id: Iaf847f2dbcce63bac685d5a22a35fc9b8085d06d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
2630eeeadf852d4327d9990f59e8c87d13c5e30e)
Robert Varga [Thu, 28 Nov 2019 13:39:59 +0000 (14:39 +0100)]
Turn JsonRpcEndpoint into a proper OvsdbRPC implementation
The Netty wiring and invocation handling is quite arcane here, relying
mostly on reflection to perform dispatch.
There is only a single direct user JsonRpcEndpoint, which expects
a OvsdbRPC to be exposed from it. Furthermore it is obvious that
JsonRpcEndpoint has a 1:1 correspondence with JsonRpcServiceBinderHandler
and that the invocation context used to pass request processing relies
on Netty Channel instance -- to which the JsonRpcEndpoint is already
bound.
This integrates JsonRpcServiceBinderHandler into JsonRpcEndpoint,
thus making the fusion obvious, eliminating the need to pass Object
context between the two.
Furthermore we eliminate JsonRpcEndpoint.getClient() and opt to make
JsonRpcEndpoint implement OvsdbRPC, providing a very clear connection
between the two and completely eliminating use of reflection in the
process.
Change-Id: I1cfcf784330fdf6e30a55fcaff6f5bd716d987e3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
fc3bf4c16d4bd71512ca991fcfc95d804c73c05e)
Robert Varga [Thu, 28 Nov 2019 12:59:02 +0000 (13:59 +0100)]
Reuse ObjectMapper across all connections
ObjectMapper is documented to be safe for sharing, make sure we
reuse a single instance across all connections.
Change-Id: Ia3ebbe1eb4772efaa1f68c0b0d4ee721431325b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
4d598cffc88333c551be88e45cef27f932b800bf)
Robert Varga [Thu, 28 Nov 2019 12:57:04 +0000 (13:57 +0100)]
Use a constant ObjectMapper in UpdateNotificationDeser
Rather than instantiating a fresh mapper for each request,
share a single pre-configured instance.
Change-Id: I231165f82dc950ae9e3adbfb816da123139cc878
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
4402e56b96f9d64e23efec322c42e6d2d7d5f3bb)
Robert Varga [Thu, 28 Nov 2019 12:49:05 +0000 (13:49 +0100)]
Use proper constant in JsonUtils
We are not using the Mapper here at all, just the writer. Make sure
we retain only the writer and make it a proper constant (to allow
JIT to do constant propagation).
Change-Id: I7df2a6234511c9dbf51509c495a59e642173fffe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
7b32c396b165fbecd707afb0d8753885816eaeed)
Robert Varga [Thu, 28 Nov 2019 12:45:04 +0000 (13:45 +0100)]
Do not reconfigure ObjectMapper in FutureTransformUtils
This is a shared ObjectMapper, which will be reconfigured on first
access -- we can do that upfront and save some cycles from the fast
path.
Change-Id: Ibdf27ff194350b96ee6aadeaa9725d4cfdc6e9db
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
d2410c0a3da59dfa11f03a74bc01f252db4894a5)
Robert Varga [Thu, 21 Nov 2019 03:35:14 +0000 (04:35 +0100)]
Bump odlparent/yangtools/mdsal to 4.0.14/2.1.14/3.0.13
Adopts upstream upgrades and fixes.
Change-Id: I14c1f3f3420f20c5a0dc090fb4941e3435afd812
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 20 Oct 2019 08:22:27 +0000 (10:22 +0200)]
Bump to odlparent-4.0.13/yangtools-2.1.13/mdsal-3.0.7
This picks up latest upgrades and fixes.
Change-Id: Ic268f6fa4ccd963af771c39dbcf6a5b455e353b5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 14 Sep 2019 06:49:02 +0000 (08:49 +0200)]
Fix checkstyle
This fixes up checkstyle violations.
Change-Id: I7ee4391b58eef76954157deb11b611a3837d0960
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
27d66a4602fca44386e6ab733b3d7748f9120b11)
Robert Varga [Mon, 28 Oct 2019 07:25:36 +0000 (08:25 +0100)]
Do not use Foo.toString() when logging
This was spotted in a JFR run, where JsonRpcEndpoint would consume
a lot of CPU formatting a logging object. Eliminate calls to toString()
in logging arguments, as the framework will call these when really
needed.
Change-Id: Id077c285074c1fd8012539ab7c144ddc4b286376
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
10119331189066c009db4f0000a39ae586cc164c)
jenkins-releng [Sat, 31 Aug 2019 12:44:16 +0000 (12:44 +0000)]
Bump versions by x.y.(z+1)
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Iebacc6bb1fbd2667bb99a70295ca366f97f6a1d1
Robert Varga [Thu, 15 Nov 2018 07:41:42 +0000 (08:41 +0100)]
Cleanup OvsdbDataTreeChangeListener
This patch restructures the logic a bit, so that it does not invoke
getData{After,Before}() multiple times, fixing Eclipse warnings and
improving performance.
Furthermore augmentation handling is refactored so that the two
cases (node/bridge) are handled in an if cascade, preserving type
safety.
Finally updateConnections() is refactored to use a switch statement
instead of multiple if conditions, which shows that delete of the
entire node are not handled -- a FIXME is placed there.
Change-Id: If5663ebd2944d7fe83c4928b96cedc0db0f90e19
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Nobin Mathew [Tue, 11 Sep 2018 06:06:10 +0000 (11:36 +0530)]
OVSDB-486 Fix Null Pointer Exception in OVSDB
Fix for Null Pointer Exception
Change-Id: I93227ab66df4529a9b8c127c4b41096335424cc3
Signed-off-by: Nobin Mathew <nobin.mathew@ericsson.com>
(cherry picked from commit
cfab9e1aefdd0c7bdb09770309f8ad05c4c2c6ce)
Robert Varga [Thu, 18 Jul 2019 13:38:51 +0000 (15:38 +0200)]
Bump mdsal to 3.0.10
This brings in latest fixes/improvements.
Change-Id: Ida49ef543f765fd8f828761d7804e5b51a93b1b3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 1 Jul 2019 07:45:13 +0000 (09:45 +0200)]
Bump mdsal to 3.0.9
This picks up latest fixes and improvements.
Change-Id: Ibb5923791ec576d6cb50bfb3a2a6078a129ff85b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 1 Jul 2019 07:45:01 +0000 (09:45 +0200)]
Bump odlparent to 4.0.11
This adopts latest upgrades.
Change-Id: Ib05b5e506f5c64aadd6bdb90e7cd52922590486d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Yi Yang [Wed, 5 Jun 2019 03:10:48 +0000 (23:10 -0400)]
Update docs/ovsdb-user-guide.rst and README
odl-ovsdb-openstack has been moved to netvirt and changed as
odl-netvirt-openstack, so update it to reflect current status.
JIRA: OVSDB-480
Change-Id: Ied1268898d0adc63894250b9733a974140bc31c4
Signed-off-by: Yi Yang <yangyi01@inspur.com>
jenkins-releng [Wed, 15 May 2019 00:05:52 +0000 (00:05 +0000)]
Bump versions by x.y.(z+1)
Change-Id: Ide65c36ab0b861c01150d4ed72b779f0e3bfca73
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Robert Varga [Wed, 24 Apr 2019 13:22:49 +0000 (15:22 +0200)]
Bump mdsal to 3.0.8
This brings in latest fixes and enhancements.
Change-Id: Iad3c8fa712dbc1ba69482772b239d2c109600823
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 24 Apr 2019 13:22:31 +0000 (15:22 +0200)]
Bump odlparent to 4.0.10
This brings in latest updates.
Change-Id: I4948552c56b68eae24d7ac1985a7bc8addb2bd9b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
jenkins-releng [Mon, 18 Mar 2019 22:21:52 +0000 (22:21 +0000)]
Bump versions by x.y.(z+1)
Change-Id: I107b54a9bde9a10862ee496874b355a6767952d7
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Robert Varga [Thu, 7 Feb 2019 13:38:48 +0000 (14:38 +0100)]
Remove useless tests
These tests are not asserting anything at all, remove them to reduce
static mocking proliferation for no value whatsoever.
Change-Id: I53b21da97d7b9c7cf6e64543e6fe73f2c08267e9
JIRA: OVSDB-476
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
4a6fd54eedf2f7275d43ac4da351b5c3abf8302d)
jenkins-releng [Fri, 1 Feb 2019 22:43:45 +0000 (22:43 +0000)]
Update .gitreview to stable/neon
Change-Id: I3380ecb1b1aeea57ed7e76afb66159a57a8cf235
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Robert Varga [Wed, 30 Jan 2019 16:19:53 +0000 (17:19 +0100)]
Remove duplicate artifact declarations
This fixes a few maven warnings about artifacts being declared
multiple times.
Change-Id: Ib6a7a31931883009868f6e4150a8cb0ed5718fd6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Tue, 29 Jan 2019 14:56:45 +0000 (15:56 +0100)]
utils: migrate to the mdsal DataBroker
This duplicates controller-based classes temporarily, so that we can
migrate hwvtepsouthbound and southbound separately.
Change-Id: I1ed7c137423deb149320df86f0abc090e1182df5
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Tue, 29 Jan 2019 10:02:25 +0000 (11:02 +0100)]
library: migrate to the mdsal DataBroker
Change-Id: I0540965fe40521dd2d18e2206fb2bb874e2f1e72
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Tue, 29 Jan 2019 17:34:23 +0000 (18:34 +0100)]
Add missing annotation dependencies for Java 11
Change-Id: I552dc74b2bb6832cc5419f309470a43430294443
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Harshini [Mon, 21 Jan 2019 08:40:49 +0000 (14:10 +0530)]
use annotations instead of XML for Blueprint
JIRA: OVSDB-474
Change-Id: Ie40dacf4b4a745d77d83bdc7e1b95fecad4fd276
Signed-off-by: Harshini <hm@luminanetworks.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Tue, 22 Jan 2019 08:50:39 +0000 (09:50 +0100)]
Bump to mdsal 3.0.6
Change-Id: Id4a938a3e8d8669b972df17ddf1d76f91ca686d0
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Mon, 21 Jan 2019 09:25:09 +0000 (10:25 +0100)]
Bump mdsal to 3.0.5
This aligns with odlparent-4.0.9 and yangtools-2.1.8.
Change-Id: I1800398e0f1cfbfc263164ea6eff878423d31b98
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Fri, 18 Jan 2019 15:33:50 +0000 (16:33 +0100)]
Bump to odlparent 4.0.9
Change-Id: Iabeeaae5001bb0fba3c84d22cedd82444b60f7b8
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Thu, 10 Jan 2019 15:53:07 +0000 (16:53 +0100)]
Bump mdsal to 3.0.4
This realigns odlparent/yangtools/mdsal and brings in the latest
improvements.
Change-Id: I6db0663fcf132b9e01839c2cc14dc611ea75aa60
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Wed, 2 Jan 2019 10:24:57 +0000 (11:24 +0100)]
Bump odlparent to 4.0.8
Change-Id: Ieee47dc9a810d99311bb1bfdeedc71655a612cab
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vishal Thapar [Fri, 4 Jan 2019 12:51:53 +0000 (18:21 +0530)]
Fix controller for ptcp manager
If a ptcp manager is set on OVS, we configure
controller through conneciton info. There are two
issues with this code today:
1. Doesn't work well for IPv6.
2. Doesn't check if connection is to same port
as configured in ptcp manager.
So we end up with an improper controller configured
basde on ptcp even if we already configured correct
ones from manager entries.
JIRA: OVSDB-475
Change-Id: Ic69be0a9a6f2fd96085b60cdc3ccb9f1022b54a8
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Robert Varga [Thu, 3 Jan 2019 14:14:08 +0000 (15:14 +0100)]
Migrate NumberUtils.isNumber()
This method is deprecated, use its replacement, isCreatable().
Change-Id: I47a6dc48e5da306f8a1c2fa2e0a19ca034756c28
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 3 Jan 2019 13:20:24 +0000 (14:20 +0100)]
Remove use StringUtils
Guava provides equivalent functionality, use that instead of
commons-lang3.
Change-Id: Ide5fb6606ea51d6a65518e5e57422b11c259d86a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 24 Dec 2018 17:50:29 +0000 (18:50 +0100)]
Bump mdsal to 3.0.3
This brings in latest fixes and alignes with odlparent-4.0.5.
Change-Id: I4626267cb5d322378e87b82045dd4f080a747e35
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Fri, 21 Dec 2018 09:11:21 +0000 (10:11 +0100)]
Bump to odlparent 4.0.5
Change-Id: Ib2f5fd0e462e8a1efdefc2e4e94acc109c688c19
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Tue, 13 Nov 2018 13:31:20 +0000 (14:31 +0100)]
Use targeted node type for bridge name search
The IdentifiableItem we're looking for when checking for a bridge name
is Node; this changes isBridgeOnOvsdbNode() to look for that
directly. If also changes toString() to a match-specific method to
avoid the temptation to use it for other purposes.
Change-Id: Ib20e2c909098af9e0643f12805d98c5f2a66b651
JIRA: OVSDB-470
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Tue, 13 Nov 2018 11:08:33 +0000 (12:08 +0100)]
reduce object allocation in SouthboundUtils.isBridgeOnOvsdbNode()
By avoiding any unnecessary toString() usage, but unfortunately not
being able to complete avoid it, without further/bigger/riskier changes.
This should help to reduce GC churn.
JIRA: OVSDB-470
Change-Id: I86cdba3c138a79b428acf960a2ddb035f2878ca9
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Mon, 26 Nov 2018 09:29:09 +0000 (10:29 +0100)]
Bump to mdsal-3.0.2
This bumps the dependency to 3.0.2.
Change-Id: I4ab38f4dce8983e310430328c4367c732a5af3ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Tim Rozet [Tue, 27 Nov 2018 16:44:53 +0000 (11:44 -0500)]
Fixes overwrite when adding termination point
A race condition was observed where OVSDB had already added the VTEP TP
to br-int, and following this Netvirt ELAN Manager added the patch port
(br-ex-patch) to br-int. Upon ELAN manager adding this using
SouthboundUtils addTerminationPoint, the previous VTEP was deleted. This
change modifies the addTerminationPoint to use a merge in MDSAL rather
than a put.
JIRA: OVSDB-472
Change-Id: I2afa7dc33ef915856774f431dd4c3d9bcd029155
Signed-off-by: Tim Rozet <trozet@redhat.com>
Stephen Kitt [Wed, 28 Nov 2018 10:01:47 +0000 (11:01 +0100)]
Log the address and port on bind errors
This ensures the address and port are available in the logs when we
fail to bind.
Change-Id: Iae6a6fd4d6f516d5dbd562a335d081181cff3b17
JIRA: OVSDB-473
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Wed, 7 Nov 2018 11:51:03 +0000 (12:51 +0100)]
Fix ovsdb compilation
southbound-impl relied on getting its dependencies transitively:
- sal-binding-api via aaa
- mdsal-dom-api via sal-core-api
Fix this up by specifying correct dependencies.
Change-Id: Iba60e8978c29a82f77c42d7ce1ee6052613fdcea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Fri, 12 Oct 2018 10:06:53 +0000 (12:06 +0200)]
Inject the certificate manager in the constructor
This simplifies wiring in other contexts (e.g. with Blueprint
annotations or Guice).
Change-Id: If76dae1ec26d3ef3e3488788b6a5b77d99bb70a1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vishal Thapar [Thu, 20 Sep 2018 15:08:36 +0000 (20:38 +0530)]
Upgrade to Neon base platform
This reverts the PowerMock and Mockito upgrades for the time being.
Change-Id: I46d935fed3ef44dede188ffd25295586010cc8a2
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Daniel Farrell [Thu, 11 Oct 2018 15:40:32 +0000 (15:40 +0000)]
Update docs header to Neon on master
This version name gets rendered into the main header of OVSDB's docs.
Now that these docs have moved from the docs repo to project-owned
repos, projects need to update this version themselves.
Should be Neon on master and Fluorine on stable/fluorine.
Change-Id: I82a4bffc06a894bbc643c496c0471f3fe413a280
Jira: DOCS-112
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Victor Pickard [Thu, 23 Aug 2018 17:09:13 +0000 (13:09 -0400)]
Close old OVSDB connection when ping fails
When rebooting a compute node, the ovsdb hostconfig is missing
from oper d/s.
The change resolves the issue, by closing the connection if
the ping/echo fails. The ping/echo is triggered when a new
connection comes in.
What was happening before this change, is that the new
connection from the rebooted compute node would be rejected
and closed, because the code saw an existing connection, and
had not yet "closed" the old connection, which would fail later,
about 3 seconds later.
Tested this with queens/oxygen by manually rebooting compute node
(sudo shutdown -r now) a number of times.
Many more details in the JIRA.
JIRA: OVSDB-444
Change-Id: I0c7e53b032fd53d0287bc28ae86f7ebda06cfabe
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Michael Vorburger [Wed, 10 Oct 2018 16:56:13 +0000 (18:56 +0200)]
fix broken build
due to today's I4f16674ba65f499944e4582fb900d90e873d14e2 (INFRAUTILS-51)
by using the new TestSystemReadyMonitor from infrautils ready
introduced in I545195b1b976f5951d2dc8e9599e7ab33bc407e9
Change-Id: I42cd734fa8df276b52112139b244b5846b6d7ba9
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 20 Sep 2018 03:34:38 +0000 (05:34 +0200)]
avoid any extra memory allocation in Version.fromString()
as this is called a lot, it's (apparently, Java Mission Control on a
scale lab test shows) worth it to avoid the RegExp Matcher and x3
intermediate String object allocations, which we can safe here by
implementing this a little smarter (lower level; feels like 6502!).
JIRA: OVSDB-469
Change-Id: I642e0bfd698e594d3c263f0a335b92f80fbde8c4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Vishal Thapar [Mon, 13 Aug 2018 07:31:57 +0000 (13:01 +0530)]
Incorrect IPv6 address for controller
getControllersFromOvsdbNode() method to uses ':' as
delimiter for protocol, IP and Port, which is broken
by IPv6 addresses which use : as delimiters for address
octets.
Fix is to handle IPv6 addresses differently.
JIRA: OVSDB-466
Change-Id: Ifc7070d0d3ba5e60a124dc612cdfc66cafa1527b
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Michael Vorburger [Mon, 27 Aug 2018 08:19:11 +0000 (10:19 +0200)]
fix broken build by adding new SystemReadyMonitor getFailureCause() impl
impact of I2420c5440366daee626da9b0ea62bbe322bc1cde
JIRA: INFRAUTILS-48
Change-Id: Ifa7255497361a17ab52784616b908efdde6f2dcd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Sat, 11 Aug 2018 07:51:29 +0000 (09:51 +0200)]
Remove references to mdsal-model-artifacts
This artifact is going away, migrate to mdsal-artifacts.
Change-Id: Iad90d1107f4b407dfd947761d96e97311496b759
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Anil Belur [Thu, 9 Aug 2018 12:40:15 +0000 (18:10 +0530)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: Id12d87739bba0216b9d0650b5bfce6a1eac91dbf
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Robert Varga [Sat, 28 Jul 2018 10:24:06 +0000 (12:24 +0200)]
Cleanup API assumptions
Migrate Identifier.Item use and allow DataObjectModification
to return a collection of implementations.
JIRA: MDSAL-342
Change-Id: I65e398ca6d6c1aabbd5a12eb75601cafb551d22e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Wed, 18 Jul 2018 16:06:42 +0000 (18:06 +0200)]
Bump to odlparent 3.1.3
Change-Id: If4a96d68f7e1bd195adb05149641538420c8afe6
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vishal Thapar [Mon, 23 Jul 2018 15:01:04 +0000 (20:31 +0530)]
Move OVSDB documentation from docs
Move OVSDB docs hosted in docs project
to OVSDB/docs.
Change-Id: Iac705f47a8b8a68662bd880b101bca32d4d719b1
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Robert Varga [Mon, 16 Jul 2018 09:34:08 +0000 (11:34 +0200)]
Use union's stringValue() method
getValue() clashes which user-derived names, migrate to stringValue(),
which also has a better type.
Change-Id: I66ca094de9fa378f576e75f1dbb057e7daee70f8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Jul 2018 02:54:02 +0000 (04:54 +0200)]
Do not mock IpAddress
There really is no need, we can use the generated implementation.
Change-Id: Ibe2514588385f54e1cca2fe4f1631f3f87b63389
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Jul 2018 02:51:22 +0000 (04:51 +0200)]
Do not mock Ipv4Address
There really is no need, we can use the generated implementation.
Change-Id: I11f5b6b6c026ae211f6ca365aea19a6e17601731
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Jul 2018 02:49:34 +0000 (04:49 +0200)]
Do not mock enumeration
This reworks mocking to eliminate open-mocked implementation, but
rather use a Guava implementation.
Change-Id: Ie4d557ca09a06d206c11160219687c006b8d2d07
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 17 Jul 2018 14:53:14 +0000 (16:53 +0200)]
Pull in minimal set of models
Rather than pulling in all mdsal models, require on the models
we specifically need.
JIRA: MDSAL-363
Change-Id: I63e2f4a01a82e361dd2847fed6796461692ba903
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Jul 2018 02:32:39 +0000 (04:32 +0200)]
Do not mock InetAddress
Rather than mocking it, create a known-good constant and rely on it.
Change-Id: I10fc205c122a77f94a7851a6fe38e9252bac73af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 17 Jul 2018 22:18:14 +0000 (00:18 +0200)]
Remove an unneded explicit cast
Implicit cast does better here, as inference works out nullness
mapping.
Change-Id: If1b7ecd8179290fae5b81151e0634b4b9a48d01f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 17 Jul 2018 22:16:44 +0000 (00:16 +0200)]
Move unchecked warnings
Tagging specific statements is better here, as there are only two. It makes
the method better protected and the code is more readable
('here I need to do a cast, which is deemed unsafe').
Change-Id: I7cb8fcfbe1080e6e869fff1de4ba227f84a78eeb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 17 Jul 2018 22:47:58 +0000 (00:47 +0200)]
Expose methods for testing
Using @VisibleForTesting to expose a method from private to package-private,
hence we do not need to use WhiteBox reflection and can do direct calls.
Change-Id: Ic6101b560595a74faaf7889dc496025f7eaf4a7f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 17 Jul 2018 13:01:09 +0000 (15:01 +0200)]
Do not squash PortNumber instances in test
There is no need to squash all PortNumbers to one instance, hence
reduce the use of mockito.
Change-Id: I403f6a12f1ccc6227830f40e6ee81476ae4b1488
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 17 Jul 2018 12:03:14 +0000 (14:03 +0200)]
Eliminate unneeded mocking of static methods
We really do not need to override behavior of contructors and
static methods, do not do that.
Change-Id: I6f2b3c31b9a3a17b42d106d97498176a0e955fbf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 17 Jul 2018 11:47:55 +0000 (13:47 +0200)]
Do not mock generated classes
These is no point in mocking classes which deliver well-defined
functionality. Just use them without mocking their contents.
Change-Id: I2dc91f2a1f383a163ebaed07f040ab416db5f17f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 17 Jul 2018 11:36:43 +0000 (13:36 +0200)]
Fix some eclipse warnings
Deprecation and unneeded raw types, this patch fixes them.
Change-Id: I5d05c3d32efeedaa30cd78563db76af1c04ec06f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 17 Jul 2018 11:30:41 +0000 (13:30 +0200)]
Remove powermock from library/impl
There is no need for powermock features in these tests, remove
the dependency.
Change-Id: Ic744f2d6e1fcda182e14c4c742b1042da97b1d2f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Sam Hague [Tue, 10 Jul 2018 19:58:24 +0000 (15:58 -0400)]
Add missing southbound.cfg to etc
Change-Id: I369096cbf8a9f31d3d6ec6629af694ef135f4fba
Signed-off-by: Sam Hague <shague@redhat.com>
K.V Suneelu Verma [Wed, 25 Apr 2018 10:07:39 +0000 (15:37 +0530)]
OVSDB-439 Stale connection check
if old client echo succeeds
do not notify new client as it has to wait
else
if all old clients got disconnected notify the new client
if new client gets disconnected remove it from pending clients
JIRA: OVSDB-439
JIRA: OVSDB-462
Change-Id: Id3cd37559825d7f0ef58331bfbd4757eae41d253
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Fri, 22 Jun 2018 11:43:02 +0000 (17:13 +0530)]
OVSDB-462 Bridge randomly missing in operds
After registering for eos check if eos state is set
if eos state is set go ahead and register for callbacks which evenutually
puts the bridge in operational datastore.
Added error log statement for transaction chain failures
Addressed connection flap race conditions.
If the bridge disconnects from one odl and connects to other odl.
Before disowning ownership, delete the bridge from oper store.
The second odl after getting the ownership will put it back in oper store.
Change-Id: I0fafa1c1d3a73523bc102e2d720fdcf65dba1e3f
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Robert Varga [Thu, 28 Jun 2018 17:36:18 +0000 (19:36 +0200)]
Update odl-jackson-2.8 version
This version should reference odlparent version, which unfortunately
is not properly exposed. Fix the declaration here while odlparent
fixes its artifacts.pom.
Change-Id: I871311a05a8c887e19ae9798df4998da00d21eab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Wed, 30 May 2018 13:45:35 +0000 (15:45 +0200)]
Bump odlparent to 3.1.2
Change-Id: I07dce263fb4b0dfcb998878d612c1955fa03da17
Signed-off-by: Stephen Kitt <skitt@redhat.com>
eaksahu [Wed, 16 May 2018 13:17:54 +0000 (18:47 +0530)]
NETVIRT-1241 : Preprovisioning of l2gw conf. fails
Removing use of ThreadLocals to avoid Np in this usecase when switch
gets connected after provisioning l2gw and l2gwconnection.
Change-Id: I78c826a80bf5ef484002d6cb052fc0e03458cfdb
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>
Code Review / ovsdb.git / log