jjb/integration/integration-test-jobs.yaml

   1
   2 - project:
   3     name: integration-test-jobs
   4     jobs:
   5         - 'integration-verify-python'
   6         - 'integration-csit-verify-1node-library'
   7         - 'integration-distribution-test-{stream}'
   8         - 'integration-patch-test-{stream}'
   9         - 'integration-multipatch-test-{stream}'
  10
  11     stream:
  12         - boron:
  13             branch: 'master'
  14             jdk: 'openjdk8'
  15             jre: 'openjdk8'
  16             csit-list: >
  17                 aaa-csit-1node-authn-only-{stream},
  18                 aaa-csit-1node-authn-all-{stream},
  19                 bgpcep-csit-1node-userfeatures-only-{stream},
  20                 bgpcep-csit-1node-userfeatures-all-{stream},
  21                 capwap-csit-1node-ac-only-{stream},
  22                 capwap-csit-1node-ac-all-{stream},
  23                 controller-csit-3node-clustering-only-{stream},
  24                 integration-csit-3node-basic-only-{stream},
  25                 integration-distribution-deploy-{stream},
  26                 integration-distribution-offline-{stream},
  27                 l2switch-csit-1node-switch-only-{stream},
  28                 l2switch-csit-1node-switch-all-{stream},
  29                 l2switch-csit-1node-scalability-only-{stream},
  30                 l2switch-csit-1node-scalability-all-{stream},
  31                 lispflowmapping-csit-1node-msmr-only-{stream},
  32                 lispflowmapping-csit-1node-msmr-all-{stream},
  33                 nemo-csit-1node-engine-all-{stream},
  34                 nemo-csit-1node-engine-only-{stream},
  35                 netconf-csit-1node-userfeatures-all-{stream},
  36                 netconf-csit-1node-userfeatures-only-{stream},
  37                 nic-csit-1node-basic-all-{stream},
  38                 nic-csit-1node-basic-only-{stream},
  39                 openflowplugin-csit-1node-flow-services-only-{stream},
  40                 openflowplugin-csit-1node-flow-services-lithium-redesign-only-{stream},
  41                 openflowplugin-csit-1node-flow-services-all-{stream},
  42                 openflowplugin-csit-1node-scalability-only-{stream},
  43                 openflowplugin-csit-1node-scalability-lithium-redesign-only-{stream},
  44                 openflowplugin-csit-1node-scalability-all-{stream},
  45                 openflowplugin-csit-1node-cbench-performance-only-{stream},
  46                 openflowplugin-csit-1node-cbench-performance-lithium-redesign-only-{stream},
  47                 openflowplugin-csit-1node-config-performance-only-{stream},
  48                 openflowplugin-csit-1node-config-performance-lithium-redesign-only-{stream},
  49                 openflowplugin-csit-3node-clustering-helium-design-only-{stream},
  50                 openflowplugin-csit-3node-clustering-only-{stream},
  51                 ovsdb-csit-3node-clustering-only-{stream},
  52                 ovsdb-csit-1node-netvirt-only-{stream},
  53                 ovsdb-csit-1node-netvirt-all-{stream},
  54                 ovsdb-csit-1node-southbound-only-{stream},
  55                 ovsdb-csit-1node-southbound-all-{stream},
  56                 packetcable-csit-1node-pcmm-only-{stream},
  57                 packetcable-csit-1node-pcmm-all-{stream},
  58                 snmp-csit-1node-basic-only-{stream},
  59                 snmp-csit-1node-basic-all-{stream},
  60                 sxp-csit-1node-basic-only-{stream},
  61                 sxp-csit-1node-basic-all-{stream},
  62                 sxp-csit-1node-filtering-only-{stream},
  63                 sxp-csit-1node-filtering-all-{stream},
  64                 sxp-csit-1node-topology-only-{stream},
  65                 sxp-csit-1node-topology-all-{stream},
  66                 topoprocessing-csit-1node-topology-operations-all-{stream},
  67                 topoprocessing-csit-1node-topology-operations-only-{stream},
  68                 tsdr-csit-1node-hbase-datastore-only-{stream},
  69                 usc-csit-1node-channel-only-{stream},
  70                 usc-csit-1node-channel-all-{stream},
  71                 vpnservice-csit-1node-vpnservice-only-{stream},
  72                 vpnservice-csit-1node-vpnservice-all-{stream},
  73                 vtn-csit-1node-manager-only-{stream}
  74
  75         - beryllium:
  76             branch: 'stable/beryllium'
  77             jdk: 'openjdk7'
  78             jre: 'openjdk7'
  79             csit-list: >
  80                 aaa-csit-1node-authn-only-{stream},
  81                 aaa-csit-1node-authn-all-{stream},
  82                 bgpcep-csit-1node-userfeatures-only-{stream},
  83                 bgpcep-csit-1node-userfeatures-all-{stream},
  84                 capwap-csit-1node-ac-only-{stream},
  85                 capwap-csit-1node-ac-all-{stream},
  86                 controller-csit-3node-clustering-only-{stream},
  87                 integration-csit-3node-basic-only-{stream},
  88                 integration-distribution-offline-{stream},
  89                 integration-distribution-deploy-{stream},
  90                 l2switch-csit-1node-switch-only-{stream},
  91                 l2switch-csit-1node-switch-all-{stream},
  92                 l2switch-csit-1node-scalability-only-{stream},
  93                 l2switch-csit-1node-scalability-all-{stream},
  94                 lispflowmapping-csit-1node-msmr-only-{stream},
  95                 lispflowmapping-csit-1node-msmr-all-{stream},
  96                 nemo-csit-1node-engine-all-{stream},
  97                 nemo-csit-1node-engine-only-{stream},
  98                 netconf-csit-1node-userfeatures-all-{stream},
  99                 netconf-csit-1node-userfeatures-only-{stream},
 100                 nic-csit-1node-basic-all-{stream},
 101                 nic-csit-1node-basic-only-{stream},
 102                 openflowplugin-csit-1node-flow-services-only-{stream},
 103                 openflowplugin-csit-1node-flow-services-lithium-redesign-only-{stream},
 104                 openflowplugin-csit-1node-flow-services-all-{stream},
 105                 openflowplugin-csit-1node-scalability-only-{stream},
 106                 openflowplugin-csit-1node-scalability-lithium-redesign-only-{stream},
 107                 openflowplugin-csit-1node-scalability-all-{stream},
 108                 openflowplugin-csit-1node-cbench-performance-only-{stream},
 109                 openflowplugin-csit-1node-cbench-performance-lithium-redesign-only-{stream},
 110                 openflowplugin-csit-1node-config-performance-only-{stream},
 111                 openflowplugin-csit-1node-config-performance-lithium-redesign-only-{stream},
 112                 openflowplugin-csit-3node-clustering-helium-design-only-{stream},
 113                 openflowplugin-csit-3node-clustering-only-{stream},
 114                 ovsdb-csit-3node-clustering-only-{stream},
 115                 ovsdb-csit-1node-netvirt-only-{stream},
 116                 ovsdb-csit-1node-netvirt-all-{stream},
 117                 ovsdb-csit-1node-southbound-only-{stream},
 118                 ovsdb-csit-1node-southbound-all-{stream},
 119                 packetcable-csit-1node-pcmm-only-{stream},
 120                 packetcable-csit-1node-pcmm-all-{stream},
 121                 snmp-csit-1node-basic-only-{stream},
 122                 snmp-csit-1node-basic-all-{stream},
 123                 sxp-csit-1node-basic-only-{stream},
 124                 sxp-csit-1node-basic-all-{stream},
 125                 sxp-csit-1node-filtering-only-{stream},
 126                 sxp-csit-1node-filtering-all-{stream},
 127                 sxp-csit-1node-topology-only-{stream},
 128                 sxp-csit-1node-topology-all-{stream},
 129                 topoprocessing-csit-1node-topology-operations-all-{stream},
 130                 topoprocessing-csit-1node-topology-operations-only-{stream},
 131                 tsdr-csit-1node-hbase-datastore-only-{stream},
 132                 usc-csit-1node-channel-only-{stream},
 133                 usc-csit-1node-channel-all-{stream},
 134                 vpnservice-csit-1node-vpnservice-only-{stream},
 135                 vpnservice-csit-1node-vpnservice-all-{stream},
 136                 vtn-csit-1node-manager-only-{stream},
 137                 vtn-csit-1node-manager-all-{stream},
 138                 vtn-csit-1node-coordinator-only-{stream}
 139
 140         - stable-lithium:
 141             branch: 'stable/lithium'
 142             jdk: 'openjdk7'
 143             jre: 'openjdk7'
 144             csit-list: >
 145                 aaa-csit-1node-authn-only-{stream},
 146                 aaa-csit-1node-authn-all-{stream},
 147                 bgpcep-csit-1node-userfeatures-only-{stream},
 148                 bgpcep-csit-1node-userfeatures-all-{stream},
 149                 capwap-csit-1node-ac-only-{stream},
 150                 capwap-csit-1node-ac-all-{stream},
 151                 controller-csit-3node-clustering-only-{stream},
 152                 integration-csit-3node-basic-only-{stream},
 153                 integration-distribution-offline-{stream},
 154                 l2switch-csit-1node-switch-only-{stream},
 155                 l2switch-csit-1node-switch-all-{stream},
 156                 l2switch-csit-1node-scalability-only-{stream},
 157                 l2switch-csit-1node-scalability-all-{stream},
 158                 lispflowmapping-csit-1node-all-only-{stream},
 159                 lispflowmapping-csit-1node-all-all-{stream},
 160                 netconf-csit-1node-userfeatures-all-{stream},
 161                 netconf-csit-1node-userfeatures-only-{stream},
 162                 nic-csit-1node-basic-all-{stream},
 163                 nic-csit-1node-basic-only-{stream},
 164                 openflowplugin-csit-1node-flow-services-only-{stream},
 165                 openflowplugin-csit-1node-flow-services-lithium-redesign-only-{stream},
 166                 openflowplugin-csit-1node-flow-services-all-{stream},
 167                 openflowplugin-csit-1node-scalability-only-{stream},
 168                 openflowplugin-csit-1node-scalability-lithium-redesign-only-{stream},
 169                 openflowplugin-csit-1node-scalability-all-{stream},
 170                 openflowplugin-csit-1node-cbench-performance-only-{stream},
 171                 openflowplugin-csit-1node-cbench-performance-lithium-redesign-only-{stream},
 172                 openflowplugin-csit-1node-config-performance-only-{stream},
 173                 openflowplugin-csit-1node-config-performance-lithium-redesign-only-{stream},
 174                 ovsdb-csit-1node-netvirt-only-{stream},
 175                 ovsdb-csit-1node-netvirt-all-{stream},
 176                 ovsdb-csit-1node-southbound-only-{stream},
 177                 ovsdb-csit-1node-southbound-all-{stream},
 178                 snmp-csit-1node-basic-only-{stream},
 179                 snmp-csit-1node-basic-all-{stream},
 180                 usc-csit-1node-channel-only-{stream},
 181                 usc-csit-1node-channel-all-{stream},
 182                 vpnservice-csit-1node-vpnservice-only-{stream},
 183                 vpnservice-csit-1node-vpnservice-all-{stream},
 184                 vtn-csit-1node-manager-li-only-{stream},
 185                 vtn-csit-1node-manager-li-all-{stream},
 186                 vtn-csit-1node-coordinator-only-{stream}
 187
 188         - stable-helium:
 189             branch: 'stable/helium'
 190             jdk: 'openjdk7'
 191             jre: 'openjdk7'
 192             csit-list: >
 193                 aaa-csit-1node-imds-authn-only-{stream},
 194                 aaa-csit-1node-imds-authn-all-{stream},
 195                 controller-csit-1node-imds-nsf-only-{stream},
 196                 controller-csit-1node-imds-nsf-all-{stream},
 197                 integration-csit-3node-basic-only-{stream},
 198                 l2switch-csit-1node-imds-switch-only-{stream},
 199                 l2switch-csit-1node-imds-switch-all-{stream},
 200                 lispflowmapping-csit-1node-imds-all-only-{stream},
 201                 lispflowmapping-csit-1node-imds-all-all-{stream},
 202                 openflowplugin-csit-1node-imds-flow-services-only-{stream},
 203                 openflowplugin-csit-1node-imds-flow-services-all-{stream},
 204                 vtn-csit-1node-imds-manager-only-{stream},
 205                 vtn-csit-1node-imds-manager-all-{stream}
 206
 207
 208
 209 # Template: integration-verify-python
 210 # Goal: Verify python scripts correct syntax
 211 # Operation: This job template performs a python tox check on any integration/test patch
 212
 213 - job-template:
 214     name: 'integration-verify-python'
 215
 216     project-type: freestyle
 217     node: dynamic_verify
 218     concurrent: true
 219
 220     logrotate:
 221         daysToKeep: '{build-days-to-keep}'
 222         numToKeep: '{build-num-to-keep}'
 223         artifactDaysToKeep: '{build-artifact-days-to-keep}'
 224         artifactNumToKeep: '{build-artifact-num-to-keep}'
 225
 226     parameters:
 227         - project-parameter:
 228             project: 'integration/test'
 229         - integration-patch-refspec:
 230             branch: '$GERRIT_REFSPEC'
 231
 232     scm:
 233         - integration-gerrit-scm:
 234             credentials-id: '{ssh-credentials}'
 235             basedir: 'test'
 236             refspec: '$PATCHREFSPEC'
 237             branch: 'master'
 238
 239     wrappers:
 240         - build-timeout
 241         - ssh-agent-credentials:
 242             users:
 243                 - '{ssh-credentials}'
 244
 245     triggers:
 246         - integration-trigger-patch-submitted:
 247             name: 'integration/test'
 248             branch: 'master'
 249             pattern: '**'
 250
 251     builders:
 252         - shell: |
 253             virtualenv $WORKSPACE/venv-tox
 254             source $WORKSPACE/venv-tox/bin/activate
 255             pip install tox argparse
 256             tox --version
 257             cd $WORKSPACE/test
 258             tox
 259
 260     publishers:
 261         - email-notification:
 262             email-prefix: '[integration]'
 263
 264 # Template: integration-csit-verify-1node-library
 265 # Goal: Verify changes in csit folder not covered by projects suite verify jobs (e.g. libraries or variables)
 266 # Operation: This job template performs a base openflow test when there is a change in the libraries folder
 267
 268 - job-template:
 269     name: 'integration-csit-verify-1node-library'
 270
 271     project-type: freestyle
 272     node: dynamic_robot
 273
 274     logrotate:
 275         daysToKeep: '{build-days-to-keep}'
 276         numToKeep: '{build-num-to-keep}'
 277         artifactDaysToKeep: '{build-artifact-days-to-keep}'
 278         artifactNumToKeep: '{build-artifact-num-to-keep}'
 279
 280     parameters:
 281         - project-parameter:
 282             project: 'integration/test'
 283         - integration-branch:
 284             branch: 'stable/beryllium'
 285         - integration-bundleurl:
 286             bundleurl: 'last'
 287         - integration-controller-scope:
 288             controller-scope: 'only'
 289         - integration-controller-features:
 290             controller-features: >
 291                 odl-clustering-test-app,
 292                 odl-openflowplugin-flow-services-ui,
 293                 odl-bgpcep-pcep,
 294                 odl-bgpcep-bgp,
 295                 odl-netconf-connector-all
 296         - integration-test-options:
 297             test-options: '-e adsal -v TIMEOUT_BUG_4220:10s'
 298         - integration-test-plan:
 299             test-plan: 'test-libraries.txt'
 300         - integration-patch-refspec:
 301             branch: '$GERRIT_REFSPEC'
 302         - integration-jdk-version:
 303             jdkversion: 'openjdk7'
 304             # TODO: Switch to openjdk8 from Boron on.
 305
 306     scm:
 307         - integration-gerrit-scm:
 308             credentials-id: '{ssh-credentials}'
 309             basedir: 'test'
 310             refspec: '$PATCHREFSPEC'
 311             branch: 'master'
 312
 313     wrappers:
 314         - build-timeout
 315         - integration-jclouds-controller-mininet:
 316             controller-vms: 1
 317             mininet-image: '{mininet-image}'
 318             mininet-vms: '{mininet-vms}'
 319             mininet-cloud-name: '{mininet-cloud-name}'
 320         - ssh-agent-credentials:
 321             users:
 322                 - '{ssh-credentials}'
 323
 324     triggers:
 325         - integration-trigger-patch-submitted:
 326             name: 'integration/test'
 327             branch: 'master'
 328             pattern: 'csit/libraries/*'
 329
 330     builders:
 331         - integration-cleanup-workspace
 332         - integration-install-robotframework
 333         - inject:
 334             properties-file: 'env.properties'
 335         - integration-get-slave-addresses
 336         - inject:
 337             properties-file: 'slave_addresses.txt'
 338         - integration-get-bundle-vars
 339         - inject:
 340             properties-file: 'bundle_vars.txt'
 341         - integration-deploy-controller-run-test
 342         - integration-cleanup-tmp
 343
 344     publishers:
 345         - integration-robot:
 346             unstable-if: 0.0
 347             pass-if: 100.0
 348         - archive:
 349             artifacts: 'karaf.log*'
 350         - email-notification:
 351             email-prefix: '[integration]'
 352
 353 # Template: integration-distribution-test-{stream}
 354 # Goal: Verify a distribution through all system test available
 355 # Operation: This daily job template takes a distribution and passes all available system test
 356
 357 - job-template:
 358     name: 'integration-distribution-test-{stream}'
 359
 360     project-type: freestyle
 361     node: dynamic_verify
 362
 363     logrotate:
 364         daysToKeep: '{build-days-to-keep}'
 365         numToKeep: '{build-num-to-keep}'
 366         artifactDaysToKeep: '{build-artifact-days-to-keep}'
 367         artifactNumToKeep: '{build-artifact-num-to-keep}'
 368
 369     parameters:
 370         - integration-bundleurl:
 371             bundleurl: 'last'
 372         - integration-jdk-version:
 373             jdkversion: '{jre}'
 374
 375     triggers:
 376         - timed: 'H H * * 6'
 377
 378     builders:
 379         - trigger-builds:
 380             - project: '{csit-list}'
 381               block: true
 382               predefined-parameters:
 383                   BUNDLEURL=$BUNDLEURL
 384                   JDKVERSION=$JDKVERSION
 385
 386     publishers:
 387         - email-notification:
 388             email-prefix: '[integration]'
 389
 390 # Template: integration-patch-test-{stream}
 391 # Goal: Build a patch and run all available system test on a distribution containing the change
 392 # Operation: This job template builds a patch, creates a distribution containing the patch, and
 393 # triggers the distribution test when test-integration is used in gerrit comments
 394
 395 - job-template:
 396     name: 'integration-patch-test-{stream}'
 397
 398     project-type: maven
 399     node: dynamic_verify
 400     jdk: '{jdk}'
 401
 402     logrotate:
 403         daysToKeep: '{build-days-to-keep}'
 404         numToKeep: '{build-num-to-keep}'
 405         artifactDaysToKeep: '{build-artifact-days-to-keep}'
 406         artifactNumToKeep: '{build-artifact-num-to-keep}'
 407
 408     parameters:
 409         - gerrit-project-parameter:
 410             project: '$GERRIT_PROJECT'
 411         - gerrit-refspec-parameter:
 412             refspec: '$GERRIT_REFSPEC'
 413         - project-parameter:
 414             project: '$GERRIT_PROJECT'
 415         - integration-branch:
 416             branch: '{branch}'
 417         - integration-distribution-git-url
 418
 419     scm:
 420         - integration-gerrit-scm:
 421             credentials-id: '{ssh-credentials}'
 422             basedir: '$GERRIT_PROJECT'
 423             refspec: '$GERRIT_REFSPEC'
 424             branch: '{branch}'
 425         - integration-distribution-scm:
 426             credentials-id: '{ssh-credentials}'
 427             branch: '{branch}'
 428
 429     wrappers:
 430         - build-timeout
 431         - ssh-agent-credentials:
 432             users:
 433                 - '{ssh-credentials}'
 434
 435     triggers:
 436         - gerrit:
 437             server-name: 'OpenDaylight'
 438             trigger-on:
 439                 - comment-added-contains-event:
 440                     comment-contains-value: 'test-integration'
 441             projects:
 442               - project-compare-type: 'ANT'
 443                 project-pattern: '**'
 444                 branches:
 445                   - branch-compare-type: 'ANT'
 446                     branch-pattern: '**/{branch}'
 447             skip-vote:
 448                 successful: true
 449                 failed: true
 450                 unstable: true
 451                 notbuilt: true
 452
 453     prebuilders:
 454         - integration-rebase-gerrit-patch
 455         - integration-get-bundle-url
 456         - inject:
 457             properties-file: 'bundle.txt'
 458         - wipe-org-opendaylight-repo
 459         - maven-target:
 460             maven-version: '{mvn33}'
 461             pom: '$GERRIT_PROJECT/pom.xml'
 462             goals: 'clean install -Djenkins -DskipTests -Dcheckstyle.skip=true -Dmaven.javadoc.skip=true -Dmaven.site.skip=true -DgenerateReports=false -Dmaven.repo.local=/tmp/r -Dorg.ops4j.pax.url.mvn.localRepository=/tmp/r -Dstream={stream}'
 463             java-opts:
 464                 - '-Xmx4096m -XX:MaxPermSize=1024m -Dmaven.compile.fork=true'
 465             settings: '{integration-settings}'
 466             global-settings: '{odl-global-settings}'
 467
 468     maven:
 469         maven-name: '{mvn33}'
 470         root-pom: 'distribution/pom.xml'
 471         goals: 'clean install -Djenkins -Dmaven.repo.local=/tmp/r -Dorg.ops4j.pax.url.mvn.localRepository=/tmp/r'
 472         maven-opts: '-Xmx1024m -XX:MaxPermSize=256m -Dmaven.compile.fork=true'
 473         settings: '{integration-settings}'
 474         global-settings: '{odl-global-settings}'
 475         ignore-upstream-changes: true
 476         post-step-run-condition: 'SUCCESS'
 477
 478     postbuilders:
 479         - trigger-builds:
 480             - project: 'integration-distribution-test-{stream}'
 481               block: true
 482               predefined-parameters:
 483                   BUNDLEURL=$BUNDLEURL
 484
 485     publishers:
 486         - email-notification:
 487             email-prefix: '[$GERRIT_PROJECT]'
 488
 489 # Template: integration-multipatch-test-{stream}
 490 # Goal: Build one or more patches and run all available system test on a distribution containing the change
 491 # Operation: This job template checks out and builds each patch provided in job parameters, creates a distribution
 492 # containing these patches, and triggers the distribution test job which includes most (if not all) available
 493 # CSIT jobs
 494
 495 - job-template:
 496     name: 'integration-multipatch-test-{stream}'
 497
 498     project-type: maven
 499     node: dynamic_verify
 500     jdk: '{jdk}'
 501
 502     logrotate:
 503         daysToKeep: '{build-days-to-keep}'
 504         numToKeep: '{build-num-to-keep}'
 505         artifactDaysToKeep: '{build-artifact-days-to-keep}'
 506         artifactNumToKeep: '{build-artifact-num-to-keep}'
 507
 508     parameters:
 509         - patches-to-build-parameter:
 510             patches_to_build: '$PATCHES_TO_BUILD'
 511         - integration-branch:
 512             branch: '{branch}'
 513
 514     wrappers:
 515         - build-timeout
 516         - ssh-agent-credentials:
 517             users:
 518                 - '{ssh-credentials}'
 519
 520     prebuilders:
 521         - wipe-org-opendaylight-repo
 522         - integration-multipatch-builder
 523         - inject:
 524             properties-file: 'bundle.txt'
 525         - provide-maven-settings:
 526             global-settings-file: '{odl-global-settings}'
 527             settings-file: '{yangtools-settings}'
 528
 529
 530     maven:
 531         maven-name: '{mvn33}'
 532         root-pom: 'patch_tester/pom.xml'
 533         # TODO: Make Maven option configurable. Currently tests are not skipped, everything elase is.
 534         goals: 'clean install -f patch_tester/pom.xml -Djenkins -Dcheckstyle.skip=true -Dmaven.javadoc.skip=true -Dmaven.site.skip=true -DgenerateReports=false -Dmaven.repo.local=/tmp/r -Dorg.ops4j.pax.url.mvn.localRepository=/tmp/r -Dstream={stream}'
 535         maven-opts: '-Xmx4096m -XX:MaxPermSize=1024m -Dmaven.compile.fork=true'
 536         settings: '{yangtools-settings}'
 537         global-settings: '{odl-global-settings}'
 538         post-step-run-condition: 'SUCCESS'
 539
 540     postbuilders:
 541         - trigger-builds:
 542             - project: 'integration-distribution-test-{stream}'
 543               block: true
 544               predefined-parameters:
 545                   BUNDLEURL=$BUNDLEURL
 546
 547     publishers:
 548         - email-notification:
 549             email-prefix: '[integration]'