Resolve shellcheck for branch_cutter.sh 13/83513/2
authorThanh Ha <zxiiro@gmail.com>
Thu, 8 Aug 2019 00:22:42 +0000 (20:22 -0400)
committerThanh Ha <zxiiro@gmail.com>
Thu, 8 Aug 2019 00:36:45 +0000 (20:36 -0400)
Change-Id: Idab84e1c911f5e1aead8a58e2e952986745c0157
Signed-off-by: Thanh Ha <zxiiro@gmail.com>
scripts/branch_cut/branch_cutter.sh

index 4fade0a72d1c0373d0b2d1955e66534fcd785589..80fc652863f09b35f5baccb9a3b3896bb7a77b25 100755 (executable)
@@ -24,7 +24,7 @@ mod=0
 count=0
 
 function usage {
-    echo "Usage: $(basename $0) options (-c [current release]) (-n [next release]) (-p [previous release]) -h for help";
+    echo "Usage: $(basename "$0") options (-c [current release]) (-n [next release]) (-p [previous release]) -h for help";
     echo "example:"
     echo "branch_cutter.sh -n oxygen -c nitrogen -p carbon"
     exit 0;
@@ -74,8 +74,8 @@ while IFS="" read -r file; do
     else
         ./branch_cut.awk -v new_reltag="$new_reltag" -v curr_reltag="$curr_reltag" -v prev_reltag="$prev_reltag" "$file" > "$TEMP"
         [[ ! -s "$TEMP" ]] && echo "$file: excluded"
-        [[ -s "$TEMP" ]] && mv "$TEMP" "$file" && echo "$file: Done" && let "mod++"
-        let "count++"
+        [[ -s "$TEMP" ]] && mv "$TEMP" "$file" && echo "$file: Done" && (( mod++ ))
+        (( count++ ))
     fi
 done < <(find ../../jjb -name "*.yaml")