Resolve packaging ShellCheck errors

Change-Id: I05fc93ee5eaf84fc95ea28af1548074945cc4380
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

diff --git a/jjb/packaging/test-ports-nofeature.sh b/jjb/packaging/test-ports-nofeature.sh
index 84f4a6968d0110cbe2502b3b3b987fe00ee41868..ea14a4e340e8f1307dca8a313c4ceaf96631007e 100644 (file)
--- a/jjb/packaging/test-ports-nofeature.sh
+++ b/jjb/packaging/test-ports-nofeature.sh
@@ -22,7 +22,7 @@ while true; do
     closed_ports=()
     for port in "${expected_ports[@]}"
     do
-        if nmap -Pn -p$port localhost | grep -q open; then
+        if nmap -Pn -p"$port" localhost | grep -q open; then
             echo "Port $port is open"
             open_ports+=("$port")
         else
@@ -55,7 +55,7 @@ open_ports=()
 closed_ports=()
 for port in "${unexpected_ports[@]}"
 do
-    if nmap -Pn -p$port localhost | grep -q open; then
+    if nmap -Pn -p"$port" localhost | grep -q open; then
         echo "Port $port is open"
         open_ports+=("$port")
     else

diff --git a/jjb/packaging/test-rpm-docker.sh b/jjb/packaging/test-rpm-docker.sh
index c68ea3964ad933272e0da3baaaaf5df7a867d857..764377e5e25c656d27b2f7dec1bb98a6dc1fd5f7 100644 (file)
--- a/jjb/packaging/test-rpm-docker.sh
+++ b/jjb/packaging/test-rpm-docker.sh
@@ -11,41 +11,41 @@ scripts_path=/builder/jjb/packaging
 # A docker container must have been created by the build script
 if [ "$DISTRO" == "epel-7" ]; then
   docker_id=$(sudo docker ps -qf name=build_rpm_epel)
-  sudo docker exec $docker_id /usr/bin/yum -y install curl expect nmap openssh
+  sudo docker exec "$docker_id" /usr/bin/yum -y install curl expect nmap openssh
 elif [ "$DISTRO" == "opensuse-42" ]; then
   docker_id=$(sudo docker ps -qf name=build_rpm_suse)
-  sudo docker exec $docker_id /usr/bin/zypper -n install curl expect nmap openssh
+  sudo docker exec "$docker_id" /usr/bin/zypper -n install curl expect nmap openssh
 fi
 
-sudo docker exec $docker_id /bin/bash $scripts_path/test-rpm-deps.sh
+sudo docker exec "$docker_id" /bin/bash $scripts_path/test-rpm-deps.sh
 
-sudo docker exec $docker_id /bin/bash $scripts_path/install-rpm.sh
+sudo docker exec "$docker_id" /bin/bash $scripts_path/install-rpm.sh
 
-sudo docker exec $docker_id /bin/bash $scripts_path/start-odl.sh
+sudo docker exec "$docker_id" /bin/bash $scripts_path/start-odl.sh
 
-sudo docker exec $docker_id /bin/bash $scripts_path/test-ports-nofeature.sh
+sudo docker exec "$docker_id" /bin/bash $scripts_path/test-ports-nofeature.sh
 
 # Don't install test feature and check REST for Oxygen, ODLPARENT-139 breaks it
 if [ "$STREAM" == "fluorine" ] || [ "$STREAM" == "neon" ] || [ "$STREAM" == "sodium" ]; then
-  sudo docker exec $docker_id /usr/bin/expect $scripts_path/test-karaf-oxygensafe.expect
+  sudo docker exec "$docker_id" /usr/bin/expect $scripts_path/test-karaf-oxygensafe.expect
 else
-  sudo docker exec $docker_id /usr/bin/expect $scripts_path/test-karaf.expect
-  sudo docker exec $docker_id /bin/bash $scripts_path/test-rest-ok.sh
+  sudo docker exec "$docker_id" /usr/bin/expect $scripts_path/test-karaf.expect
+  sudo docker exec "$docker_id" /bin/bash $scripts_path/test-rest-ok.sh
 fi
 
-sudo docker exec $docker_id /bin/bash $scripts_path/stop-odl.sh
+sudo docker exec "$docker_id" /bin/bash $scripts_path/stop-odl.sh
 
-sudo docker exec $docker_id /bin/bash $scripts_path/uninstall-rpm.sh
+sudo docker exec "$docker_id" /bin/bash $scripts_path/uninstall-rpm.sh
 
 if [ "$SILO" == "sandbox" ]; then
   echo "Not uploading RPMs to Nexus because running in sandbox"
 elif [ "$SILO" == "releng" ]; then
-  RPM_NAME=$(sudo docker exec $docker_id find /root/rpmbuild/RPMS/noarch/ -wholename '*.rpm')
-  SRPM_NAME=$(sudo docker exec $docker_id find /root/rpmbuild/SRPMS/ -wholename '*.rpm')
+  RPM_NAME=$(sudo docker exec "$docker_id" find /root/rpmbuild/RPMS/noarch/ -wholename '*.rpm')
+  SRPM_NAME=$(sudo docker exec "$docker_id" find /root/rpmbuild/SRPMS/ -wholename '*.rpm')
   UPLOAD_FILES_PATH="$WORKSPACE/upload_files"
   mkdir -p "$UPLOAD_FILES_PATH"
-  sudo docker cp $docker_id:$RPM_NAME "$_"
-  sudo docker cp $docker_id:$SRPM_NAME "$_"
+  sudo docker cp "$docker_id:$RPM_NAME" "$_"
+  sudo docker cp "$docker_id:$SRPM_NAME" "$_"
 else
   echo "Unknown Jenkins silo: $SILO"
   exit 1