Add Coala deps to java-builder, cleanup docs

Change-Id: Ic10d8c610f99a241b25d4e42c4e9e48a69f7dd00
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Merge "Disable ubuntu16.04 packer merge job for gpb"

Disable ubuntu16.04 packer merge job for gpb

Change-Id: Ic01a5c20bc76e534c88eae20fa0c08559b0443f5
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Build Ubuntu 16.04 for mininet-ovs-2.5"

Merge "Add job to automatically cleanup old images"

Build Ubuntu 16.04 for mininet-ovs-2.5

- Use default version of mininet and openvswitch
- Add workaround for mtcbench build issue
  https://github.com/intracom-telecom-sdn/mtcbench/issues/10
- Enable Ubuntu1604 image only for mininet-ovs-2.5
- Enable Ubuntu1404 image only for mininet, mininet-ovs-2.3
- trello: https://trello.com/c/chIxf7ca

Change-Id: Ide927e10cd35f131a4507bb898ad5d4520843f07
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Bug 8033: Change path_mtu to fix mtu tempest test"

Bug 8033: Change path_mtu to fix mtu tempest test

Change-Id: Ia33f7a0d2ad484b209b792ef58f629a5a1df77e9
Signed-off-by: Revital Aronis <revital.aronis@hpe.com>

Merge "Bug 7974: Create check job for distribution"

Merge "Add jmespath module used by TeplatedRequests lib"

Merge "Update docs with renamed ubuntu labels"

Merge "Trigger verify on commit-message-only changes"

Auto Update CSIT Jobs to run

Change-Id: I51fea1d215431db8bf2181bb6562edc3b63209c6
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Merge "Change iotdm-csit-basic to use odl-iotdmcsitdist"

Trigger verify on commit-message-only changes

Some project check commit message formatting in -tox- jobs.

This change is global across all Gerrit-triggered jobs,
so all other verify-type jobs are triggered as well.
That is to avoid false Verify+1 votes
when the previous patch set failed on a code-sensitive job.

Also, values without variables do not need to be quoted.

Change-Id: I8eb8cb21c99acd9d2f92a76c941312ce21efa89c
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Change iotdm-csit-basic to use odl-iotdmcsitdist

Install odl-iotdmcsitdist  feature instead of odl-onem2mall-iotdm
Feature odl-iotdmcsitdist includes all features implemented
in iotdm and adds testing specific features.

Change-Id: I8e905ab5cff5d0cc6c98b71dfd6501b0e7c34a60
Signed-off-by: Tomas Janciga <tjanciga@cisco.com>

Update docs with renamed ubuntu labels

Change-Id: Ib5d0079c8895e7d0f2c64c8234eeb92313e8d712
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Remove zombie ovsdb scalability job with no csit

Change-Id: Ie255a98f71b348e55e6e244147bb167c7853fc8f
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Add CSIT job support for distribution-check links

Change-Id: I73ca4f223ed8bdb135839ae3896f03de7ace3f4c
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Auto Update CSIT Jobs to run

Change-Id: I8db9feb978ac5f88d48fa9e3fbefcc64b973c33f
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Fix openflowplugin gate job names

Change-Id: I2c988f7368374241dbe5c259b6c28cc00b0b66e0
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Merge "Create gate and sanity job for openflowplugin"

Merge "Add option to not skip git.properties"

Merge "Compress Java heap dumps using xz"

Bug 7974: Create check job for distribution

The new jobs uses some steps of the usual
{project}-distribution-check-{stream}
which are now defined as macros.

Change-Id: I3ab85ba932b382c793bd5a713e8ee813cecd566c
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Create gate and sanity job for openflowplugin

Also removing some obsolete jobs.

Change-Id: I145b18abe102f18b8e77dcd2383c504cdbf52b52
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Add jmespath module used by TeplatedRequests lib

Change-Id: Ic9f11fa4e9eb83590ce4a03b11c33d576b0b009a
Signed-off-by: Tomas Janciga <tjanciga@cisco.com>

Compress Java heap dumps using xz

xz is included in the baseline image.

Change-Id: Ie9cf324331d3a82c89b2265259448dd708759d66
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Enable tox verify for odlparent"

Merge "Replace image code name with version numbers"

Add vlan interface to the gateway

Change-Id: I308cbd0273d7d5e016f45657bdc7f04c9b09042b
Signed-off-by: Revital Aronis <revital.aronis@hpe.com>
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Merge "Refactor netvirt job params to use default values"

Add option to not skip git.properties

The q(uick) profile skips the git-commit-id-plugin.
This patch adds the skip override so that the plugin
wil run and the git.properties file included in the jars
so that the distchanges tool works properly.

There is also some cleanup to make the distribution builders
be more consistent and use the quick profile.

Change-Id: I5476f8c911ed7899a78577a6e61e1e88b620b747
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Only send autorelease failure email in releng silo"

Enable tox verify for odlparent

Change-Id: I8065c837de819c8fbf21ee904c6797ce6754b870
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Update cloud image list docs

Change-Id: I98f13ad2642b683e4b6d4f7805f02b602a18c7e5
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Replace image code name with version numbers

Change-Id: Icf2f6f708ab7dce560ccc9cb1072b32b7a5a0c24
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Refactor netvirt job params to use default values

Change-Id: Icbd7609272a46a4f628a8fc9276211ecf2f4149b
Signed-off-by: Alon Kochba <alonko@hpe.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Only send autorelease failure email in releng silo

Don't send emails to release and project lists during sandbox testing.

Change-Id: I595b23f1314f9c6ab2e92b6de4658842ab679400
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Merge "Temporary workaround for Nexus SNI issue"

Merge "Set recommended ~/.ssh folder permissions"

Run a sync before restarting spectrometer-api

Fixes issue with mirroring when a new repo is created in Gerrit.

Change-Id: I730df43d856e026ab1b002cd6a03cb6ea9666328
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Temporary workaround for Nexus SNI issue

This should be reverted once Sonatype has an updated nexus staging
plugin for us.

Trello: https://trello.com/c/VBeO8STM
Change-Id: Ia7c0916d6b181bfd153183ea5defb39ed8f7b7d5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix mailing list address

Change-Id: I3ccd5cb92aa9b1f9a70ab8cd3390aab30954a521
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Update devstack images to latest available

Change-Id: I94092f80cdb52b8d9a11a8c7fa5a53f70f18fb9e
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Bump staging plugin to latest version

Hopefully this fixes the SNI issue on deploy due to certificate change
on nexus.opendaylight.org.

Change-Id: I7648841c98563b77f18066e6aae36dd3c091b88e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Set recommended ~/.ssh folder permissions

- set ~/.ssh permissions to 700, which is being set as 755 by default

Change-Id: I2ed9c0ad5494b02f503fa9616f6ca5dee5e9af9d
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Add job to automatically cleanup old images

Depends on lftools>=0.0.8. Adds a jjb job to automatically cleanup
non-public images in the Private Cloud and Rackspace Public clouds.

Criteria:

    - Uses the sandbox account and checks only the sandbox tenant
    - Images 30 days or older
    - Non-public images

In ODL we mark images public when we want to allow the community to use
them. These are officially supported images that has passed testing
typically in the sandbox.

Change-Id: Id4ce204393408a087739ea18d1dd9700d346ad30
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Add new job to trigger longevity jobs every sunday"

Add new job to trigger longevity jobs every sunday

The patch also contain a new job
controller-csit-1node-notifications-longevity-only-carbon, which is in
the https://git.opendaylight.org/gerrit/#/c/53342/

Change-Id: Ia611a14ea3dda49956fe5d4e15e30ffcce7721c9
Signed-off-by: Peter Gubka <pgubka@cisco.com>

Add installation of modules used by IoTDM

Jsonpointer and tornado installation added

Change-Id: Iec0edd1fa4ddbaac76ad85282ab050a8edb46270
Signed-off-by: Tomas Janciga <tjanciga@cisco.com>

Auto Update CSIT Jobs to run

Change-Id: I46e26583c2e98abdac1930722517af8f2a9578d0
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

add patch-test jobs for sfc

Change-Id: I3ee29f73664899408d69e4ea91e5048e7bb0c5f0
Signed-off-by: Ursicio Martin <Ursicio.Javier.Martin@ericsson.com>

Merge "AAA: New job for Keystone Realm"

Merge "Remove duplicate KARAF_REDIRECT var export"

Merge "Update devstack packer to install OVS 2.6"

Remove duplicate KARAF_REDIRECT var export

Export is duplicated (with better wording, quoting) a bit below (L54).

Change-Id: Id066729c4f2f106ab299301d03a1ad5ed70a2845
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Merge "Fix JSON linting and add Linter"

Fix JSON linting and add Linter

Add the JSON linter to .coafile so that our JSON files also get linted.

Change-Id: Ic8a73c4e90d359066de157365a66397a82d72e0e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Update cloud image list docs"

Remove autorelease-project-report-{stream} jobs

This job was useful when Stephen was sending weekly reports on
interesting developments in ODL however this hasn't really happened in
awhile due to time constraints. Remove the job to free up resources.

This patch removes:

    - Job
    - Macro
    - Script
    - Template

Change-Id: I551e35a884db01fd85036410a122f949f5c6dd2a
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Update cloud image list docs

Change-Id: I0355e0fcc4985bcb4ea18545b19fd0061bf4e750
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Merge "Add SpaceConsistencyBear to ShellCheck"

Merge "Disable GitCommit check for some patterns"

Add graphviz dependency

OpenDaylight docs project needs graphviz for a Sphinx extension.

Change-Id: I19ad6d20abc6b4544da4a3f8ce2a52854ab5a7d6
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Archive .hprof memory dumps

Change-Id: If73296d0a919299a663ec14a186c957bba2c9e7a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add SpaceConsistencyBear to ShellCheck

We weren't linting all shell scripts with the space consistency bear.
This enables that and sets it to 4 space indents.

Change-Id: I9cefdcedef9dc6a5cf700d4472b6f5ae85ba4320
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Disable GitCommit check for some patterns

Some patterns can be long such as:

    - Sign-off-by when someone has a long name
    - http / https URLs

Change-Id: Ie5401a116de9599aaf85b91e63e1522d962c8e1a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Include pycurllibrary in robotframework"

Merge "Update cloud image list docs"

Merge "Use new Ubuntu 16.04 image for deb Ansible tests"

Merge "Update requirements to JJB 1.6.2"

Revert "Make testplan more configurable"

This reverts commit 5eda0e0f59e224b8ba9775ef3fafbb28edd4177a.
See comments in https://git.opendaylight.org/gerrit/53115

Change-Id: I63eefb5b1b276fde7fed8b83f302fe8cd2c76e35
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Update requirements to JJB 1.6.2

Verify and merge jobs are already using that version.

Change-Id: I034ad7a5cb06e9f2da1a4845fcb3ffa343d4bf08
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Update cloud image list docs

Change-Id: I21d18d28dbbdcb33d1c229a25dccdbbd7ba85fd0
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Include pycurllibrary in robotframework

This library is required to work with HTTPS/TLS and particularly
in handling client authentication with certificates

Change-Id: I441c2d6c3db8ee42d725affaeb6bef03c7121992
Signed-off-by: Miguel Angel Munoz Gonzalez <miguel.angel.munoz.gonzalez@ericsson.com>

Merge "Disable color for packer build"

Make testplan more configurable

before our standard 1node and 3node templates had to have testplans
of the format {project}-{functionality}.txt. That is still the
default, but now a project can override the testplan by defining
a testplan element in their project jjb yaml.

Change-Id: I922f8feadf3f69b4c4b1e0bc36ee0fc07741af56
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Use new Ubuntu 16.04 image for deb Ansible tests

The ansible-opendaylight module doesn't support Ubuntu 14.04, so this
was failing with the previous Ubuntu 14.04 boxes.

Fixes:

https://trello.com/c/ZeVAWpw5/472-fix-test-ansible-deb-job

Change-Id: I510b46024453965c1b96cbc056cac95da3481ea0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Ignore *-local-env.sh scripts and ignore SC2092

These files don't contain any commands and ShellCheck fails on them
because of that.

Change-Id: I4ec11081a3b7de3cfbb38f7a35480ff54fc0cc7d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix grub grepping code for RS Public Cloud

It appears images in the public cloud uses Grub 2 instead of Grub 1
configuration.

Change-Id: I138f8d118d81ae2b64bae84e1f0cc4a0f0d3771f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Make autorelease-beryllium build only once a week"

Merge "Add workaround for mkinitrd failing on CentOS7"

Auto Update CSIT Jobs to run

Change-Id: Ibbd801ad701bf2b6dc571cd3d6acaa8bc7d3df99
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Merge "Changing ovsdb job names to work better with patch-test"

Merge "Add job to install ODL via ansible-opendaylight"

Changing ovsdb job names to work better with patch-test

patch test will now call the jobs with the string -gate- in them.
any jobs matching that string (regex match on -gate-) will get
jenkins priority. that let's devs use the gate and get results
faster.

the -upstream- job will now only run on the main automatic
triggers and never on gerrit patches. jobs that run on gerrit
patches could potentially break (bad controller code) which
then pollutes the job history.

Change-Id: Iedf936e53521e07691ba007bf1efb490b0941a5c
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Merge "Replace exit 404 to exit 1"

Make autorelease-beryllium build only once a week

Since Beryllium is in maintenance mode and we're no longer doing
releases. Make Beryllium only run once a week so that it doesn't use our
infra resources.

Change-Id: I3212b99217f8840913ef225e27ef8f1af2dd3e1b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Update infra-properties macro

The infra-properties macro should be setting all values of purgeable
components.

In particular, a forced maximum number of build logs and very small
number of maximum artifacts need to be put in place or Jenkins will
continue to consume more and more space for unneeded or unwanted build
artifacts.

Change-Id: I05ddacd1fca617f389c4a28c4ee38664bfc1cd8e
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Merge "IMAGES should be an array"

Replace exit 404 to exit 1

Per Vratko's suggestion in Id4b67cb38a6ba297e9e2cd3f9091a1666b9c955c

Change-Id: Ibe607e43578e831dd1c88883f97c264b51657253
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

IMAGES should be an array

Change-Id: Ib8b76d232ef8da139c3d595c1c89ed96e955ca66
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Update devstack packer to install OVS 2.6

Change-Id: I631f137e4ccd73a35be80c5a8576ccf3bdd9dc62
Signed-off-by: Alon Kochba <alonko@hpe.com>

Revert ssh-copy-id shellcheck change

Change-Id: I2b63cb053721e7aebe54414a72495088295bc101
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix ssh-copy-keys script

Disable SC2006 for the ADDR line as there's some issues converting it to
$().

Change-Id: I2fd268d78ff0a539d47c7dd212392abb6ca6849e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Ignore ShellCheck rule SC2046

Not sure how to resolve this at the moment. If we quote it as suggested
the check fails and compare with -eq 0. Ignore this ShellCheck for now
until we figure out a proper solution.

Change-Id: I4b14d3db442a2cba8020b4823ef8c5b87ce5ccea
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix heat cleanup script missing array ()

While cleaning up ShellCheck issues we mistakenly changed a variable
from an array. Put it back.

Change-Id: Ie91764fa60489d62c6df20d335c92df238deca45
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Fix if-statement for pkg retry loop"

Fix if-statement for pkg retry loop

Refer to: https://github.com/koalaman/shellcheck/wiki/SC2181

Change-Id: I5df7b344ea2abc5aef6b675022125f14b22d0607
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>