OduSwitchingPools osp = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL,
ospIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT).get();
Uint16 ospNumber = osp.getSwitchingPoolNumber();
- Map<SwitchingPoolLcpKey, SwitchingPoolLcp> splMap = new HashMap(portmappingNode.nonnullSwitchingPoolLcp());
+ Map<SwitchingPoolLcpKey, SwitchingPoolLcp> splMap =
+ new HashMap<SwitchingPoolLcpKey, SwitchingPoolLcp>(portmappingNode.nonnullSwitchingPoolLcp());
SwitchingPoolLcpBuilder splBldr = splMap.containsKey(new SwitchingPoolLcpKey(ospNumber))
? new SwitchingPoolLcpBuilder(splMap.get(new SwitchingPoolLcpKey(ospNumber)))
: new SwitchingPoolLcpBuilder().setSwitchingPoolNumber(ospNumber)
}
@Parameterized.Parameters
- public static Collection nodes() {
+ public static Collection<?> nodes() {
NodeIdPair same = new NodeIdPair("nodeS", "CLIENT");
return Arrays.asList(new Object[][] {
{ new NodeIdPair("",""), null, false },
spectrumInformation.setWaveLength(Uint32.valueOf(1));
spectrumInformation.setLowerSpectralSlotNumber(761);
spectrumInformation.setHigherSpectralSlotNumber(768);
- Optional res = crossConnectImpl221.postCrossConnect("deviceId", "srcTp", "destTp", spectrumInformation);
+ Optional<String> res = crossConnectImpl221.postCrossConnect("deviceId", "srcTp", "destTp", spectrumInformation);
Assert.assertEquals(res.get(), "srcTp-destTp-761:768");
}
Mockito.when(nodes.getNodeId()).thenReturn("nodeId");
Mockito.when(deviceTransactionManager.getDeviceTransaction(any()))
.thenReturn(CompletableFuture.completedFuture(Optional.of(mock(DeviceTransaction.class))));
- Optional res = crossConnectImpl221.postOtnCrossConnect(List.of("src1", "src2"), nodes);
+ Optional<String> res = crossConnectImpl221.postOtnCrossConnect(List.of("src1", "src2"), nodes);
Assert.assertTrue("Optional value should have a value", res.isPresent());
}
private OlmTransactionUtils() {
}
- @SuppressWarnings("unchecked")
+ @SuppressWarnings({"unchecked","rawtypes"})
+ // FIXME check if the InstanceIdentifier raw type can be avoided
+ // Raw types use are discouraged since they lack type safety.
+ // Resulting Problems are observed at run time and not at compile time
public static void writeTransaction(DataBroker dataBroker, InstanceIdentifier instanceIdentifier,
DataObject object) {
@NonNull
}
- @SuppressWarnings("unchecked")
+ @SuppressWarnings({"unchecked","rawtypes"})
+ // FIXME check if the InstanceIdentifier raw type can be avoided
+ // Raw types use are discouraged since they lack type safety.
+ // Resulting Problems are observed at run time and not at compile time
public static boolean writeTransaction(DataBroker dataBroker, InstanceIdentifier instanceIdentifier,
DataObject object) {
ReadWriteTransaction transaction = dataBroker.newReadWriteTransaction();
private TransactionUtils() {
}
- @SuppressWarnings("unchecked")
+ @SuppressWarnings({"unchecked","rawtypes"})
+ // FIXME check if the InstanceIdentifier raw type can be avoided
+ // Raw types use are discouraged since they lack type safety.
+ // Resulting Problems are observed at run time and not at compile time
public static void writeTransaction(DataBroker dataBroker, InstanceIdentifier instanceIdentifier,
DataObject object) {
@NonNull
this.networkModelService = networkModelService;
}
+ @SuppressWarnings("rawtypes")
+ // FIXME check if the ForkJoinTask raw type can be avoided
+ // Raw types use are discouraged since they lack type safety.
+ // Resulting Problems are observed at run time and not at compile time
@Override
public ServicePathOutput setupServicePath(ServicePathInput input, ServicePathDirection direction) {
LOG.info("setup service path for input {} and direction {}", input, direction);
return messages;
}
+ @SuppressWarnings("rawtypes")
+ // FIXME check if the ForkJoinTask raw type can be avoided
+ // Raw types use are discouraged since they lack type safety.
+ // Resulting Problems are observed at run time and not at compile time
@Override
public ServicePathOutput deleteServicePath(ServicePathInput input) {
if (!alarmSuppressionNodeRegistration(input)) {
.build();
}
+ @SuppressWarnings("rawtypes")
+ // FIXME check if the ForkJoinTask raw type can be avoided
+ // Raw types use are discouraged since they lack type safety.
+ // Resulting Problems are observed at run time and not at compile time
public OtnServicePathOutput deleteOtnServicePath(OtnServicePathInput input) {
if (input.getNodes() == null) {
LOG.error("Unable to delete otn service path. input nodes = null");
}
- @SuppressWarnings({ "unchecked", "deprecation" })
+ @SuppressWarnings({ "unchecked", "deprecation", "rawtypes" })
// deviceTx.put needs the "true" boolean parameter at the end in order to not compromise the Junit test suite
+ // FIXME check if the InstanceIdentifier raw type can be avoided
+ // Raw types use are discouraged since they lack type safety.
+ // Resulting Problems are observed at run time and not at compile time
public static boolean writeTransaction(DeviceTransactionManager deviceTransactionManager,
String nodeId,
LogicalDatastoreType logicalDatastoreType,
private static final Logger LOG = LoggerFactory.getLogger(TopologyDataUtils.class);
+ @SuppressWarnings({"unchecked","rawtypes"})
+ // FIXME check if the InstanceIdentifier raw type can be avoided
+ // Raw types use are discouraged since they lack type safety.
+ // Resulting Problems are observed at run time and not at compile time
public static <T> void writeTopologyFromFileToDatastore(DataStoreContext dataStoreContextUtil, String file,
InstanceIdentifier ii) throws InterruptedException, ExecutionException {
Networks networks = null;
LOG.info("extraction from {} stored with success in datastore", topoFile.getName());
}
- @SuppressWarnings("unchecked")
+ @SuppressWarnings({"unchecked","rawtypes"})
+ // FIXME check if the InstanceIdentifier raw type can be avoided
+ // Raw types use are discouraged since they lack type safety.
+ // Resulting Problems are observed at run time and not at compile time
private static FluentFuture<? extends CommitInfo> writeTransaction(DataBroker dataBroker,
InstanceIdentifier instanceIdentifier, DataObject object) {
WriteTransaction transaction = dataBroker.newWriteOnlyTransaction();
Code Review / transportpce.git / commitdiff