Rewrite JUnit tests of PowerMgmt implementation 88/103988/3
authorGilles Thouenon <gilles.thouenon@orange.com>
Tue, 10 Jan 2023 09:27:25 +0000 (10:27 +0100)
committerGilles Thouenon <gilles.thouenon@orange.com>
Fri, 13 Jan 2023 07:34:50 +0000 (08:34 +0100)
- Rewrite all the PowerMgmtTest class using mocks instead of
instantiating dependent objects
- adapt OlmPowerServiceRpcImplUtils consequently

JIRA: TRNSPRTPCE-717
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I486988fc4f0abe2b937288570c81a5c24ce3847c

olm/src/main/java/org/opendaylight/transportpce/olm/power/PowerMgmtImpl.java
olm/src/test/java/org/opendaylight/transportpce/olm/power/PowerMgmtTest.java
olm/src/test/java/org/opendaylight/transportpce/olm/util/OlmPowerServiceRpcImplUtil.java

index 5524171d63459ee40e9841ebd037dff002a196d5..d3b16f3110fa8d4dcf71e5acb59830e7b1a90057 100644 (file)
@@ -101,6 +101,10 @@ public class PowerMgmtImpl implements PowerMgmt {
         String spectralSlotName = String.join(GridConstant.SPECTRAL_SLOT_SEPARATOR,
                 input.getLowerSpectralSlotNumber().toString(),
                 input.getHigherSpectralSlotNumber().toString());
+        if (input.getNodes() == null) {
+            LOG.error("No Nodes to configure");
+            return false;
+        }
         for (int i = 0; i < input.getNodes().size(); i++) {
             String nodeId = input.getNodes().get(i).getNodeId();
             String destTpId = input.getNodes().get(i).getDestTp();
index 6a0b80c7a8462b764f6ceee5ab69eee41e0d1393..a96fc1a972a1c8788c5130916804c94fb23ea81d 100644 (file)
 
 package org.opendaylight.transportpce.olm.power;
 
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoInteractions;
+
+import java.math.BigDecimal;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
+import java.util.Optional;
 import org.junit.Assert;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
+import org.mockito.MockedStatic;
 import org.mockito.Mockito;
 import org.opendaylight.mdsal.binding.api.DataBroker;
-import org.opendaylight.mdsal.binding.api.MountPoint;
-import org.opendaylight.mdsal.binding.api.MountPointService;
-import org.opendaylight.transportpce.common.StringConstants;
 import org.opendaylight.transportpce.common.crossconnect.CrossConnect;
 import org.opendaylight.transportpce.common.crossconnect.CrossConnectImpl;
-import org.opendaylight.transportpce.common.crossconnect.CrossConnectImpl121;
-import org.opendaylight.transportpce.common.crossconnect.CrossConnectImpl221;
-import org.opendaylight.transportpce.common.crossconnect.CrossConnectImpl710;
 import org.opendaylight.transportpce.common.device.DeviceTransactionManager;
-import org.opendaylight.transportpce.common.device.DeviceTransactionManagerImpl;
-import org.opendaylight.transportpce.common.mapping.MappingUtils;
-import org.opendaylight.transportpce.common.mapping.MappingUtilsImpl;
 import org.opendaylight.transportpce.common.mapping.PortMapping;
-import org.opendaylight.transportpce.common.mapping.PortMappingVersion121;
-import org.opendaylight.transportpce.common.mapping.PortMappingVersion221;
-import org.opendaylight.transportpce.common.mapping.PortMappingVersion710;
+import org.opendaylight.transportpce.common.openroadminterfaces.OpenRoadmInterfaceException;
 import org.opendaylight.transportpce.common.openroadminterfaces.OpenRoadmInterfaces;
-import org.opendaylight.transportpce.common.openroadminterfaces.OpenRoadmInterfacesImpl;
-import org.opendaylight.transportpce.common.openroadminterfaces.OpenRoadmInterfacesImpl121;
-import org.opendaylight.transportpce.common.openroadminterfaces.OpenRoadmInterfacesImpl221;
-import org.opendaylight.transportpce.common.openroadminterfaces.OpenRoadmInterfacesImpl710;
-import org.opendaylight.transportpce.olm.stub.MountPointServiceStub;
-import org.opendaylight.transportpce.olm.stub.MountPointStub;
 import org.opendaylight.transportpce.olm.util.OlmPowerServiceRpcImplUtil;
-import org.opendaylight.transportpce.olm.util.TransactionUtils;
-import org.opendaylight.transportpce.test.AbstractTest;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.olm.rev210618.ServicePowerSetupInput;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.olm.rev210618.ServicePowerTurndownInput;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.OpenroadmNodeVersion;
-import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network.NodesBuilder;
-import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network.nodes.NodeInfoBuilder;
-import org.opendaylight.yang.gen.v1.http.org.openroadm.device.types.rev191129.NodeTypes;
-import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.NodeId;
-
+import org.opendaylight.yang.gen.v1.http.org.openroadm.common.types.rev161014.OpticalControlMode;
+import org.opendaylight.yang.gen.v1.http.org.openroadm.common.types.rev161014.RatioDB;
+import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.interfaces.grp.Interface;
+import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.interfaces.grp.InterfaceBuilder;
+import org.opendaylight.yang.gen.v1.http.org.openroadm.optical.channel.interfaces.rev161014.Interface1Builder;
+import org.opendaylight.yang.gen.v1.http.org.openroadm.optical.channel.interfaces.rev161014.och.container.OchBuilder;
+import org.opendaylight.yang.gen.v1.http.org.openroadm.optical.transport.interfaces.rev161014.ots.container.OtsBuilder;
+import org.opendaylight.yangtools.yang.common.Decimal64;
 
-public class PowerMgmtTest extends AbstractTest {
-    private MountPoint mountPoint;
-    private MountPointService mountPointService;
-    private DeviceTransactionManager deviceTransactionManager;
-    private CrossConnect crossConnect;
+public class PowerMgmtTest {
+    private DataBroker dataBroker;
     private OpenRoadmInterfaces openRoadmInterfaces;
+    private CrossConnect crossConnect;
+    private DeviceTransactionManager deviceTransactionManager;
     private PortMapping portMapping;
     private PowerMgmt powerMgmt;
-    private CrossConnectImpl121 crossConnectImpl121;
-    private CrossConnectImpl221 crossConnectImpl22;
-    private CrossConnectImpl710 crossConnectImpl710;
-    private MappingUtils mappingUtils;
-    private OpenRoadmInterfacesImpl121 openRoadmInterfacesImpl121;
-    private OpenRoadmInterfacesImpl221 openRoadmInterfacesImpl22;
-    private OpenRoadmInterfacesImpl710 openRoadmInterfacesImpl710;
-    private PortMappingVersion710 portMappingVersion710;
-    private PortMappingVersion221 portMappingVersion22;
-    private PortMappingVersion121 portMappingVersion121;
-    private DataBroker dataBroker;
 
     @Before
     public void setUp() {
-        dataBroker = this.getNewDataBroker();
-        this.mountPoint = new MountPointStub(dataBroker);
-        this.mountPointService = new MountPointServiceStub(mountPoint);
-        this.mappingUtils = Mockito.spy(new MappingUtilsImpl(dataBroker));
-        Mockito.doReturn(StringConstants.OPENROADM_DEVICE_VERSION_1_2_1).when(mappingUtils)
-                .getOpenRoadmVersion(Mockito.anyString());
-        this.deviceTransactionManager = new DeviceTransactionManagerImpl(mountPointService, 3000);
-        this.crossConnectImpl121 = new CrossConnectImpl121(deviceTransactionManager);
-        this.crossConnectImpl22 = new CrossConnectImpl221(deviceTransactionManager);
-        this.crossConnect = new CrossConnectImpl(deviceTransactionManager, this.mappingUtils, this.crossConnectImpl121,
-                this.crossConnectImpl22, this.crossConnectImpl710);
-        this.portMappingVersion22 = new PortMappingVersion221(dataBroker, deviceTransactionManager);
-        this.portMappingVersion121 = new PortMappingVersion121(dataBroker, deviceTransactionManager);
-//        this.portMapping = new PortMappingImpl(getDataBroker(), this.portMappingVersion710,
-//                this.portMappingVersion22, this.portMappingVersion121);
+        this.dataBroker = Mockito.mock(DataBroker.class);
+        this.openRoadmInterfaces = Mockito.mock(OpenRoadmInterfaces.class);
+        this.crossConnect = Mockito.mock((CrossConnectImpl.class));
+        this.deviceTransactionManager = Mockito.mock(DeviceTransactionManager.class);
         this.portMapping = Mockito.mock(PortMapping.class);
-        this.openRoadmInterfacesImpl121 = new OpenRoadmInterfacesImpl121(deviceTransactionManager);
-        this.openRoadmInterfacesImpl22 = new OpenRoadmInterfacesImpl221(deviceTransactionManager, this.portMapping,
-            this.portMappingVersion22);
-        this.openRoadmInterfacesImpl710 = new OpenRoadmInterfacesImpl710(deviceTransactionManager, this.portMapping,
-            this.portMappingVersion710);
-        this.openRoadmInterfaces = new OpenRoadmInterfacesImpl((this.deviceTransactionManager),
-                this.mappingUtils,this.openRoadmInterfacesImpl121,this.openRoadmInterfacesImpl22,
-            this.openRoadmInterfacesImpl710);
-        this.openRoadmInterfaces = Mockito.spy(this.openRoadmInterfaces);
-        this.portMapping = Mockito.spy(this.portMapping);
         this.powerMgmt = new PowerMgmtImpl(this.dataBroker, this.openRoadmInterfaces, this.crossConnect,
-                this.deviceTransactionManager, this.portMapping);
-        Mockito.when(this.portMapping.getNode(Mockito.anyString()))
-                .thenReturn(new NodesBuilder()
-                        .setNodeId("node")
-                        .setNodeInfo(new NodeInfoBuilder()
-                                .setNodeType(NodeTypes.Xpdr)
-                                .setOpenroadmVersion(OpenroadmNodeVersion._121)
-                                .build())
-                        .build());
+                this.deviceTransactionManager, this.portMapping, "1000", "1000");
     }
 
     @Test
@@ -118,196 +70,282 @@ public class PowerMgmtTest extends AbstractTest {
     }
 
     @Test
-    public void testSetPower() {
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
-    }
+    public void testSetPowerForTransponderAEnd() throws OpenRoadmInterfaceException {
+        Mockito.when(this.portMapping.getNode("xpdr-A"))
+            .thenReturn(OlmPowerServiceRpcImplUtil.getMappingNodeTpdr("xpdr-A", OpenroadmNodeVersion._121,
+                    List.of("network-A")));
+        Mockito.when(this.portMapping.getNode("roadm-A"))
+            .thenReturn(OlmPowerServiceRpcImplUtil.getMappingNodeRdm("roadm-A", OpenroadmNodeVersion._121,
+                    List.of("srg1-A", "deg2-A")));
+        Interface interfOch = new InterfaceBuilder()
+                .setName("interface name")
+                .addAugmentation(new Interface1Builder()
+                        .setOch(new OchBuilder().build())
+                        .build())
+                .build();
+        Mockito.when(this.openRoadmInterfaces.getInterface(Mockito.matches("xpdr-A"), Mockito.anyString()))
+            .thenReturn(Optional.of(interfOch));
+        Interface interfOts = new InterfaceBuilder()
+                .setName("interface name")
+                .addAugmentation(
+                        new org.opendaylight.yang.gen.v1.http.org.openroadm.optical.transport.interfaces.rev161014
+                                .Interface1Builder()
+                                .setOts(new OtsBuilder()
+                                        .setSpanLossTransmit(new RatioDB(Decimal64.valueOf("6")))
+                                        .build())
+                                .build())
+                .build();
+        Mockito.when(this.openRoadmInterfaces
+                        .getInterface(Mockito.matches("roadm-A"), Mockito.anyString()))
+                .thenReturn(Optional.of(interfOts));
+        MockedStatic<PowerMgmtVersion121> pmv121 = Mockito.mockStatic(PowerMgmtVersion121.class);
+        pmv121.when(() -> PowerMgmtVersion121.setTransponderPower(Mockito.anyString(), Mockito.anyString(),
+                    Mockito.any(), Mockito.any(), Mockito.any()))
+                .thenReturn(true);
+        Map<String, Double> powerRangeMap = new HashMap<>();
+        powerRangeMap.put("MaxTx", 0.1);
+        powerRangeMap.put("MinTx", -5.1);
+        pmv121.when(() -> PowerMgmtVersion121.getXponderPowerRange(Mockito.anyString(), Mockito.anyString(),
+                    Mockito.anyString(), Mockito.any()))
+                .thenReturn(powerRangeMap);
+        Mockito.when(this.crossConnect.setPowerLevel(Mockito.anyString(), Mockito.anyString(), Mockito.any(),
+                        Mockito.anyString()))
+                .thenReturn(true);
 
-    @Ignore
-    @Test
-    public void testSetPower2() {
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput2();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
+        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInputForTransponder();
+        boolean result = this.powerMgmt.setPower(input);
+        Assert.assertEquals(true, result);
     }
 
     @Test
-    public void testSetPower3() {
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput3();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
-    }
+    public void testSetPowerForTransponderZEnd() throws OpenRoadmInterfaceException {
+        Mockito.when(this.portMapping.getNode("xpdr-C"))
+                .thenReturn(OlmPowerServiceRpcImplUtil.getMappingNodeTpdr("xpdr-C", OpenroadmNodeVersion._121,
+                        List.of("client-C")));
 
-    @Test
-    public void testSetPower4() {
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput4();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
+        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil
+                .getServicePowerSetupInputForOneNode("xpdr-C", "network-C", "client-C");
+        boolean result = this.powerMgmt.setPower(input);
+        Assert.assertEquals(true, result);
     }
 
     @Test
-    public void testPowerTurnDown() {
-        ServicePowerTurndownInput input = OlmPowerServiceRpcImplUtil.getServicePowerTurndownInput();
-        boolean output = this.powerMgmt.powerTurnDown(input);
-        Assert.assertEquals(true, output);
-    }
+    public void testSetPowerForRoadmAEnd() throws OpenRoadmInterfaceException {
+        Mockito.when(this.portMapping.getNode("roadm-A"))
+                .thenReturn(OlmPowerServiceRpcImplUtil.getMappingNodeRdm("roadm-A", OpenroadmNodeVersion._121,
+                        List.of("srg1-A", "deg2-A")));
+        Mockito.when(this.deviceTransactionManager.getDataFromDevice(Mockito.anyString(), Mockito.any(),
+                        Mockito.any(), Mockito.anyLong(), Mockito.any()))
+                .thenReturn(Optional.empty());
+        Interface interfOts = new InterfaceBuilder()
+                .setName("interface name")
+                .addAugmentation(
+                        new org.opendaylight.yang.gen.v1.http.org.openroadm.optical.transport.interfaces.rev161014
+                            .Interface1Builder()
+                    .setOts(new OtsBuilder()
+                            .setSpanLossTransmit(new RatioDB(Decimal64.valueOf("6")))
+                            .build())
+                    .build())
+                .build();
+        Mockito.when(this.openRoadmInterfaces.getInterface(Mockito.anyString(), Mockito.anyString()))
+                .thenReturn(Optional.of(interfOts));
+        Mockito.when(this.crossConnect.setPowerLevel(Mockito.anyString(), Mockito.anyString(), Mockito.any(),
+                        Mockito.anyString()))
+                .thenReturn(true);
 
-    @Test
-    public void testPowerTurnDown2() {
-        ServicePowerTurndownInput input = OlmPowerServiceRpcImplUtil.getServicePowerTurndownInput2();
-        boolean output = this.powerMgmt.powerTurnDown(input);
-        Assert.assertEquals(false, output);
+        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil
+                .getServicePowerSetupInputForOneNode("roadm-A", "srg1-A", "deg2-A");
+        boolean result = this.powerMgmt.setPower(input);
+        Assert.assertEquals(true, result);
+        verify(this.crossConnect, times(1)).setPowerLevel(Mockito.matches("roadm-A"),
+                Mockito.matches(OpticalControlMode.Power.getName()), eq(Decimal64.valueOf("-3.00")),
+                Mockito.matches("srg1-A-deg2-A-761:768"));
+        verify(this.crossConnect, times(1)).setPowerLevel(Mockito.matches("roadm-A"),
+                Mockito.matches(OpticalControlMode.GainLoss.getName()), eq(Decimal64.valueOf("-3.00")),
+                Mockito.matches("srg1-A-deg2-A-761:768"));
     }
 
     @Test
-    public void testPowerTurnDown3() {
-        ServicePowerTurndownInput input = OlmPowerServiceRpcImplUtil.getServicePowerTurndownInput3();
-        boolean output = this.powerMgmt.powerTurnDown(input);
-        Assert.assertEquals(true, output);
-    }
+    public void testSetPowerForRoadmZEnd() throws OpenRoadmInterfaceException {
+        Mockito.when(this.portMapping.getNode("roadm-C"))
+                .thenReturn(OlmPowerServiceRpcImplUtil.getMappingNodeRdm("roadm-C", OpenroadmNodeVersion._121,
+                        List.of("deg1-C", "srg1-C")));
+        Mockito.when(this.deviceTransactionManager.getDataFromDevice(Mockito.anyString(), Mockito.any(),
+                        Mockito.any(), Mockito.anyLong(), Mockito.any()))
+                .thenReturn(Optional.empty());
+        Mockito.when(this.crossConnect.setPowerLevel(Mockito.anyString(), Mockito.anyString(), Mockito.any(),
+                        Mockito.anyString()))
+                .thenReturn(true);
 
-    @Test
-    public void testPowerTurnDown4() {
-        ServicePowerTurndownInput input = OlmPowerServiceRpcImplUtil.getServicePowerTurndownInput4();
-        boolean output = this.powerMgmt.powerTurnDown(input);
-        Assert.assertEquals(false, output);
+        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil
+                .getServicePowerSetupInputForOneNode("roadm-C", "deg1-C", "srg1-C");
+        boolean result = this.powerMgmt.setPower(input);
+        Assert.assertEquals(true, result);
+        verify(this.crossConnect, times(1)).setPowerLevel(Mockito.matches("roadm-C"),
+                Mockito.matches(OpticalControlMode.Power.getName()), Mockito.isNull(),
+                Mockito.matches("deg1-C-srg1-C-761:768"));
     }
 
     @Test
-    public void testSetPowerPresentNodes() throws InterruptedException {
-        List<NodeId> nodes = TransactionUtils.getNodeIds();
-        for (NodeId nodeId : nodes) {
-            TransactionUtils.writeNodeTransaction(nodeId.getValue(), this.dataBroker, null);
-            Thread.sleep(1000);
-        }
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
-    }
+    public void testSetPowerForTransponderWhenNoTransponderPort() throws OpenRoadmInterfaceException {
+        Mockito.when(this.portMapping.getNode("xpdr-A"))
+                .thenReturn(OlmPowerServiceRpcImplUtil.getMappingNodeTpdr("xpdr-A", OpenroadmNodeVersion._121,
+                        List.of("network-A")));
+        Mockito.when(this.portMapping.getNode("roadm-A"))
+                .thenReturn(OlmPowerServiceRpcImplUtil.getMappingNodeRdm("roadm-A", OpenroadmNodeVersion._121,
+                        List.of("srg1-A", "deg2-A")));
+        Interface interfOch = new InterfaceBuilder()
+                .setName("interface name")
+                .addAugmentation(new Interface1Builder()
+                        .setOch(new OchBuilder().build())
+                        .build())
+                .build();
+        Mockito.when(this.openRoadmInterfaces.getInterface(Mockito.matches("xpdr-A"), Mockito.anyString()))
+                .thenReturn(Optional.of(interfOch));
+        Interface interfOts = new InterfaceBuilder()
+                .setName("interface name")
+                .addAugmentation(
+                        new org.opendaylight.yang.gen.v1.http.org.openroadm.optical.transport.interfaces.rev161014
+                                .Interface1Builder()
+                                .setOts(new OtsBuilder()
+                                        .setSpanLossTransmit(new RatioDB(Decimal64.valueOf("6")))
+                                        .build())
+                                .build())
+                .build();
+        Mockito.when(this.openRoadmInterfaces
+                        .getInterface(Mockito.matches("roadm-A"), Mockito.anyString()))
+                .thenReturn(Optional.of(interfOts));
+        try (MockedStatic<PowerMgmtVersion121> pmv121 = Mockito.mockStatic(PowerMgmtVersion121.class)) {
+            pmv121.when(() -> PowerMgmtVersion121.setTransponderPower(Mockito.anyString(), Mockito.anyString(),
+                            Mockito.any(), Mockito.any(), Mockito.any()))
+                    .thenReturn(true);
+            pmv121.when(() -> PowerMgmtVersion121.getXponderPowerRange(Mockito.anyString(), Mockito.anyString(),
+                            Mockito.anyString(), Mockito.any()))
+                    .thenReturn(new HashMap<>());
 
-    @Test
-    public void testSetPowerPresentNodes2() throws InterruptedException {
-        List<NodeId> nodes = TransactionUtils.getNodeIds();
-        for (NodeId nodeId : nodes) {
-            TransactionUtils.writeNodeTransaction2(nodeId.getValue(), this.dataBroker, null);
-            Thread.sleep(500);
-        }
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
-    }
+            Mockito.when(this.crossConnect.setPowerLevel(Mockito.anyString(), Mockito.anyString(), Mockito.any(),
+                            Mockito.anyString()))
+                    .thenReturn(true);
 
-    @Test
-    public void testSetPowerPresentNodes3() throws InterruptedException {
-        List<NodeId> nodes = TransactionUtils.getNodeIds();
-        for (NodeId nodeId : nodes) {
-            TransactionUtils.writeNodeTransaction3(nodeId.getValue(), this.dataBroker, null);
-            Thread.sleep(500);
-        }
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
-    }
-    /*
-    TODO: see if this test is always relevant
-    @Test
-    public void testSetPowerPresentNodes31() throws InterruptedException {
-        List<NodeId> nodes = TransactionUtils.getNodeIds();
-        for (NodeId nodeId : nodes) {
-            TransactionUtils.writeNodeTransaction3(nodeId.getValue(), this.getDataBroker(), "deg");
-            Thread.sleep(500);
-        }
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput3();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(false, output);
-    }*/
 
-    @Test
-    public void testSetPowerPresentNodes312() throws InterruptedException {
-        List<NodeId> nodes = TransactionUtils.getNodeIds();
-        for (NodeId nodeId : nodes) {
-            TransactionUtils.writeNodeTransaction3(nodeId.getValue(), this.dataBroker, "deg");
-            Thread.sleep(500);
+            ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInputForTransponder();
+            boolean result = this.powerMgmt.setPower(input);
+            Assert.assertEquals(true, result);
+            pmv121.verify(() -> PowerMgmtVersion121.setTransponderPower(Mockito.matches("xpdr-A"),
+                    Mockito.anyString(), eq(new BigDecimal("-5")), Mockito.any(), Mockito.any()));
+            verify(this.crossConnect, times(1)).setPowerLevel(Mockito.matches("roadm-A"),
+                    Mockito.matches(OpticalControlMode.GainLoss.getName()), eq(Decimal64.valueOf("-3.00")),
+                    Mockito.matches("srg1-A-deg2-A-761:768"));
         }
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput4();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
     }
 
     @Test
-    public void testSetPowerPresentNodes32() throws InterruptedException {
-        List<NodeId> nodes = TransactionUtils.getNodeIds();
-        for (NodeId nodeId : nodes) {
-            TransactionUtils.writeNodeTransaction3(nodeId.getValue(), this.dataBroker, null);
-            Thread.sleep(500);
+    public void testSetPowerForTransponderAEndWithRoadmPort() throws OpenRoadmInterfaceException {
+        Mockito.when(this.portMapping.getNode("xpdr-A"))
+                .thenReturn(OlmPowerServiceRpcImplUtil.getMappingNodeTpdr("xpdr-A", OpenroadmNodeVersion._121,
+                        List.of("network-A")));
+        Mockito.when(this.portMapping.getNode("roadm-A"))
+                .thenReturn(OlmPowerServiceRpcImplUtil.getMappingNodeRdm("roadm-A", OpenroadmNodeVersion._121,
+                        List.of("srg1-A", "deg2-A")));
+        Interface interfOch = new InterfaceBuilder()
+                .setName("interface name")
+                .addAugmentation(new Interface1Builder()
+                        .setOch(new OchBuilder().build())
+                        .build())
+                .build();
+        Mockito.when(this.openRoadmInterfaces.getInterface(Mockito.matches("xpdr-A"), Mockito.anyString()))
+                .thenReturn(Optional.of(interfOch));
+        Interface interfOts = new InterfaceBuilder()
+                .setName("interface name")
+                .addAugmentation(
+                        new org.opendaylight.yang.gen.v1.http.org.openroadm.optical.transport.interfaces.rev161014
+                                .Interface1Builder()
+                                .setOts(new OtsBuilder()
+                                        .setSpanLossTransmit(new RatioDB(Decimal64.valueOf("6")))
+                                        .build())
+                                .build())
+                .build();
+        Mockito.when(this.openRoadmInterfaces
+                        .getInterface(Mockito.matches("roadm-A"), Mockito.anyString()))
+                .thenReturn(Optional.of(interfOts));
+        try (MockedStatic<PowerMgmtVersion121> pmv121 = Mockito.mockStatic(PowerMgmtVersion121.class)) {
+
+            pmv121.when(() -> PowerMgmtVersion121.setTransponderPower(Mockito.anyString(), Mockito.anyString(),
+                            Mockito.any(), Mockito.any(), Mockito.any()))
+                    .thenReturn(true);
+            Map<String, Double> powerRangeMapTpdrTx = new HashMap<>();
+            powerRangeMapTpdrTx.put("MaxTx", 0.1);
+            powerRangeMapTpdrTx.put("MinTx", -5.1);
+            pmv121.when(() -> PowerMgmtVersion121.getXponderPowerRange(Mockito.anyString(), Mockito.anyString(),
+                            Mockito.anyString(), Mockito.any()))
+                    .thenReturn(powerRangeMapTpdrTx);
+            Map<String, Double> powerRangeMapSrgRx = new HashMap<>();
+            powerRangeMapSrgRx.put("MaxRx", -4.2);
+            powerRangeMapSrgRx.put("MinRx", -22.2);
+            pmv121.when(() -> PowerMgmtVersion121.getSRGRxPowerRange(Mockito.anyString(), Mockito.anyString(),
+                            Mockito.any(), Mockito.anyString(), Mockito.anyString()))
+                    .thenReturn(powerRangeMapSrgRx);
+            Mockito.when(this.crossConnect.setPowerLevel(Mockito.anyString(), Mockito.anyString(), Mockito.any(),
+                            Mockito.anyString()))
+                    .thenReturn(true);
+
+            ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInputForTransponder();
+            boolean result = this.powerMgmt.setPower(input);
+            Assert.assertEquals(true, result);
+            pmv121.verify(() -> PowerMgmtVersion121.setTransponderPower(Mockito.matches("xpdr-A"),
+                    Mockito.anyString(), eq(new BigDecimal("-4.20000000000000017763568394002504646778106689453125")),
+                    Mockito.any(), Mockito.any()));
         }
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput3();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
     }
 
-    @Ignore
     @Test
-    public void testSetPowerPresentNodes4() throws InterruptedException {
-        List<NodeId> nodes = TransactionUtils.getNodeIds();
-        for (NodeId nodeId : nodes) {
-            TransactionUtils.writeNodeTransaction(nodeId.getValue(), this.dataBroker, "network");
-            Thread.sleep(500);
-        }
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput2();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
+    public void testSetPowerWithoutNode() {
+        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInputWthoutNode();
+        boolean result = this.powerMgmt.setPower(input);
+        Assert.assertEquals(false, result);
+        verifyNoInteractions(this.crossConnect);
     }
 
-    /*
-    TODO: see if this test is always relevant
     @Test
-    public void testSetPowerPresentNodes41() throws InterruptedException {
-        List<NodeId> nodes = TransactionUtils.getNodeIds();
-        for (NodeId nodeId : nodes) {
-            TransactionUtils.writeNodeTransaction(nodeId.getValue(), this.getDataBroker(), null);
-            Thread.sleep(500);
-        }
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput2();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(false, output);
-    }*/
+    public void testSetPowerForBadNodeType() throws OpenRoadmInterfaceException {
+        Mockito.when(this.portMapping.getNode("ila node"))
+                .thenReturn(OlmPowerServiceRpcImplUtil.getMappingNodeIla());
 
-    @Test
-    public void testSetPowerPresentNodes42() throws InterruptedException {
-        List<NodeId> nodes = TransactionUtils.getNodeIds();
-        for (NodeId nodeId : nodes) {
-            TransactionUtils.writeNodeTransaction(nodeId.getValue(), this.dataBroker, "deg");
-            Thread.sleep(500);
-        }
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput3();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
+        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil
+                .getServicePowerSetupInputForOneNode("ila node", "rx-port", "tx-port");
+        boolean result = this.powerMgmt.setPower(input);
+        Assert.assertEquals(true, result);
+        verifyNoInteractions(this.crossConnect);
+        verifyNoInteractions(this.openRoadmInterfaces);
     }
 
+
     @Test
-    public void testSetPowerPresentNodes422() throws InterruptedException {
-        List<NodeId> nodes = TransactionUtils.getNodeIds();
-        for (NodeId nodeId : nodes) {
-            TransactionUtils.writeNodeTransaction(nodeId.getValue(), this.dataBroker, "deg");
-            Thread.sleep(500);
-        }
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput4();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
+    public void testPowerTurnDownWhenSuccess() {
+        Mockito.when(this.crossConnect.setPowerLevel(Mockito.anyString(), Mockito.anyString(), Mockito.any(),
+                        Mockito.anyString()))
+                .thenReturn(true);
+        ServicePowerTurndownInput input = OlmPowerServiceRpcImplUtil.getServicePowerTurndownInput();
+        boolean result = this.powerMgmt.powerTurnDown(input);
+        Assert.assertEquals(true, result);
+        verify(this.crossConnect, times(1)).setPowerLevel(Mockito.matches("roadm-C"),
+                Mockito.matches(OpticalControlMode.Off.getName()), Mockito.isNull(), Mockito.anyString());
+        verify(this.crossConnect, times(1)).setPowerLevel(Mockito.matches("roadm-A"),
+                Mockito.matches(OpticalControlMode.Power.getName()), eq(Decimal64.valueOf("-60")),
+                Mockito.anyString());
+        verify(this.crossConnect, times(1)).setPowerLevel(Mockito.matches("roadm-A"),
+                Mockito.matches(OpticalControlMode.Off.getName()), Mockito.isNull(), Mockito.anyString());
     }
 
     @Test
-    public void testSetPowerPresentNodes43() throws InterruptedException {
-        List<NodeId> nodes = TransactionUtils.getNodeIds();
-        for (NodeId nodeId : nodes) {
-            TransactionUtils.writeNodeTransaction(nodeId.getValue(), this.dataBroker, null);
-            Thread.sleep(500);
-        }
-        ServicePowerSetupInput input = OlmPowerServiceRpcImplUtil.getServicePowerSetupInput3();
-        boolean output = this.powerMgmt.setPower(input);
-        Assert.assertEquals(true, output);
+    public void testPowerTurnDownWhenFailure() {
+        Mockito.when(this.crossConnect.setPowerLevel(Mockito.anyString(), Mockito.anyString(), Mockito.any(),
+                        Mockito.anyString()))
+                .thenReturn(false);
+        ServicePowerTurndownInput input = OlmPowerServiceRpcImplUtil.getServicePowerTurndownInput();
+        boolean result = this.powerMgmt.powerTurnDown(input);
+        Assert.assertEquals(false, result);
+        verify(this.crossConnect, times(2))
+                .setPowerLevel(Mockito.anyString(), Mockito.any(), Mockito.any(), Mockito.anyString());
     }
-
 }
index 8dadf659d8436ad0914bfd8a3a7bd00f1e1a5c62..9e07f968ba4bd39d899b72f4e77f65ff76cddd0a 100644 (file)
@@ -9,7 +9,9 @@
 package org.opendaylight.transportpce.olm.util;
 
 import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.olm.rev210618.CalculateSpanlossBaseInput;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.olm.rev210618.CalculateSpanlossBaseInputBuilder;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.olm.rev210618.CalculateSpanlossCurrentInput;
@@ -22,6 +24,12 @@ import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.olm.rev21
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.olm.rev210618.ServicePowerSetupInputBuilder;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.olm.rev210618.ServicePowerTurndownInput;
 import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.olm.rev210618.ServicePowerTurndownInputBuilder;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.OpenroadmNodeVersion;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.mapping.Mapping;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.mapping.MappingBuilder;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.mapping.MappingKey;
+import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network.nodes.NodeInfoBuilder;
+import org.opendaylight.yang.gen.v1.http.org.openroadm.device.types.rev191129.NodeTypes;
 import org.opendaylight.yang.gen.v1.http.org.openroadm.resource.types.rev161014.ResourceTypeEnum;
 import org.opendaylight.yang.gen.v1.http.org.transportpce.common.types.rev220926.PmGranularity;
 import org.opendaylight.yang.gen.v1.http.org.transportpce.common.types.rev220926.olm.get.pm.input.ResourceIdentifierBuilder;
@@ -42,6 +50,99 @@ public final class OlmPowerServiceRpcImplUtil {
         return input;
     }
 
+    public static ServicePowerSetupInput getServicePowerSetupInputForTransponder() {
+        return new ServicePowerSetupInputBuilder()
+                .setNodes(List.of(
+                        new NodesBuilder().setNodeId("xpdr-A").setSrcTp("client-A").setDestTp("network-A").build(),
+                        new NodesBuilder().setNodeId("roadm-A").setSrcTp("srg1-A").setDestTp("deg2-A").build()))
+                .setServiceName("service 1")
+                .setWaveNumber(Uint32.valueOf("1"))
+                .setLowerSpectralSlotNumber(Uint32.valueOf(761))
+                .setHigherSpectralSlotNumber(Uint32.valueOf(768))
+                .build();
+    }
+
+    public static ServicePowerSetupInput getServicePowerSetupInputForOneNode(String nodeId, String srcTp,
+            String destTp) {
+        return new ServicePowerSetupInputBuilder()
+                .setNodes(List.of(
+                        new NodesBuilder().setNodeId(nodeId).setSrcTp(srcTp).setDestTp(destTp).build()))
+                .setServiceName("service 1")
+                .setWaveNumber(Uint32.valueOf("1"))
+                .setLowerSpectralSlotNumber(Uint32.valueOf(761))
+                .setHigherSpectralSlotNumber(Uint32.valueOf(768))
+                .build();
+    }
+
+    public static ServicePowerSetupInput getServicePowerSetupInputWthoutNode() {
+        return new ServicePowerSetupInputBuilder()
+                .setNodes(List.of())
+                .setServiceName("service 1")
+                .setWaveNumber(Uint32.valueOf("1"))
+                .setLowerSpectralSlotNumber(Uint32.valueOf(761))
+                .setHigherSpectralSlotNumber(Uint32.valueOf(768))
+                .build();
+    }
+
+    public static org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network
+            .Nodes getMappingNodeTpdr(String nodeId, OpenroadmNodeVersion nodeVersion, List<String> lcps) {
+        Map<MappingKey, Mapping> mappings = new HashMap();
+        for (String lcp:lcps) {
+            Mapping mapping = new MappingBuilder()
+                    .setLogicalConnectionPoint(lcp)
+                    .setSupportingCircuitPackName("circuit pack")
+                    .setSupportingPort("port")
+                    .build();
+            mappings.put(mapping.key(), mapping);
+        }
+        return new org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network
+                .NodesBuilder()
+            .setNodeId(nodeId)
+            .setNodeInfo(new NodeInfoBuilder()
+                .setNodeType(NodeTypes.Xpdr)
+                .setOpenroadmVersion(nodeVersion)
+                .build())
+            .setMapping(mappings)
+            .build();
+    }
+
+    public static org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network
+            .Nodes getMappingNodeRdm(String nodeId, OpenroadmNodeVersion nodeVersion, List<String> lcps) {
+        Map<MappingKey, Mapping> mappings = new HashMap();
+        for (String lcp:lcps) {
+            MappingBuilder mappingBldr = new MappingBuilder()
+                    .setLogicalConnectionPoint(lcp)
+                    .setSupportingCircuitPackName("circuit pack")
+                    .setSupportingPort("port");
+            if (lcp.contains("deg")) {
+                mappingBldr.setSupportingOts("interface ots")
+                        .setSupportingOms("interface oms");
+            }
+            mappings.put(mappingBldr.build().key(), mappingBldr.build());
+        }
+        return new org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network
+                    .NodesBuilder()
+                .setNodeId(nodeId)
+                .setNodeInfo(new NodeInfoBuilder()
+                        .setNodeType(NodeTypes.Rdm)
+                        .setOpenroadmVersion(nodeVersion)
+                        .build())
+                .setMapping(mappings)
+                .build();
+    }
+
+    public static org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network
+            .Nodes getMappingNodeIla() {
+        return new org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network
+                    .NodesBuilder()
+                .setNodeId("ila node")
+                .setNodeInfo(new NodeInfoBuilder()
+                        .setNodeType(NodeTypes.Ila)
+                        .setOpenroadmVersion(OpenroadmNodeVersion._121)
+                        .build())
+                .build();
+    }
+
     public static ServicePowerSetupInput getServicePowerSetupInput() {
         Nodes node1 = new NodesBuilder().setDestTp("dest").setSrcTp("src").setNodeId("node 1").build();
         Nodes node2 = new NodesBuilder().setDestTp("dest").setSrcTp("src").setNodeId("node 2").build();
@@ -85,34 +186,17 @@ public final class OlmPowerServiceRpcImplUtil {
         return input;
     }
 
-    public static ServicePowerSetupInput getServicePowerSetupInput4() {
-        Nodes node1 = new NodesBuilder().setDestTp("srg").setSrcTp("src").setNodeId("node 1").build();
-        Nodes node2 = new NodesBuilder().setDestTp("srg").setSrcTp("src").setNodeId("node 2").build();
-        List<Nodes> nodes = new ArrayList<>();
-        nodes.add(node1);
-        nodes.add(node2);
-        ServicePowerSetupInput input = new ServicePowerSetupInputBuilder().setNodes(nodes)
-            .setServiceName("service 1")
-            .setWaveNumber(Uint32.valueOf("1"))
-            .setLowerSpectralSlotNumber(Uint32.valueOf(761))
-            .setHigherSpectralSlotNumber(Uint32.valueOf(768)).build();
-        return input;
-    }
-
     public static ServicePowerTurndownInput getServicePowerTurndownInput() {
-        Nodes node1 = new NodesBuilder().setDestTp("dest").setSrcTp("src").setNodeId("node 1").build();
-        Nodes node2 = new NodesBuilder().setDestTp("dest").setSrcTp("src").setNodeId("node 2").build();
-        List<Nodes> nodes = new ArrayList<>();
-        nodes.add(node1);
-        nodes.add(node2);
-        ServicePowerTurndownInput input = new ServicePowerTurndownInputBuilder()
-                .setNodes(nodes)
+        return new ServicePowerTurndownInputBuilder()
+                .setNodes(List.of(
+                        new NodesBuilder().setNodeId("roadm-A").setSrcTp("srg1-A").setDestTp("deg2-A").build(),
+                        new NodesBuilder().setNodeId("roadm-C").setSrcTp("deg1-C").setDestTp("srg1-C").build())
+                        )
                 .setServiceName("service 1")
                 .setWaveNumber(Uint32.valueOf("1"))
                 .setLowerSpectralSlotNumber(Uint32.valueOf(761))
-                .setHigherSpectralSlotNumber(Uint32.valueOf(768)).build();
-
-        return input;
+                .setHigherSpectralSlotNumber(Uint32.valueOf(768))
+                .build();
     }
 
     public static ServicePowerTurndownInput getServicePowerTurndownInput2() {
@@ -131,37 +215,6 @@ public final class OlmPowerServiceRpcImplUtil {
         return input;
     }
 
-    public static ServicePowerTurndownInput getServicePowerTurndownInput3() {
-        Nodes node1 = new NodesBuilder().setDestTp("destsrg").setSrcTp("src").setNodeId("node 1").build();
-        Nodes node2 = new NodesBuilder().setDestTp("destsrg").setSrcTp("src").setNodeId("node 2").build();
-        List<Nodes> nodes = new ArrayList<>();
-        nodes.add(node1);
-        nodes.add(node2);
-        ServicePowerTurndownInput input = new ServicePowerTurndownInputBuilder()
-                .setNodes(nodes)
-                .setServiceName("service 1")
-                .setWaveNumber(Uint32.valueOf("1"))
-                .setLowerSpectralSlotNumber(Uint32.valueOf(761))
-                .setHigherSpectralSlotNumber(Uint32.valueOf(768)).build();
-
-        return input;
-    }
-
-    public static ServicePowerTurndownInput getServicePowerTurndownInput4() {
-        Nodes node1 = new NodesBuilder().setDestTp("destdeg").setSrcTp("src").setNodeId("node 1").build();
-        Nodes node2 = new NodesBuilder().setDestTp("destdeg").setSrcTp("src").setNodeId("node 2").build();
-        List<Nodes> nodes = new ArrayList<>();
-        nodes.add(node1);
-        nodes.add(node2);
-        ServicePowerTurndownInput input = new ServicePowerTurndownInputBuilder()
-                .setNodes(nodes)
-                .setServiceName("service 1")
-                .setWaveNumber(Uint32.valueOf("1"))
-                .setLowerSpectralSlotNumber(Uint32.valueOf(761))
-                .setHigherSpectralSlotNumber(Uint32.valueOf(768)).build();
-
-        return input;
-    }
 
     public static CalculateSpanlossBaseInput getCalculateSpanlossBaseInputLink() {
         CalculateSpanlossBaseInput input = new CalculateSpanlossBaseInputBuilder()