Improve ImmutableAugmentationNodeBuilder defensiveness 60/95860/1
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 19 Apr 2021 19:41:10 +0000 (21:41 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Tue, 20 Apr 2021 22:30:39 +0000 (00:30 +0200)
commit63e5382df42a1018ce79d5d4221819fc5ea2a5c4
treeda2d1b55993073abac353edd384d09880d4066ca
parent99d0a43d0f67ab0b98d56ac4a5b51cb7b1f76e80
Improve ImmutableAugmentationNodeBuilder defensiveness

The check for nested augmentations is rather ugly and will trigger
a secondary UnsupportedOperationException -- simply because we are
accessing getNodeType() even for AugmentationNodes.

Fix the thinko by performing an explicit check first, which also makes
things a wee bit faster.

Change-Id: I001c8d3b7c4a53ddb2c45d7c9157f7b1081dc992
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 1e24596294bdc2a57a808b77a2d9862198e4f46e)
yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableAugmentationNodeBuilder.java