Disable SpotBugs enforcement on select artifacts

odlparent has started enforcing SpotBugs by default, but some of
our artifacts are not ready for that. Disable enforcement through
the odlparent property and document why we are disabling it.

Change-Id: Ie8d3e43b26efd75e70223dde2b4555865ce25001
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/benchmarks/pom.xml b/benchmarks/pom.xml
index 54159e3bc9392a72eba4f87c35220463d57fc47f..1d7a0c374b1b3bb3484a78ab0e28beddb1c2a819 100644 (file)
--- a/benchmarks/pom.xml
+++ b/benchmarks/pom.xml
@@ -20,6 +20,11 @@
     <artifactId>benchmarks</artifactId>
     <version>4.0.0-SNAPSHOT</version>
 
+    <properties>
+        <!-- JMH-generated code does not pass SB (very noisily)-->
+        <odlparent.spotbugs.skip>true</odlparent.spotbugs.skip>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.yangtools</groupId>

diff --git a/yang-validation-tool/pom.xml b/yang-validation-tool/pom.xml
index dcb90d38147ca35dd64365113255d63727c928ad..5d6d0f19128e4812e22f19bd35c5f5a7b7633bda 100644 (file)
--- a/yang-validation-tool/pom.xml
+++ b/yang-validation-tool/pom.xml
@@ -20,6 +20,11 @@
     <artifactId>yang-validation-tool</artifactId>
     <version>4.0.0-SNAPSHOT</version>
 
+    <properties>
+        <!-- FIXME: we have some violations here -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
+    </properties>
+
     <dependencyManagement>
         <dependencies>
             <dependency>

diff --git a/yang/yang-data-impl/pom.xml b/yang/yang-data-impl/pom.xml
index 06188af15e3b82beee75ec25ad75785fd0a73000..ca1d1a38b40c2f1b3150c38b3d0b3f002bad7a18 100644 (file)
--- a/yang/yang-data-impl/pom.xml
+++ b/yang/yang-data-impl/pom.xml
@@ -21,6 +21,9 @@
     <properties>
         <!-- FIXME: workaround for MJAVADOC-586 -->
         <maven.compiler.release>8</maven.compiler.release>
+
+        <!-- FIXME: antlr-generated code does not pass SB -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
     </properties>
 
     <build>

diff --git a/yang/yang-data-jaxen/pom.xml b/yang/yang-data-jaxen/pom.xml
index e7bb768f941e8111bdfeb2cd6c5faa67b9f2ee4c..ce2dbf384187fa597bd0635d9b2abb75dda7df40 100644 (file)
--- a/yang/yang-data-jaxen/pom.xml
+++ b/yang/yang-data-jaxen/pom.xml
@@ -21,6 +21,11 @@
     <description>${project.artifactId}</description>
     <packaging>bundle</packaging>
 
+    <properties>
+        <!-- FIXME: we have some violations here -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>com.google.guava</groupId>

diff --git a/yang/yang-model-export/pom.xml b/yang/yang-model-export/pom.xml
index 0d8294398ac41b18cbca4310e252697f59339625..4ae34e1650bcfc2f29e49dc2f0fd5cd6e8ad5c28 100644 (file)
--- a/yang/yang-model-export/pom.xml
+++ b/yang/yang-model-export/pom.xml
@@ -21,6 +21,11 @@
     <name>${project.artifactId}</name>
     <description>${project.artifactId}</description>
 
+    <properties>
+        <!-- FIXME: we have some violations here -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.yangtools</groupId>

diff --git a/yang/yang-parser-rfc7950/pom.xml b/yang/yang-parser-rfc7950/pom.xml
index 1e2913170edf211376b9311ac8f53848bfb4ea58..681d90c2cf189022df98298f5cc67e457a238588 100644 (file)
--- a/yang/yang-parser-rfc7950/pom.xml
+++ b/yang/yang-parser-rfc7950/pom.xml
@@ -24,6 +24,9 @@
     <properties>
         <!-- FIXME: workaround for MJAVADOC-586 -->
         <maven.compiler.release>8</maven.compiler.release>
+
+        <!-- FIXME: antlr-generated code does not pass SB -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
     </properties>
 
     <dependencies>

diff --git a/yang/yang-xpath-impl/pom.xml b/yang/yang-xpath-impl/pom.xml
index 9d4e6aa8e792d6de5b17373f2d0087164cba9226..43988872dd7d215ee117090966463513a9165133 100644 (file)
--- a/yang/yang-xpath-impl/pom.xml
+++ b/yang/yang-xpath-impl/pom.xml
@@ -25,6 +25,9 @@
     <properties>
         <!-- FIXME: workaround for MJAVADOC-586 -->
         <maven.compiler.release>8</maven.compiler.release>
+
+        <!-- FIXME: antlr-generated code does not pass SB -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
     </properties>
 
     <dependencies>