Fix warnings in yang-model-api

This fixes warnings reported in yang-model-api and enables findbugs
enforcement.

Change-Id: Iad35b5ba7c4b9c0373dbcf7be2d696cb66755600
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/yang/yang-model-api/pom.xml b/yang/yang-model-api/pom.xml
index e1758dd5313950f872ab8b07827b43d2cb5b9862..7a71e007014dc89e24b0cdffcf6c9903d46e72a4 100644 (file)
--- a/yang/yang-model-api/pom.xml
+++ b/yang/yang-model-api/pom.xml
@@ -60,6 +60,13 @@
                     <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>findbugs-maven-plugin</artifactId>
+                <configuration>
+                    <failOnError>true</failOnError>
+                </configuration>
+           </plugin>
         </plugins>
     </build>
 

diff --git a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/BelongsToStatement.java b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/BelongsToStatement.java
index 30600e10a0db2120e73decb5225b3a9e5813c0d0..8a7df9685b339d1867075bfe7d6efd7d8b0fbe44 100644 (file)
--- a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/BelongsToStatement.java
+++ b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/BelongsToStatement.java
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.yangtools.yang.model.api.stmt;
 
-import java.util.Optional;
 import javax.annotation.Nonnull;
 import org.opendaylight.yangtools.yang.model.api.meta.DeclaredStatement;
 
@@ -17,8 +16,7 @@ public interface BelongsToStatement extends DeclaredStatement<String> {
     }
 
     default @Nonnull PrefixStatement getPrefix() {
-        final Optional<PrefixStatement> opt = findFirstDeclaredSubstatement(PrefixStatement.class);
-        return opt.isPresent() ? opt.get() : null;
+        return findFirstDeclaredSubstatement(PrefixStatement.class).get();
     }
 }
 

diff --git a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/ImportStatement.java b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/ImportStatement.java
index fd5443ce78a653a1a1ecaa0aedcf009bc418a132..460a80b2810cf03f83106f7f1e7c450cb61713c2 100644 (file)
--- a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/ImportStatement.java
+++ b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/ImportStatement.java
@@ -17,8 +17,7 @@ public interface ImportStatement extends DocumentedDeclaredStatement<String> {
     }
 
     default @Nonnull PrefixStatement getPrefix() {
-        final Optional<PrefixStatement> opt = findFirstDeclaredSubstatement(PrefixStatement.class);
-        return opt.isPresent() ? opt.get() : null;
+        return findFirstDeclaredSubstatement(PrefixStatement.class).get();
     }
 
     default @Nullable RevisionDateStatement getRevisionDate() {

diff --git a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/ModuleStatement.java b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/ModuleStatement.java
index bea4422b59072bcb521ef465c357f5f7395ad14f..3f629c550f58caa64f741c71bfcba5e390ff2b6c 100644 (file)
--- a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/ModuleStatement.java
+++ b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/stmt/ModuleStatement.java
@@ -22,16 +22,13 @@ public interface ModuleStatement extends MetaDeclaredStatement<String>, ModuleHe
         return opt.isPresent() ? opt.get() : null;
     }
 
-    @Nonnull
     @Override
     default NamespaceStatement getNamespace() {
-        final Optional<NamespaceStatement> opt = findFirstDeclaredSubstatement(NamespaceStatement.class);
-        return opt.isPresent() ? opt.get() : null;
+        return findFirstDeclaredSubstatement(NamespaceStatement.class).get();
     }
 
     @Override
     default PrefixStatement getPrefix() {
-        final Optional<PrefixStatement> opt = findFirstDeclaredSubstatement(PrefixStatement.class);
-        return opt.isPresent() ? opt.get() : null;
+        return findFirstDeclaredSubstatement(PrefixStatement.class).get();
     }
 }