Minor inline code comment to clarify TestClass has intentional CS issues

Change-Id: I96133746447dd909cb55b45cbe4dfdca278b1bde
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

diff --git a/common/checkstyle-logging/src/test/java/org/opendaylight/yangtools/checkstyle/CheckLoggingTestClass.java b/common/checkstyle-logging/src/test/java/org/opendaylight/yangtools/checkstyle/CheckLoggingTestClass.java
index f038dda5f5bc7ea74d8fc86a0d06395e77e04df7..ed5a1719cf24fa4d8157e7054dfea532e2e0ea2e 100644 (file)
--- a/common/checkstyle-logging/src/test/java/org/opendaylight/yangtools/checkstyle/CheckLoggingTestClass.java
+++ b/common/checkstyle-logging/src/test/java/org/opendaylight/yangtools/checkstyle/CheckLoggingTestClass.java
@@ -11,6 +11,7 @@ package org.opendaylight.yangtools.checkstyle;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+// NOTE:  This test class contains intentional checkstyle issues, for CheckstyleTest
 public class CheckLoggingTestClass {
     final Logger logger = LoggerFactory.getLogger(CheckstyleTest.class);
     private static final java.util.logging.Logger LOG2 = java.util.logging.Logger.getGlobal();

diff --git a/common/checkstyle-logging/src/test/java/org/opendaylight/yangtools/checkstyle/CheckstyleTest.java b/common/checkstyle-logging/src/test/java/org/opendaylight/yangtools/checkstyle/CheckstyleTest.java
index 0fe027b0af2e46d23e622e620ce4af4ceba77b40..977b61a9c9ce5fe46f3b642338e893cb01ec4e61 100644 (file)
--- a/common/checkstyle-logging/src/test/java/org/opendaylight/yangtools/checkstyle/CheckstyleTest.java
+++ b/common/checkstyle-logging/src/test/java/org/opendaylight/yangtools/checkstyle/CheckstyleTest.java
@@ -55,17 +55,17 @@ public class CheckstyleTest {
     @Test
     public void testLoggerChecks() throws Exception {
         verify(CheckLoggingTestClass.class, true,
-                "15: Logger must be declared as private static final",
-                "15: Logger name should be LOG",
-                "15: LoggerFactory.getLogger Class argument is incorrect",
-                "17: Logger might be declared only once",
-                "16: Logger must be slf4j",
-                "22: Line contains printStacktrace",
-                "23: Line contains console output",
+                "16: Logger must be declared as private static final",
+                "16: Logger name should be LOG",
+                "16: LoggerFactory.getLogger Class argument is incorrect",
+                "18: Logger might be declared only once",
+                "17: Logger must be slf4j",
+                "23: Line contains printStacktrace",
                 "24: Line contains console output",
-                "26: Log message placeholders count is incorrect",
-                "32: Log message placeholders count is incorrect",
-                "41: Log message contains string concatenation");
+                "25: Line contains console output",
+                "27: Log message placeholders count is incorrect",
+                "33: Log message placeholders count is incorrect",
+                "42: Log message contains string concatenation");
     }
 
     @Test