if (isEmptyElement(data)) {
if (hasAttributes(data)) {
writer.writeStartElement(pfx, qname.getLocalName(), ns);
- RandomPrefix randomPrefix = new RandomPrefix();
+ final RandomPrefix randomPrefix = new RandomPrefix();
writeAttributes(writer, (AttributesContainer) data, randomPrefix);
writer.writeEndElement();
} else {
private static boolean hasAttributes(final Node<?> data) {
if (data instanceof AttributesContainer) {
final Map<QName, String> c = ((AttributesContainer) data).getAttributes();
- return c == null || c.isEmpty();
+ return c != null && !c.isEmpty();
} else {
return false;
}
import static org.junit.Assert.assertTrue;
import com.google.common.base.Optional;
+import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import java.io.ByteArrayOutputStream;
+import java.io.File;
import java.net.URI;
import java.util.AbstractMap;
+import java.util.Collections;
import java.util.Map;
import javax.xml.stream.XMLOutputFactory;
import org.junit.Test;
import org.opendaylight.yangtools.yang.common.QName;
import org.opendaylight.yangtools.yang.common.QNameModule;
+import org.opendaylight.yangtools.yang.data.api.Node;
+import org.opendaylight.yangtools.yang.data.api.SimpleNode;
+import org.opendaylight.yangtools.yang.data.impl.ImmutableCompositeNode;
+import org.opendaylight.yangtools.yang.data.impl.NodeFactory;
+import org.opendaylight.yangtools.yang.data.impl.SimpleNodeTOImpl;
+import org.opendaylight.yangtools.yang.model.api.SchemaContext;
+import org.opendaylight.yangtools.yang.parser.impl.YangParserImpl;
import org.w3c.dom.Document;
public class XmlStreamUtilsTest {
assertTrue("Xml differs: " + diff.toString(), identical);
}
+ @Test
+ public void testEmptyNodeWithAttribute() throws Exception {
+ final ByteArrayOutputStream out = new ByteArrayOutputStream();
+ final XMLStreamWriter writer = XML_OUTPUT_FACTORY.createXMLStreamWriter(out);
+
+ final Map<QName, String> attrs = Maps.newHashMap();
+ attrs.put(QName.create("namespaceAttr", "2012-12-12", "attr1"), "value");
+ final QName qName = QName.create("urn:opendaylight:controller:rpc:test", "2014-07-28", "cont");
+ final ImmutableCompositeNode dataAttributes = ImmutableCompositeNode.create(qName, attrs, Collections.<Node<?>>emptyList());
+ XmlStreamUtils.create(XmlUtils.DEFAULT_XML_CODEC_PROVIDER).writeDocument(writer, dataAttributes);
+
+ writer.close();
+ out.close();
+
+ final String xmlAsString = new String(out.toByteArray());
+
+ // TODO why resulting xml does not have namespace definition ? If sending xml by e.g. netconf the namespace is there but not here in test
+ final String expectedXmlAsString = "<cont xmlns:a=\"namespaceAttr\" a:attr1=\"value\"></cont>";
+
+ XMLUnit.setIgnoreAttributeOrder(true);
+ final Document control = XMLUnit.buildControlDocument(expectedXmlAsString);
+ final Document test = XMLUnit.buildTestDocument(xmlAsString);
+ final Diff diff = XMLUnit.compareXML(control, test);
+
+ final boolean identical = diff.identical();
+ assertTrue("Xml differs: " + diff.toString(), identical);
+ }
+
private Map<String, String> mapPrefixed(final Iterable<Map.Entry<URI, String>> prefixes) {
final Map<String, String> mappedPrefixes = Maps.newHashMap();
for (final Map.Entry<URI, String> prefix : prefixes) {