Use StringBuilder instead of StringWriter 44/28244/2
authorRobert Varga <rovarga@cisco.com>
Fri, 9 Oct 2015 16:59:31 +0000 (18:59 +0200)
committerGerrit Code Review <gerrit@opendaylight.org>
Mon, 12 Oct 2015 08:53:50 +0000 (08:53 +0000)
We do not need a Writer interface, as we are simply compositing a
String.

Change-Id: Ied863fe0bf39e99dffe83c2520c56e735d4102d4
Signed-off-by: Robert Varga <rovarga@cisco.com>
yang/yang-data-codec-gson/src/main/java/org/opendaylight/yangtools/yang/data/codec/gson/JSONStreamWriterContext.java

index 6506eada3ac0b34fde11a9149a67a218966b23d7..5449f4c4c70869706316a6bb52158a2fabd18bfc 100644 (file)
@@ -10,7 +10,6 @@ package org.opendaylight.yangtools.yang.data.codec.gson;
 import com.google.common.base.Preconditions;
 import com.google.gson.stream.JsonWriter;
 import java.io.IOException;
-import java.io.StringWriter;
 import java.net.URI;
 import javax.annotation.Nonnull;
 import org.opendaylight.yangtools.yang.common.QName;
@@ -57,19 +56,19 @@ abstract class JSONStreamWriterContext {
      */
     final void writeChildJsonIdentifier(final SchemaContext schema, final JsonWriter writer, final QName qname) throws IOException {
 
-        StringWriter strWriter = new StringWriter();
+        final StringBuilder sb = new StringBuilder();
         // Prepend module name if namespaces do not match
         final URI ns = qname.getNamespace();
         if (!ns.equals(getNamespace())) {
             final Module module = schema.findModuleByNamespaceAndRevision(ns, null);
             Preconditions.checkArgument(module != null, "Could not find module for namespace {}", ns);
 
-            strWriter.append(module.getName());
-            strWriter.append(':');
+            sb.append(module.getName());
+            sb.append(':');
         }
-        strWriter.append(qname.getLocalName());
+        sb.append(qname.getLocalName());
 
-        writer.name(strWriter.toString());
+        writer.name(sb.toString());
     }
 
     /**