Bump versions to 2.1.3-SNAPSHOT

This starts the development of 2.1.3.

Change-Id: I710c410311cff014ed4249a158242400be3c3a62
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup MinMaxElementsValidation with disappearances

When a list disappears, even when it has a certain number of minimum
elements, MinMaxElementsValidation should not take any action.
The resposibility for enforcing the list being present when it has
min-elements > 0 falls under perview of MandatoryNodeValidator, which
covers the non-existence of the list at the proper enforcement point
-- something MinMaxElementsValidation cannot do.

JIRA: YANGTOOLS-909
Change-Id: I3612a1c1461456b2bd41651decab1032581f85d1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

MinMaxElementsValidation needs to deal with lists disappearing

Constrained lists may become empty, in which case applying
the modification will result in a non-present TreeNode. In that
case the list needs to count as zero elements rather than tripping
up VerifyException.

MinMaxElementsValidation really needs to become a full-blown proxy
ModificationApplyOperation instead of being piggy-backed on
SchemaAwareApplyOperation, as otherwise can end up tripping up
preconditions which ware dealt by the proxy.

JIRA: YANGTOOLS-909
Change-Id: Ia410231f701223792a821cd69af84b7742fe5156
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Drop the use of project.groupId

Spelling out org.opendaylight.yangtools makes things more
clear without being too verbose.

Change-Id: I10aabbd4a07eb6d6c25aa8f68157a889ee7ab43e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add bundle-parent and use it

This concentrates common version definitions into a yangtools
bundle-parent and reuses it them where possible -- shaving almost
500 lines of XML.

Change-Id: Ifc79fee557dc0a49fc0a277c2fafa34199171151
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

jaxb-api should be scope=compile

Keeping scope=provided breaks downstream tests with JDK9+,
hence we need to rework the dependencies to make sure we always
pull jaxb-api, but we also need to exclude it from odl-yangtools-data
feature, because it is provided by Karaf.

Change-Id: Id09281c89a74c3d6c780179dfa21ced545318ba1
JIRA: YANGTOOLS-906
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate parser extensions to JDT annotations

This removes run-time reliance on javax.annotation package.

JIRA: YANGTOOLS-907
Change-Id: I9cd870882d8c7edfcc44a50154d0e4148bd4eca5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate common/util to use JDT annotations

This removes run-time reliance on javax.annotation package.

Change-Id: I59193dbe7fcf472fbab29099b685df669c3b301a
JIRA: YANGTOOLS-907
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate yang-common to use JDT annotations

This removes run-time reliance on javax.annotation package.

Change-Id: If8870ba4f6aed9b77d65dc129e3fd7112fb01949
JIRA: YANGTOOLS-907
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate concepts to use JDT annotations

This removes run-time reliance on javax.annotation package.

Change-Id: Ia4c2115f1160446d781f2d7fa1a7b5a4940a3feb
JIRA: YANGTOOLS-907
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix Java 11 build

This fixes spotbugs/Java11 false positive.

Change-Id: Idb8e648bf35f0c9f73a236dcfc8a8419e800cacb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not import java.annotation

Nullable JSR305 annotations have runtime retention scope, which is
causing javax.annotation being imported by our bundles, which is not
correct as we do not need the annotation. Reduce the use of these
and suppress javax.annotation imports.

JIRA: YANGTOOLS-907
Change-Id: I0e1f384880e148c707037f8afd4b8cb9d2e00e72
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Migrate common/util to use JDT annotations"

This reverts commit f069fc0c4ef1a95ef7ca81a2d83301a48bf18fb8.

Change-Id: Icaa2bf8d664fcacf4cb7ac97bdb796414845d623
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Migrate yang-common to use JDT annotations"

This reverts commit 7286488bb26fbd175297925978c4f75ecee1b70f.

Change-Id: I39afedde0aa2d58b9fe8a809a6f8a7a6de59b770
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Migrate concepts to use JDT annotations"

This reverts commit 99379bf4ef363ff88b1898aac1ad671025407322.

Change-Id: I4c3915be96ba1344ca05933359ed88aa238c8913
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate common/util to use JDT annotations

This removes run-time reliance on javax.annotation package.

JIRA: YANGTOOLS-907
Change-Id: I6665adc378a37b09669de5542b7571a040a5d6f6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate yang-common to use JDT annotations

This removes run-time reliance on javax.annotation package.

JIRA: YANGTOOLS-907
Change-Id: I9fc87546af3c3a0ee194be68e5cf9278b18b836c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate concepts to use JDT annotations

This removes run-time reliance on javax.annotation package.

JIRA: YANGTOOLS-907
Change-Id: I9345cd4cd1e5554e18717e4eea721b1fd7fe984b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix spotbugs with Java 11

https://github.com/spotbugs/spotbugs/issues/600 is still present,
biting us.

Change-Id: If9bcd5540c5c0d1427a9e69fde87a674d771c182
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup ScannedDependencyTest

Rather than messing with test resources set them up properly
in the project so that we can rely on them being present.

Also make sure we clean up our resources correctly.

Change-Id: Idb1b8a8d87293a255582f7120cdb0e47f7278080
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to x.1.2-SNAPSHOT

This starts the next development cycle.

Change-Id: I69d1b41f0deed275a1654f623a15c667b6dcfa37
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add NoOp{Listener,Object}Registration

As it turns out, there are use cases for registration which do
nothing in their close() method. Add utility classes to support
those use cases. Also update javadocs a bit.

Change-Id: Ife196f26229cf54173e9b9046ece22bd0138c2ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump triemap to 1.0.1

This brings in the latest version, making sure we pull the same
odlparent.

Change-Id: I47c6a26d8cd9f1d38ae7c57246a0ebe6c4c7540d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 4.0.2

This brings in the latest fixes.

Change-Id: Ia50b273da19ab43a6a2439b9a15fbd94d5f79069
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add jaxb-api dependency

For JDK11 we need an explicit scope=provided dependency on
jaxb-api.

JIRA: YANGTOOLS-906
Change-Id: Ifee829a5cd04561f6124ff03b772db2f5d12f04e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove javadoc overrides

JDK9 javadoc generation breaks due to us excluding the generated
package. Do not do that, allowing build to pass here.

Change-Id: I4076753a136b9ce52ef9cbad5a1fec1901bfe681
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent 4.0.1

Change-Id: I1ec17a54dc4765e392a67ac36d65789a28e988af
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Disable illegal UTs

The XSD/Pattern conversion does not really work in this case, as
"&&" is not something which has the same meaning in XSD patterns.

The test is vailing with JDK9+, but is in general invalid. Disable
it for now, we will re-enable it once we have correct translation.

Change-Id: If54d4b9b4fcf3f612885f4af407d4d32ffcd916f
JIRA: YANGTOOLS-887
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix compilation with JDK9

This fixes type inference failure by using a temporary variable.

Change-Id: I298cb7778d590842911dca9e2bd4936b887a221e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable spotbugs in yang-data-transform

This just flips the enforcement switch.

Change-Id: Ie9eb853bcdd2425417f214a736558a86bebe23b9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 2.1.1-SNAPSHOT

This starts the next development cycle.

Change-Id: I8037e20694f5668249a8c8ee161f2a63b8817b46
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not clutter logs with a thrown exception

SourceException is an unchecked exception which we handle at a higher
layer. The logging statement does not add anything useful, so let's
remove it.

Change-Id: I8a4654b44469a2193996d1d90e982d01a1a62bf3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix TypedefEffectiveStatementImpl double-checked load

We really need a volatile read here to make things alright, make
the field volatile.

Change-Id: Id04917a04f9f1fdba6ded2c773571d90106e877f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded interface declaration

DataNodeContainer is already specified by superclass, no need to
repeat that declaration.

Change-Id: I9a409662d87b02ec9b4abcba88c90bccf684829a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded check

brk is known to be different from -1, hence we can use it directly
rather than using a temporary variable.

Change-Id: If089baa50b8e7b15d8ab03a8e09f7d6d6d0ea7e6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not emit empty non-presence containers

Since the data store portion of container lifecycle has been
fixed, this patch reverts cb247b77dfab26658e434a593ca282fcd723022f
and takes containers' presence statement into account again.

JIRA: YANGTOOLS-903
Change-Id: I9aeeeb72848dd61f8abfe83ae7f22036aae2c214
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable spotbugs in yang-model-validator

This adds supressions as needed and flips the switch.

Change-Id: I35d60ad737a63b4f4e9f2c7819ab3ad8ebb7843a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correctly activate jacoco report aggregation

The profile was missing activation, hence we failed to activate
it -- leading to zero coverage.

Change-Id: Icec36e7347a60f4cc077835596af99a6dd3f7379
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix spotbugs warnings in yang-data-codec-gson

This fixes the simple warnings and flips the switch.

Change-Id: I31cf662d0be9c905b7b7c4f0d2ce44142fa4d71c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove redundant interface declarations

As pointed out by spotbugs, these classes specify Immutable while
it is already specified by a superclass.

Change-Id: I1836b1ec8ffacf441deaf1cb93a8df589ba74374
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings in yang-maven-plugin

Fix spotbugs warnings and flip the switch.

Change-Id: I69f2f65962af3a44b9205f1659af051a30c5133d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable spotbugs in yang-data-util

Fix the few reported warnings and flip the switch.

Change-Id: I31874f55eff860067cda7858381b0abc44444ab6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove sonar.jacoco.reportPath overrides

Now that yangtools-sonar provides sonar.jacoco.reportPaths, there
is no need for us to override it.

Change-Id: I2915a6398bd64b22f8a8368c3276cc0e5af9443a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Activate jacoco aggregation on odl.jacoco.aggregateFile

Unless this property is defined, we don't really have a user,
which means we should not be aggragating jacoco.

Change-Id: I2e9c72d1a30b531111089e14c1fc99ffebb4da28
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch to spotbugs

Findbugs is ancient, spotbugs is a live project, switch to using
it.

Change-Id: I160bb14eb1b32bc226b1e94955d340c7cc79fa5e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate to tech.pantheon.TrieMap

TrieMap has a new how outside of yangtools, use that source and
provide a compatibility wrapper.

JIRA: YANGTOOLS-902
Change-Id: Ifcc27f1dddd0e4f97ee992618bd2941c7c2821bc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove the object cache

It’s been experimental for four years and isn’t used anywhere in ODL.

Change-Id: Icc9778ef5ab777ae217b3ccd02e54de680460c73
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove jacoco overrides

odlparent-4.0.0 includes a refactor which renders these overrides
unneeded. Remove them.

Change-Id: I898160e74e698dd939b582b7c2355165a3041fd9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable findbugs in yang-data-codec-xml

This fixes warnings reported and flips the switch.

Change-Id: I78121287fdc9d3bef6e1b0c52300c57c5be074d6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable findbugs in mockito-configuration

This fixes warnings reported and flips the switch.

Change-Id: I4f035e4c3a9c7bc4a764668abb6adb9b8d952c9c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent 4.0.0

Change-Id: I67af761a5a5f45fe8a76c3905661cff626355935
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add a license badge

This adds a bit of visibility on github.

Change-Id: I4e62496583184ac28a39fcf8efbff869dfc5461e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix Sonar integration

Use project-wide merged JaCoCo execution profile for Sonar purposes,
providing real coverage provided by yangtools UTs. This patch is rather
intrusive due to the need to override odlparent settings to make it
work.

Change-Id: I8aacec9bd2ab45d5a4ffe83d692b020d7bf32ab8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix logging template

Logger template is missing a placeholder, add it.

Change-Id: Ib1068bc4e122affc69e408da87378230607b7408
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable findbugs in more artifacts

This fixed/enables FB warnings in yang-maven-plugin-spi,
yang-parser-spi, yang-test-util and yang-xpath-api,
yang-parser-impl and ang-maven-plugin-it.

Change-Id: I1b9abdbd32f81b16243c111c74143929a573d76e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix pom.xml formatting

The patches to enable findbugs had incorrect indentation of
</plugin>. Fix that.

Change-Id: I0c58c600625a44500ff68b39fc6653d7721f2519
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Experiment: aggregate jacoco for sonar"

This reverts commit 7358371685ccb40a38f7214acd1785d4c9e73236
and cfceb5bc60cbf0d622db1f41466ace602c3ab6e5.

Change-Id: I63153afeedd1ca91835ca6fc63c6af6a71fa3a3b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Experiment: fix base.directory vs. basedir

This fixes up previous patch to correctly reference maven
base directory.

Change-Id: Ib10d67ddbc9d1db116a237f99455cb0a676645c3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Experiment: aggregate jacoco for sonar

This is a second cut, overriding targets for jacoco and also
pointing sonar to the aggregate report.

Change-Id: I07f13985edfbe766c41f6adff1a714c31b6d017a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Experiment: merge jacoco reports"

This reverts commit 5ae609d30b1584d716e93b5faedcb80e1405fd99.

Change-Id: I75da3ddef983b8eb71f577394e056ce245f05c5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Experiment: merge jacoco reports

This is an experiment with sonar, which should allow us to get
better coverage reports.

Change-Id: Ic5649dc88fe36e33a0274f089961a642bfc2e719
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings in yang-model-util

This fixes warnings reported in yang-model-util and enables findbugs
enforcement.

Change-Id: Ieb04815237075f6606711ac72e2b10910b2aa854
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings in yang-model-api

This fixes warnings reported in yang-model-api and enables findbugs
enforcement.

Change-Id: Iad35b5ba7c4b9c0373dbcf7be2d696cb66755600
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove tabs from pom.xmls

This fixes formatting to comply with ODL standards.

Change-Id: Ieffe637a9ce2d5663164e979822be5c2646ecd7e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings in yang-data-api

This fixes warnings reported in yang-data-api and enables findbugs
enforcement.

Change-Id: Ibb999c321b852ad71f21301c31322f9659adffd1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable findbugs in yang-parser-api

Flip the switch on enforcement.

Change-Id: I7bcb413c1aafd00ec63efc1ac296332ae0c1118b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings in rfc8040 support

This fixes warnings reported in rfc8040-model-api and
rfc8040-parser-support, and enables findbugs enforcement.

Change-Id: I4ee91b65cc7f6ae11fffbdd3181d6470d9214c04
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable findbugs in rfc7952 support

This just flips the enforcement switch, not further changes.

Change-Id: Idb94e589ec7ba58f9ee22231ff5c6fd0d27fc49f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable findbugs in rfc6536 support

This just flips the enforcement switch, not further changes.

Change-Id: Iec68058a4e056b4e7b3320213a3ae290a46d3837
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings in openconfig support

This fixes warnings reported in openconfig-model-api and
openconfig-parser-support, and enables findbugs enforcement.

Change-Id: I6769c4b4ddb4f4782911619e4d6c177d55f7dccf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings in odlext support

This fixes warnings reported in odlext-model-api and odlext-parser-support,
and enables findbugs enforcement.

Change-Id: I97d0f98052d36fbbbee1590abbc33ad4e9db07a8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix findbugs in yang-common and enable enforcement

Fix trivial issues and suppress places where findbugs does not
understand annotations.

Change-Id: I988e1471b04d42e988f20b9492d6b0f07252f6be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix javadoc warnings in testutils and enable findbugs

This fixes javadoc warnings and enables findbugs in testutils.

Change-Id: If5b4cfe8cc30f8c551534e506be9d322d9c4ce03
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings in concepts and enable findbugs

This patch fixes all javac/checkstyle/findbugs/javadoc warnings
and enables findbugs enforcement.

Change-Id: I48a488e54cb533dd38fba5c3a61233dadef35e43
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add yang-model-api tests

This improves test coverage by testing default methods in yang-model-api.

Change-Id: Iee9290c86ad7b9ab7c20c56b5ebd51ffa966c4d7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Consider AugmentationNodes when direct descendant is not found

With previous refactors it is quite easy to arrive at a simple
solution to take augmentations into account. This also

This includes a unit test from upstream based on afi-safi-name
with bgp-openconfig-extensions.

JIRA: YANGTOOLS-892
Change-Id: I237ed2c6cbed458a2109a48b468a30650f103a48
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate LeafRefValidation.forEachChoice()

As it turns out the two call sites can share more code. Introduce
processChildNode(), inlining forEachChoice() and its surrounding
lookup logic.

JIRA: YANGTOOLS-892
Change-Id: I2091abcd579ce1d48a628c3bdea9b4514b050e29
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Optimize QNameWithPredicateImpl

Create a dedicated QName-only implementation, saving some space.

Change-Id: I0218763aaf4e809f50b580677fc0b634b7c918fa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Split up LeafRefValidation.validateNodeData()

Turn this method into a dispatch and move logic into dedicated
methods. This makes it easier to follow the code flow and eliminate
duplicates.

JIRA: YANGTOOLS-892
Change-Id: I840fa0d2e8c7ea86efa05c1afea825e85d890837
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Minor code cleanups

- static private method
- reduce use of ChoiceSchemaNode.getCaseNodeByName()
- QNameWithPredicateBuilder(QName)

Change-Id: I9cf97ba4c6ef667e39212f511e17bb18b4002bc3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use Iterables.filter() instead of FluentIterable

This removes allocation of one instance of FluentIterable, reducing
the amount of garbage we produce.

Change-Id: I93953f1263426f7fff20e579e56f82506fb423d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename LeafRefValidatation to LeafRefValidation

This is a naming typo which went unnoticed for quite some time,
rename the implementation class and instantiate a proxy for
compatibility.

JIRA: YANGTOOLS-892
Change-Id: I3ec77d7df41942502394047e9e13007c6693d3af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rework choice iteration in LeafRefValidatation

Rather than extracting ChoiceNodes into a temporary list, use
a consumer which will be invoked for each of them.

JIRA: YANGTOOLS-892
Change-Id: I0956bed6e446c1ee4bf44c88fcc361abe8a508e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup map iteration in LeafRefValidatation

We have two codepaths for non-filtered and filtered map entry case,
which end up iterating over map entries. Rewrite the code in terms
of an optionally-filtered stream, reducing code duplication.

JIRA: YANGTOOLS-892
Change-Id: I3ca37edb66373cc5ab4632210980cd4a467fd198
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rework path LeafRefValidatation path tracking

Rather than using a plain iterable sourced from LeafRefPath.getPathFromRoot(),
maintain a Deque sourced via getPathTowardsRoot(). This eliminates the need
for Iterables.skip() as well as not forcing getPathFromRoot() being initialized.

Change-Id: I23c054a63b2c0ceed24fcf48d2636508ee13d568
JIRA: YANGTOOLS-892
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Pass down predicates instead of the entire predicate node

Since we are not using the rest of the data, it is much simpler
to just pass down predicates. It also reduces confusion as to
what state we are propagating.

Change-Id: If790fcc2a8d023cb863d09162b25d644b0dd4638
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not validate non-existent roots

If we have no data there is no point to validate anything, and
having the root value as an invariant makes code a lot simpler.

JIRA: YANGTOOLS-892
Change-Id: Ifd68b09c03d90c8881381809047e59f3fe92682b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add LeafRefValidatation.computeValues()

This separates out the heavy-weight value computation, simplifying
callers a bit.

JIRA: YANGTOOLS-892
Change-Id: I218659f830aec822f80decd3622c9890df832379
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate leafRefTargetNodeDataLog()

Now that we captured invariants, we can proceed to turn
leafRefTargetNodeDataLog() into a simpler lambda form.

JIRA: YANGTOOLS-892
Change-Id: I4644d0f3bc31f9f9cb3643e8443159522f14ccaa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Untangle result processing logic.

leafRefTargetNodeDataLog() is needlessly complex, where it is called
with 3 different sets of arguments from validateLeafRefTargetNodeData()
only.

Inline two of those callers, reducing nesting significantly and
making the code flow more obvious.

Change-Id: I68205d58677e2392989a5fc064a986f5c1716666
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move LeafRefPath creation from fast path

LeafRefValidation is the fast path and LeafRefPath we are creating
is in an invariant. Cache it in LeafRefContext as needed.

JIRA: YANGTOOLS-892
Change-Id: I40ef136630b7cdacca84b2f08a9e0491daa03c14
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup leafref path parsing

We have a String on input and LeafRefPathParserImpl uses ANTLR's
CharStreams -- hence it makes no sense to bounce input through
an InputStream.

Remove this atrocity, eliminating an IOException/IllegalStateException
error path in process.

JIRA: YANGTOOLS-892
Change-Id: I78eadf30da6a1e64621ca4c14dfa13e84524b591
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup LeafRefContext(Tree)Builder

These are package-private classes, make them final, eliminate
unneeded methods and improve code formatting.

JIRA: YANGTOOLS-892
Change-Id: I8a4925a665b1bcac7abd8088719e80f53229bafe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup LeafRefPath

Remove commented-out code and cleanup javadocs.

Change-Id: I7d6d62bd091191d3ab914a5767eaf4a2ab7830b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not leak Optional in QNameWithPredicateImpl.toString()

The toString() method blindly appends the revision, leading to
Optional[] being present in the result. Fix the method to look
at the returned version and append the query only when it is
present -- just like QName does.

Change-Id: I47dcdaa3c7ca7b3bfaf34898f76b10dfb2ddbe00
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Consider namespace in namesakes

XML (unlike JSON) has explicit namespaces which we need to take
into consideration when determining whether two elements have the
same name.

JIRA: YANGTOOLS-900
Change-Id: I0d53bee5d18d211343c094941985bd3f0b6a8776
Signed-off-by: Isabel Lloret <illoret@indra.es>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Note UniqueConstraint changes

We should not be using Collection here, but rather Set. Mark the
change for 3.0.0.

Change-Id: I42c5070f7f243f3ad03e481d47757812029b5d55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Avoid depending on immutables.value at runtime"

This reverts commit 8ed3332603523219d19bd8481664790db4d8acc7. It
should not be necessary with immutables.org-2.7.1.

Change-Id: Ifb323f6f17b9ec1119b74f036925b05fa44addce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean various constructs

* Remove intern() on constant strings.
* Avoid some casts by changing test instance types.
* Remove a number of unnecessary type specifiers and casts.
* Remove an unnecessary return.
* Use StringBuilder::append()'s substring parameters instead of a
  separate String::substring().

Change-Id: Iaaa206d233fbc43ed1bed2d651c549643e6e7697
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Drop commons-lang dependency

yang-data-impl's test dependency on commons-lang is unused.

Change-Id: I46d543ede3190537ff9f9dacffa57a78e1e1f462
Signed-off-by: Stephen Kitt <skitt@redhat.com>