import javax.management.InstanceAlreadyExistsException;
import javax.management.ObjectName;
import org.opendaylight.controller.config.api.jmx.ObjectNameUtil;
-import org.opendaylight.controller.config.manager.impl.jmx.InternalJMXRegistrator.InternalJMXRegistration;
public interface ServiceReferenceRegistrator extends AutoCloseable {
- public String getNullableTransactionName();
+ String getNullableTransactionName();
ServiceReferenceJMXRegistration registerMBean(ServiceReferenceMXBeanImpl object,
ObjectName on) throws InstanceAlreadyExistsException;
@Override
void close();
- public static class ServiceReferenceJMXRegistration implements AutoCloseable {
+ class ServiceReferenceJMXRegistration implements AutoCloseable {
private final InternalJMXRegistration registration;
ServiceReferenceJMXRegistration(InternalJMXRegistration registration) {
}
}
- public static interface ServiceReferenceTransactionRegistratorFactory {
- public ServiceReferenceRegistrator create();
+ interface ServiceReferenceTransactionRegistratorFactory {
+ ServiceReferenceRegistrator create();
}
- public static class ServiceReferenceRegistratorImpl implements ServiceReferenceRegistrator {
+ class ServiceReferenceRegistratorImpl implements ServiceReferenceRegistrator {
private final InternalJMXRegistrator currentJMXRegistrator;
private final String nullableTransactionName;
this.nullableTransactionName = nullableTransactionName;
}
+ @Override
public String getNullableTransactionName() {
return nullableTransactionName;
}
+ @Override
public ServiceReferenceJMXRegistration registerMBean(ServiceReferenceMXBeanImpl object,
ObjectName on) throws InstanceAlreadyExistsException {
String actualTransactionName = ObjectNameUtil.getTransactionName(on);
boolean broken = false;
broken |= (nullableTransactionName == null) != (actualTransactionName == null);
- broken |= (nullableTransactionName != null) && nullableTransactionName.equals(actualTransactionName) == false;
+ broken |= (nullableTransactionName != null) && !nullableTransactionName.equals(actualTransactionName);
if (broken) {
throw new IllegalArgumentException("Transaction name mismatch between expected "
+ nullableTransactionName + ", got " + actualTransactionName + " in " + on);
}
- if (ObjectNameUtil.isServiceReference(on) == false) {
+ if (!ObjectNameUtil.isServiceReference(on)) {
throw new IllegalArgumentException("Invalid type of " + on);
}
return new ServiceReferenceJMXRegistration(currentJMXRegistrator.registerMBean(object, on));
public void close() {
currentJMXRegistrator.close();
}
- public static interface ServiceReferenceTransactionRegistratorFactory {
- public ServiceReferenceRegistrator create();
+ public interface ServiceReferenceTransactionRegistratorFactory {
+ ServiceReferenceRegistrator create();
}
}
- public static class ServiceReferenceTransactionRegistratorFactoryImpl implements ServiceReferenceTransactionRegistratorFactory {
+ class ServiceReferenceTransactionRegistratorFactoryImpl implements ServiceReferenceTransactionRegistratorFactory {
private final NestableJMXRegistrator parentRegistrator;
private final String nullableTransactionName;
this.nullableTransactionName = null;
}
+ @Override
public ServiceReferenceRegistrator create() {
return new ServiceReferenceRegistratorImpl(parentRegistrator, nullableTransactionName);
}