controller.git
2 days agoBump upstreams 14/104214/3 master
Robert Varga [Wed, 1 Feb 2023 15:46:37 +0000 (16:46 +0100)]
Bump upstreams

Adopt:
- odlparent-12.0.2
- yangtools-10.0.3
- mdsal-11.0.5

Change-Id: I2fa6e32b7275bb50118289af2d096b98cce95680
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
11 days agoBump versions to 7.0.3-SNAPSHOT 97/104097/1
Robert Varga [Mon, 23 Jan 2023 10:09:52 +0000 (11:09 +0100)]
Bump versions to 7.0.3-SNAPSHOT

This starts the next development iteration.

Change-Id: I3449be174e52ea7b964a321545254165f326d575
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
11 days agoBump mdsal to 11.0.4 96/104096/1
Robert Varga [Mon, 23 Jan 2023 10:09:09 +0000 (11:09 +0100)]
Bump mdsal to 11.0.4

Pick up codegen fix for bits.

Change-Id: I341ab659a3f1874d902e55cf656702d3d8eae18c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 weeks agoBump versions to 7.0.2-SNAPSHOT 99/103699/1
Robert Varga [Sun, 18 Dec 2022 12:26:48 +0000 (13:26 +0100)]
Bump versions to 7.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I2fdeca1eaac7770d1e147c37edac62500434559c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 weeks agoBump mdsal to 11.0.3 98/103698/1
Robert Varga [Sun, 18 Dec 2022 12:24:38 +0000 (13:24 +0100)]
Bump mdsal to 11.0.3

Adopt fixes from upstream.

Change-Id: I5d37f13c2c9c09895b5c34f58d98985635c2bbab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 weeks agoModernize cds-access-client 80/103580/4
Robert Varga [Sun, 4 Dec 2022 20:46:03 +0000 (21:46 +0100)]
Modernize cds-access-client

Use instanceof patterns to reduce the number of casts.

Change-Id: If0f3d0d47e9a68b24372b79e93aa478ec32cf9b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 weeks agoModernize sal-remoterpc-connector 81/103581/4
Robert Varga [Sun, 4 Dec 2022 20:55:04 +0000 (21:55 +0100)]
Modernize sal-remoterpc-connector

Use instanceof patterns to reduce casts.

Change-Id: Iafcb05461e2c241310857ee2bf93591bed66a7d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoModernize sal-clustering-commons 79/103579/2
Robert Varga [Sun, 4 Dec 2022 20:39:46 +0000 (21:39 +0100)]
Modernize sal-clustering-commons

Use instanceof patterns to reduce the number of casts.

Change-Id: I40eb35b3b1afdae30d461a608aeabda2d7e09ce8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoBump versions to 7.0.1-SNAPSHOT 78/103578/1
Robert Varga [Sun, 4 Dec 2022 20:26:24 +0000 (21:26 +0100)]
Bump versions to 7.0.1-SNAPSHOT

This starts the next development iteration.

Change-Id: Ia719b57550d7d8f3e26a20b5bfbc4c1935dd8a25
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoRemove blueprint from clustering-test-app 47/103147/13
matus.matok [Mon, 28 Nov 2022 07:28:35 +0000 (08:28 +0100)]
Remove blueprint from clustering-test-app

Replace bluprint wiring with explicit MD-SAL registration and OSGi
Declarative Services.

JIRA: CONTROLLER-2002
Change-Id: Ibbc7129062224b666d04ec76a04b2779f2662a6e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: matusmatok <matus.matok@pantheon.tech>
2 months agoBump upstreams 72/103572/1
Robert Varga [Sun, 4 Dec 2022 17:44:19 +0000 (18:44 +0100)]
Bump upstreams

Adopt:
- yangtools-10.0.2
- mdsal-11.0.2

Change-Id: I7e3214e2a4ef430eb1c111d4a8c77c042d66419c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoObsolete ask-based protocol 03/103103/11
Robert Varga [Sat, 5 Nov 2022 02:11:54 +0000 (03:11 +0100)]
Obsolete ask-based protocol

Mark the switch to use ask-based protocol obsolete and deprecate all
classes implementing it.

JIRA: CONTROLLER-2053
Change-Id: Ib0f5d6a946090addde255423d51746a52e785b2a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoFix more Sonar warnings 44/103544/3
Robert Varga [Sat, 3 Dec 2022 12:24:16 +0000 (13:24 +0100)]
Fix more Sonar warnings

Ignored exceptions, mergeable if statements and similar.

Change-Id: Iea262b7c410cfde16fd4f101d3c7c8195ff1ea1f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoFixup Sonar issues 34/103534/4
Robert Varga [Sat, 3 Dec 2022 00:32:37 +0000 (01:32 +0100)]
Fixup Sonar issues

Perform automatic conversions and also fixup Sonar issues reported,
which tend to be very minor.

Change-Id: Ia0d980105f4635218bacb9161a39ecb87838a9ff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoSeal Snapshot 30/103530/2
Robert Varga [Fri, 2 Dec 2022 16:57:24 +0000 (17:57 +0100)]
Seal Snapshot

We do not want people to subclass this class, make sure it is sealed.

Change-Id: I81e8a2ba5232471a8f153a710d957e3cb22bbb5e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoSwitch to use PayloadVersion.CHLORINE_SR2 20/103520/6
Robert Varga [Fri, 2 Dec 2022 12:05:36 +0000 (13:05 +0100)]
Switch to use PayloadVersion.CHLORINE_SR2

PayloadVersion.CHLORINE_SR2 is more efficient format, switch to using
it and deprecate old versions for removal.

JIRA: CONTROLLER-2056
Change-Id: Id05a34a28e4d3e817fc6ff783669493ee80af3b7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoModernize sal-akka-raft 29/103529/2
Robert Varga [Fri, 2 Dec 2022 16:17:54 +0000 (17:17 +0100)]
Modernize sal-akka-raft

Use instanceof and switch expressions to improve code flows. Also
shortcut handleRequestVote(), as we can have the instance casted
in AbstractLeader.

Change-Id: Ib726c79fbcc667335a3749f528b3836dc3896e73
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoTrigger snapshots on legacy persisted entries 25/103525/1
Robert Varga [Fri, 2 Dec 2022 16:00:02 +0000 (17:00 +0100)]
Trigger snapshots on legacy persisted entries

We have migrated proxies, hence we should be purging them from journal
if we encounter them during recovery. Introduce a marker interface for
that and subclasses which implement it.

JIRA: CONTROLLER-2064
Change-Id: Ie16b1247306d64580df977bece70a94eb3187cbf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoSwitch to ARGON raft version 14/103514/9
Robert Varga [Fri, 2 Dec 2022 08:10:07 +0000 (09:10 +0100)]
Switch to ARGON raft version

We have new, more efficient serialization format. Switch to using it and
deprecate old proxies.

JIRA: CONTROLLER-2064
Change-Id: Ie549f08d62953ff6019ff915b12d0d4fedb1d3a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoDefine RaftVersions.ARGON_VERSION 13/103513/9
Robert Varga [Fri, 2 Dec 2022 08:00:40 +0000 (09:00 +0100)]
Define RaftVersions.ARGON_VERSION

Our serialization proxies result in a unnecessarity-big footprint.
Define their replacements for forward compatibility with Argon raft
version.

JIRA: CONTROLLER-2058
Change-Id: I545485c6abdf16f6d81a48672b36eb83613013e1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoDeprecate old RaftVersions 10/103510/2
Robert Varga [Fri, 2 Dec 2022 07:29:49 +0000 (08:29 +0100)]
Deprecate old RaftVersions

Mark old RaftVersion constants as deprecated and adjust checks to work
on BORON instead of FLUORINE, so they can be properly removed when we
remove BORON support.

Change-Id: Id5b4d2995306d9639a2cd81b82304e090d1f105d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoUse instanceof patterns in Follower 16/103516/1
Robert Varga [Fri, 2 Dec 2022 10:33:42 +0000 (11:33 +0100)]
Use instanceof patterns in Follower

We can reduce casts and improve logic a bit with instanceof patterns.

Change-Id: Ife036c99cba938b79c35fb042f642e96b6a769a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoAdd sal-akka-raft serialization assertions 09/103509/1
Robert Varga [Fri, 2 Dec 2022 06:55:33 +0000 (07:55 +0100)]
Add sal-akka-raft serialization assertions

We need to be in control of serialized payload size. This patch adds the
assertions on sizes.

Change-Id: Ic73724d0acc51d7d7f28acb392fe569f719762c9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoDeprecate ABIVersion.MAGNESIUM 82/103482/17
Robert Varga [Wed, 30 Nov 2022 17:58:22 +0000 (18:58 +0100)]
Deprecate ABIVersion.MAGNESIUM

This version is using inefficient Externalizable proxy and has been
supersed by CHLORINE_SR2. Deprecate it for removal and old proxies
as deprecated as well.

JIRA: CONTROLLER-2061
Change-Id: I0959f88d759d2aad33e16e13e9fefe34cd51a740
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoPrune old ABI versions 99/103099/12
Robert Varga [Fri, 4 Nov 2022 21:11:03 +0000 (22:11 +0100)]
Prune old ABI versions

Remove all ABIVersion constants before MAGNESIUM, and adjust the test
for that. Also modernize tests a bit.

JIRA: CONTROLLER-2060
Change-Id: Ie9e3106e24b0b75d58b360ba2296d85e46be351a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoDeprecate ABIVersion.{BORON,NEON_SR2,SODIUM_SR1} 93/103493/5
Robert Varga [Thu, 1 Dec 2022 13:50:52 +0000 (14:50 +0100)]
Deprecate ABIVersion.{BORON,NEON_SR2,SODIUM_SR1}

These versions are ancient and should not be used. They will be removed
in version 7.0.0.

JIRA: CONTROLLER-2059
Change-Id: I1e4584f0771d3e40eee1fcf9ada6e564a9bb2475
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoSwitch identifiers to new proxies 85/103485/10
Robert Varga [Wed, 30 Nov 2022 22:07:11 +0000 (23:07 +0100)]
Switch identifiers to new proxies

We have more efficient serialization proxies defined, use them for
writeout and deprecate the old ones.

JIRA: CONTROLLER-2051
Change-Id: I1daa83e8fcdd3776951fc1c284c9e6d0d7f64078
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoSwitch ABIVersion.current() to CHLORINE_SR2 92/103492/4
Robert Varga [Thu, 1 Dec 2022 12:31:49 +0000 (13:31 +0100)]
Switch ABIVersion.current() to CHLORINE_SR2

We should be safe to enable this version by default, reaping
serialization overhead benefits. This impacts envelope serialization
tests, as those are picking up default versions and flipping it enables
new codepath.

JIRA: CONTROLLER-2051
Change-Id: I7720871775777bf187137482ad72d473acbece16
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoUse current ABIVersion for testing 96/103496/1
Robert Varga [Thu, 1 Dec 2022 16:37:25 +0000 (17:37 +0100)]
Use current ABIVersion for testing

There is no point in cloning messages we use, just use the current ABI
version, whichever that is.

Change-Id: Id19780dc402077e5c0883db238d4af081112a4c8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoAssert new request sizes 79/103479/14
Robert Varga [Wed, 30 Nov 2022 14:26:48 +0000 (15:26 +0100)]
Assert new request sizes

We now have ABIVersion.CHLORINE_SR2, use it to test serialization
proxy sizes -- showing the improvements to size.

JIRA: CONTROLLER-2051
Change-Id: I8c37201e531c00c5ff9d1322db911dfbcf8fd97b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoAdd ABIVersion.CHLORINE_SR2 77/103477/14
Robert Varga [Wed, 30 Nov 2022 13:24:23 +0000 (14:24 +0100)]
Add ABIVersion.CHLORINE_SR2

We have a fresh set of serialization proxies used when we have a version
newer than MAGNESIUM. This patch defines that new version.

JIRA: CONTROLLER-2051
Change-Id: Id91201652afc9dd55d4b44c73bd2d9d3fa3853d3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoAdd new cds-access-api proxies 47/103447/26
Robert Varga [Sun, 27 Nov 2022 12:59:16 +0000 (13:59 +0100)]
Add new cds-access-api proxies

Externalizable serialization format record class hierarchy, which leads
to significant overheads. This patch introduces proxies which are are
flat, i.e. have java.Object as their superclass, eliminating this
overhead.

The way we do this is we defined SerialForm interfaces which extend
Externalizable and define the serialization protocol in terms of default
methods. We then define a bunch of classes which are pure data holders
implementing individual SerialForms.

Also ensure messages properly implement cloneAsVersion() to propagate
the target version, now that it matters for them.

Finally audit use of java.io.Serial so that we do not import it -- it is
just pure overhead vs. using @java.io.Serial directly.

JIRA: CONTROLLER-2051
Change-Id: I01132665027687edc1c6d44dda8a6ab0cab6ad6a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoAdd serialization size assertions for Request{Failure,Success} 78/103478/2
Robert Varga [Wed, 30 Nov 2022 13:37:20 +0000 (14:37 +0100)]
Add serialization size assertions for Request{Failure,Success}

We have a bunch of unasserted sizes, make sure we fill them in.

JIRA: CONTROLLER-2051
Change-Id: I7b812d53133425b5ac754652901787b202e16c63
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoAdd missing final keywords 69/103469/1
Robert Varga [Tue, 29 Nov 2022 21:07:21 +0000 (22:07 +0100)]
Add missing final keywords

We have a few ommissions here, fix that up.

Change-Id: If633f22e293e7a0ca022d12bed8f39ec68ae05d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoDefine PayloadVersion.CHLORINE_SR2 64/103464/3
Robert Varga [Tue, 29 Nov 2022 19:00:38 +0000 (20:00 +0100)]
Define PayloadVersion.CHLORINE_SR2

Add the definition of PayloadVersion.CHLORINE_SR2. This is backwards
compatiblein most senses.

JIRA: CONTROLLER-2056
Change-Id: Ia39ccf117ec1a0eb0edf909fbaea903f13c185f3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoUse a switch expression for Payload parsing 63/103463/1
Robert Varga [Tue, 29 Nov 2022 18:55:04 +0000 (19:55 +0100)]
Use a switch expression for Payload parsing

We can simplify the switch statement here, making it easier to read.

Change-Id: Ie6e23e7817072b5968f14d17d7063e036563122b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoDefine efficient serialization proxies 22/103422/25
Robert Varga [Sat, 26 Nov 2022 17:35:35 +0000 (18:35 +0100)]
Define efficient serialization proxies

Superclasses have footprint in serialization protocol, as their
descriptors get written out.

Capture Externalizable logic into SerialForm, which implements
Externalizable -- the protocol to be easily implemented without a
superclass. This entails updating the API footprint of AbstractProxy
to reuse its methods.

Then introduce shorthand proxy classes which behave exactly like their
AbstractProxy counterparts, but without the AbstractProxy baggage.

This enables reading implied serialization format, if we encounter it,
providing forward compatibility with the format.

JIRA: CONTROLLER-2056
Change-Id: I4da54ca57849c2bfdaaf76c22e7903abcfa58be9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoUse a switch expression for TreeType 62/103462/1
Robert Varga [Tue, 29 Nov 2022 15:17:23 +0000 (16:17 +0100)]
Use a switch expression for TreeType

Use exhaustiveness of a switch expression to peel an impossible case.

Change-Id: I7d1d228484656fc81b51762878d569698d570f80
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoUse an instanceof pattern 60/103460/1
Robert Varga [Tue, 29 Nov 2022 09:50:48 +0000 (10:50 +0100)]
Use an instanceof pattern

We can merge the check and cast here.

Change-Id: I95cb4d5574dab43e4f5f06c9c372fe294c131224
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoReuse cause message 53/103453/2
Robert Varga [Mon, 28 Nov 2022 19:41:53 +0000 (20:41 +0100)]
Reuse cause message

We are actually hiding information, make sure we reuse the message from
cause.

Change-Id: Ia361c0b06ed173cbe1a3c8a7fb86b1869ea88da2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoAssert payload serialized size 21/103421/9
Robert Varga [Sat, 26 Nov 2022 11:42:15 +0000 (12:42 +0100)]
Assert payload serialized size

We want to be in control over the size of our serialization, make sure
to add assertions.

JIRA: CONTROLLER-2051
JIRA: CONTROLLER-2056
Change-Id: I72957eaf284bfd5498cfdb11301239ac50d612f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoAdd serialVersionUID fields 46/103446/7
Robert Varga [Mon, 28 Nov 2022 17:38:48 +0000 (18:38 +0100)]
Add serialVersionUID fields

We are missing a few definitions and are about to modify the classes
in backwards-compatible ways, but the changes would end up changing
the versions. Make sure to define generated serialVersionUIDs.

JIRA: CONTROLLER-2051
JIRA: CONTROLLER-2056
Change-Id: I006f51e16dd3fee66fb9c344bb99235780b08d3e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoShardSnapshotState is final 32/103432/3
Robert Varga [Sat, 26 Nov 2022 21:59:08 +0000 (22:59 +0100)]
ShardSnapshotState is final

This is a well-known contract, it should be final.

Change-Id: Ib1748ed05969a56266a62477dc794d6df43b2df1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoDatastoreSnapshot is final 31/103431/3
Robert Varga [Sat, 26 Nov 2022 21:15:14 +0000 (22:15 +0100)]
DatastoreSnapshot is final

This is DTO, it should be final.

Change-Id: I46944b1a3b6aff51e2fe20f117c598d88e1e8469
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoShardSnapshot is final 30/103430/3
Robert Varga [Sat, 26 Nov 2022 20:50:07 +0000 (21:50 +0100)]
ShardSnapshot is final

There is no point in extending this class, make it final.

Change-Id: I6f73c5be57e6fb58e7c74b5681907ae0f492437d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoShardManagerSnapshot is final 29/103429/3
Robert Varga [Sat, 26 Nov 2022 20:04:07 +0000 (21:04 +0100)]
ShardManagerSnapshot is final

This is a well-known construct, it does not have any subclasses.

Change-Id: I40d0c605c776e0cf185bcd0425cfe48bb92d64f0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoSeal CommitTransactionPayload 28/103428/3
Robert Varga [Sat, 26 Nov 2022 19:02:41 +0000 (20:02 +0100)]
Seal CommitTransactionPayload

We only provide two specializations, seal the base class.

Change-Id: I27f55a79fb1b9b284f1cb4c1c639e28ab9b9df51
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoAdopt mdsal-11.0.1 52/103452/1
Robert Varga [Mon, 28 Nov 2022 19:18:16 +0000 (20:18 +0100)]
Adopt mdsal-11.0.1

We have exposed a regression in mdsal-11.0.0, adopt the fix from
upstream.

Change-Id: I0f82ba6d0748f7cbb159e800a964b3abe4b3742f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoRemove unused ShardManagerSnapshot 20/103420/1
Robert Varga [Sat, 26 Nov 2022 11:59:17 +0000 (12:59 +0100)]
Remove unused ShardManagerSnapshot

This class has been migrated to persisted package. Remove it.

Change-Id: Ie5390eb1679f4ffc74d7d6a8cccf45f1f273105a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoUse diamond notation 19/103419/1
Robert Varga [Sat, 26 Nov 2022 10:48:51 +0000 (11:48 +0100)]
Use diamond notation

We do not need to specify arguments here.

Change-Id: If92534ae0306e8abe27919cbc368da55683fa97b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoUpdate upstreams 05/103405/2
Robert Varga [Fri, 25 Nov 2022 23:23:37 +0000 (00:23 +0100)]
Update upstreams

Adopt:
- odlparent-12.0.1
- yangtools-10.0.1
- mdsal-11.0.0

Change-Id: Ied40be292d9de2ea2d20ba3a454582d910624474
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoDo not allow multi-datastore transactions 81/103181/3
Ruslan Kashapov [Wed, 9 Nov 2022 17:16:58 +0000 (19:16 +0200)]
Do not allow multi-datastore transactions

The ability to access multiple datastores from the same transaction
has been long-deprecated. This patch disables that ability, binding
each transaction to the datastore it first accesses.

JIRA: CONTROLLER-2055
Change-Id: I57fed3daf2ae9cd0cc6f4899fe1975c05def5c46
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoBump upstreams 44/103144/6
Robert Varga [Tue, 8 Nov 2022 10:30:12 +0000 (11:30 +0100)]
Bump upstreams

Adopt:
- odlparent-12.0.0
- yangtools-10.0.0
- mdsal-11.0.0-SNAPSHOT

Update toaster test to not use the same transaction for both config
and oper access.

Update RPC invocation paths to assume ContainerNode as opposed to a
plain NormalizedNode.

Change-Id: I31c6350746be4e176a389d8a14a12de89119a78b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoUse a VarHandle for closed flag 45/103145/1
Robert Varga [Tue, 8 Nov 2022 11:26:22 +0000 (12:26 +0100)]
Use a VarHandle for closed flag

This eliminates type safety warnings and make it more explicit as to
what we mean.

Change-Id: I2335ff7c970ec7f5f55624a02a0c49b349deaa64
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoImprove AbstractDOMTransactionFactory 43/103143/1
Robert Varga [Tue, 8 Nov 2022 11:23:19 +0000 (12:23 +0100)]
Improve AbstractDOMTransactionFactory

AutoCloseable.close() is recommended to be idempotent, follow that
guidance, producing a warning with a stack trace if that is not the
case.

Change-Id: I1b65466f9b84e05417d8cd24c1b7a5e89e8e836b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoBump versions to 7.0.0-SNAPSHOT 13/103113/1
Robert Varga [Sun, 6 Nov 2022 20:44:15 +0000 (21:44 +0100)]
Bump versions to 7.0.0-SNAPSHOT

This starts the next development iteration.

Change-Id: I78683b4b6ce4cc03e211d39c0a72f34446bd8b1e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoBump verions to 6.0.4-SNAPSHOT 02/103102/1
Robert Varga [Sat, 5 Nov 2022 00:38:26 +0000 (01:38 +0100)]
Bump verions to 6.0.4-SNAPSHOT

This starts the next development iteration.

Change-Id: Icca925e3b86b9e44aa7000ce0844c274857936d1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoBump upstrems 48/103048/6
Robert Varga [Thu, 3 Nov 2022 02:15:17 +0000 (03:15 +0100)]
Bump upstrems

Adopt:
- odlparent-11.0.2
- yangtools-9.0.2
- mdsal-10.0.3

Change-Id: I221bb0697db1987c2cb3069ec88f492ce7201e5a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoSwitch default ABIVersion 98/103098/2
Robert Varga [Fri, 4 Nov 2022 21:09:56 +0000 (22:09 +0100)]
Switch default ABIVersion

Somehow we missed an update of version here. Make sure to use Magnesium.

JIRA: CONTROLLER-2052
Change-Id: I1d45b4fc558c34c0c40faba41f29522772431a24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoModernize AbstractLocalTransactionRequestTest 97/103097/1
Robert Varga [Fri, 4 Nov 2022 21:17:46 +0000 (22:17 +0100)]
Modernize AbstractLocalTransactionRequestTest

Use static imports and use assertThrows() and better assertion on the
thrown exception.

Change-Id: I9b11e8a6797b76efa52f1eb3506b630de4a3ae44
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoModernize AbstractRequestTest 96/103096/1
Robert Varga [Fri, 4 Nov 2022 21:13:36 +0000 (22:13 +0100)]
Modernize AbstractRequestTest

Use static imports and improve message assertion.

Change-Id: I97cf242781c25988bf3bcf50f76e9a2dd1b0c8fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoModernize ABIVersionTest 95/103095/2
Robert Varga [Fri, 4 Nov 2022 21:03:42 +0000 (22:03 +0100)]
Modernize ABIVersionTest

Use assertThrows() instead of expected exception.

Change-Id: Ib2cfc2af5d8da99951d9c8fb6fcedf7eba894b6b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoMore cds-access-api cleanup 64/103064/1
Robert Varga [Thu, 3 Nov 2022 13:12:34 +0000 (14:12 +0100)]
More cds-access-api cleanup

Fixup previous patch and sprinkle more @Serial annotations.

Change-Id: I74414861197bb417dadc445ebc3fc2703a97ea4d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoUse constructor injection in OSGiClusterAdmin 56/103056/3
Robert Varga [Thu, 3 Nov 2022 10:04:34 +0000 (11:04 +0100)]
Use constructor injection in OSGiClusterAdmin

Remove @Beta and inject services directly into RPC service.

Change-Id: I6d836c84099f17945d0e1e6af8a38e8dbd03f123
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoPromote cds-access-client constructs 55/103055/3
Robert Varga [Thu, 3 Nov 2022 03:53:53 +0000 (04:53 +0100)]
Promote cds-access-client constructs

These constructs are stable enough, remove @Beta annotation.

Change-Id: I0a63f306fea0fca884fb26ec09560420652c4983
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoPromote AbstractMXBean 54/103054/3
Robert Varga [Thu, 3 Nov 2022 03:41:27 +0000 (04:41 +0100)]
Promote AbstractMXBean

This class can be evolved with SemVer, drop @Beta annotation.

Change-Id: Ie34b2b0e557691ea471cf03e23ad927153aadff5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoPromote cds-access-api 53/103053/7
Robert Varga [Thu, 3 Nov 2022 02:45:41 +0000 (03:45 +0100)]
Promote cds-access-api

This API is no longer @Beta.

Change-Id: If81e77c8b2c9dc2fcfa6bcd94f58426c75f6cd0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoPromote BucketStoreAccess 51/103051/3
Robert Varga [Thu, 3 Nov 2022 02:35:17 +0000 (03:35 +0100)]
Promote BucketStoreAccess

This is no longer @Beta.

Change-Id: I294085026f7306547230d476951793e09b3d0618
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoPromote cds-dom-api contracts 50/103050/2
Robert Varga [Thu, 3 Nov 2022 02:31:04 +0000 (03:31 +0100)]
Promote cds-dom-api contracts

These are stable enough not to warrant a @Beta annotation.

Change-Id: I2e493febf1a99560047b86ff5aa576c5428ff35d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoPromote DataCenterControl 52/103052/2
Robert Varga [Thu, 3 Nov 2022 02:37:04 +0000 (03:37 +0100)]
Promote DataCenterControl

This is no longer @Beta.

Change-Id: Ic1c2686e8d6c71e27d65a4a8a2ae13979724f2b8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoPromote OSGiGlobalEventExecutor 49/103049/1
Robert Varga [Thu, 3 Nov 2022 02:29:10 +0000 (03:29 +0100)]
Promote OSGiGlobalEventExecutor

Drop @Beta annotation.

Change-Id: I15e93a4645dd586fe80aab36e6d27495508fda82
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoDo not reference immutable node builders 40/103040/1
Robert Varga [Wed, 2 Nov 2022 22:17:39 +0000 (23:17 +0100)]
Do not reference immutable node builders

Use Builders/ImmutableNodes instead of direct implementation reference.
Also use fluent nature of builders, which flushes out a number of unused
constructs, which we remove here.

Change-Id: I8803da6a244f4f4dceaf4da06934b0f8df24b827
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoBump scala to 2.13.10 66/102666/1
Robert Varga [Thu, 13 Oct 2022 13:42:31 +0000 (15:42 +0200)]
Bump scala to 2.13.10

https://github.com/scala/scala/releases/tag/v2.13.10

Change-Id: I2c18e38c5f72be43f4bfb71c67049552ad690784
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoBump Scala to 2.13.9 45/102445/1
Robert Varga [Thu, 22 Sep 2022 15:26:13 +0000 (17:26 +0200)]
Bump Scala to 2.13.9

https://github.com/scala/scala/releases/tag/v2.13.9

Change-Id: I2d004d2c3e7d193c803786191c55b53018f63156
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoBump versions to 6.0.3-SNAPSHOT 74/102374/1
Robert Varga [Wed, 14 Sep 2022 14:27:23 +0000 (16:27 +0200)]
Bump versions to 6.0.3-SNAPSHOT

This starts the next development iteration.

Change-Id: Ia7fdafe6d534daeef8fb636907367358d135ae24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoBump mdsal to 10.0.2 73/102373/1
Robert Varga [Wed, 14 Sep 2022 14:26:41 +0000 (16:26 +0200)]
Bump mdsal to 10.0.2

Pick up fixes from upstream.

Change-Id: I66e104394b41052d6821da6d3d159fa49f5a0626
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoBump junit-4-13_2.13 05/102305/4
Robert Varga [Wed, 7 Sep 2022 16:13:02 +0000 (18:13 +0200)]
Bump junit-4-13_2.13

Adopt version 3.2.13.0.

Change-Id: I421dd2ae4be9a560eaeffe6f86d9828ed9c2e7eb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoBump Akka to 2.6.20 03/102303/4
Robert Varga [Wed, 7 Sep 2022 10:33:40 +0000 (12:33 +0200)]
Bump Akka to 2.6.20

https://akka.io/blog/news/2022/09/06/akka-2.6.20-released
https://github.com/real-logic/agrona/releases/tag/1.15.0
https://github.com/real-logic/agrona/releases/tag/1.15.1
https://github.com/real-logic/agrona/releases/tag/1.15.2
https://github.com/real-logic/aeron/releases/tag/1.38.0
https://github.com/real-logic/aeron/releases/tag/1.38.1

JIRA: CONTROLLER-2048
Change-Id: I4d3b2da9bd1a716403bfae5b957c73b05406ba15
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoBump reactive-streams to 1.0.4 06/102306/4
Robert Varga [Wed, 7 Sep 2022 16:13:35 +0000 (18:13 +0200)]
Bump reactive-streams to 1.0.4

https://github.com/reactive-streams/reactive-streams-jvm/blob/master/RELEASE-NOTES.md#version-104-released-on-2022-05-20

Change-Id: I6f9072f4b053f831a4855c2c5c97ad8509d9e8bb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoBump versions to 6.0.2-SNAPSHOT 50/102150/1
Robert Varga [Thu, 18 Aug 2022 13:59:11 +0000 (15:59 +0200)]
Bump versions to 6.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I313fd43923f2f8c82aaf8d999846e7c98a1e81d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoBump upstreams 48/102148/1
Robert Varga [Thu, 18 Aug 2022 11:01:35 +0000 (13:01 +0200)]
Bump upstreams

Adopt:
- odlparent-11.0.1
- yangtools-9.0.1
- mdsal-10.0.1

Change-Id: I63b6d252955e9397dd9283fd37522046eabf7036
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoUse FrameworkUtil.asDictionary() 08/101808/1
Robert Varga [Mon, 11 Jul 2022 21:25:38 +0000 (23:25 +0200)]
Use FrameworkUtil.asDictionary()

We do not need a Hashtable, use FrameworkUtil to give us what we need.

Change-Id: I50099a7b8f036d7f7f8af467242005e74b48d89d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoBump versions to 6.0.1-SNAPSHOT 31/101631/1
Robert Varga [Mon, 27 Jun 2022 11:55:25 +0000 (13:55 +0200)]
Bump versions to 6.0.1-SNAPSHOT

This starts the next development iteration.

Change-Id: If243be33db2568b59ceee22084e1abf19d95dae0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoUse mdsal-10.0.0 29/101629/1
Robert Varga [Mon, 27 Jun 2022 11:07:30 +0000 (13:07 +0200)]
Use mdsal-10.0.0

Use released artifacts instead of snapshots.

Change-Id: Ia6f4c28001d19449ee47c62a5754f6966103e4ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoUse yangtools-9.0.0 13/101613/1
Robert Varga [Mon, 20 Jun 2022 17:25:28 +0000 (19:25 +0200)]
Use yangtools-9.0.0

We have a release available, use that instead of snapshots.

Change-Id: I845de0908448e1e8dbceda3f5700d090226d0fb3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoFix a documentation reference 84/101484/1
Robert Varga [Tue, 7 Jun 2022 09:06:24 +0000 (11:06 +0200)]
Fix a documentation reference

We do not use ConstructorProperties, fix the reference.

Change-Id: I3fed8217367ce3948fa561bdf4b00a4e99087c07
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoFixup javadoc build 82/101482/1
Robert Varga [Tue, 7 Jun 2022 07:33:46 +0000 (09:33 +0200)]
Fixup javadoc build

javadoc-3.4.0 has problems with scala-parser-combinators, as it cannot
derive its module name. Fix this by downgrading javadoc plugin version
for now.

Change-Id: Ica9274e2afc50306c1620e9f32efc5d7371a7c2b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoAdd an automatic module name for repackaged akka 79/101479/2
Robert Varga [Mon, 6 Jun 2022 17:43:27 +0000 (19:43 +0200)]
Add an automatic module name for repackaged akka

We need to be referencing this artifact, let's make sure it has a proper
JPMS name.

Change-Id: Idb6981a5e550bb1572600b317789cf23922897c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoDrop unused cds-dom-api dependencies 80/101480/2
Robert Varga [Mon, 6 Jun 2022 17:51:00 +0000 (19:51 +0200)]
Drop unused cds-dom-api dependencies

We have two dependencies which are not used, one of which is causing
problems to our build. Fix them up.

Change-Id: I10505acc6649a699ebd78cd761df8f71de208b39
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoUse odlparent-11.0.0 release 74/101474/5
Robert Varga [Mon, 6 Jun 2022 14:44:46 +0000 (16:44 +0200)]
Use odlparent-11.0.0 release

We have released artifacts, use them instead of snapshots.

Change-Id: I4cad35236149feca2ed18bd2ae40a6bdfcf350a6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoUpdate javadoc links 73/101473/5
Robert Varga [Mon, 6 Jun 2022 14:43:59 +0000 (16:43 +0200)]
Update javadoc links

We have slightly updated versions, fix links to them.

Change-Id: Ib849b18dafe7f6e491cde8ac209df3cac1795a3b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoModernize AutoCloseableEventExecutor 95/101395/3
Robert Varga [Tue, 31 May 2022 21:47:23 +0000 (23:47 +0200)]
Modernize AutoCloseableEventExecutor

Remove unneeded indirection through a class, so that we can eliminate
a suppression.

Change-Id: I52710d8a85a2081afe4b325d57acef70d434acce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoCleanup sal-distributed-datastore dependencies 23/101423/1
Robert Varga [Wed, 1 Jun 2022 21:31:54 +0000 (23:31 +0200)]
Cleanup sal-distributed-datastore dependencies

We have quite a few warnings here, fix some of those up.

Change-Id: I99da5099c006d8af8d6622bb15d0881763b03965
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoSwitch to jakarta.annotation-api 22/101422/1
Robert Varga [Wed, 1 Jun 2022 20:24:21 +0000 (22:24 +0200)]
Switch to jakarta.annotation-api

odlparent has switched to a more modern version, follow it.

Change-Id: Ia17c4d91a5e6e5da6d327ccaa96e41bbd629a8de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoMore pattern matching 11/101311/1
Robert Varga [Thu, 26 May 2022 20:51:47 +0000 (22:51 +0200)]
More pattern matching

Remove mulitple casts in favor of instanceof pattern match.

Change-Id: I301a00ec98127c2e5f6ae2326d95fd68c8e31ad0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoAdd Payload.serializedSize() 11/101211/9
Robert Varga [Wed, 18 May 2022 07:15:22 +0000 (09:15 +0200)]
Add Payload.serializedSize()

There is a rather big difference in payload sizing when we consider
how big an entry is: in-memory size can easily be "zero", which can
translate to a serialized size of hundreds of bytes. This difference
is problematic, as we use the former to estimate how many payloads
we can squeeze in AppendEntries and we compare that to the configured
payload limit. Even when there is some (32KiB by default) cushion, we
can end up blowing past the frame size.

Add Payload.serializedSize(), which should provide a semi-conservative
estimate of serialized size and use that to select the cut-off.

Also improve SimpleReplicatedLogEntry's estimates by performing a a
quick serialization operation -- which reduces potential waste for each
entry by 294 bytes, as our hard-coded estimate of 400 bytes was way too
conservative.

JIRA: CONTROLLER-2037
Change-Id: I5abe7d00db9e10f1c66e6db0f7c82854f9aa352d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoAdd a missing @Override annotation 06/101306/1
Robert Varga [Thu, 26 May 2022 17:12:25 +0000 (19:12 +0200)]
Add a missing @Override annotation

writeReplace() is specified by payload, make sure we mark it as such.

JIRA: CONTROLLER-2037
Change-Id: I21902a859563baf990e8bb8513281516d099c619
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoFix raw type warnings in OSGiDistributedDataStore 05/101305/1
Robert Varga [Thu, 26 May 2022 17:05:52 +0000 (19:05 +0200)]
Fix raw type warnings in OSGiDistributedDataStore

Component{Factory,Instance} are now properly generic, specify arguments
pointing to OSGiDOMStore.

Change-Id: I4593b18df88302f933647ed09818633d76efca41
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoMake Payload Serializable 10/101210/3
Robert Varga [Fri, 13 May 2022 12:52:16 +0000 (14:52 +0200)]
Make Payload Serializable

All payloads are serialized via Java serialization, which is not great,
but needs to be expressed in the API contract. Also codify that each
payload needs to have a serializable proxy.

JIRA: CONTROLLER-2037
Change-Id: I99f146413e42af68bb33b942c2222c091a87cf3f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoMove {Identifiable,Persistent,}Payload 12/101112/7
Robert Varga [Fri, 13 May 2022 12:23:27 +0000 (14:23 +0200)]
Move {Identifiable,Persistent,}Payload

Payloads are really part of raft message specification, not some vague
sal-clustering-commons detail. They have a strong relationship with
AppendEntries and therefore really need to be co-located.

As a first step in dealing with AppendEntries sizing, move Payloads so
we can properly evolve them.

JIRA: CONTROLLER-2037
Change-Id: I069f311b1c1b211b8429a721e6b239e5e08ed813
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>