package org.opendaylight.controller.cluster.datastore.messages;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import com.google.common.collect.ImmutableSortedSet;
import java.io.Serializable;
-import org.apache.commons.lang.SerializationUtils;
+import java.util.Optional;
+import java.util.SortedSet;
+import org.apache.commons.lang3.SerializationUtils;
import org.junit.Test;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+import org.opendaylight.controller.cluster.datastore.AbstractTest;
import org.opendaylight.controller.cluster.datastore.DataStoreVersions;
import org.opendaylight.controller.cluster.datastore.modification.DeleteModification;
import org.opendaylight.controller.cluster.datastore.modification.MergeModification;
import org.opendaylight.controller.cluster.datastore.modification.WriteModification;
import org.opendaylight.controller.md.cluster.datastore.model.TestModel;
import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
-import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
+import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.NodeIdentifier;
+import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode;
+import org.opendaylight.yangtools.yang.data.impl.schema.Builders;
import org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNodes;
-import org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableContainerNodeBuilder;
/**
* Unit tests for BatchedModifications.
*
* @author Thomas Pantelis
*/
-public class BatchedModificationsTest {
-
+@Deprecated(since = "9.0.0", forRemoval = true)
+public class BatchedModificationsTest extends AbstractTest {
@Test
public void testSerialization() {
YangInstanceIdentifier writePath = TestModel.TEST_PATH;
- NormalizedNode<?, ?> writeData = ImmutableContainerNodeBuilder.create().withNodeIdentifier(
- new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)).
- withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build();
+ ContainerNode writeData = Builders.containerBuilder()
+ .withNodeIdentifier(new NodeIdentifier(TestModel.TEST_QNAME))
+ .withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo"))
+ .build();
YangInstanceIdentifier mergePath = TestModel.OUTER_LIST_PATH;
- NormalizedNode<?, ?> mergeData = ImmutableContainerNodeBuilder.create().withNodeIdentifier(
- new YangInstanceIdentifier.NodeIdentifier(TestModel.OUTER_LIST_QNAME)).build();
+ ContainerNode mergeData = Builders.containerBuilder()
+ .withNodeIdentifier(new NodeIdentifier(TestModel.OUTER_LIST_QNAME))
+ .build();
YangInstanceIdentifier deletePath = TestModel.TEST_PATH;
- BatchedModifications batched = new BatchedModifications("tx1", DataStoreVersions.CURRENT_VERSION, "txChain");
+ final TransactionIdentifier tx1 = nextTransactionId();
+ BatchedModifications batched = new BatchedModifications(tx1, DataStoreVersions.CURRENT_VERSION);
batched.addModification(new WriteModification(writePath, writeData));
batched.addModification(new MergeModification(mergePath, mergeData));
batched.addModification(new DeleteModification(deletePath));
- batched.setReady(true);
+ assertFalse("isReady", batched.isReady());
+ batched.setReady();
+ assertTrue("isReady", batched.isReady());
+ batched.setTotalMessagesSent(5);
BatchedModifications clone = (BatchedModifications) SerializationUtils.clone(
(Serializable) batched.toSerializable());
assertEquals("getVersion", DataStoreVersions.CURRENT_VERSION, clone.getVersion());
- assertEquals("getTransactionID", "tx1", clone.getTransactionID());
- assertEquals("getTransactionChainID", "txChain", clone.getTransactionChainID());
- assertEquals("isReady", true, clone.isReady());
+ assertEquals("getTransactionID", tx1, clone.getTransactionId());
+ assertTrue("isReady", clone.isReady());
+ assertFalse("isDoCommitOnReady", clone.isDoCommitOnReady());
+ assertFalse("participatingShardNames present", clone.getParticipatingShardNames().isPresent());
+ assertEquals("getTotalMessagesSent", 5, clone.getTotalMessagesSent());
assertEquals("getModifications size", 3, clone.getModifications().size());
assertEquals("getVersion", DataStoreVersions.CURRENT_VERSION, delete.getVersion());
assertEquals("getPath", deletePath, delete.getPath());
- // Test with different params.
+ // Test with participating shard names.
- batched = new BatchedModifications("tx2", (short)10, null);
+ final TransactionIdentifier tx2 = nextTransactionId();
+ batched = new BatchedModifications(tx2, (short)10000);
+ final SortedSet<String> shardNames = ImmutableSortedSet.of("one", "two");
+ batched.setReady(Optional.of(shardNames));
+ batched.setDoCommitOnReady(true);
+ assertTrue("isReady", batched.isReady());
clone = (BatchedModifications) SerializationUtils.clone((Serializable) batched.toSerializable());
- assertEquals("getVersion", 10, clone.getVersion());
- assertEquals("getTransactionID", "tx2", clone.getTransactionID());
- assertEquals("getTransactionChainID", "", clone.getTransactionChainID());
- assertEquals("isReady", false, clone.isReady());
-
+ assertEquals("getVersion", DataStoreVersions.CURRENT_VERSION, clone.getVersion());
+ assertEquals("getTransactionID", tx2, clone.getTransactionId());
+ assertTrue("isReady", clone.isReady());
+ assertTrue("isDoCommitOnReady", clone.isDoCommitOnReady());
+ assertEquals("participatingShardNames", Optional.of(shardNames), clone.getParticipatingShardNames());
assertEquals("getModifications size", 0, clone.getModifications().size());
+ // Test not ready.
+
+ batched = new BatchedModifications(tx2, DataStoreVersions.CURRENT_VERSION);
+
+ clone = (BatchedModifications) SerializationUtils.clone((Serializable) batched.toSerializable());
+
+ assertEquals("getVersion", DataStoreVersions.CURRENT_VERSION, clone.getVersion());
+ assertEquals("getTransactionID", tx2, clone.getTransactionId());
+ assertFalse("isReady", clone.isReady());
+ assertEquals("getModifications size", 0, clone.getModifications().size());
}
@Test