Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
String performance and maintenability
[controller.git]
/
opendaylight
/
config
/
config-manager
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
config
/
manager
/
impl
/
jmx
/
ServiceReference.java
diff --git
a/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ServiceReference.java
b/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ServiceReference.java
index 3ad35ac5b5f48d27041244f795a35f32ca781972..88646b4cc1b759b95cede46d7db99103103bc57a 100644
(file)
--- a/
opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ServiceReference.java
+++ b/
opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ServiceReference.java
@@
-1,5
+1,5
@@
/*
/*
- * Copyright (c) 2013 Cisco Systems, Inc. and others. All rights reserved.
+ * Copyright (c) 2013
, 2017
Cisco Systems, Inc. and others. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
@@
-8,9
+8,10
@@
package org.opendaylight.controller.config.manager.impl.jmx;
public class ServiceReference {
package org.opendaylight.controller.config.manager.impl.jmx;
public class ServiceReference {
- private final String serviceInterfaceName, refName;
+ private final String serviceInterfaceName;
+ private final String refName;
- public ServiceReference(
String serviceInterfaceName,
String refName) {
+ public ServiceReference(
final String serviceInterfaceName, final
String refName) {
this.serviceInterfaceName = serviceInterfaceName;
this.refName = refName;
}
this.serviceInterfaceName = serviceInterfaceName;
this.refName = refName;
}
@@
-24,15
+25,15
@@
public class ServiceReference {
}
@Override
}
@Override
- public boolean equals(
Object o
) {
- if (this == o) {
+ public boolean equals(
final Object object
) {
+ if (this == o
bject
) {
return true;
}
return true;
}
- if (o
== null || getClass() != o
.getClass()) {
+ if (o
bject == null || getClass() != object
.getClass()) {
return false;
}
return false;
}
- ServiceReference that = (ServiceReference) o;
+ ServiceReference that = (ServiceReference) o
bject
;
if (!refName.equals(that.refName)) {
return false;
if (!refName.equals(that.refName)) {
return false;
@@
-53,9
+54,7
@@
public class ServiceReference {
@Override
public String toString() {
@Override
public String toString() {
- return "ServiceReference{" +
- "serviceInterfaceName='" + serviceInterfaceName + '\'' +
- ", refName='" + refName + '\'' +
- '}';
+ return "ServiceReference{" + "serviceInterfaceName='" + serviceInterfaceName + '\'' + ", refName='" + refName
+ + '\'' + '}';
}
}
}
}