Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Yang code generator cleanup
[controller.git]
/
opendaylight
/
config
/
yang-jmx-generator-plugin
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
config
/
yangjmxgenerator
/
plugin
/
gofactory
/
AbsModuleGeneratedObjectFactory.java
diff --git
a/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/gofactory/AbsModuleGeneratedObjectFactory.java
b/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/gofactory/AbsModuleGeneratedObjectFactory.java
index 92a0eec5866877834f4fef563e9d3a3e06acc3aa..7118405deaff7559ec7c60777a8da1c8f0055aa3 100644
(file)
--- a/
opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/gofactory/AbsModuleGeneratedObjectFactory.java
+++ b/
opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/gofactory/AbsModuleGeneratedObjectFactory.java
@@
-149,8
+149,8
@@
public class AbsModuleGeneratedObjectFactory {
return "\n"+
"@Override\n"+
"public boolean equals(Object o) {\n"+
return "\n"+
"@Override\n"+
"public boolean equals(Object o) {\n"+
- "if (this == o)
return true;
\n"+
- "if (o == null || getClass() != o.getClass())
return false;
\n"+
+ "if (this == o)
{ return true; }
\n"+
+ "if (o == null || getClass() != o.getClass())
{ return false; }
\n"+
format("%s that = (%1$s) o;\n", abstractFQN.getTypeName())+
"return identifier.equals(that.identifier);\n"+
"}\n"+
format("%s that = (%1$s) o;\n", abstractFQN.getTypeName())+
"return identifier.equals(that.identifier);\n"+
"}\n"+
@@
-182,7
+182,7
@@
public class AbsModuleGeneratedObjectFactory {
for (ModuleField moduleField : moduleFields) {
result += format(
for (ModuleField moduleField : moduleFields) {
result += format(
- "if (
java.util.Objects.deepEquals(%s, other.%1$s) == false
) {\n"+
+ "if (
!java.util.Objects.deepEquals(%s, other.%1$s)
) {\n"+
"return false;\n"+
"}\n", moduleField.getName());
"return false;\n"+
"}\n", moduleField.getName());