Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fix CS warnings in cds-access-api and enable enforcement
[controller.git]
/
opendaylight
/
md-sal
/
cds-access-api
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
cluster
/
access
/
commands
/
TransactionCanCommitSuccessProxyV1.java
diff --git
a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java
b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java
index a6d54f50368a9d655b7294d3ead6a0782a3f3d74..b41ec2998fd4a5e6b3616e64f90ff5cd526372da 100644
(file)
--- a/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java
+++ b/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java
@@
-7,9
+7,6
@@
*/
package org.opendaylight.controller.cluster.access.commands;
*/
package org.opendaylight.controller.cluster.access.commands;
-import akka.actor.ActorRef;
-import akka.serialization.JavaSerializer;
-import akka.serialization.Serialization;
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
@@
-23,31
+20,30
@@
import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier
*/
final class TransactionCanCommitSuccessProxyV1 extends AbstractTransactionSuccessProxy<TransactionCanCommitSuccess> {
private static final long serialVersionUID = 1L;
*/
final class TransactionCanCommitSuccessProxyV1 extends AbstractTransactionSuccessProxy<TransactionCanCommitSuccess> {
private static final long serialVersionUID = 1L;
- private ActorRef cohort;
+ // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
+ // be able to create instances via reflection.
+ @SuppressWarnings("checkstyle:RedundantModifier")
public TransactionCanCommitSuccessProxyV1() {
// For Externalizable
}
TransactionCanCommitSuccessProxyV1(final TransactionCanCommitSuccess success) {
super(success);
public TransactionCanCommitSuccessProxyV1() {
// For Externalizable
}
TransactionCanCommitSuccessProxyV1(final TransactionCanCommitSuccess success) {
super(success);
- this.cohort = success.getCohort();
}
@Override
public void writeExternal(final ObjectOutput out) throws IOException {
super.writeExternal(out);
}
@Override
public void writeExternal(final ObjectOutput out) throws IOException {
super.writeExternal(out);
- out.writeUTF(Serialization.serializedActorPath(cohort));
}
@Override
public void readExternal(final ObjectInput in) throws IOException, ClassNotFoundException {
super.readExternal(in);
}
@Override
public void readExternal(final ObjectInput in) throws IOException, ClassNotFoundException {
super.readExternal(in);
- cohort = JavaSerializer.currentSystem().value().provider().resolveActorRef(in.readUTF());
}
@Override
}
@Override
- protected TransactionCanCommitSuccess createSuccess(final TransactionIdentifier target) {
- return new TransactionCanCommitSuccess(target,
cohort
);
+ protected TransactionCanCommitSuccess createSuccess(final TransactionIdentifier target
, final long sequence
) {
+ return new TransactionCanCommitSuccess(target,
sequence
);
}
}
}
}