Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Optimize NodeIdentifier reading
[controller.git]
/
opendaylight
/
md-sal
/
cds-access-api
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
cluster
/
access
/
concepts
/
ClientIdentifier.java
diff --git
a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ClientIdentifier.java
b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ClientIdentifier.java
index 5842ade3c203f29048caa16480742dc83510a6f7..fe178f26e9d25cc0aa29202ce951b5096fd6a3c1 100644
(file)
--- a/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ClientIdentifier.java
+++ b/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ClientIdentifier.java
@@
-32,6
+32,9
@@
public final class ClientIdentifier implements WritableIdentifier {
private FrontendIdentifier frontendId;
private long generation;
private FrontendIdentifier frontendId;
private long generation;
+ // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
+ // be able to create instances via reflection.
+ @SuppressWarnings("checkstyle:RedundantModifier")
public Proxy() {
// Needed for Externalizable
}
public Proxy() {
// Needed for Externalizable
}
@@
-97,15
+100,15
@@
public final class ClientIdentifier implements WritableIdentifier {
}
@Override
}
@Override
- public boolean equals(final Object o) {
- if (this == o) {
+ public boolean equals(final Object o
bj
) {
+ if (this == o
bj
) {
return true;
}
return true;
}
- if (!(o instanceof ClientIdentifier)) {
+ if (!(o
bj
instanceof ClientIdentifier)) {
return false;
}
return false;
}
- final ClientIdentifier other = (ClientIdentifier) o;
+ final ClientIdentifier other = (ClientIdentifier) o
bj
;
return generation == other.generation && frontendId.equals(other.frontendId);
}
return generation == other.generation && frontendId.equals(other.frontendId);
}