Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
BUG-5280: add executionTimeNanos
[controller.git]
/
opendaylight
/
md-sal
/
cds-access-api
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
cluster
/
access
/
concepts
/
FrontendIdentifier.java
diff --git
a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java
b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java
index fe85ef6e52e6eaf773356123f068bd5bae95ba5b..60e40e9e161faf74c5f82c7fdd564c1872d916f9 100644
(file)
--- a/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java
+++ b/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java
@@
-8,7
+8,6
@@
package org.opendaylight.controller.cluster.access.concepts;
import com.google.common.annotations.Beta;
package org.opendaylight.controller.cluster.access.concepts;
import com.google.common.annotations.Beta;
-import com.google.common.base.MoreObjects;
import com.google.common.base.Preconditions;
import java.io.DataInput;
import java.io.DataOutput;
import com.google.common.base.Preconditions;
import java.io.DataInput;
import java.io.DataOutput;
@@
-31,6
+30,9
@@
public final class FrontendIdentifier implements WritableIdentifier {
private MemberName memberName;
private FrontendType clientType;
private MemberName memberName;
private FrontendType clientType;
+ // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
+ // be able to create instances via reflection.
+ @SuppressWarnings("checkstyle:RedundantModifier")
public Proxy() {
// Needed for Externalizable
}
public Proxy() {
// Needed for Externalizable
}
@@
-96,22
+98,25
@@
public final class FrontendIdentifier implements WritableIdentifier {
}
@Override
}
@Override
- public boolean equals(final Object o) {
- if (this == o) {
+ public boolean equals(final Object o
bj
) {
+ if (this == o
bj
) {
return true;
}
return true;
}
- if (!(o instanceof FrontendIdentifier)) {
+ if (!(o
bj
instanceof FrontendIdentifier)) {
return false;
}
return false;
}
- final FrontendIdentifier other = (FrontendIdentifier) o;
+ final FrontendIdentifier other = (FrontendIdentifier) o
bj
;
return memberName.equals(other.memberName) && clientType.equals(other.clientType);
}
return memberName.equals(other.memberName) && clientType.equals(other.clientType);
}
+ public String toPersistentId() {
+ return memberName.getName() + "-frontend-" + clientType.getName();
+ }
+
@Override
public String toString() {
@Override
public String toString() {
- return MoreObjects.toStringHelper(FrontendIdentifier.class).add("member", memberName)
- .add("clientType", clientType).toString();
+ return toPersistentId();
}
private Object writeReplace() {
}
private Object writeReplace() {