Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fix CS warnings in cds-access-api and enable enforcement
[controller.git]
/
opendaylight
/
md-sal
/
cds-access-api
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
cluster
/
access
/
concepts
/
LocalHistoryIdentifier.java
diff --git
a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java
b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java
index a6e81f13aa111134570354241895e5c2a37316e3..29e3df74f5657a9697731d4cdc60c526a8baf14d 100644
(file)
--- a/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java
+++ b/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java
@@
-42,6
+42,9
@@
public final class LocalHistoryIdentifier implements WritableIdentifier {
private long historyId;
private long cookie;
private long historyId;
private long cookie;
+ // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
+ // be able to create instances via reflection.
+ @SuppressWarnings("checkstyle:RedundantModifier")
public Proxy() {
// For Externalizable
}
public Proxy() {
// For Externalizable
}
@@
-122,15
+125,15
@@
public final class LocalHistoryIdentifier implements WritableIdentifier {
}
@Override
}
@Override
- public boolean equals(final Object o) {
- if (this == o) {
+ public boolean equals(final Object o
bj
) {
+ if (this == o
bj
) {
return true;
}
return true;
}
- if (!(o instanceof LocalHistoryIdentifier)) {
+ if (!(o
bj
instanceof LocalHistoryIdentifier)) {
return false;
}
return false;
}
- final LocalHistoryIdentifier other = (LocalHistoryIdentifier) o;
+ final LocalHistoryIdentifier other = (LocalHistoryIdentifier) o
bj
;
return historyId == other.historyId && cookie == other.cookie && clientId.equals(other.clientId);
}
return historyId == other.historyId && cookie == other.cookie && clientId.equals(other.clientId);
}