Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Sprinkle @NonNull annotations
[controller.git]
/
opendaylight
/
md-sal
/
cds-access-api
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
cluster
/
access
/
concepts
/
LocalHistoryIdentifier.java
diff --git
a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java
b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java
index f8f890e2c1df0e75969b2c85fb82b8fd2d93f2aa..137bf5907f3ca985170f482d49ae48d86debbc56 100644
(file)
--- a/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java
+++ b/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java
@@
-16,6
+16,7
@@
import java.io.Externalizable;
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
+import org.eclipse.jdt.annotation.NonNull;
import org.opendaylight.yangtools.concepts.WritableIdentifier;
import org.opendaylight.yangtools.concepts.WritableObjects;
import org.opendaylight.yangtools.concepts.WritableIdentifier;
import org.opendaylight.yangtools.concepts.WritableObjects;
@@
-51,7
+52,7
@@
public final class LocalHistoryIdentifier implements WritableIdentifier {
}
Proxy(final ClientIdentifier frontendId, final long historyId, final long cookie) {
}
Proxy(final ClientIdentifier frontendId, final long historyId, final long cookie) {
-
this.
clientId = requireNonNull(frontendId);
+ clientId = requireNonNull(frontendId);
this.historyId = historyId;
this.cookie = cookie;
}
this.historyId = historyId;
this.cookie = cookie;
}
@@
-77,7
+78,7
@@
public final class LocalHistoryIdentifier implements WritableIdentifier {
}
private static final long serialVersionUID = 1L;
}
private static final long serialVersionUID = 1L;
- private final ClientIdentifier clientId;
+ private final
@NonNull
ClientIdentifier clientId;
private final long historyId;
private final long cookie;
private final long historyId;
private final long cookie;
@@
-86,12
+87,12
@@
public final class LocalHistoryIdentifier implements WritableIdentifier {
}
public LocalHistoryIdentifier(final ClientIdentifier frontendId, final long historyId, final long cookie) {
}
public LocalHistoryIdentifier(final ClientIdentifier frontendId, final long historyId, final long cookie) {
-
this.
clientId = requireNonNull(frontendId);
+ clientId = requireNonNull(frontendId);
this.historyId = historyId;
this.cookie = cookie;
}
this.historyId = historyId;
this.cookie = cookie;
}
- public static LocalHistoryIdentifier readFrom(final DataInput in) throws IOException {
+ public static
@NonNull
LocalHistoryIdentifier readFrom(final DataInput in) throws IOException {
final ClientIdentifier clientId = ClientIdentifier.readFrom(in);
final byte header = WritableObjects.readLongHeader(in);
final ClientIdentifier clientId = ClientIdentifier.readFrom(in);
final byte header = WritableObjects.readLongHeader(in);
@@
-105,7
+106,7
@@
public final class LocalHistoryIdentifier implements WritableIdentifier {
WritableObjects.writeLongs(out, historyId, cookie);
}
WritableObjects.writeLongs(out, historyId, cookie);
}
- public ClientIdentifier getClientId() {
+ public
@NonNull
ClientIdentifier getClientId() {
return clientId;
}
return clientId;
}