Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fix FindBugs warnings in cds-access-api and enable enforcement
[controller.git]
/
opendaylight
/
md-sal
/
cds-access-api
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
cluster
/
access
/
concepts
/
Request.java
diff --git
a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Request.java
b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Request.java
index 2f5cb4f4becaa84e1fd6677d93dd7d2375d27442..75fbadd00a702c0f5129a0a13686e2901382f823 100644
(file)
--- a/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Request.java
+++ b/
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Request.java
@@
-29,12
+29,12
@@
public abstract class Request<T extends WritableIdentifier, C extends Request<T,
private static final long serialVersionUID = 1L;
private final ActorRef replyTo;
private static final long serialVersionUID = 1L;
private final ActorRef replyTo;
- protected Request(
final @Nonnull T target, final long sequence, final @Nonnul
l ActorRef replyTo) {
+ protected Request(
@Nonnull final T target, final long sequence, @Nonnull fina
l ActorRef replyTo) {
super(target, sequence);
this.replyTo = Preconditions.checkNotNull(replyTo);
}
super(target, sequence);
this.replyTo = Preconditions.checkNotNull(replyTo);
}
- protected Request(
final @Nonnull C request, final @Nonnul
l ABIVersion version) {
+ protected Request(
@Nonnull final C request, @Nonnull fina
l ABIVersion version) {
super(request, version);
this.replyTo = Preconditions.checkNotNull(request.getReplyTo());
}
super(request, version);
this.replyTo = Preconditions.checkNotNull(request.getReplyTo());
}
@@
-44,7
+44,8
@@
public abstract class Request<T extends WritableIdentifier, C extends Request<T,
*
* @return Original requestor
*/
*
* @return Original requestor
*/
- public final @Nonnull ActorRef getReplyTo() {
+ @Nonnull
+ public final ActorRef getReplyTo() {
return replyTo;
}
return replyTo;
}
@@
-54,7
+55,8
@@
public abstract class Request<T extends WritableIdentifier, C extends Request<T,
* @param cause Failure cause
* @return {@link RequestFailure} corresponding to this request
*/
* @param cause Failure cause
* @return {@link RequestFailure} corresponding to this request
*/
- public abstract @Nonnull RequestFailure<T, ?> toRequestFailure(final @Nonnull RequestException cause);
+ @Nonnull
+ public abstract RequestFailure<T, ?> toRequestFailure(@Nonnull final RequestException cause);
@Override
protected ToStringHelper addToStringAttributes(final ToStringHelper toStringHelper) {
@Override
protected ToStringHelper addToStringAttributes(final ToStringHelper toStringHelper) {