Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fix checkstyle violations in sal-binding-api
[controller.git]
/
opendaylight
/
md-sal
/
sal-binding-api
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
sal
/
binding
/
api
/
RpcConsumerRegistry.java
diff --git
a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcConsumerRegistry.java
b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcConsumerRegistry.java
index 615acd3195c8a99ed5b5f372f53dee46d5faac7b..3967ff1c4421fbd77386199d956c81119f70ce94 100644
(file)
--- a/
opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcConsumerRegistry.java
+++ b/
opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcConsumerRegistry.java
@@
-7,16
+7,18
@@
*/
package org.opendaylight.controller.sal.binding.api;
*/
package org.opendaylight.controller.sal.binding.api;
+import org.opendaylight.controller.md.sal.binding.api.BindingService;
import org.opendaylight.yangtools.yang.binding.RpcService;
/**
* Provides access to registered Remote Procedure Call (RPC) service implementations. The RPCs are
* defined in YANG models.
import org.opendaylight.yangtools.yang.binding.RpcService;
/**
* Provides access to registered Remote Procedure Call (RPC) service implementations. The RPCs are
* defined in YANG models.
+ *
* <p>
* RPC implementations are registered using the {@link RpcProviderRegistry}.
*
*/
* <p>
* RPC implementations are registered using the {@link RpcProviderRegistry}.
*
*/
-public interface RpcConsumerRegistry extends BindingAwareService {
+public interface RpcConsumerRegistry extends BindingAwareService
, BindingService
{
/**
* Returns an implementation of a requested RPC service.
*
/**
* Returns an implementation of a requested RPC service.
*
@@
-44,23
+46,25
@@
public interface RpcConsumerRegistry extends BindingAwareService {
* RPC methods may be implemented asynchronously, callers should avoid blocking on the
* {@link java.util.concurrent.Future Future} result. Instead, it is recommended to use
* {@link com.google.common.util.concurrent.JdkFutureAdapters#listenInPoolThread(java.util.concurrent.Future)}
* RPC methods may be implemented asynchronously, callers should avoid blocking on the
* {@link java.util.concurrent.Future Future} result. Instead, it is recommended to use
* {@link com.google.common.util.concurrent.JdkFutureAdapters#listenInPoolThread(java.util.concurrent.Future)}
- * or {@link com.google.common.util.concurrent.JdkFutureAdapters#listenInPoolThread(java.util.concurrent.Future, java.util.concurrent.Executor)}
+ * or {@link com.google.common.util.concurrent.JdkFutureAdapters#listenInPoolThread(java.util.concurrent.Future,
+ * java.util.concurrent.Executor)}
* to listen for Rpc Result. This will asynchronously listen for future result in executor and
* will not block current thread.
*
* to listen for Rpc Result. This will asynchronously listen for future result in executor and
* will not block current thread.
*
- *
<pre>
+ *
{@code
* final Future<RpcResult<SomeRpcOutput>> future = someRpcService.someRpc( ... );
* final Future<RpcResult<SomeRpcOutput>> future = someRpcService.someRpc( ... );
- * Futures.addCallback(JdkFutureAdapters.listenInThreadPool(future), new FutureCallback<RpcResult<SomeRpcOutput>>() {
+ * Futures.addCallback(JdkFutureAdapters.listenInThreadPool(future),
+ * new FutureCallback<RpcResult<SomeRpcOutput>>() {
+ * public void onSuccess(RpcResult<SomeRpcOutput> result) {
+ * // process result ...
+ * }
*
*
- * public void onSuccess(RpcResult<SomeRpcOutput> result) {
- * // process result ...
- * }
+ * public void onFailure(Throwable t) {
+ * // RPC failed
+ * }
+ * });
+ * }
*
*
- * public void onFailure(Throwable t) {
- * // RPC failed
- * }
- * );
- * </pre>
* @param serviceInterface the interface of the RPC Service. Typically this is an interface generated
* from a YANG model.
* @return the proxy for the requested RPC service. This method never returns null.
* @param serviceInterface the interface of the RPC Service. Typically this is an interface generated
* from a YANG model.
* @return the proxy for the requested RPC service. This method never returns null.