Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Reduce missing feature warning to debug
[controller.git]
/
opendaylight
/
md-sal
/
sal-distributed-datastore
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
cluster
/
datastore
/
ShardDataTreeCohort.java
diff --git
a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeCohort.java
b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeCohort.java
index f7cdd4e8dc3e8c13730e668627e03782703edffc..47876123cfa7b716edae5b72e74ee50c7faacd12 100644
(file)
--- a/
opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeCohort.java
+++ b/
opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTreeCohort.java
@@
-17,9
+17,12
@@
public abstract class ShardDataTreeCohort {
// Prevent foreign instantiation
}
// Prevent foreign instantiation
}
+ // FIXME: This leaks internal state generated in preCommit,
+ // should be result of canCommit
abstract DataTreeCandidateTip getCandidate();
abstract DataTreeModification getDataTreeModification();
abstract DataTreeCandidateTip getCandidate();
abstract DataTreeModification getDataTreeModification();
+ // FIXME: Should return rebased DataTreeCandidateTip
@VisibleForTesting
public abstract ListenableFuture<Boolean> canCommit();
@VisibleForTesting
@VisibleForTesting
public abstract ListenableFuture<Boolean> canCommit();
@VisibleForTesting