Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Merge "BUG 652 leafref CCE & BUG 720 colons problem"
[controller.git]
/
opendaylight
/
netconf
/
config-netconf-connector
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
netconf
/
confignetconfconnector
/
mapping
/
attributes
/
mapping
/
ObjectNameAttributeMappingStrategy.java
diff --git
a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectNameAttributeMappingStrategy.java
b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectNameAttributeMappingStrategy.java
index 1febf02a2dc971b7d7fd884d2e62ff1ff57600ac..b827a5b03965d7f7471731a646b80e44ee835266 100644
(file)
--- a/
opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectNameAttributeMappingStrategy.java
+++ b/
opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectNameAttributeMappingStrategy.java
@@
-10,28
+10,28
@@
package org.opendaylight.controller.netconf.confignetconfconnector.mapping.attri
import com.google.common.base.Optional;
import com.google.common.base.Preconditions;
import com.google.common.base.Optional;
import com.google.common.base.Preconditions;
-import org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.Services;
-import org.opendaylight.controller.netconf.confignetconfconnector.util.Util;
-
import javax.management.ObjectName;
import javax.management.openmbean.SimpleType;
import javax.management.ObjectName;
import javax.management.openmbean.SimpleType;
+import org.opendaylight.controller.config.api.jmx.ObjectNameUtil;
+import org.opendaylight.controller.netconf.confignetconfconnector.util.Util;
public class ObjectNameAttributeMappingStrategy extends
AbstractAttributeMappingStrategy<ObjectNameAttributeMappingStrategy.MappedDependency, SimpleType<?>> {
public class ObjectNameAttributeMappingStrategy extends
AbstractAttributeMappingStrategy<ObjectNameAttributeMappingStrategy.MappedDependency, SimpleType<?>> {
- private final Services tracker;
private final String serviceName;
private final String serviceName;
+ private final String namespace;
- public ObjectNameAttributeMappingStrategy(SimpleType<?> openType,
Services dependencyTracker, String serviceNam
e) {
+ public ObjectNameAttributeMappingStrategy(SimpleType<?> openType,
String serviceName, String namespac
e) {
super(openType);
super(openType);
- this.tracker = dependencyTracker;
this.serviceName = serviceName;
this.serviceName = serviceName;
+ this.namespace = namespace;
}
@Override
public Optional<MappedDependency> mapAttribute(Object value) {
}
@Override
public Optional<MappedDependency> mapAttribute(Object value) {
- if (value == null)
+ if (value == null)
{
return Optional.absent();
return Optional.absent();
+ }
String expectedClass = getOpenType().getClassName();
String realClass = value.getClass().getName();
String expectedClass = getOpenType().getClassName();
String realClass = value.getClass().getName();
@@
-40,17
+40,19
@@
public class ObjectNameAttributeMappingStrategy extends
Util.checkType(value, ObjectName.class);
ObjectName on = (ObjectName) value;
Util.checkType(value, ObjectName.class);
ObjectName on = (ObjectName) value;
- String refName = tracker.addServiceEntry(serviceName, on);
- return Optional.of(new MappedDependency(serviceName, refName));
+ String refName = ObjectNameUtil.getReferenceName(on);
+
+ return Optional.of(new MappedDependency(namespace, serviceName, refName));
}
public static class MappedDependency {
}
public static class MappedDependency {
- private final String serviceName, refName;
+ private final String
namespace,
serviceName, refName;
- public MappedDependency(String serviceName, String refName) {
+ public MappedDependency(String
namespace, String
serviceName, String refName) {
this.serviceName = serviceName;
this.refName = refName;
this.serviceName = serviceName;
this.refName = refName;
+ this.namespace = namespace;
}
public String getServiceName() {
}
public String getServiceName() {
@@
-61,10
+63,15
@@
public class ObjectNameAttributeMappingStrategy extends
return refName;
}
return refName;
}
+ public String getNamespace() {
+ return namespace;
+ }
+
@Override
public String toString() {
final StringBuffer sb = new StringBuffer("MappedDependency{");
@Override
public String toString() {
final StringBuffer sb = new StringBuffer("MappedDependency{");
- sb.append("serviceName='").append(serviceName).append('\'');
+ sb.append("namespace='").append(namespace).append('\'');
+ sb.append(", serviceName='").append(serviceName).append('\'');
sb.append(", refName='").append(refName).append('\'');
sb.append('}');
return sb.toString();
sb.append(", refName='").append(refName).append('\'');
sb.append('}');
return sb.toString();